commit e908412a35f6bc8329b73411aa9ad519b7a3f664
author Hanno Becker <hanno.becker@arm.com> Fri Jun 07 12:04:39 2019 +0100
committer Hanno Becker <hanno.becker@arm.com> Tue Jun 25 09:11:11 2019 +0100
tree ae4c61bb658b236e2b394866406e9fb2fd281b08
parent fd64f14ef9a1a8b9ba328a1494f5b094c67b700e

Simplify logic for issuer/subject ID parsing

library/x509_crt.c

diff --git a/library/x509_crt.c b/library/x509_crt.c
index c79193e..e9672e4 100644
--- a/library/x509_crt.c
+++ b/library/x509_crt.c
@@ -696,15 +696,13 @@
  */
 static int x509_get_uid( unsigned char **p,
                          const unsigned char *end,
-                         mbedtls_x509_buf *uid, int n )
+                         mbedtls_x509_buf_raw *uid, int n )
 {
     int ret;
 
     if( *p == end )
         return( 0 );
 
-    uid->tag = **p;
-
     if( ( ret = mbedtls_asn1_get_tag( p, end, &uid->len,
             MBEDTLS_ASN1_CONTEXT_SPECIFIC | MBEDTLS_ASN1_CONSTRUCTED | n ) ) != 0 )
     {
@@ -1303,25 +1301,17 @@
          *  issuerUniqueID  [1]  IMPLICIT UniqueIdentifier OPTIONAL,
          *                       -- If present, version shall be v2 or v3
          */
-
-        ret = x509_get_uid( &p, end, &tmp, 1 /* implicit tag */ );
+        ret = x509_get_uid( &p, end, &frame->issuer_id, 1 /* implicit tag */ );
         if( ret != 0 )
             return( ret );
 
-        frame->issuer_id.p   = tmp.p;
-        frame->issuer_id.len = tmp.len;
-
         /*
          *  subjectUniqueID [2]  IMPLICIT UniqueIdentifier OPTIONAL,
          *                       -- If present, version shall be v2 or v3
          */
-
-        ret = x509_get_uid( &p, end, &tmp, 2 /* implicit tag */ );
+        ret = x509_get_uid( &p, end, &frame->subject_id, 2 /* implicit tag */ );
         if( ret != 0 )
             return( ret );
-
-        frame->subject_id.p   = tmp.p;
-        frame->subject_id.len = tmp.len;
     }
 
     /*