commit ec4c47f62b73c83b0f80c8b6f7fe93448c138e83
author David Horstmann <david.horstmann@arm.com> Fri Dec 08 18:27:48 2023 +0000
committer David Horstmann <david.horstmann@arm.com> Fri Dec 08 18:36:07 2023 +0000
tree aa69f8555a8a8528a35ccd039dd5e048be932465
parent 0dc3ed029a019c789283935a6fb10e7b7769d4a2

Move MPI initialization to start of function

This prevents a call to mbedtls_mpi_free() on uninitialized data when
USE_PSA_INIT() fails.

Signed-off-by: David Horstmann <david.horstmann@arm.com>

tests/suites/test_suite_x509write.function

diff --git a/tests/suites/test_suite_x509write.function b/tests/suites/test_suite_x509write.function
index ad0f2a6..90c2192 100644
--- a/tests/suites/test_suite_x509write.function
+++ b/tests/suites/test_suite_x509write.function
@@ -435,10 +435,11 @@
     mbedtls_mpi serial_mpi;
     uint8_t invalid_serial[MBEDTLS_X509_RFC5280_MAX_SERIAL_LEN + 1];
 
+    mbedtls_mpi_init(&serial_mpi);
+
     USE_PSA_INIT();
     memset(invalid_serial, 0x01, sizeof(invalid_serial));
 
-    mbedtls_mpi_init(&serial_mpi);
     TEST_EQUAL(mbedtls_mpi_read_binary(&serial_mpi, invalid_serial,
                                        sizeof(invalid_serial)), 0);
     TEST_EQUAL(mbedtls_x509write_crt_set_serial(&ctx, &serial_mpi),