commit f048618b43f74e7383ba62b94c65b4bfdf73d6ac
author gabor-mezei-arm <gabor.mezei@arm.com> Wed May 12 11:03:09 2021 +0200
committer gabor-mezei-arm <gabor.mezei@arm.com> Thu May 13 11:19:01 2021 +0200
tree c96c033aaa3b684a4e1a0f94dfb4ae37c9f0207d
parent 2b8373f8567e457ce59b1d5b68b87e4c1f3f24e8

Unify variable type and rename to be unambiguous

Signed-off-by: gabor-mezei-arm <gabor.mezei@arm.com>

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index 077b294..1ecab4e 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -2460,10 +2460,10 @@
 /* Asymmetric cryptography */
 /****************************************************************/
 
-static psa_status_t psa_sign_verify_check_alg( uint8_t do_hash,
+static psa_status_t psa_sign_verify_check_alg( int input_is_message,
                                                psa_algorithm_t alg )
 {
-    if( do_hash )
+    if( input_is_message )
     {
         if( ! PSA_ALG_IS_SIGN_MESSAGE( alg ) )
             return( PSA_ERROR_INVALID_ARGUMENT );
@@ -2484,7 +2484,7 @@
 }
 
 static psa_status_t psa_sign_internal( mbedtls_svc_key_id_t key,
-                                       uint8_t do_hash,
+                                       int input_is_message,
                                        psa_algorithm_t alg,
                                        const uint8_t * input,
                                        size_t input_length,
@@ -2498,7 +2498,7 @@
 
     *signature_length = 0;
 
-    status = psa_sign_verify_check_alg( do_hash, alg );
+    status = psa_sign_verify_check_alg( input_is_message, alg );
     if( status != PSA_SUCCESS )
         return status;
 
@@ -2511,8 +2511,8 @@
 
     status = psa_get_and_lock_key_slot_with_policy(
                 key, &slot,
-                do_hash ? PSA_KEY_USAGE_SIGN_MESSAGE :
-                          PSA_KEY_USAGE_SIGN_HASH,
+                input_is_message ? PSA_KEY_USAGE_SIGN_MESSAGE :
+                                   PSA_KEY_USAGE_SIGN_HASH,
                 alg );
 
     if( status != PSA_SUCCESS )
@@ -2528,7 +2528,7 @@
       .core = slot->attr
     };
 
-    if( do_hash )
+    if( input_is_message )
     {
         status = psa_driver_wrapper_sign_message(
             &attributes, slot->key.data, slot->key.bytes,
@@ -2564,7 +2564,7 @@
 }
 
 static psa_status_t psa_verify_internal( mbedtls_svc_key_id_t key,
-                                         uint8_t do_hash,
+                                         int input_is_message,
                                          psa_algorithm_t alg,
                                          const uint8_t * input,
                                          size_t input_length,
@@ -2575,14 +2575,14 @@
     psa_status_t unlock_status = PSA_ERROR_CORRUPTION_DETECTED;
     psa_key_slot_t *slot;
 
-    status = psa_sign_verify_check_alg( do_hash, alg );
+    status = psa_sign_verify_check_alg( input_is_message, alg );
     if( status != PSA_SUCCESS )
         return status;
 
     status = psa_get_and_lock_key_slot_with_policy(
                 key, &slot,
-                do_hash ? PSA_KEY_USAGE_VERIFY_MESSAGE :
-                          PSA_KEY_USAGE_VERIFY_HASH,
+                input_is_message ? PSA_KEY_USAGE_VERIFY_MESSAGE :
+                                   PSA_KEY_USAGE_VERIFY_HASH,
                 alg );
 
     if( status != PSA_SUCCESS )
@@ -2592,7 +2592,7 @@
       .core = slot->attr
     };
 
-    if( do_hash )
+    if( input_is_message )
     {
         status = psa_driver_wrapper_verify_message(
             &attributes, slot->key.data, slot->key.bytes,