commit f1ff9a83fa895e9c47103d755970e497131b5994
author Ronald Cron <ronald.cron@arm.com> Mon Oct 19 08:44:19 2020 +0200
committer Ronald Cron <ronald.cron@arm.com> Tue Nov 10 16:18:07 2020 +0100
tree ad85bbd82ef366a29ec1302c60458ec081851cf5
parent 390f607f7f7efc98d61c678e9c835dbd91f1c656

tests: psa: Use PSA_KEY_LIFETIME_IS_VOLATILE where it should

Signed-off-by: Ronald Cron <ronald.cron@arm.com>

tests/suites/test_suite_psa_crypto.function

diff --git a/tests/suites/test_suite_psa_crypto.function b/tests/suites/test_suite_psa_crypto.function
index 9b113b4..204e36e 100644
--- a/tests/suites/test_suite_psa_crypto.function
+++ b/tests/suites/test_suite_psa_crypto.function
@@ -112,7 +112,7 @@
 {
     /* At the moment, anything that isn't a built-in lifetime is either
      * a secure element or unassigned. */
-    return( lifetime != PSA_KEY_LIFETIME_VOLATILE &&
+    return( ( ! PSA_KEY_LIFETIME_IS_VOLATILE( lifetime ) ) &&
             lifetime != PSA_KEY_LIFETIME_PERSISTENT );
 }
 #else
@@ -245,7 +245,7 @@
     bits = psa_get_key_bits( &attributes );
 
     /* Persistence */
-    if( lifetime == PSA_KEY_LIFETIME_VOLATILE )
+    if( PSA_KEY_LIFETIME_IS_VOLATILE( lifetime ) )
     {
         TEST_ASSERT(
             ( PSA_KEY_ID_VOLATILE_MIN <=

tests/suites/test_suite_psa_crypto_slot_management.function

diff --git a/tests/suites/test_suite_psa_crypto_slot_management.function b/tests/suites/test_suite_psa_crypto_slot_management.function
index 75e1d8b..817094b 100644
--- a/tests/suites/test_suite_psa_crypto_slot_management.function
+++ b/tests/suites/test_suite_psa_crypto_slot_management.function
@@ -561,7 +561,7 @@
 
     /* If the target key is persistent, restart the system to make
      * sure that the material is still alive. */
-    if( target_lifetime != PSA_KEY_LIFETIME_VOLATILE )
+    if( ! PSA_KEY_LIFETIME_IS_VOLATILE( target_lifetime ) )
     {
         mbedtls_psa_crypto_free( );
         PSA_ASSERT( psa_crypto_init( ) );
@@ -573,7 +573,7 @@
     PSA_ASSERT( psa_get_key_attributes( returned_target_id,
                                         &target_attributes ) );
 
-    if( target_lifetime != PSA_KEY_LIFETIME_VOLATILE )
+    if( ! PSA_KEY_LIFETIME_IS_VOLATILE( target_lifetime ) )
     {
         TEST_ASSERT( mbedtls_svc_key_id_equal(
                          target_id, psa_get_key_id( &target_attributes ) ) );
@@ -657,7 +657,7 @@
     PSA_ASSERT( psa_crypto_init( ) );
 
     /* Populate the source slot. */
-    if( source_lifetime != PSA_KEY_LIFETIME_VOLATILE )
+    if( ! PSA_KEY_LIFETIME_IS_VOLATILE( source_lifetime ) )
     {
         psa_set_key_id( &attributes, source_id );
         psa_set_key_lifetime( &attributes, source_lifetime );