commit f2ffbc43878c971235253f815f3d1ce61012c92c
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Tue Dec 01 09:57:55 2020 +0100
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu Dec 03 12:25:09 2020 +0100
tree 6c2c53103b30eee693eaa288860b89fca9d9c9b9
parent 53f10e70fda847ef8c4c80cb6877c83e58c03891

Stop supporting NIST_KW in cipher_auth_xxcrypt()

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>

library/cipher.c

diff --git a/library/cipher.c b/library/cipher.c
index 20e1e7b..47dafa4 100644
--- a/library/cipher.c
+++ b/library/cipher.c
@@ -1491,16 +1491,10 @@
     if( MBEDTLS_MODE_KW == ctx->cipher_info->mode ||
         MBEDTLS_MODE_KWP == ctx->cipher_info->mode )
     {
-        mbedtls_nist_kw_mode_t mode = ( MBEDTLS_MODE_KW == ctx->cipher_info->mode ) ?
-                                        MBEDTLS_KW_MODE_KW : MBEDTLS_KW_MODE_KWP;
-
-        /* There is no iv, tag or ad associated with KW and KWP, these length should be 0 */
-        if( iv_len != 0 || tag_len != 0 || ad_len != 0 )
-        {
-            return( MBEDTLS_ERR_CIPHER_BAD_INPUT_DATA );
-        }
-
-        return( mbedtls_nist_kw_wrap( ctx->cipher_ctx, mode, input, ilen, output, olen, SIZE_MAX ) );
+        /* NIST_KW is not supported because we used to document the wrong size
+         * of the output buffer, so people should move to the _ext API,
+         * which has an explicit argument for buffer size. */
+        return( MBEDTLS_ERR_CIPHER_FEATURE_UNAVAILABLE );
     }
 #endif /* MBEDTLS_NIST_KW_C */
 
@@ -1531,16 +1525,10 @@
     if( MBEDTLS_MODE_KW == ctx->cipher_info->mode ||
         MBEDTLS_MODE_KWP == ctx->cipher_info->mode )
     {
-        mbedtls_nist_kw_mode_t mode = ( MBEDTLS_MODE_KW == ctx->cipher_info->mode ) ?
-                                        MBEDTLS_KW_MODE_KW : MBEDTLS_KW_MODE_KWP;
-
-        /* There is no iv, tag or ad associated with KW and KWP, these length should be 0 */
-        if( iv_len != 0 || tag_len != 0 || ad_len != 0 )
-        {
-            return( MBEDTLS_ERR_CIPHER_BAD_INPUT_DATA );
-        }
-
-        return( mbedtls_nist_kw_unwrap( ctx->cipher_ctx, mode, input, ilen, output, olen, SIZE_MAX ) );
+        /* NIST_KW is not supported because we used to document the wrong size
+         * of the output buffer, so people should move to the _ext API,
+         * which has an explicit argument for buffer size. */
+        return( MBEDTLS_ERR_CIPHER_FEATURE_UNAVAILABLE );
     }
 #endif /* MBEDTLS_NIST_KW_C */