commit f7a8814b723df9310ef826833631bb2bd131468f
author Gilles Peskine <Gilles.Peskine@arm.com> Tue Oct 02 22:43:06 2018 +0200
committer Gilles Peskine <Gilles.Peskine@arm.com> Mon Oct 08 11:38:50 2018 +0200
tree 3a78fc46eb324cbba92e3e70b18c00bd2858df8d
parent 5bcbd4e7f43356e25bde3aa9899ebdef1f42f170

Minor readability improvement

Polish the beginning of mbedtls_rsa_rsaes_pkcs1_v15_decrypt a little,
to prepare for some behavior changes.

library/rsa.c

diff --git a/library/rsa.c b/library/rsa.c
index 13beba4..29d7901 100644
--- a/library/rsa.c
+++ b/library/rsa.c
@@ -964,18 +964,20 @@
                                  int mode, size_t *olen,
                                  const unsigned char *input,
                                  unsigned char *output,
-                                 size_t output_max_len)
+                                 size_t output_max_len )
 {
     int ret;
-    size_t ilen, pad_count = 0, i;
-    unsigned char *p, bad, pad_done = 0;
+    size_t ilen = ctx->len;
+    size_t pad_count = 0;
+    size_t i;
+    unsigned bad = 0;
+    unsigned char pad_done = 0;
     unsigned char buf[MBEDTLS_MPI_MAX_SIZE];
+    unsigned char *p = buf;
 
     if( mode == MBEDTLS_RSA_PRIVATE && ctx->padding != MBEDTLS_RSA_PKCS_V15 )
         return( MBEDTLS_ERR_RSA_BAD_INPUT_DATA );
 
-    ilen = ctx->len;
-
     if( ilen < 16 || ilen > sizeof( buf ) )
         return( MBEDTLS_ERR_RSA_BAD_INPUT_DATA );
 
@@ -986,9 +988,6 @@
     if( ret != 0 )
         goto cleanup;
 
-    p = buf;
-    bad = 0;
-
     /*
      * Check and get padding len in "constant-time"
      */