commit fa24f9d6ea4be3aa5f91a0e9c5a13753022a6fd0
author Raef Coles <raef.coles@arm.com> Fri Sep 02 17:46:52 2022 +0100
committer Raef Coles <raef.coles@arm.com> Thu Oct 13 14:28:48 2022 +0100
tree a1145e00e2b60125ea60d797260893bca3dccbe7
parent 0a967ccf9ac868ddaf5f8da3cd4ab3a0119d81af

Minor fixes to LMS and LMOTS macros

Update some names, use the correct macro in certain places.

Signed-off-by: Raef Coles <raef.coles@arm.com>

library/lmots.c

diff --git a/library/lmots.c b/library/lmots.c
index fe01bf6..8e56696 100644
--- a/library/lmots.c
+++ b/library/lmots.c
@@ -194,7 +194,7 @@
         goto exit;
 
     status = psa_hash_finish( &op, out,
-                              MBEDTLS_LMOTS_P_SIG_DIGIT_COUNT(params->type),
+                              MBEDTLS_LMOTS_N_HASH_LEN(params->type),
                               &output_hash_len );
     ret = mbedtls_lms_error_from_psa( status );
     if( ret != 0 )

library/lmots.h

diff --git a/library/lmots.h b/library/lmots.h
index 03e44af..56d23f8 100644
--- a/library/lmots.h
+++ b/library/lmots.h
@@ -104,7 +104,7 @@
  */
 typedef struct {
     mbedtls_lmots_parameters_t MBEDTLS_PRIVATE(params);
-    unsigned char MBEDTLS_PRIVATE(public_key)[32];
+    unsigned char MBEDTLS_PRIVATE(public_key)[MBEDTLS_LMOTS_N_HASH_LEN_MAX];
     unsigned char MBEDTLS_PRIVATE(have_public_key); /*!< Whether the context contains a public key.
                                                      Boolean values only. */
 } mbedtls_lmots_public_t;
@@ -129,7 +129,7 @@
  */
 typedef struct {
     mbedtls_lmots_parameters_t MBEDTLS_PRIVATE(params);
-    unsigned char MBEDTLS_PRIVATE(private_key)[MBEDTLS_LMOTS_P_SIG_DIGIT_COUNT_MAX][32];
+    unsigned char MBEDTLS_PRIVATE(private_key)[MBEDTLS_LMOTS_P_SIG_DIGIT_COUNT_MAX][MBEDTLS_LMOTS_N_HASH_LEN_MAX];
     unsigned char MBEDTLS_PRIVATE(have_private_key); /*!< Whether the context contains a private key.
                                                      Boolean values only. */
 } mbedtls_lmots_private_t;

library/lms.c

diff --git a/library/lms.c b/library/lms.c
index e0f5946..26c48ef 100644
--- a/library/lms.c
+++ b/library/lms.c
@@ -205,7 +205,7 @@
     if( ret != 0 )
         goto exit;
 
-    status = psa_hash_update( &op, D_INTERNAL_CONSTANT_BYTES, D_CONST_LEN );
+    status = psa_hash_update( &op, D_INTR_CONSTANT_BYTES, D_CONST_LEN );
     ret = mbedtls_lms_error_from_psa( status );
     if( ret != 0 )
         goto exit;