commit fc735dffd600808fb998141274c8323e98bfb79f
author David Horstmann <david.horstmann@arm.com> Thu Oct 06 19:11:04 2022 +0100
committer David Horstmann <david.horstmann@arm.com> Fri Oct 07 14:08:42 2022 +0100
tree 2635a25af7cc14b91b25e50b42275dd4323bd4d6
parent 8a7629fd0ffc0709eb47cdaf4607e76f35fc009b

Refactor macro-spanning ifs in ecp.c

Signed-off-by: David Horstmann <david.horstmann@arm.com>

library/ecp.c

diff --git a/library/ecp.c b/library/ecp.c
index 009be61..2cec0a0 100644
--- a/library/ecp.c
+++ b/library/ecp.c
@@ -2287,12 +2287,14 @@
         mbedtls_free( T );
     }
 
-    /* don't free R while in progress in case R == P */
-#if defined(MBEDTLS_ECP_RESTARTABLE)
-    if( ret != MBEDTLS_ERR_ECP_IN_PROGRESS )
-#endif
+    int should_free_R = 0;
     /* prevent caller from using invalid value */
-    if( ret != 0 )
+    should_free_R = ( ret != 0 );
+#if defined(MBEDTLS_ECP_RESTARTABLE)
+    /* don't free R while in progress in case R == P */
+    should_free_R = should_free_R && ( ret != MBEDTLS_ERR_ECP_IN_PROGRESS );
+#endif
+    if( should_free_R )
         mbedtls_ecp_point_free( R );
 
     ECP_RS_LEAVE( rsm );
@@ -2537,10 +2539,12 @@
         MBEDTLS_MPI_CHK( mbedtls_internal_ecp_init( grp ) );
 #endif /* MBEDTLS_ECP_INTERNAL_ALT */
 
+    int restarting = 0;
 #if defined(MBEDTLS_ECP_RESTARTABLE)
-    /* skip argument check when restarting */
-    if( rs_ctx == NULL || rs_ctx->rsm == NULL )
+    restarting = ( rs_ctx != NULL && rs_ctx->rsm != NULL );
 #endif
+    /* skip argument check when restarting */
+    if( !restarting )
     {
         /* check_privkey is free */
         MBEDTLS_ECP_BUDGET( MBEDTLS_ECP_OPS_CHK );