commit fd56f409b3c3d864c545957600df662fe0679c2e
author Andrzej Kurek <andrzej.kurek@arm.com> Mon May 25 11:52:05 2020 -0400
committer Andrzej Kurek <andrzej.kurek@arm.com> Fri Jun 05 12:26:07 2020 -0400
tree 60e7e6393de887d223b9c521608319419478d555
parent 2d21e3e47b93e7f3722c04d4e92d2d0b8e9be735

Change the default value of status variables to an error


Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>

library/pk.c

diff --git a/library/pk.c b/library/pk.c
index caa5e17..8557513 100644
--- a/library/pk.c
+++ b/library/pk.c
@@ -576,8 +576,8 @@
                        const unsigned char *hash, size_t hash_len,
                        const unsigned char *sig, size_t sig_len )
 {
-    int ret;
-    volatile int ret_fi;
+    int ret = MBEDTLS_ERR_PLATFORM_FAULT_DETECTED;
+    volatile int ret_fi = UECC_FAULT_DETECTED;
     uint8_t signature[2*NUM_ECC_BYTES];
     unsigned char *p;
     const mbedtls_uecc_keypair *keypair = (const mbedtls_uecc_keypair *) ctx;
@@ -677,7 +677,7 @@
 static int pk_ecdsa_sig_asn1_from_uecc( unsigned char *sig, size_t *sig_len,
                                         size_t buf_len )
 {
-    int ret;
+    int ret = MBEDTLS_ERR_PLATFORM_FAULT_DETECTED;
     size_t len = 0;
     const size_t rs_len = *sig_len / 2;
     unsigned char *p = sig + buf_len;
@@ -691,10 +691,11 @@
     *--p = MBEDTLS_ASN1_CONSTRUCTED | MBEDTLS_ASN1_SEQUENCE;
     len += 2;
 
+    ret = 0;
     memmove( sig, p, len );
     *sig_len = len;
 
-    return( 0 );
+    return( ret );
 }
 
 static int uecc_eckey_sign_wrap( void *ctx, mbedtls_md_type_t md_alg,