tree d5e82d4c7681f515ae443c5bd22e7400dd6ce263
parent 7fe2c5f086770a0f90ec5c15cc85880f3751568d
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> 1597910373 +0200
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> 1597911692 +0200

Fix memory leak in test_suite_x509write with PSA crypto

The documentation of mbedtls_pk_wrap_as_opaque is quite clear:

 * \param handle    Output: a PSA key handle.
 *                  It's the caller's responsibility to call
 *                  psa_destroy_key() on that handle after calling
 *                  mbedtls_pk_free() on the PK context.

But the test failed to call psa_destroy_key().

While at it, also use PSA_DONE(): it ensures that if we fail to destroy the
key, we'll get an explicit error message about it without the need for
valgrind.

This is a preliminary to adding a valgrind-based test for constant-flow code:
we need to make sure the rest of the tests are fully valgrind-clean, which
they weren't.

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>