gabor-mezei-arm | d112534 | 2021-07-12 16:31:22 +0200 | [diff] [blame] | 1 | /** |
| 2 | * Constant-time functions |
| 3 | * |
| 4 | * Copyright The Mbed TLS Contributors |
| 5 | * SPDX-License-Identifier: Apache-2.0 |
| 6 | * |
| 7 | * Licensed under the Apache License, Version 2.0 (the "License"); you may |
| 8 | * not use this file except in compliance with the License. |
| 9 | * You may obtain a copy of the License at |
| 10 | * |
| 11 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 12 | * |
| 13 | * Unless required by applicable law or agreed to in writing, software |
| 14 | * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT |
| 15 | * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 16 | * See the License for the specific language governing permissions and |
| 17 | * limitations under the License. |
| 18 | */ |
| 19 | |
| 20 | #include "common.h" |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 21 | #include "constant_time.h" |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 22 | #include "mbedtls/error.h" |
gabor-mezei-arm | 5b3a32d | 2021-09-29 10:50:31 +0200 | [diff] [blame] | 23 | #include "mbedtls/platform_util.h" |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 24 | |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 25 | #if defined(MBEDTLS_BIGNUM_C) |
| 26 | #include "mbedtls/bignum.h" |
| 27 | #endif |
| 28 | |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 29 | #if defined(MBEDTLS_SSL_TLS_C) |
| 30 | #include "ssl_misc.h" |
| 31 | #endif |
| 32 | |
gabor-mezei-arm | 5b3a32d | 2021-09-29 10:50:31 +0200 | [diff] [blame] | 33 | #if defined(MBEDTLS_RSA_C) |
| 34 | #include "mbedtls/rsa.h" |
| 35 | #endif |
| 36 | |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 37 | #include <string.h> |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 38 | |
gabor-mezei-arm | 4602564 | 2021-07-19 15:19:19 +0200 | [diff] [blame] | 39 | int mbedtls_cf_memcmp( const void *a, |
| 40 | const void *b, |
| 41 | size_t n ) |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 42 | { |
| 43 | size_t i; |
| 44 | volatile const unsigned char *A = (volatile const unsigned char *) a; |
| 45 | volatile const unsigned char *B = (volatile const unsigned char *) b; |
| 46 | volatile unsigned char diff = 0; |
| 47 | |
| 48 | for( i = 0; i < n; i++ ) |
| 49 | { |
| 50 | /* Read volatile data in order before computing diff. |
| 51 | * This avoids IAR compiler warning: |
| 52 | * 'the order of volatile accesses is undefined ..' */ |
| 53 | unsigned char x = A[i], y = B[i]; |
| 54 | diff |= x ^ y; |
| 55 | } |
| 56 | |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 57 | return( (int)diff ); |
| 58 | } |
| 59 | |
gabor-mezei-arm | 340948e | 2021-09-27 11:40:03 +0200 | [diff] [blame] | 60 | unsigned mbedtls_cf_uint_mask( unsigned value ) |
| 61 | { |
| 62 | /* MSVC has a warning about unary minus on unsigned, but this is |
| 63 | * well-defined and precisely what we want to do here */ |
| 64 | #if defined(_MSC_VER) |
| 65 | #pragma warning( push ) |
| 66 | #pragma warning( disable : 4146 ) |
| 67 | #endif |
| 68 | return( - ( ( value | - value ) >> ( sizeof( value ) * 8 - 1 ) ) ); |
| 69 | #if defined(_MSC_VER) |
| 70 | #pragma warning( pop ) |
| 71 | #endif |
| 72 | } |
gabor-mezei-arm | 3733bf8 | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 73 | |
gabor-mezei-arm | 396438c | 2021-08-10 20:56:21 +0200 | [diff] [blame] | 74 | size_t mbedtls_cf_size_mask( size_t value ) |
gabor-mezei-arm | 3733bf8 | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 75 | { |
| 76 | /* MSVC has a warning about unary minus on unsigned integer types, |
| 77 | * but this is well-defined and precisely what we want to do here. */ |
| 78 | #if defined(_MSC_VER) |
| 79 | #pragma warning( push ) |
| 80 | #pragma warning( disable : 4146 ) |
| 81 | #endif |
gabor-mezei-arm | 396438c | 2021-08-10 20:56:21 +0200 | [diff] [blame] | 82 | return( - ( ( value | - value ) >> ( sizeof( value ) * 8 - 1 ) ) ); |
gabor-mezei-arm | 3733bf8 | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 83 | #if defined(_MSC_VER) |
| 84 | #pragma warning( pop ) |
| 85 | #endif |
| 86 | } |
gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 87 | |
gabor-mezei-arm | 9cb5569 | 2021-08-11 15:07:02 +0200 | [diff] [blame] | 88 | #if defined(MBEDTLS_BIGNUM_C) |
| 89 | |
| 90 | mbedtls_mpi_uint mbedtls_cf_mpi_uint_mask( mbedtls_mpi_uint value ) |
| 91 | { |
| 92 | /* MSVC has a warning about unary minus on unsigned, but this is |
| 93 | * well-defined and precisely what we want to do here */ |
| 94 | #if defined(_MSC_VER) |
| 95 | #pragma warning( push ) |
| 96 | #pragma warning( disable : 4146 ) |
| 97 | #endif |
| 98 | return( - ( ( value | - value ) >> ( sizeof( value ) * 8 - 1 ) ) ); |
| 99 | #if defined(_MSC_VER) |
| 100 | #pragma warning( pop ) |
| 101 | #endif |
| 102 | } |
| 103 | |
| 104 | #endif /* MBEDTLS_BIGNUM_C */ |
| 105 | |
Gabor Mezei | 1e64261 | 2021-10-18 16:05:50 +0200 | [diff] [blame^] | 106 | /** Constant-flow mask generation for "less than" comparison: |
| 107 | * - if \p x < \p y, return all-bits 1, that is (size_t) -1 |
| 108 | * - otherwise, return all bits 0, that is 0 |
| 109 | * |
| 110 | * This function can be used to write constant-time code by replacing branches |
| 111 | * with bit operations using masks. |
| 112 | * |
| 113 | * \param x The first value to analyze. |
| 114 | * \param y The second value to analyze. |
| 115 | * |
| 116 | * \return All-bits-one if \p x is less than \p y, otherwise zero. |
| 117 | */ |
| 118 | static size_t mbedtls_cf_size_mask_lt( size_t x, |
| 119 | size_t y ) |
gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 120 | { |
| 121 | /* This has the most significant bit set if and only if x < y */ |
| 122 | const size_t sub = x - y; |
| 123 | |
| 124 | /* sub1 = (x < y) ? 1 : 0 */ |
| 125 | const size_t sub1 = sub >> ( sizeof( sub ) * 8 - 1 ); |
| 126 | |
| 127 | /* mask = (x < y) ? 0xff... : 0x00... */ |
| 128 | const size_t mask = mbedtls_cf_size_mask( sub1 ); |
| 129 | |
| 130 | return( mask ); |
| 131 | } |
gabor-mezei-arm | 16fc57b | 2021-09-27 11:58:31 +0200 | [diff] [blame] | 132 | |
gabor-mezei-arm | 2dcd768 | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 133 | size_t mbedtls_cf_size_mask_ge( size_t x, |
| 134 | size_t y ) |
gabor-mezei-arm | 16fc57b | 2021-09-27 11:58:31 +0200 | [diff] [blame] | 135 | { |
| 136 | return( ~mbedtls_cf_size_mask_lt( x, y ) ); |
| 137 | } |
gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 138 | |
gabor-mezei-arm | b11a56e | 2021-08-11 17:28:49 +0200 | [diff] [blame] | 139 | unsigned mbedtls_cf_size_bool_eq( size_t x, |
| 140 | size_t y ) |
gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 141 | { |
| 142 | /* diff = 0 if x == y, non-zero otherwise */ |
| 143 | const size_t diff = x ^ y; |
| 144 | |
| 145 | /* MSVC has a warning about unary minus on unsigned integer types, |
| 146 | * but this is well-defined and precisely what we want to do here. */ |
| 147 | #if defined(_MSC_VER) |
| 148 | #pragma warning( push ) |
| 149 | #pragma warning( disable : 4146 ) |
| 150 | #endif |
| 151 | |
| 152 | /* diff_msb's most significant bit is equal to x != y */ |
| 153 | const size_t diff_msb = ( diff | (size_t) -diff ); |
| 154 | |
| 155 | #if defined(_MSC_VER) |
| 156 | #pragma warning( pop ) |
| 157 | #endif |
| 158 | |
| 159 | /* diff1 = (x != y) ? 1 : 0 */ |
gabor-mezei-arm | b11a56e | 2021-08-11 17:28:49 +0200 | [diff] [blame] | 160 | const unsigned diff1 = diff_msb >> ( sizeof( diff_msb ) * 8 - 1 ); |
gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 161 | |
| 162 | return( 1 ^ diff1 ); |
| 163 | } |
gabor-mezei-arm | 5a85442 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 164 | |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 165 | unsigned mbedtls_cf_size_gt( size_t x, |
| 166 | size_t y ) |
gabor-mezei-arm | 5a85442 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 167 | { |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 168 | /* Return the sign bit (1 for negative) of (y - x). */ |
| 169 | return( ( y - x ) >> ( sizeof( size_t ) * 8 - 1 ) ); |
gabor-mezei-arm | 5a85442 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 170 | } |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 171 | |
| 172 | #if defined(MBEDTLS_BIGNUM_C) |
| 173 | |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 174 | unsigned mbedtls_cf_mpi_uint_lt( const mbedtls_mpi_uint x, |
gabor-mezei-arm | 2dcd768 | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 175 | const mbedtls_mpi_uint y ) |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 176 | { |
| 177 | mbedtls_mpi_uint ret; |
| 178 | mbedtls_mpi_uint cond; |
| 179 | |
| 180 | /* |
| 181 | * Check if the most significant bits (MSB) of the operands are different. |
| 182 | */ |
| 183 | cond = ( x ^ y ); |
| 184 | /* |
| 185 | * If the MSB are the same then the difference x-y will be negative (and |
| 186 | * have its MSB set to 1 during conversion to unsigned) if and only if x<y. |
| 187 | */ |
| 188 | ret = ( x - y ) & ~cond; |
| 189 | /* |
| 190 | * If the MSB are different, then the operand with the MSB of 1 is the |
| 191 | * bigger. (That is if y has MSB of 1, then x<y is true and it is false if |
| 192 | * the MSB of y is 0.) |
| 193 | */ |
| 194 | ret |= y & cond; |
| 195 | |
| 196 | |
| 197 | ret = ret >> ( sizeof( mbedtls_mpi_uint ) * 8 - 1 ); |
| 198 | |
| 199 | return (unsigned) ret; |
| 200 | } |
| 201 | |
| 202 | #endif /* MBEDTLS_BIGNUM_C */ |
gabor-mezei-arm | b2dbf2c | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 203 | |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 204 | unsigned mbedtls_cf_uint_if( unsigned condition, |
gabor-mezei-arm | 2dcd768 | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 205 | unsigned if1, |
| 206 | unsigned if0 ) |
gabor-mezei-arm | b2dbf2c | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 207 | { |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 208 | unsigned mask = mbedtls_cf_uint_mask( condition ); |
gabor-mezei-arm | b2dbf2c | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 209 | return( ( mask & if1 ) | (~mask & if0 ) ); |
| 210 | } |
gabor-mezei-arm | d3230d5 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 211 | |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 212 | size_t mbedtls_cf_size_if( unsigned condition, |
gabor-mezei-arm | 2dcd768 | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 213 | size_t if1, |
| 214 | size_t if0 ) |
gabor-mezei-arm | 65cefdb | 2021-09-27 15:47:00 +0200 | [diff] [blame] | 215 | { |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 216 | size_t mask = mbedtls_cf_size_mask( condition ); |
gabor-mezei-arm | 65cefdb | 2021-09-27 15:47:00 +0200 | [diff] [blame] | 217 | return( ( mask & if1 ) | (~mask & if0 ) ); |
| 218 | } |
| 219 | |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 220 | int mbedtls_cf_cond_select_sign( unsigned char condition, |
| 221 | int if1, |
| 222 | int if0 ) |
gabor-mezei-arm | d3230d5 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 223 | { |
| 224 | /* In order to avoid questions about what we can reasonnably assume about |
| 225 | * the representations of signed integers, move everything to unsigned |
| 226 | * by taking advantage of the fact that a and b are either +1 or -1. */ |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 227 | unsigned uif1 = if1 + 1; |
| 228 | unsigned uif0 = if0 + 1; |
gabor-mezei-arm | d3230d5 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 229 | |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 230 | /* condition was 0 or 1, mask is 0 or 2 as are ua and ub */ |
| 231 | const unsigned mask = condition << 1; |
gabor-mezei-arm | d3230d5 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 232 | |
| 233 | /* select ua or ub */ |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 234 | unsigned ur = ( uif0 & ~mask ) | ( uif1 & mask ); |
gabor-mezei-arm | d3230d5 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 235 | |
| 236 | /* ur is now 0 or 2, convert back to -1 or +1 */ |
| 237 | return( (int) ur - 1 ); |
| 238 | } |
gabor-mezei-arm | be8d98b | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 239 | |
| 240 | #if defined(MBEDTLS_BIGNUM_C) |
| 241 | |
gabor-mezei-arm | be8d98b | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 242 | void mbedtls_cf_mpi_uint_cond_assign( size_t n, |
| 243 | mbedtls_mpi_uint *dest, |
| 244 | const mbedtls_mpi_uint *src, |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 245 | unsigned char condition ) |
gabor-mezei-arm | be8d98b | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 246 | { |
| 247 | size_t i; |
| 248 | |
| 249 | /* MSVC has a warning about unary minus on unsigned integer types, |
| 250 | * but this is well-defined and precisely what we want to do here. */ |
| 251 | #if defined(_MSC_VER) |
| 252 | #pragma warning( push ) |
| 253 | #pragma warning( disable : 4146 ) |
| 254 | #endif |
| 255 | |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 256 | /* all-bits 1 if condition is 1, all-bits 0 if condition is 0 */ |
| 257 | const mbedtls_mpi_uint mask = -condition; |
gabor-mezei-arm | be8d98b | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 258 | |
| 259 | #if defined(_MSC_VER) |
| 260 | #pragma warning( pop ) |
| 261 | #endif |
| 262 | |
| 263 | for( i = 0; i < n; i++ ) |
| 264 | dest[i] = ( src[i] & mask ) | ( dest[i] & ~mask ); |
| 265 | } |
| 266 | |
| 267 | #endif /* MBEDTLS_BIGNUM_C */ |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 268 | |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 269 | void mbedtls_cf_mem_move_to_left( void *start, |
gabor-mezei-arm | 2dcd768 | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 270 | size_t total, |
| 271 | size_t offset ) |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 272 | { |
| 273 | volatile unsigned char *buf = start; |
| 274 | size_t i, n; |
| 275 | if( total == 0 ) |
| 276 | return; |
| 277 | for( i = 0; i < total; i++ ) |
| 278 | { |
| 279 | unsigned no_op = mbedtls_cf_size_gt( total - offset, i ); |
| 280 | /* The first `total - offset` passes are a no-op. The last |
| 281 | * `offset` passes shift the data one byte to the left and |
| 282 | * zero out the last byte. */ |
| 283 | for( n = 0; n < total - 1; n++ ) |
| 284 | { |
| 285 | unsigned char current = buf[n]; |
| 286 | unsigned char next = buf[n+1]; |
| 287 | buf[n] = mbedtls_cf_uint_if( no_op, current, next ); |
| 288 | } |
| 289 | buf[total-1] = mbedtls_cf_uint_if( no_op, buf[total-1], 0 ); |
| 290 | } |
| 291 | } |
gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 292 | |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 293 | void mbedtls_cf_memcpy_if_eq( unsigned char *dest, |
gabor-mezei-arm | 2dcd768 | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 294 | const unsigned char *src, |
| 295 | size_t len, |
| 296 | size_t c1, |
| 297 | size_t c2 ) |
gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 298 | { |
| 299 | /* mask = c1 == c2 ? 0xff : 0x00 */ |
| 300 | const size_t equal = mbedtls_cf_size_bool_eq( c1, c2 ); |
| 301 | const unsigned char mask = (unsigned char) mbedtls_cf_size_mask( equal ); |
| 302 | |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 303 | /* dest[i] = c1 == c2 ? src[i] : dest[i] */ |
gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 304 | for( size_t i = 0; i < len; i++ ) |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 305 | dest[i] = ( src[i] & mask ) | ( dest[i] & ~mask ); |
gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 306 | } |
gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 307 | |
gabor-mezei-arm | 2dcd768 | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 308 | void mbedtls_cf_memcpy_offset( unsigned char *dst, |
| 309 | const unsigned char *src_base, |
| 310 | size_t offset_secret, |
| 311 | size_t offset_min, |
| 312 | size_t offset_max, |
| 313 | size_t len ) |
gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 314 | { |
| 315 | size_t offset; |
| 316 | |
| 317 | for( offset = offset_min; offset <= offset_max; offset++ ) |
| 318 | { |
| 319 | mbedtls_cf_memcpy_if_eq( dst, src_base + offset, len, |
| 320 | offset, offset_secret ); |
| 321 | } |
| 322 | } |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 323 | |
| 324 | #if defined(MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC) |
| 325 | |
gabor-mezei-arm | 2dcd768 | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 326 | int mbedtls_cf_hmac( mbedtls_md_context_t *ctx, |
| 327 | const unsigned char *add_data, |
| 328 | size_t add_data_len, |
| 329 | const unsigned char *data, |
| 330 | size_t data_len_secret, |
| 331 | size_t min_data_len, |
| 332 | size_t max_data_len, |
| 333 | unsigned char *output ) |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 334 | { |
| 335 | /* |
| 336 | * This function breaks the HMAC abstraction and uses the md_clone() |
| 337 | * extension to the MD API in order to get constant-flow behaviour. |
| 338 | * |
| 339 | * HMAC(msg) is defined as HASH(okey + HASH(ikey + msg)) where + means |
| 340 | * concatenation, and okey/ikey are the XOR of the key with some fixed bit |
| 341 | * patterns (see RFC 2104, sec. 2), which are stored in ctx->hmac_ctx. |
| 342 | * |
| 343 | * We'll first compute inner_hash = HASH(ikey + msg) by hashing up to |
| 344 | * minlen, then cloning the context, and for each byte up to maxlen |
| 345 | * finishing up the hash computation, keeping only the correct result. |
| 346 | * |
| 347 | * Then we only need to compute HASH(okey + inner_hash) and we're done. |
| 348 | */ |
| 349 | const mbedtls_md_type_t md_alg = mbedtls_md_get_type( ctx->md_info ); |
| 350 | /* TLS 1.2 only supports SHA-384, SHA-256, SHA-1, MD-5, |
| 351 | * all of which have the same block size except SHA-384. */ |
| 352 | const size_t block_size = md_alg == MBEDTLS_MD_SHA384 ? 128 : 64; |
| 353 | const unsigned char * const ikey = ctx->hmac_ctx; |
| 354 | const unsigned char * const okey = ikey + block_size; |
| 355 | const size_t hash_size = mbedtls_md_get_size( ctx->md_info ); |
| 356 | |
| 357 | unsigned char aux_out[MBEDTLS_MD_MAX_SIZE]; |
| 358 | mbedtls_md_context_t aux; |
| 359 | size_t offset; |
| 360 | int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED; |
| 361 | |
| 362 | mbedtls_md_init( &aux ); |
| 363 | |
| 364 | #define MD_CHK( func_call ) \ |
| 365 | do { \ |
| 366 | ret = (func_call); \ |
| 367 | if( ret != 0 ) \ |
| 368 | goto cleanup; \ |
| 369 | } while( 0 ) |
| 370 | |
| 371 | MD_CHK( mbedtls_md_setup( &aux, ctx->md_info, 0 ) ); |
| 372 | |
| 373 | /* After hmac_start() of hmac_reset(), ikey has already been hashed, |
| 374 | * so we can start directly with the message */ |
| 375 | MD_CHK( mbedtls_md_update( ctx, add_data, add_data_len ) ); |
| 376 | MD_CHK( mbedtls_md_update( ctx, data, min_data_len ) ); |
| 377 | |
| 378 | /* For each possible length, compute the hash up to that point */ |
| 379 | for( offset = min_data_len; offset <= max_data_len; offset++ ) |
| 380 | { |
| 381 | MD_CHK( mbedtls_md_clone( &aux, ctx ) ); |
| 382 | MD_CHK( mbedtls_md_finish( &aux, aux_out ) ); |
| 383 | /* Keep only the correct inner_hash in the output buffer */ |
| 384 | mbedtls_cf_memcpy_if_eq( output, aux_out, hash_size, |
| 385 | offset, data_len_secret ); |
| 386 | |
| 387 | if( offset < max_data_len ) |
| 388 | MD_CHK( mbedtls_md_update( ctx, data + offset, 1 ) ); |
| 389 | } |
| 390 | |
| 391 | /* The context needs to finish() before it starts() again */ |
| 392 | MD_CHK( mbedtls_md_finish( ctx, aux_out ) ); |
| 393 | |
| 394 | /* Now compute HASH(okey + inner_hash) */ |
| 395 | MD_CHK( mbedtls_md_starts( ctx ) ); |
| 396 | MD_CHK( mbedtls_md_update( ctx, okey, block_size ) ); |
| 397 | MD_CHK( mbedtls_md_update( ctx, output, hash_size ) ); |
| 398 | MD_CHK( mbedtls_md_finish( ctx, output ) ); |
| 399 | |
| 400 | /* Done, get ready for next time */ |
| 401 | MD_CHK( mbedtls_md_hmac_reset( ctx ) ); |
| 402 | |
| 403 | #undef MD_CHK |
| 404 | |
| 405 | cleanup: |
| 406 | mbedtls_md_free( &aux ); |
| 407 | return( ret ); |
| 408 | } |
| 409 | |
| 410 | #endif /* MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC */ |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 411 | |
| 412 | #if defined(MBEDTLS_BIGNUM_C) |
| 413 | |
| 414 | #define MPI_VALIDATE_RET( cond ) \ |
| 415 | MBEDTLS_INTERNAL_VALIDATE_RET( cond, MBEDTLS_ERR_MPI_BAD_INPUT_DATA ) |
| 416 | |
| 417 | /* |
| 418 | * Conditionally assign X = Y, without leaking information |
| 419 | * about whether the assignment was made or not. |
| 420 | * (Leaking information about the respective sizes of X and Y is ok however.) |
| 421 | */ |
gabor-mezei-arm | 2dcd768 | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 422 | int mbedtls_mpi_safe_cond_assign( mbedtls_mpi *X, |
| 423 | const mbedtls_mpi *Y, |
| 424 | unsigned char assign ) |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 425 | { |
| 426 | int ret = 0; |
| 427 | size_t i; |
| 428 | mbedtls_mpi_uint limb_mask; |
| 429 | MPI_VALIDATE_RET( X != NULL ); |
| 430 | MPI_VALIDATE_RET( Y != NULL ); |
| 431 | |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 432 | /* all-bits 1 if assign is 1, all-bits 0 if assign is 0 */ |
gabor-mezei-arm | 9cb5569 | 2021-08-11 15:07:02 +0200 | [diff] [blame] | 433 | limb_mask = mbedtls_cf_mpi_uint_mask( assign );; |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 434 | |
| 435 | MBEDTLS_MPI_CHK( mbedtls_mpi_grow( X, Y->n ) ); |
| 436 | |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 437 | X->s = mbedtls_cf_cond_select_sign( assign, Y->s, X->s ); |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 438 | |
| 439 | mbedtls_cf_mpi_uint_cond_assign( Y->n, X->p, Y->p, assign ); |
| 440 | |
| 441 | for( i = Y->n; i < X->n; i++ ) |
| 442 | X->p[i] &= ~limb_mask; |
| 443 | |
| 444 | cleanup: |
| 445 | return( ret ); |
| 446 | } |
| 447 | |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 448 | /* |
| 449 | * Conditionally swap X and Y, without leaking information |
| 450 | * about whether the swap was made or not. |
| 451 | * Here it is not ok to simply swap the pointers, which whould lead to |
| 452 | * different memory access patterns when X and Y are used afterwards. |
| 453 | */ |
gabor-mezei-arm | 2dcd768 | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 454 | int mbedtls_mpi_safe_cond_swap( mbedtls_mpi *X, |
| 455 | mbedtls_mpi *Y, |
| 456 | unsigned char swap ) |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 457 | { |
| 458 | int ret, s; |
| 459 | size_t i; |
| 460 | mbedtls_mpi_uint limb_mask; |
| 461 | mbedtls_mpi_uint tmp; |
| 462 | MPI_VALIDATE_RET( X != NULL ); |
| 463 | MPI_VALIDATE_RET( Y != NULL ); |
| 464 | |
| 465 | if( X == Y ) |
| 466 | return( 0 ); |
| 467 | |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 468 | /* all-bits 1 if swap is 1, all-bits 0 if swap is 0 */ |
gabor-mezei-arm | 9cb5569 | 2021-08-11 15:07:02 +0200 | [diff] [blame] | 469 | limb_mask = mbedtls_cf_mpi_uint_mask( swap ); |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 470 | |
| 471 | MBEDTLS_MPI_CHK( mbedtls_mpi_grow( X, Y->n ) ); |
| 472 | MBEDTLS_MPI_CHK( mbedtls_mpi_grow( Y, X->n ) ); |
| 473 | |
| 474 | s = X->s; |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 475 | X->s = mbedtls_cf_cond_select_sign( swap, Y->s, X->s ); |
| 476 | Y->s = mbedtls_cf_cond_select_sign( swap, s, Y->s ); |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 477 | |
| 478 | |
| 479 | for( i = 0; i < X->n; i++ ) |
| 480 | { |
| 481 | tmp = X->p[i]; |
| 482 | X->p[i] = ( X->p[i] & ~limb_mask ) | ( Y->p[i] & limb_mask ); |
| 483 | Y->p[i] = ( Y->p[i] & ~limb_mask ) | ( tmp & limb_mask ); |
| 484 | } |
| 485 | |
| 486 | cleanup: |
| 487 | return( ret ); |
| 488 | } |
| 489 | |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 490 | /* |
| 491 | * Compare signed values in constant time |
| 492 | */ |
gabor-mezei-arm | 2dcd768 | 2021-09-27 16:29:52 +0200 | [diff] [blame] | 493 | int mbedtls_mpi_lt_mpi_ct( const mbedtls_mpi *X, |
| 494 | const mbedtls_mpi *Y, |
| 495 | unsigned *ret ) |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 496 | { |
| 497 | size_t i; |
| 498 | /* The value of any of these variables is either 0 or 1 at all times. */ |
| 499 | unsigned cond, done, X_is_negative, Y_is_negative; |
| 500 | |
| 501 | MPI_VALIDATE_RET( X != NULL ); |
| 502 | MPI_VALIDATE_RET( Y != NULL ); |
| 503 | MPI_VALIDATE_RET( ret != NULL ); |
| 504 | |
| 505 | if( X->n != Y->n ) |
| 506 | return MBEDTLS_ERR_MPI_BAD_INPUT_DATA; |
| 507 | |
| 508 | /* |
| 509 | * Set sign_N to 1 if N >= 0, 0 if N < 0. |
| 510 | * We know that N->s == 1 if N >= 0 and N->s == -1 if N < 0. |
| 511 | */ |
| 512 | X_is_negative = ( X->s & 2 ) >> 1; |
| 513 | Y_is_negative = ( Y->s & 2 ) >> 1; |
| 514 | |
| 515 | /* |
| 516 | * If the signs are different, then the positive operand is the bigger. |
| 517 | * That is if X is negative (X_is_negative == 1), then X < Y is true and it |
| 518 | * is false if X is positive (X_is_negative == 0). |
| 519 | */ |
| 520 | cond = ( X_is_negative ^ Y_is_negative ); |
| 521 | *ret = cond & X_is_negative; |
| 522 | |
| 523 | /* |
| 524 | * This is a constant-time function. We might have the result, but we still |
| 525 | * need to go through the loop. Record if we have the result already. |
| 526 | */ |
| 527 | done = cond; |
| 528 | |
| 529 | for( i = X->n; i > 0; i-- ) |
| 530 | { |
| 531 | /* |
| 532 | * If Y->p[i - 1] < X->p[i - 1] then X < Y is true if and only if both |
| 533 | * X and Y are negative. |
| 534 | * |
| 535 | * Again even if we can make a decision, we just mark the result and |
| 536 | * the fact that we are done and continue looping. |
| 537 | */ |
| 538 | cond = mbedtls_cf_mpi_uint_lt( Y->p[i - 1], X->p[i - 1] ); |
| 539 | *ret |= cond & ( 1 - done ) & X_is_negative; |
| 540 | done |= cond; |
| 541 | |
| 542 | /* |
| 543 | * If X->p[i - 1] < Y->p[i - 1] then X < Y is true if and only if both |
| 544 | * X and Y are positive. |
| 545 | * |
| 546 | * Again even if we can make a decision, we just mark the result and |
| 547 | * the fact that we are done and continue looping. |
| 548 | */ |
| 549 | cond = mbedtls_cf_mpi_uint_lt( X->p[i - 1], Y->p[i - 1] ); |
| 550 | *ret |= cond & ( 1 - done ) & ( 1 - X_is_negative ); |
| 551 | done |= cond; |
| 552 | } |
| 553 | |
| 554 | return( 0 ); |
| 555 | } |
| 556 | |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 557 | #endif /* MBEDTLS_BIGNUM_C */ |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 558 | |
| 559 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) |
| 560 | |
| 561 | int mbedtls_cf_rsaes_pkcs1_v15_unpadding( size_t ilen, |
| 562 | size_t *olen, |
| 563 | unsigned char *output, |
| 564 | size_t output_max_len, |
| 565 | unsigned char *buf ) |
| 566 | { |
| 567 | int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED; |
| 568 | size_t i, plaintext_max_size; |
| 569 | |
| 570 | /* The following variables take sensitive values: their value must |
| 571 | * not leak into the observable behavior of the function other than |
| 572 | * the designated outputs (output, olen, return value). Otherwise |
| 573 | * this would open the execution of the function to |
| 574 | * side-channel-based variants of the Bleichenbacher padding oracle |
| 575 | * attack. Potential side channels include overall timing, memory |
| 576 | * access patterns (especially visible to an adversary who has access |
| 577 | * to a shared memory cache), and branches (especially visible to |
| 578 | * an adversary who has access to a shared code cache or to a shared |
| 579 | * branch predictor). */ |
| 580 | size_t pad_count = 0; |
| 581 | unsigned bad = 0; |
| 582 | unsigned char pad_done = 0; |
| 583 | size_t plaintext_size = 0; |
| 584 | unsigned output_too_large; |
| 585 | |
| 586 | plaintext_max_size = mbedtls_cf_size_if( output_max_len > ilen - 11, |
| 587 | ilen - 11, |
| 588 | output_max_len ); |
| 589 | |
| 590 | /* Check and get padding length in constant time and constant |
| 591 | * memory trace. The first byte must be 0. */ |
| 592 | bad |= buf[0]; |
| 593 | |
| 594 | |
| 595 | /* Decode EME-PKCS1-v1_5 padding: 0x00 || 0x02 || PS || 0x00 |
| 596 | * where PS must be at least 8 nonzero bytes. */ |
| 597 | bad |= buf[1] ^ MBEDTLS_RSA_CRYPT; |
| 598 | |
| 599 | /* Read the whole buffer. Set pad_done to nonzero if we find |
| 600 | * the 0x00 byte and remember the padding length in pad_count. */ |
| 601 | for( i = 2; i < ilen; i++ ) |
| 602 | { |
| 603 | pad_done |= ((buf[i] | (unsigned char)-buf[i]) >> 7) ^ 1; |
| 604 | pad_count += ((pad_done | (unsigned char)-pad_done) >> 7) ^ 1; |
| 605 | } |
| 606 | |
| 607 | |
| 608 | /* If pad_done is still zero, there's no data, only unfinished padding. */ |
| 609 | bad |= mbedtls_cf_uint_if( pad_done, 0, 1 ); |
| 610 | |
| 611 | /* There must be at least 8 bytes of padding. */ |
| 612 | bad |= mbedtls_cf_size_gt( 8, pad_count ); |
| 613 | |
| 614 | /* If the padding is valid, set plaintext_size to the number of |
| 615 | * remaining bytes after stripping the padding. If the padding |
| 616 | * is invalid, avoid leaking this fact through the size of the |
| 617 | * output: use the maximum message size that fits in the output |
| 618 | * buffer. Do it without branches to avoid leaking the padding |
| 619 | * validity through timing. RSA keys are small enough that all the |
| 620 | * size_t values involved fit in unsigned int. */ |
| 621 | plaintext_size = mbedtls_cf_uint_if( |
| 622 | bad, (unsigned) plaintext_max_size, |
| 623 | (unsigned) ( ilen - pad_count - 3 ) ); |
| 624 | |
| 625 | /* Set output_too_large to 0 if the plaintext fits in the output |
| 626 | * buffer and to 1 otherwise. */ |
| 627 | output_too_large = mbedtls_cf_size_gt( plaintext_size, |
| 628 | plaintext_max_size ); |
| 629 | |
| 630 | /* Set ret without branches to avoid timing attacks. Return: |
| 631 | * - INVALID_PADDING if the padding is bad (bad != 0). |
| 632 | * - OUTPUT_TOO_LARGE if the padding is good but the decrypted |
| 633 | * plaintext does not fit in the output buffer. |
| 634 | * - 0 if the padding is correct. */ |
| 635 | ret = - (int) mbedtls_cf_uint_if( |
| 636 | bad, - MBEDTLS_ERR_RSA_INVALID_PADDING, |
| 637 | mbedtls_cf_uint_if( output_too_large, |
| 638 | - MBEDTLS_ERR_RSA_OUTPUT_TOO_LARGE, |
| 639 | 0 ) ); |
| 640 | |
| 641 | /* If the padding is bad or the plaintext is too large, zero the |
| 642 | * data that we're about to copy to the output buffer. |
| 643 | * We need to copy the same amount of data |
| 644 | * from the same buffer whether the padding is good or not to |
| 645 | * avoid leaking the padding validity through overall timing or |
| 646 | * through memory or cache access patterns. */ |
| 647 | bad = mbedtls_cf_uint_mask( bad | output_too_large ); |
| 648 | for( i = 11; i < ilen; i++ ) |
| 649 | buf[i] &= ~bad; |
| 650 | |
| 651 | /* If the plaintext is too large, truncate it to the buffer size. |
| 652 | * Copy anyway to avoid revealing the length through timing, because |
| 653 | * revealing the length is as bad as revealing the padding validity |
| 654 | * for a Bleichenbacher attack. */ |
| 655 | plaintext_size = mbedtls_cf_uint_if( output_too_large, |
| 656 | (unsigned) plaintext_max_size, |
| 657 | (unsigned) plaintext_size ); |
| 658 | |
| 659 | /* Move the plaintext to the leftmost position where it can start in |
| 660 | * the working buffer, i.e. make it start plaintext_max_size from |
| 661 | * the end of the buffer. Do this with a memory access trace that |
| 662 | * does not depend on the plaintext size. After this move, the |
| 663 | * starting location of the plaintext is no longer sensitive |
| 664 | * information. */ |
| 665 | mbedtls_cf_mem_move_to_left( buf + ilen - plaintext_max_size, |
| 666 | plaintext_max_size, |
| 667 | plaintext_max_size - plaintext_size ); |
| 668 | |
| 669 | /* Finally copy the decrypted plaintext plus trailing zeros into the output |
| 670 | * buffer. If output_max_len is 0, then output may be an invalid pointer |
| 671 | * and the result of memcpy() would be undefined; prevent undefined |
| 672 | * behavior making sure to depend only on output_max_len (the size of the |
| 673 | * user-provided output buffer), which is independent from plaintext |
| 674 | * length, validity of padding, success of the decryption, and other |
| 675 | * secrets. */ |
| 676 | if( output_max_len != 0 ) |
| 677 | memcpy( output, buf + ilen - plaintext_max_size, plaintext_max_size ); |
| 678 | |
| 679 | /* Report the amount of data we copied to the output buffer. In case |
| 680 | * of errors (bad padding or output too large), the value of *olen |
| 681 | * when this function returns is not specified. Making it equivalent |
| 682 | * to the good case limits the risks of leaking the padding validity. */ |
| 683 | *olen = plaintext_size; |
| 684 | |
| 685 | return( ret ); |
| 686 | } |
| 687 | |
| 688 | #endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */ |