blob: 5f2a7b0c06b4176b48eecc52ea1aba638eeb45f0 [file] [log] [blame]
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01001/*
Manuel Pégourié-Gonnard32b04c12013-12-02 15:49:09 +01002 * Elliptic curves over GF(p): generic functions
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003 *
Bence Szépkúti1e148272020-08-07 13:07:28 +02004 * Copyright The Mbed TLS Contributors
Manuel Pégourié-Gonnard37ff1402015-09-04 14:21:07 +02005 * SPDX-License-Identifier: Apache-2.0
6 *
7 * Licensed under the Apache License, Version 2.0 (the "License"); you may
8 * not use this file except in compliance with the License.
9 * You may obtain a copy of the License at
10 *
11 * http://www.apache.org/licenses/LICENSE-2.0
12 *
13 * Unless required by applicable law or agreed to in writing, software
14 * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
15 * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16 * See the License for the specific language governing permissions and
17 * limitations under the License.
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +010018 */
19
20/*
21 * References:
22 *
Xiaokang Qian669c7c32023-04-10 07:36:04 +000023 * SEC1 https://www.secg.org/sec1-v2.pdf
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +010024 * GECC = Guide to Elliptic Curve Cryptography - Hankerson, Menezes, Vanstone
Manuel Pégourié-Gonnard62aad142012-11-10 00:27:12 +010025 * FIPS 186-3 http://csrc.nist.gov/publications/fips/fips186-3/fips_186-3.pdf
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +010026 * RFC 4492 for the related TLS structures and constants
Xiaokang Qian50fe3632023-04-12 06:08:45 +000027 * - https://www.rfc-editor.org/rfc/rfc4492
Nicholas Wilson08f3ef12015-11-10 13:10:01 +000028 * RFC 7748 for the Curve448 and Curve25519 curve definitions
Xiaokang Qian50fe3632023-04-12 06:08:45 +000029 * - https://www.rfc-editor.org/rfc/rfc7748
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +020030 *
Xiaokang Qian50fe3632023-04-12 06:08:45 +000031 * [Curve25519] https://cr.yp.to/ecdh/curve25519-20060209.pdf
Manuel Pégourié-Gonnardfe0af402013-12-04 18:14:55 +010032 *
Manuel Pégourié-Gonnard998930a2015-04-03 13:48:06 +020033 * [2] CORON, Jean-S'ebastien. Resistance against differential power analysis
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +020034 * for elliptic curve cryptosystems. In : Cryptographic Hardware and
35 * Embedded Systems. Springer Berlin Heidelberg, 1999. p. 292-302.
36 * <http://link.springer.com/chapter/10.1007/3-540-48059-5_25>
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +010037 *
Manuel Pégourié-Gonnard998930a2015-04-03 13:48:06 +020038 * [3] HEDABOU, Mustapha, PINEL, Pierre, et B'EN'ETEAU, Lucien. A comb method to
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +010039 * render ECC resistant against Side Channel Attacks. IACR Cryptology
40 * ePrint Archive, 2004, vol. 2004, p. 342.
41 * <http://eprint.iacr.org/2004/342.pdf>
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +010042 */
43
Gilles Peskinedb09ef62020-06-03 01:43:33 +020044#include "common.h"
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +010045
Andrzej Kurekc470b6b2019-01-31 08:20:20 -050046/**
47 * \brief Function level alternative implementation.
48 *
49 * The MBEDTLS_ECP_INTERNAL_ALT macro enables alternative implementations to
50 * replace certain functions in this module. The alternative implementations are
51 * typically hardware accelerators and need to activate the hardware before the
52 * computation starts and deactivate it after it finishes. The
53 * mbedtls_internal_ecp_init() and mbedtls_internal_ecp_free() functions serve
54 * this purpose.
55 *
56 * To preserve the correct functionality the following conditions must hold:
57 *
58 * - The alternative implementation must be activated by
59 * mbedtls_internal_ecp_init() before any of the replaceable functions is
60 * called.
61 * - mbedtls_internal_ecp_free() must \b only be called when the alternative
62 * implementation is activated.
63 * - mbedtls_internal_ecp_init() must \b not be called when the alternative
64 * implementation is activated.
65 * - Public functions must not return while the alternative implementation is
66 * activated.
67 * - Replaceable functions are guarded by \c MBEDTLS_ECP_XXX_ALT macros and
68 * before calling them an \code if( mbedtls_internal_ecp_grp_capable( grp ) )
69 * \endcode ensures that the alternative implementation supports the current
70 * group.
71 */
72#if defined(MBEDTLS_ECP_INTERNAL_ALT)
73#endif
74
Valerio Settifd122f42023-04-05 18:15:32 +020075#if defined(MBEDTLS_ECP_LIGHT)
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +010076
Manuel Pégourié-Gonnard7f809972015-03-09 17:05:11 +000077#include "mbedtls/ecp.h"
Janos Follath430d3372016-11-03 14:25:37 +000078#include "mbedtls/threading.h"
Andres Amaya Garcia1f6301b2018-04-17 09:51:09 -050079#include "mbedtls/platform_util.h"
Janos Follath24eed8d2019-11-22 13:21:35 +000080#include "mbedtls/error.h"
Paul Bakker6e339b52013-07-03 13:37:05 +020081
Janos Follath8c70e812021-06-24 14:48:38 +010082#include "bn_mul.h"
Gabor Mezei2a7bcaf2023-07-06 10:37:51 +020083#include "ecp_invasive.h"
Gilles Peskine80ba8502021-04-03 20:36:37 +020084
Rich Evans00ab4702015-02-06 13:43:58 +000085#include <string.h>
86
Janos Follathb0697532016-08-18 12:38:46 +010087#if !defined(MBEDTLS_ECP_ALT)
88
Manuel Pégourié-Gonnard7f809972015-03-09 17:05:11 +000089#include "mbedtls/platform.h"
Paul Bakker6e339b52013-07-03 13:37:05 +020090
Gilles Peskine6a2fb612021-05-24 22:25:04 +020091#include "ecp_internal_alt.h"
Janos Follathb0697532016-08-18 12:38:46 +010092
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +020093#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +010094/*
Manuel Pégourié-Gonnard91814812013-11-21 20:23:55 +010095 * Counts of point addition and doubling, and field multiplications.
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +020096 * Used to test resistance of point multiplication to simple timing attacks.
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +010097 */
Valerio Settifd122f42023-04-05 18:15:32 +020098#if defined(MBEDTLS_ECP_C)
99static unsigned long add_count, dbl_count;
100#endif /* MBEDTLS_ECP_C */
101static unsigned long mul_count;
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +0100102#endif
103
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +0200104#if defined(MBEDTLS_ECP_RESTARTABLE)
Manuel Pégourié-Gonnard054433c2017-03-22 11:18:33 +0100105/*
106 * Maximum number of "basic operations" to be done in a row.
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +0200107 *
108 * Default value 0 means that ECC operations will not yield.
109 * Note that regardless of the value of ecp_max_ops, always at
110 * least one step is performed before yielding.
111 *
112 * Setting ecp_max_ops=1 can be suitable for testing purposes
113 * as it will interrupt computation at all possible points.
Manuel Pégourié-Gonnard054433c2017-03-22 11:18:33 +0100114 */
115static unsigned ecp_max_ops = 0;
116
117/*
118 * Set ecp_max_ops
119 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100120void mbedtls_ecp_set_max_ops(unsigned max_ops)
Manuel Pégourié-Gonnard054433c2017-03-22 11:18:33 +0100121{
122 ecp_max_ops = max_ops;
123}
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +0100124
125/*
Manuel Pégourié-Gonnarda0c5bcc2017-04-21 11:33:57 +0200126 * Check if restart is enabled
127 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100128int mbedtls_ecp_restart_is_enabled(void)
Manuel Pégourié-Gonnarda0c5bcc2017-04-21 11:33:57 +0200129{
Gilles Peskine449bd832023-01-11 14:50:10 +0100130 return ecp_max_ops != 0;
Manuel Pégourié-Gonnarda0c5bcc2017-04-21 11:33:57 +0200131}
132
133/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200134 * Restart sub-context for ecp_mul_comb()
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +0100135 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100136struct mbedtls_ecp_restart_mul {
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +0100137 mbedtls_ecp_point R; /* current intermediate result */
Manuel Pégourié-Gonnardc5d844b2017-03-15 13:06:28 +0100138 size_t i; /* current index in various loops, 0 outside */
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +0100139 mbedtls_ecp_point *T; /* table for precomputed points */
140 unsigned char T_size; /* number of points in table T */
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +0200141 enum { /* what were we doing last time we returned? */
142 ecp_rsm_init = 0, /* nothing so far, dummy initial state */
143 ecp_rsm_pre_dbl, /* precompute 2^n multiples */
Manuel Pégourié-Gonnard45fd0162017-03-22 08:24:42 +0100144 ecp_rsm_pre_norm_dbl, /* normalize precomputed 2^n multiples */
145 ecp_rsm_pre_add, /* precompute remaining points by adding */
146 ecp_rsm_pre_norm_add, /* normalize all precomputed points */
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +0200147 ecp_rsm_comb_core, /* ecp_mul_comb_core() */
Manuel Pégourié-Gonnard45fd0162017-03-22 08:24:42 +0100148 ecp_rsm_final_norm, /* do the final normalization */
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100149 } state;
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100150};
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +0100151
152/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200153 * Init restart_mul sub-context
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +0100154 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100155static void ecp_restart_rsm_init(mbedtls_ecp_restart_mul_ctx *ctx)
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100156{
Gilles Peskine449bd832023-01-11 14:50:10 +0100157 mbedtls_ecp_point_init(&ctx->R);
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200158 ctx->i = 0;
159 ctx->T = NULL;
160 ctx->T_size = 0;
161 ctx->state = ecp_rsm_init;
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100162}
163
164/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200165 * Free the components of a restart_mul sub-context
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100166 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100167static void ecp_restart_rsm_free(mbedtls_ecp_restart_mul_ctx *ctx)
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100168{
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +0100169 unsigned char i;
170
Gilles Peskine449bd832023-01-11 14:50:10 +0100171 if (ctx == NULL) {
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100172 return;
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +0100173 }
174
Gilles Peskine449bd832023-01-11 14:50:10 +0100175 mbedtls_ecp_point_free(&ctx->R);
176
177 if (ctx->T != NULL) {
178 for (i = 0; i < ctx->T_size; i++) {
179 mbedtls_ecp_point_free(ctx->T + i);
180 }
181 mbedtls_free(ctx->T);
182 }
183
184 ecp_restart_rsm_init(ctx);
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100185}
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100186
187/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200188 * Restart context for ecp_muladd()
189 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100190struct mbedtls_ecp_restart_muladd {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +0200191 mbedtls_ecp_point mP; /* mP value */
192 mbedtls_ecp_point R; /* R intermediate result */
193 enum { /* what should we do next? */
194 ecp_rsma_mul1 = 0, /* first multiplication */
195 ecp_rsma_mul2, /* second multiplication */
196 ecp_rsma_add, /* addition */
197 ecp_rsma_norm, /* normalization */
198 } state;
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200199};
200
201/*
202 * Init restart_muladd sub-context
203 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100204static void ecp_restart_ma_init(mbedtls_ecp_restart_muladd_ctx *ctx)
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200205{
Gilles Peskine449bd832023-01-11 14:50:10 +0100206 mbedtls_ecp_point_init(&ctx->mP);
207 mbedtls_ecp_point_init(&ctx->R);
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200208 ctx->state = ecp_rsma_mul1;
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200209}
210
211/*
212 * Free the components of a restart_muladd sub-context
213 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100214static void ecp_restart_ma_free(mbedtls_ecp_restart_muladd_ctx *ctx)
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200215{
Gilles Peskine449bd832023-01-11 14:50:10 +0100216 if (ctx == NULL) {
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200217 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100218 }
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200219
Gilles Peskine449bd832023-01-11 14:50:10 +0100220 mbedtls_ecp_point_free(&ctx->mP);
221 mbedtls_ecp_point_free(&ctx->R);
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +0200222
Gilles Peskine449bd832023-01-11 14:50:10 +0100223 ecp_restart_ma_init(ctx);
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200224}
225
226/*
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200227 * Initialize a restart context
228 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100229void mbedtls_ecp_restart_init(mbedtls_ecp_restart_ctx *ctx)
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200230{
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200231 ctx->ops_done = 0;
232 ctx->depth = 0;
233 ctx->rsm = NULL;
234 ctx->ma = NULL;
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200235}
236
237/*
238 * Free the components of a restart context
239 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100240void mbedtls_ecp_restart_free(mbedtls_ecp_restart_ctx *ctx)
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200241{
Gilles Peskine449bd832023-01-11 14:50:10 +0100242 if (ctx == NULL) {
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200243 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100244 }
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200245
Gilles Peskine449bd832023-01-11 14:50:10 +0100246 ecp_restart_rsm_free(ctx->rsm);
247 mbedtls_free(ctx->rsm);
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +0200248
Gilles Peskine449bd832023-01-11 14:50:10 +0100249 ecp_restart_ma_free(ctx->ma);
250 mbedtls_free(ctx->ma);
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200251
Gilles Peskine449bd832023-01-11 14:50:10 +0100252 mbedtls_ecp_restart_init(ctx);
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200253}
254
255/*
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100256 * Check if we can do the next step
257 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100258int mbedtls_ecp_check_budget(const mbedtls_ecp_group *grp,
259 mbedtls_ecp_restart_ctx *rs_ctx,
260 unsigned ops)
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100261{
Gilles Peskine449bd832023-01-11 14:50:10 +0100262 if (rs_ctx != NULL && ecp_max_ops != 0) {
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100263 /* scale depending on curve size: the chosen reference is 256-bit,
264 * and multiplication is quadratic. Round to the closest integer. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100265 if (grp->pbits >= 512) {
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100266 ops *= 4;
Gilles Peskine449bd832023-01-11 14:50:10 +0100267 } else if (grp->pbits >= 384) {
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100268 ops *= 2;
Gilles Peskine449bd832023-01-11 14:50:10 +0100269 }
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100270
Hanno Beckerb10c6602018-10-26 13:50:13 +0100271 /* Avoid infinite loops: always allow first step.
272 * Because of that, however, it's not generally true
273 * that ops_done <= ecp_max_ops, so the check
274 * ops_done > ecp_max_ops below is mandatory. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100275 if ((rs_ctx->ops_done != 0) &&
276 (rs_ctx->ops_done > ecp_max_ops ||
277 ops > ecp_max_ops - rs_ctx->ops_done)) {
278 return MBEDTLS_ERR_ECP_IN_PROGRESS;
Hanno Beckerb10c6602018-10-26 13:50:13 +0100279 }
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100280
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100281 /* update running count */
Manuel Pégourié-Gonnard646393b2017-04-20 10:03:45 +0200282 rs_ctx->ops_done += ops;
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100283 }
284
Gilles Peskine449bd832023-01-11 14:50:10 +0100285 return 0;
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100286}
287
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +0200288/* Call this when entering a function that needs its own sub-context */
Gilles Peskine449bd832023-01-11 14:50:10 +0100289#define ECP_RS_ENTER(SUB) do { \
290 /* reset ops count for this call if top-level */ \
291 if (rs_ctx != NULL && rs_ctx->depth++ == 0) \
Manuel Pégourié-Gonnarda58e0112018-10-16 10:42:47 +0200292 rs_ctx->ops_done = 0; \
293 \
Gilles Peskine449bd832023-01-11 14:50:10 +0100294 /* set up our own sub-context if needed */ \
295 if (mbedtls_ecp_restart_is_enabled() && \
296 rs_ctx != NULL && rs_ctx->SUB == NULL) \
297 { \
298 rs_ctx->SUB = mbedtls_calloc(1, sizeof(*rs_ctx->SUB)); \
299 if (rs_ctx->SUB == NULL) \
300 return MBEDTLS_ERR_ECP_ALLOC_FAILED; \
301 \
302 ecp_restart_## SUB ##_init(rs_ctx->SUB); \
303 } \
304} while (0)
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +0200305
306/* Call this when leaving a function that needs its own sub-context */
Gilles Peskine449bd832023-01-11 14:50:10 +0100307#define ECP_RS_LEAVE(SUB) do { \
308 /* clear our sub-context when not in progress (done or error) */ \
309 if (rs_ctx != NULL && rs_ctx->SUB != NULL && \
310 ret != MBEDTLS_ERR_ECP_IN_PROGRESS) \
311 { \
312 ecp_restart_## SUB ##_free(rs_ctx->SUB); \
313 mbedtls_free(rs_ctx->SUB); \
314 rs_ctx->SUB = NULL; \
315 } \
Manuel Pégourié-Gonnarda58e0112018-10-16 10:42:47 +0200316 \
Gilles Peskine449bd832023-01-11 14:50:10 +0100317 if (rs_ctx != NULL) \
Manuel Pégourié-Gonnarda58e0112018-10-16 10:42:47 +0200318 rs_ctx->depth--; \
Gilles Peskine449bd832023-01-11 14:50:10 +0100319} while (0)
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +0200320
321#else /* MBEDTLS_ECP_RESTARTABLE */
322
Gilles Peskine449bd832023-01-11 14:50:10 +0100323#define ECP_RS_ENTER(sub) (void) rs_ctx;
324#define ECP_RS_LEAVE(sub) (void) rs_ctx;
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +0200325
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +0200326#endif /* MBEDTLS_ECP_RESTARTABLE */
Manuel Pégourié-Gonnard054433c2017-03-22 11:18:33 +0100327
Valerio Settifd122f42023-04-05 18:15:32 +0200328#if defined(MBEDTLS_ECP_C)
Gilles Peskine449bd832023-01-11 14:50:10 +0100329static void mpi_init_many(mbedtls_mpi *arr, size_t size)
Hanno Becker466df6e2022-01-10 11:16:51 +0000330{
Gilles Peskine449bd832023-01-11 14:50:10 +0100331 while (size--) {
332 mbedtls_mpi_init(arr++);
333 }
Hanno Becker466df6e2022-01-10 11:16:51 +0000334}
335
Gilles Peskine449bd832023-01-11 14:50:10 +0100336static void mpi_free_many(mbedtls_mpi *arr, size_t size)
Hanno Becker466df6e2022-01-10 11:16:51 +0000337{
Gilles Peskine449bd832023-01-11 14:50:10 +0100338 while (size--) {
339 mbedtls_mpi_free(arr++);
340 }
Hanno Becker466df6e2022-01-10 11:16:51 +0000341}
Valerio Settifd122f42023-04-05 18:15:32 +0200342#endif /* MBEDTLS_ECP_C */
Hanno Becker466df6e2022-01-10 11:16:51 +0000343
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +0100344/*
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200345 * List of supported curves:
346 * - internal ID
Christoph M. Wintersteigercb310732019-02-15 15:50:38 +0000347 * - TLS NamedCurve ID (RFC 4492 sec. 5.1.1, RFC 7071 sec. 2, RFC 8446 sec. 4.2.7)
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200348 * - size in bits
Manuel Pégourié-Gonnard8195c1a2013-10-07 19:40:41 +0200349 * - readable name
Gergely Budaie40c4692014-01-22 11:22:20 +0100350 *
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100351 * Curves are listed in order: largest curves first, and for a given size,
Gilles Peskineae270bf2021-06-02 00:05:29 +0200352 * fastest curves first.
Manuel Pégourié-Gonnard88db5da2015-06-15 14:34:59 +0200353 *
Gilles Peskineae270bf2021-06-02 00:05:29 +0200354 * Reminder: update profiles in x509_crt.c and ssl_tls.c when adding a new curve!
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200355 */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200356static const mbedtls_ecp_curve_info ecp_supported_curves[] =
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200357{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200358#if defined(MBEDTLS_ECP_DP_SECP521R1_ENABLED)
359 { MBEDTLS_ECP_DP_SECP521R1, 25, 521, "secp521r1" },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200360#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200361#if defined(MBEDTLS_ECP_DP_BP512R1_ENABLED)
362 { MBEDTLS_ECP_DP_BP512R1, 28, 512, "brainpoolP512r1" },
Gergely Budaie40c4692014-01-22 11:22:20 +0100363#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200364#if defined(MBEDTLS_ECP_DP_SECP384R1_ENABLED)
365 { MBEDTLS_ECP_DP_SECP384R1, 24, 384, "secp384r1" },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200366#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200367#if defined(MBEDTLS_ECP_DP_BP384R1_ENABLED)
368 { MBEDTLS_ECP_DP_BP384R1, 27, 384, "brainpoolP384r1" },
Gergely Budaie40c4692014-01-22 11:22:20 +0100369#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200370#if defined(MBEDTLS_ECP_DP_SECP256R1_ENABLED)
371 { MBEDTLS_ECP_DP_SECP256R1, 23, 256, "secp256r1" },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200372#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200373#if defined(MBEDTLS_ECP_DP_SECP256K1_ENABLED)
374 { MBEDTLS_ECP_DP_SECP256K1, 22, 256, "secp256k1" },
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100375#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200376#if defined(MBEDTLS_ECP_DP_BP256R1_ENABLED)
377 { MBEDTLS_ECP_DP_BP256R1, 26, 256, "brainpoolP256r1" },
Gergely Budaie40c4692014-01-22 11:22:20 +0100378#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200379#if defined(MBEDTLS_ECP_DP_SECP224R1_ENABLED)
380 { MBEDTLS_ECP_DP_SECP224R1, 21, 224, "secp224r1" },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200381#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200382#if defined(MBEDTLS_ECP_DP_SECP224K1_ENABLED)
383 { MBEDTLS_ECP_DP_SECP224K1, 20, 224, "secp224k1" },
Manuel Pégourié-Gonnard9bcff392014-01-10 18:26:48 +0100384#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200385#if defined(MBEDTLS_ECP_DP_SECP192R1_ENABLED)
386 { MBEDTLS_ECP_DP_SECP192R1, 19, 192, "secp192r1" },
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100387#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200388#if defined(MBEDTLS_ECP_DP_SECP192K1_ENABLED)
389 { MBEDTLS_ECP_DP_SECP192K1, 18, 192, "secp192k1" },
Manuel Pégourié-Gonnard9bcff392014-01-10 18:26:48 +0100390#endif
Gilles Peskine360e2c42020-07-24 02:03:20 +0200391#if defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Christoph M. Wintersteiger86e36c42018-12-06 17:27:31 +0000392 { MBEDTLS_ECP_DP_CURVE25519, 29, 256, "x25519" },
Christoph M. Wintersteigerc9f737b2018-10-25 13:03:05 +0100393#endif
Gilles Peskine360e2c42020-07-24 02:03:20 +0200394#if defined(MBEDTLS_ECP_DP_CURVE448_ENABLED)
395 { MBEDTLS_ECP_DP_CURVE448, 30, 448, "x448" },
396#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200397 { MBEDTLS_ECP_DP_NONE, 0, 0, NULL },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200398};
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100399
Gilles Peskine449bd832023-01-11 14:50:10 +0100400#define ECP_NB_CURVES sizeof(ecp_supported_curves) / \
401 sizeof(ecp_supported_curves[0])
Manuel Pégourié-Gonnardba782bb2014-07-08 13:31:34 +0200402
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200403static mbedtls_ecp_group_id ecp_supported_grp_id[ECP_NB_CURVES];
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200404
405/*
Manuel Pégourié-Gonnardda179e42013-09-18 15:31:24 +0200406 * List of supported curves and associated info
407 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100408const mbedtls_ecp_curve_info *mbedtls_ecp_curve_list(void)
Manuel Pégourié-Gonnardda179e42013-09-18 15:31:24 +0200409{
Gilles Peskine449bd832023-01-11 14:50:10 +0100410 return ecp_supported_curves;
Manuel Pégourié-Gonnardda179e42013-09-18 15:31:24 +0200411}
412
413/*
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100414 * List of supported curves, group ID only
415 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100416const mbedtls_ecp_group_id *mbedtls_ecp_grp_id_list(void)
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100417{
418 static int init_done = 0;
419
Gilles Peskine449bd832023-01-11 14:50:10 +0100420 if (!init_done) {
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100421 size_t i = 0;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200422 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100423
Gilles Peskine449bd832023-01-11 14:50:10 +0100424 for (curve_info = mbedtls_ecp_curve_list();
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200425 curve_info->grp_id != MBEDTLS_ECP_DP_NONE;
Gilles Peskine449bd832023-01-11 14:50:10 +0100426 curve_info++) {
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100427 ecp_supported_grp_id[i++] = curve_info->grp_id;
428 }
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200429 ecp_supported_grp_id[i] = MBEDTLS_ECP_DP_NONE;
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100430
431 init_done = 1;
432 }
433
Gilles Peskine449bd832023-01-11 14:50:10 +0100434 return ecp_supported_grp_id;
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100435}
436
437/*
438 * Get the curve info for the internal identifier
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200439 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100440const mbedtls_ecp_curve_info *mbedtls_ecp_curve_info_from_grp_id(mbedtls_ecp_group_id grp_id)
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200441{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200442 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200443
Gilles Peskine449bd832023-01-11 14:50:10 +0100444 for (curve_info = mbedtls_ecp_curve_list();
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200445 curve_info->grp_id != MBEDTLS_ECP_DP_NONE;
Gilles Peskine449bd832023-01-11 14:50:10 +0100446 curve_info++) {
447 if (curve_info->grp_id == grp_id) {
448 return curve_info;
449 }
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200450 }
451
Gilles Peskine449bd832023-01-11 14:50:10 +0100452 return NULL;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200453}
454
455/*
456 * Get the curve info from the TLS identifier
457 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100458const mbedtls_ecp_curve_info *mbedtls_ecp_curve_info_from_tls_id(uint16_t tls_id)
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200459{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200460 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200461
Gilles Peskine449bd832023-01-11 14:50:10 +0100462 for (curve_info = mbedtls_ecp_curve_list();
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200463 curve_info->grp_id != MBEDTLS_ECP_DP_NONE;
Gilles Peskine449bd832023-01-11 14:50:10 +0100464 curve_info++) {
465 if (curve_info->tls_id == tls_id) {
466 return curve_info;
467 }
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200468 }
469
Gilles Peskine449bd832023-01-11 14:50:10 +0100470 return NULL;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200471}
472
473/*
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100474 * Get the curve info from the name
475 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100476const mbedtls_ecp_curve_info *mbedtls_ecp_curve_info_from_name(const char *name)
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100477{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200478 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100479
Gilles Peskine449bd832023-01-11 14:50:10 +0100480 if (name == NULL) {
481 return NULL;
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100482 }
483
Gilles Peskine449bd832023-01-11 14:50:10 +0100484 for (curve_info = mbedtls_ecp_curve_list();
485 curve_info->grp_id != MBEDTLS_ECP_DP_NONE;
486 curve_info++) {
487 if (strcmp(curve_info->name, name) == 0) {
488 return curve_info;
489 }
490 }
491
492 return NULL;
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100493}
494
495/*
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +0100496 * Get the type of a curve
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +0100497 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100498mbedtls_ecp_curve_type mbedtls_ecp_get_type(const mbedtls_ecp_group *grp)
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +0100499{
Gilles Peskine449bd832023-01-11 14:50:10 +0100500 if (grp->G.X.p == NULL) {
501 return MBEDTLS_ECP_TYPE_NONE;
502 }
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +0100503
Gilles Peskine449bd832023-01-11 14:50:10 +0100504 if (grp->G.Y.p == NULL) {
505 return MBEDTLS_ECP_TYPE_MONTGOMERY;
506 } else {
507 return MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS;
508 }
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +0100509}
510
511/*
Manuel Pégourié-Gonnardb505c272012-11-05 17:27:54 +0100512 * Initialize (the components of) a point
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100513 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100514void mbedtls_ecp_point_init(mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100515{
Gilles Peskine449bd832023-01-11 14:50:10 +0100516 mbedtls_mpi_init(&pt->X);
517 mbedtls_mpi_init(&pt->Y);
518 mbedtls_mpi_init(&pt->Z);
Manuel Pégourié-Gonnardb505c272012-11-05 17:27:54 +0100519}
520
521/*
522 * Initialize (the components of) a group
523 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100524void mbedtls_ecp_group_init(mbedtls_ecp_group *grp)
Manuel Pégourié-Gonnardb505c272012-11-05 17:27:54 +0100525{
Manuel Pégourié-Gonnard95e2eca2018-06-20 10:29:47 +0200526 grp->id = MBEDTLS_ECP_DP_NONE;
Gilles Peskine449bd832023-01-11 14:50:10 +0100527 mbedtls_mpi_init(&grp->P);
528 mbedtls_mpi_init(&grp->A);
529 mbedtls_mpi_init(&grp->B);
530 mbedtls_ecp_point_init(&grp->G);
531 mbedtls_mpi_init(&grp->N);
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200532 grp->pbits = 0;
533 grp->nbits = 0;
534 grp->h = 0;
535 grp->modp = NULL;
536 grp->t_pre = NULL;
537 grp->t_post = NULL;
538 grp->t_data = NULL;
539 grp->T = NULL;
540 grp->T_size = 0;
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100541}
542
543/*
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200544 * Initialize (the components of) a key pair
545 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100546void mbedtls_ecp_keypair_init(mbedtls_ecp_keypair *key)
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200547{
Gilles Peskine449bd832023-01-11 14:50:10 +0100548 mbedtls_ecp_group_init(&key->grp);
549 mbedtls_mpi_init(&key->d);
550 mbedtls_ecp_point_init(&key->Q);
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200551}
552
553/*
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100554 * Unallocate (the components of) a point
555 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100556void mbedtls_ecp_point_free(mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100557{
Gilles Peskine449bd832023-01-11 14:50:10 +0100558 if (pt == NULL) {
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100559 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100560 }
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100561
Gilles Peskine449bd832023-01-11 14:50:10 +0100562 mbedtls_mpi_free(&(pt->X));
563 mbedtls_mpi_free(&(pt->Y));
564 mbedtls_mpi_free(&(pt->Z));
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100565}
566
567/*
kXuanba9cb762021-04-08 14:32:06 +0800568 * Check that the comb table (grp->T) is static initialized.
569 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100570static int ecp_group_is_static_comb_table(const mbedtls_ecp_group *grp)
571{
kXuanba9cb762021-04-08 14:32:06 +0800572#if MBEDTLS_ECP_FIXED_POINT_OPTIM == 1
573 return grp->T != NULL && grp->T_size == 0;
574#else
575 (void) grp;
576 return 0;
577#endif
578}
579
580/*
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100581 * Unallocate (the components of) a group
582 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100583void mbedtls_ecp_group_free(mbedtls_ecp_group *grp)
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100584{
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +0200585 size_t i;
586
Gilles Peskine449bd832023-01-11 14:50:10 +0100587 if (grp == NULL) {
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100588 return;
Manuel Pégourié-Gonnard1f82b042013-12-06 12:51:50 +0100589 }
Manuel Pégourié-Gonnardc9727702013-09-16 18:56:28 +0200590
Gilles Peskine449bd832023-01-11 14:50:10 +0100591 if (grp->h != 1) {
Gilles Peskine449bd832023-01-11 14:50:10 +0100592 mbedtls_mpi_free(&grp->A);
593 mbedtls_mpi_free(&grp->B);
594 mbedtls_ecp_point_free(&grp->G);
Janos Follathd8cb3d72023-07-31 12:54:59 +0100595
596#if !defined(MBEDTLS_ECP_WITH_MPI_UINT)
Xiaokang Qianb903f4e2023-07-20 05:51:53 +0000597 mbedtls_mpi_free(&grp->N);
Janos Follathd8cb3d72023-07-31 12:54:59 +0100598 mbedtls_mpi_free(&grp->P);
599#endif
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +0200600 }
601
Gilles Peskine449bd832023-01-11 14:50:10 +0100602 if (!ecp_group_is_static_comb_table(grp) && grp->T != NULL) {
603 for (i = 0; i < grp->T_size; i++) {
604 mbedtls_ecp_point_free(&grp->T[i]);
605 }
606 mbedtls_free(grp->T);
607 }
608
609 mbedtls_platform_zeroize(grp, sizeof(mbedtls_ecp_group));
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100610}
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +0100611
Manuel Pégourié-Gonnard883f3132012-11-02 09:40:25 +0100612/*
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200613 * Unallocate (the components of) a key pair
614 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100615void mbedtls_ecp_keypair_free(mbedtls_ecp_keypair *key)
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200616{
Gilles Peskine449bd832023-01-11 14:50:10 +0100617 if (key == NULL) {
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200618 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100619 }
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200620
Gilles Peskine449bd832023-01-11 14:50:10 +0100621 mbedtls_ecp_group_free(&key->grp);
622 mbedtls_mpi_free(&key->d);
623 mbedtls_ecp_point_free(&key->Q);
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200624}
625
626/*
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200627 * Copy the contents of a point
628 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100629int mbedtls_ecp_copy(mbedtls_ecp_point *P, const mbedtls_ecp_point *Q)
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200630{
Janos Follath24eed8d2019-11-22 13:21:35 +0000631 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +0100632 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&P->X, &Q->X));
633 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&P->Y, &Q->Y));
634 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&P->Z, &Q->Z));
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200635
636cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100637 return ret;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200638}
639
640/*
641 * Copy the contents of a group object
642 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100643int mbedtls_ecp_group_copy(mbedtls_ecp_group *dst, const mbedtls_ecp_group *src)
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200644{
Gilles Peskine449bd832023-01-11 14:50:10 +0100645 return mbedtls_ecp_group_load(dst, src->id);
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200646}
647
648/*
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100649 * Set point to zero
650 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100651int mbedtls_ecp_set_zero(mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100652{
Janos Follath24eed8d2019-11-22 13:21:35 +0000653 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +0100654 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->X, 1));
655 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->Y, 1));
656 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->Z, 0));
Manuel Pégourié-Gonnard1c2782c2012-11-19 20:16:28 +0100657
658cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100659 return ret;
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100660}
661
662/*
Manuel Pégourié-Gonnard6545ca72013-01-26 16:05:22 +0100663 * Tell if a point is zero
664 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100665int mbedtls_ecp_is_zero(mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnard6545ca72013-01-26 16:05:22 +0100666{
Gilles Peskine449bd832023-01-11 14:50:10 +0100667 return mbedtls_mpi_cmp_int(&pt->Z, 0) == 0;
Manuel Pégourié-Gonnard6545ca72013-01-26 16:05:22 +0100668}
669
670/*
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500671 * Compare two points lazily
Manuel Pégourié-Gonnard6029a852015-08-11 15:44:41 +0200672 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100673int mbedtls_ecp_point_cmp(const mbedtls_ecp_point *P,
674 const mbedtls_ecp_point *Q)
Manuel Pégourié-Gonnard6029a852015-08-11 15:44:41 +0200675{
Gilles Peskine449bd832023-01-11 14:50:10 +0100676 if (mbedtls_mpi_cmp_mpi(&P->X, &Q->X) == 0 &&
677 mbedtls_mpi_cmp_mpi(&P->Y, &Q->Y) == 0 &&
678 mbedtls_mpi_cmp_mpi(&P->Z, &Q->Z) == 0) {
679 return 0;
Manuel Pégourié-Gonnard6029a852015-08-11 15:44:41 +0200680 }
681
Gilles Peskine449bd832023-01-11 14:50:10 +0100682 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnard6029a852015-08-11 15:44:41 +0200683}
684
685/*
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +0100686 * Import a non-zero point from ASCII strings
687 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100688int mbedtls_ecp_point_read_string(mbedtls_ecp_point *P, int radix,
689 const char *x, const char *y)
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +0100690{
Janos Follath24eed8d2019-11-22 13:21:35 +0000691 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +0100692 MBEDTLS_MPI_CHK(mbedtls_mpi_read_string(&P->X, radix, x));
693 MBEDTLS_MPI_CHK(mbedtls_mpi_read_string(&P->Y, radix, y));
694 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&P->Z, 1));
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +0100695
696cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100697 return ret;
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +0100698}
699
700/*
Janos Follath7caf8e42019-02-20 12:00:22 +0000701 * Export a point into unsigned binary data (SEC1 2.3.3 and RFC7748)
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100702 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100703int mbedtls_ecp_point_write_binary(const mbedtls_ecp_group *grp,
704 const mbedtls_ecp_point *P,
705 int format, size_t *olen,
706 unsigned char *buf, size_t buflen)
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100707{
Janos Follath28eb06d2019-02-26 10:53:34 +0000708 int ret = MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100709 size_t plen;
Gilles Peskine449bd832023-01-11 14:50:10 +0100710 if (format != MBEDTLS_ECP_PF_UNCOMPRESSED &&
711 format != MBEDTLS_ECP_PF_COMPRESSED) {
712 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
713 }
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100714
Gilles Peskine449bd832023-01-11 14:50:10 +0100715 plen = mbedtls_mpi_size(&grp->P);
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100716
Gilles Peskinee8c04fe2018-09-14 17:44:21 +0200717#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine59970052019-02-28 13:12:06 +0100718 (void) format; /* Montgomery curves always use the same point format */
Gilles Peskine449bd832023-01-11 14:50:10 +0100719 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
Janos Follath7caf8e42019-02-20 12:00:22 +0000720 *olen = plen;
Gilles Peskine449bd832023-01-11 14:50:10 +0100721 if (buflen < *olen) {
722 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
723 }
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100724
Gilles Peskine449bd832023-01-11 14:50:10 +0100725 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary_le(&P->X, buf, plen));
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100726 }
Janos Follath7caf8e42019-02-20 12:00:22 +0000727#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +0200728#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +0100729 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
Janos Follath7caf8e42019-02-20 12:00:22 +0000730 /*
731 * Common case: P == 0
732 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100733 if (mbedtls_mpi_cmp_int(&P->Z, 0) == 0) {
734 if (buflen < 1) {
735 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
736 }
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100737
Janos Follath7caf8e42019-02-20 12:00:22 +0000738 buf[0] = 0x00;
739 *olen = 1;
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100740
Gilles Peskine449bd832023-01-11 14:50:10 +0100741 return 0;
Janos Follath7caf8e42019-02-20 12:00:22 +0000742 }
743
Gilles Peskine449bd832023-01-11 14:50:10 +0100744 if (format == MBEDTLS_ECP_PF_UNCOMPRESSED) {
Janos Follath7caf8e42019-02-20 12:00:22 +0000745 *olen = 2 * plen + 1;
746
Gilles Peskine449bd832023-01-11 14:50:10 +0100747 if (buflen < *olen) {
748 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
749 }
Janos Follath7caf8e42019-02-20 12:00:22 +0000750
751 buf[0] = 0x04;
Gilles Peskine449bd832023-01-11 14:50:10 +0100752 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(&P->X, buf + 1, plen));
753 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(&P->Y, buf + 1 + plen, plen));
754 } else if (format == MBEDTLS_ECP_PF_COMPRESSED) {
Janos Follath7caf8e42019-02-20 12:00:22 +0000755 *olen = plen + 1;
756
Gilles Peskine449bd832023-01-11 14:50:10 +0100757 if (buflen < *olen) {
758 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
759 }
Janos Follath7caf8e42019-02-20 12:00:22 +0000760
Gilles Peskine449bd832023-01-11 14:50:10 +0100761 buf[0] = 0x02 + mbedtls_mpi_get_bit(&P->Y, 0);
762 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(&P->X, buf + 1, plen));
Janos Follath7caf8e42019-02-20 12:00:22 +0000763 }
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100764 }
Janos Follath7caf8e42019-02-20 12:00:22 +0000765#endif
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100766
767cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100768 return ret;
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100769}
770
Glenn Strauss2ff77112022-09-14 23:27:50 -0400771#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +0100772static int mbedtls_ecp_sw_derive_y(const mbedtls_ecp_group *grp,
773 const mbedtls_mpi *X,
774 mbedtls_mpi *Y,
775 int parity_bit);
Glenn Strauss2ff77112022-09-14 23:27:50 -0400776#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
777
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100778/*
Janos Follath59b813c2019-02-13 10:44:06 +0000779 * Import a point from unsigned binary data (SEC1 2.3.4 and RFC7748)
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100780 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100781int mbedtls_ecp_point_read_binary(const mbedtls_ecp_group *grp,
782 mbedtls_ecp_point *pt,
783 const unsigned char *buf, size_t ilen)
Manuel Pégourié-Gonnard5246ee52014-03-19 16:18:38 +0100784{
Janos Follath28eb06d2019-02-26 10:53:34 +0000785 int ret = MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100786 size_t plen;
Gilles Peskine449bd832023-01-11 14:50:10 +0100787 if (ilen < 1) {
788 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
789 }
Manuel Pégourié-Gonnard67dbe1e2014-07-08 13:09:24 +0200790
Gilles Peskine449bd832023-01-11 14:50:10 +0100791 plen = mbedtls_mpi_size(&grp->P);
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100792
Gilles Peskinee8c04fe2018-09-14 17:44:21 +0200793#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +0100794 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
795 if (plen != ilen) {
796 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
797 }
Manuel Pégourié-Gonnard5246ee52014-03-19 16:18:38 +0100798
Gilles Peskine449bd832023-01-11 14:50:10 +0100799 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary_le(&pt->X, buf, plen));
800 mbedtls_mpi_free(&pt->Y);
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100801
Gilles Peskine449bd832023-01-11 14:50:10 +0100802 if (grp->id == MBEDTLS_ECP_DP_CURVE25519) {
Janos Follathffbd7e82019-02-25 11:35:20 +0000803 /* Set most significant bit to 0 as prescribed in RFC7748 §5 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100804 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&pt->X, plen * 8 - 1, 0));
805 }
Janos Follath28eb06d2019-02-26 10:53:34 +0000806
Gilles Peskine449bd832023-01-11 14:50:10 +0100807 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->Z, 1));
Janos Follath59b813c2019-02-13 10:44:06 +0000808 }
809#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +0200810#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +0100811 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
812 if (buf[0] == 0x00) {
813 if (ilen == 1) {
814 return mbedtls_ecp_set_zero(pt);
815 } else {
816 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
817 }
Janos Follath59b813c2019-02-13 10:44:06 +0000818 }
819
Gilles Peskine449bd832023-01-11 14:50:10 +0100820 if (ilen < 1 + plen) {
821 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
822 }
Janos Follath59b813c2019-02-13 10:44:06 +0000823
Gilles Peskine449bd832023-01-11 14:50:10 +0100824 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary(&pt->X, buf + 1, plen));
825 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->Z, 1));
Glenn Strauss2ff77112022-09-14 23:27:50 -0400826
Gilles Peskine449bd832023-01-11 14:50:10 +0100827 if (buf[0] == 0x04) {
Glenn Strauss2ff77112022-09-14 23:27:50 -0400828 /* format == MBEDTLS_ECP_PF_UNCOMPRESSED */
Gilles Peskine449bd832023-01-11 14:50:10 +0100829 if (ilen != 1 + plen * 2) {
830 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
831 }
832 return mbedtls_mpi_read_binary(&pt->Y, buf + 1 + plen, plen);
833 } else if (buf[0] == 0x02 || buf[0] == 0x03) {
Glenn Strauss2ff77112022-09-14 23:27:50 -0400834 /* format == MBEDTLS_ECP_PF_COMPRESSED */
Gilles Peskine449bd832023-01-11 14:50:10 +0100835 if (ilen != 1 + plen) {
836 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
837 }
838 return mbedtls_ecp_sw_derive_y(grp, &pt->X, &pt->Y,
839 (buf[0] & 1));
840 } else {
841 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Glenn Strauss2ff77112022-09-14 23:27:50 -0400842 }
Janos Follath59b813c2019-02-13 10:44:06 +0000843 }
844#endif
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100845
846cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100847 return ret;
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100848}
849
850/*
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100851 * Import a point from a TLS ECPoint record (RFC 4492)
852 * struct {
853 * opaque point <1..2^8-1>;
854 * } ECPoint;
855 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100856int mbedtls_ecp_tls_read_point(const mbedtls_ecp_group *grp,
857 mbedtls_ecp_point *pt,
858 const unsigned char **buf, size_t buf_len)
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100859{
860 unsigned char data_len;
Manuel Pégourié-Gonnard98f51812013-02-10 13:38:29 +0100861 const unsigned char *buf_start;
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100862 /*
Manuel Pégourié-Gonnard67dbe1e2014-07-08 13:09:24 +0200863 * We must have at least two bytes (1 for length, at least one for data)
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100864 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100865 if (buf_len < 2) {
866 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
867 }
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100868
Manuel Pégourié-Gonnard98f51812013-02-10 13:38:29 +0100869 data_len = *(*buf)++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100870 if (data_len < 1 || data_len > buf_len - 1) {
871 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
872 }
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100873
Manuel Pégourié-Gonnard98f51812013-02-10 13:38:29 +0100874 /*
875 * Save buffer start for read_binary and update buf
876 */
877 buf_start = *buf;
878 *buf += data_len;
879
Gilles Peskine449bd832023-01-11 14:50:10 +0100880 return mbedtls_ecp_point_read_binary(grp, pt, buf_start, data_len);
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100881}
882
883/*
884 * Export a point as a TLS ECPoint record (RFC 4492)
885 * struct {
886 * opaque point <1..2^8-1>;
887 * } ECPoint;
888 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100889int mbedtls_ecp_tls_write_point(const mbedtls_ecp_group *grp, const mbedtls_ecp_point *pt,
890 int format, size_t *olen,
891 unsigned char *buf, size_t blen)
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100892{
Janos Follath24eed8d2019-11-22 13:21:35 +0000893 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +0100894 if (format != MBEDTLS_ECP_PF_UNCOMPRESSED &&
895 format != MBEDTLS_ECP_PF_COMPRESSED) {
896 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
897 }
Manuel Pégourié-Gonnard420f1eb2013-02-10 12:22:46 +0100898
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100899 /*
Manuel Pégourié-Gonnard420f1eb2013-02-10 12:22:46 +0100900 * buffer length must be at least one, for our length byte
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100901 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100902 if (blen < 1) {
903 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
904 }
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100905
Gilles Peskine449bd832023-01-11 14:50:10 +0100906 if ((ret = mbedtls_ecp_point_write_binary(grp, pt, format,
907 olen, buf + 1, blen - 1)) != 0) {
908 return ret;
909 }
Manuel Pégourié-Gonnard420f1eb2013-02-10 12:22:46 +0100910
911 /*
912 * write length to the first byte and update total length
913 */
Paul Bakkerb9cfaa02013-10-11 18:58:55 +0200914 buf[0] = (unsigned char) *olen;
Manuel Pégourié-Gonnard420f1eb2013-02-10 12:22:46 +0100915 ++*olen;
916
Gilles Peskine449bd832023-01-11 14:50:10 +0100917 return 0;
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100918}
919
920/*
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100921 * Set a group from an ECParameters record (RFC 4492)
922 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100923int mbedtls_ecp_tls_read_group(mbedtls_ecp_group *grp,
924 const unsigned char **buf, size_t len)
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500925{
Janos Follath24eed8d2019-11-22 13:21:35 +0000926 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500927 mbedtls_ecp_group_id grp_id;
Gilles Peskine449bd832023-01-11 14:50:10 +0100928 if ((ret = mbedtls_ecp_tls_read_group_id(&grp_id, buf, len)) != 0) {
929 return ret;
930 }
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500931
Gilles Peskine449bd832023-01-11 14:50:10 +0100932 return mbedtls_ecp_group_load(grp, grp_id);
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500933}
934
935/*
936 * Read a group id from an ECParameters record (RFC 4492) and convert it to
937 * mbedtls_ecp_group_id.
938 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100939int mbedtls_ecp_tls_read_group_id(mbedtls_ecp_group_id *grp,
940 const unsigned char **buf, size_t len)
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100941{
Manuel Pégourié-Gonnardf24b4a72013-09-23 18:14:50 +0200942 uint16_t tls_id;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200943 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100944 /*
945 * We expect at least three bytes (see below)
946 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100947 if (len < 3) {
948 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
949 }
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100950
951 /*
952 * First byte is curve_type; only named_curve is handled
953 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100954 if (*(*buf)++ != MBEDTLS_ECP_TLS_NAMED_CURVE) {
955 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
956 }
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100957
958 /*
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100959 * Next two bytes are the namedcurve value
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100960 */
Dave Rodgman6a9fb932023-08-16 17:50:36 +0100961 tls_id = MBEDTLS_GET_UINT16_BE(*buf, 0);
962 *buf += 2;
Manuel Pégourié-Gonnardf24b4a72013-09-23 18:14:50 +0200963
Gilles Peskine449bd832023-01-11 14:50:10 +0100964 if ((curve_info = mbedtls_ecp_curve_info_from_tls_id(tls_id)) == NULL) {
965 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
966 }
Manuel Pégourié-Gonnardf24b4a72013-09-23 18:14:50 +0200967
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500968 *grp = curve_info->grp_id;
969
Gilles Peskine449bd832023-01-11 14:50:10 +0100970 return 0;
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100971}
972
973/*
974 * Write the ECParameters record corresponding to a group (RFC 4492)
975 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100976int mbedtls_ecp_tls_write_group(const mbedtls_ecp_group *grp, size_t *olen,
977 unsigned char *buf, size_t blen)
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100978{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200979 const mbedtls_ecp_curve_info *curve_info;
Gilles Peskine449bd832023-01-11 14:50:10 +0100980 if ((curve_info = mbedtls_ecp_curve_info_from_grp_id(grp->id)) == NULL) {
981 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
982 }
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +0200983
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100984 /*
985 * We are going to write 3 bytes (see below)
986 */
987 *olen = 3;
Gilles Peskine449bd832023-01-11 14:50:10 +0100988 if (blen < *olen) {
989 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
990 }
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100991
992 /*
993 * First byte is curve_type, always named_curve
994 */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200995 *buf++ = MBEDTLS_ECP_TLS_NAMED_CURVE;
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100996
997 /*
998 * Next two bytes are the namedcurve value
999 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001000 MBEDTLS_PUT_UINT16_BE(curve_info->tls_id, buf, 0);
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +01001001
Gilles Peskine449bd832023-01-11 14:50:10 +01001002 return 0;
Manuel Pégourié-Gonnarda5402fe2012-11-07 20:24:05 +01001003}
Manuel Pégourié-Gonnardab38b702012-11-05 17:34:55 +01001004
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001005/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001006 * Wrapper around fast quasi-modp functions, with fall-back to mbedtls_mpi_mod_mpi.
1007 * See the documentation of struct mbedtls_ecp_group.
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +02001008 *
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001009 * This function is in the critial loop for mbedtls_ecp_mul, so pay attention to perf.
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001010 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001011static int ecp_modp(mbedtls_mpi *N, const mbedtls_ecp_group *grp)
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +02001012{
Janos Follath24eed8d2019-11-22 13:21:35 +00001013 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001014
Gilles Peskine449bd832023-01-11 14:50:10 +01001015 if (grp->modp == NULL) {
1016 return mbedtls_mpi_mod_mpi(N, N, &grp->P);
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +02001017 }
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001018
Gilles Peskine449bd832023-01-11 14:50:10 +01001019 /* N->s < 0 is a much faster test, which fails only if N is 0 */
1020 if ((N->s < 0 && mbedtls_mpi_cmp_int(N, 0) != 0) ||
1021 mbedtls_mpi_bitlen(N) > 2 * grp->pbits) {
1022 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
1023 }
1024
1025 MBEDTLS_MPI_CHK(grp->modp(N));
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +02001026
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +02001027 /* N->s < 0 is a much faster test, which fails only if N is 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001028 while (N->s < 0 && mbedtls_mpi_cmp_int(N, 0) != 0) {
1029 MBEDTLS_MPI_CHK(mbedtls_mpi_add_mpi(N, N, &grp->P));
1030 }
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001031
Gilles Peskine449bd832023-01-11 14:50:10 +01001032 while (mbedtls_mpi_cmp_mpi(N, &grp->P) >= 0) {
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +02001033 /* we known P, N and the result are positive */
Gilles Peskine449bd832023-01-11 14:50:10 +01001034 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_abs(N, N, &grp->P));
1035 }
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001036
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +02001037cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001038 return ret;
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +02001039}
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001040
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +01001041/*
Manuel Pégourié-Gonnard47123252012-11-10 14:44:24 +01001042 * Fast mod-p functions expect their argument to be in the 0..p^2 range.
Manuel Pégourié-Gonnarddada4da2012-11-10 14:23:17 +01001043 *
Manuel Pégourié-Gonnard47123252012-11-10 14:44:24 +01001044 * In order to guarantee that, we need to ensure that operands of
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001045 * mbedtls_mpi_mul_mpi are in the 0..p range. So, after each operation we will
Manuel Pégourié-Gonnarddada4da2012-11-10 14:23:17 +01001046 * bring the result back to this range.
1047 *
Manuel Pégourié-Gonnard47123252012-11-10 14:44:24 +01001048 * The following macros are shortcuts for doing that.
Manuel Pégourié-Gonnarddada4da2012-11-10 14:23:17 +01001049 */
1050
1051/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001052 * Reduce a mbedtls_mpi mod p in-place, general case, to use after mbedtls_mpi_mul_mpi
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001053 */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001054#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnard91814812013-11-21 20:23:55 +01001055#define INC_MUL_COUNT mul_count++;
1056#else
1057#define INC_MUL_COUNT
1058#endif
1059
Gilles Peskine449bd832023-01-11 14:50:10 +01001060#define MOD_MUL(N) \
Hanno Becker1eeca412018-10-15 12:01:35 +01001061 do \
1062 { \
Gilles Peskine449bd832023-01-11 14:50:10 +01001063 MBEDTLS_MPI_CHK(ecp_modp(&(N), grp)); \
Hanno Becker1eeca412018-10-15 12:01:35 +01001064 INC_MUL_COUNT \
Gilles Peskine449bd832023-01-11 14:50:10 +01001065 } while (0)
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001066
Gilles Peskine449bd832023-01-11 14:50:10 +01001067static inline int mbedtls_mpi_mul_mod(const mbedtls_ecp_group *grp,
1068 mbedtls_mpi *X,
1069 const mbedtls_mpi *A,
1070 const mbedtls_mpi *B)
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001071{
Janos Follath24eed8d2019-11-22 13:21:35 +00001072 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001073 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_mpi(X, A, B));
1074 MOD_MUL(*X);
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001075cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001076 return ret;
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001077}
1078
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001079/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001080 * Reduce a mbedtls_mpi mod p in-place, to use after mbedtls_mpi_sub_mpi
Manuel Pégourié-Gonnardc9e387c2013-10-17 17:15:35 +02001081 * N->s < 0 is a very fast test, which fails only if N is 0
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001082 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001083#define MOD_SUB(N) \
Hanno Beckerce29ae82022-01-04 04:55:11 +00001084 do { \
Gilles Peskine449bd832023-01-11 14:50:10 +01001085 while ((N)->s < 0 && mbedtls_mpi_cmp_int((N), 0) != 0) \
1086 MBEDTLS_MPI_CHK(mbedtls_mpi_add_mpi((N), (N), &grp->P)); \
1087 } while (0)
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001088
Gilles Peskine449bd832023-01-11 14:50:10 +01001089#if (defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED) && \
1090 !(defined(MBEDTLS_ECP_NO_FALLBACK) && \
1091 defined(MBEDTLS_ECP_DOUBLE_JAC_ALT) && \
1092 defined(MBEDTLS_ECP_ADD_MIXED_ALT))) || \
1093 (defined(MBEDTLS_ECP_MONTGOMERY_ENABLED) && \
1094 !(defined(MBEDTLS_ECP_NO_FALLBACK) && \
1095 defined(MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT)))
1096static inline int mbedtls_mpi_sub_mod(const mbedtls_ecp_group *grp,
1097 mbedtls_mpi *X,
1098 const mbedtls_mpi *A,
1099 const mbedtls_mpi *B)
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001100{
Janos Follath24eed8d2019-11-22 13:21:35 +00001101 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001102 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(X, A, B));
1103 MOD_SUB(X);
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001104cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001105 return ret;
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001106}
Steven Cooremane5388962021-03-01 14:04:53 +01001107#endif /* All functions referencing mbedtls_mpi_sub_mod() are alt-implemented without fallback */
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001108
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001109/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001110 * Reduce a mbedtls_mpi mod p in-place, to use after mbedtls_mpi_add_mpi and mbedtls_mpi_mul_int.
Manuel Pégourié-Gonnardc9e387c2013-10-17 17:15:35 +02001111 * We known P, N and the result are positive, so sub_abs is correct, and
1112 * a bit faster.
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001113 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001114#define MOD_ADD(N) \
1115 while (mbedtls_mpi_cmp_mpi((N), &grp->P) >= 0) \
1116 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_abs((N), (N), &grp->P))
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001117
Gilles Peskine449bd832023-01-11 14:50:10 +01001118static inline int mbedtls_mpi_add_mod(const mbedtls_ecp_group *grp,
1119 mbedtls_mpi *X,
1120 const mbedtls_mpi *A,
1121 const mbedtls_mpi *B)
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001122{
Janos Follath24eed8d2019-11-22 13:21:35 +00001123 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001124 MBEDTLS_MPI_CHK(mbedtls_mpi_add_mpi(X, A, B));
1125 MOD_ADD(X);
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001126cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001127 return ret;
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001128}
1129
Gilles Peskine449bd832023-01-11 14:50:10 +01001130static inline int mbedtls_mpi_mul_int_mod(const mbedtls_ecp_group *grp,
1131 mbedtls_mpi *X,
1132 const mbedtls_mpi *A,
1133 mbedtls_mpi_uint c)
Hanno Becker02b35bd2022-01-01 06:54:25 +00001134{
1135 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
1136
Gilles Peskine449bd832023-01-11 14:50:10 +01001137 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_int(X, A, c));
1138 MOD_ADD(X);
Hanno Becker02b35bd2022-01-01 06:54:25 +00001139cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001140 return ret;
Hanno Becker02b35bd2022-01-01 06:54:25 +00001141}
1142
Gilles Peskine449bd832023-01-11 14:50:10 +01001143static inline int mbedtls_mpi_sub_int_mod(const mbedtls_ecp_group *grp,
1144 mbedtls_mpi *X,
1145 const mbedtls_mpi *A,
1146 mbedtls_mpi_uint c)
Hanno Beckerce29ae82022-01-04 04:55:11 +00001147{
1148 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
1149
Gilles Peskine449bd832023-01-11 14:50:10 +01001150 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_int(X, A, c));
1151 MOD_SUB(X);
Hanno Beckerce29ae82022-01-04 04:55:11 +00001152cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001153 return ret;
Hanno Beckerce29ae82022-01-04 04:55:11 +00001154}
1155
Gilles Peskine449bd832023-01-11 14:50:10 +01001156#define MPI_ECP_SUB_INT(X, A, c) \
1157 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_int_mod(grp, X, A, c))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001158
Steven Cooremane5388962021-03-01 14:04:53 +01001159#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED) && \
Gilles Peskine449bd832023-01-11 14:50:10 +01001160 !(defined(MBEDTLS_ECP_NO_FALLBACK) && \
1161 defined(MBEDTLS_ECP_DOUBLE_JAC_ALT) && \
1162 defined(MBEDTLS_ECP_ADD_MIXED_ALT))
1163static inline int mbedtls_mpi_shift_l_mod(const mbedtls_ecp_group *grp,
1164 mbedtls_mpi *X,
1165 size_t count)
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001166{
Janos Follath24eed8d2019-11-22 13:21:35 +00001167 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001168 MBEDTLS_MPI_CHK(mbedtls_mpi_shift_l(X, count));
1169 MOD_ADD(X);
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001170cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001171 return ret;
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001172}
Gilles Peskine449bd832023-01-11 14:50:10 +01001173#endif \
1174 /* All functions referencing mbedtls_mpi_shift_l_mod() are alt-implemented without fallback */
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001175
Hanno Becker595616e2022-01-05 08:28:24 +00001176/*
1177 * Macro wrappers around ECP modular arithmetic
1178 *
1179 * Currently, these wrappers are defined via the bignum module.
1180 */
1181
Gilles Peskine449bd832023-01-11 14:50:10 +01001182#define MPI_ECP_ADD(X, A, B) \
1183 MBEDTLS_MPI_CHK(mbedtls_mpi_add_mod(grp, X, A, B))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001184
Gilles Peskine449bd832023-01-11 14:50:10 +01001185#define MPI_ECP_SUB(X, A, B) \
1186 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mod(grp, X, A, B))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001187
Gilles Peskine449bd832023-01-11 14:50:10 +01001188#define MPI_ECP_MUL(X, A, B) \
1189 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_mod(grp, X, A, B))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001190
Gilles Peskine449bd832023-01-11 14:50:10 +01001191#define MPI_ECP_SQR(X, A) \
1192 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_mod(grp, X, A, A))
Hanno Becker885ed402022-01-04 06:43:50 +00001193
Gilles Peskine449bd832023-01-11 14:50:10 +01001194#define MPI_ECP_MUL_INT(X, A, c) \
1195 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_int_mod(grp, X, A, c))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001196
Gilles Peskine449bd832023-01-11 14:50:10 +01001197#define MPI_ECP_INV(dst, src) \
1198 MBEDTLS_MPI_CHK(mbedtls_mpi_inv_mod((dst), (src), &grp->P))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001199
Gilles Peskine449bd832023-01-11 14:50:10 +01001200#define MPI_ECP_MOV(X, A) \
1201 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(X, A))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001202
Gilles Peskine449bd832023-01-11 14:50:10 +01001203#define MPI_ECP_SHIFT_L(X, count) \
1204 MBEDTLS_MPI_CHK(mbedtls_mpi_shift_l_mod(grp, X, count))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001205
Gilles Peskine449bd832023-01-11 14:50:10 +01001206#define MPI_ECP_LSET(X, c) \
1207 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(X, c))
Hanno Becker595616e2022-01-05 08:28:24 +00001208
Gilles Peskine449bd832023-01-11 14:50:10 +01001209#define MPI_ECP_CMP_INT(X, c) \
1210 mbedtls_mpi_cmp_int(X, c)
Hanno Becker595616e2022-01-05 08:28:24 +00001211
Gilles Peskine449bd832023-01-11 14:50:10 +01001212#define MPI_ECP_CMP(X, Y) \
1213 mbedtls_mpi_cmp_mpi(X, Y)
Hanno Becker595616e2022-01-05 08:28:24 +00001214
1215/* Needs f_rng, p_rng to be defined. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001216#define MPI_ECP_RAND(X) \
1217 MBEDTLS_MPI_CHK(mbedtls_mpi_random((X), 2, &grp->P, f_rng, p_rng))
Hanno Becker595616e2022-01-05 08:28:24 +00001218
1219/* Conditional negation
1220 * Needs grp and a temporary MPI tmp to be defined. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001221#define MPI_ECP_COND_NEG(X, cond) \
Hanno Becker595616e2022-01-05 08:28:24 +00001222 do \
1223 { \
Gilles Peskine449bd832023-01-11 14:50:10 +01001224 unsigned char nonzero = mbedtls_mpi_cmp_int((X), 0) != 0; \
1225 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(&tmp, &grp->P, (X))); \
1226 MBEDTLS_MPI_CHK(mbedtls_mpi_safe_cond_assign((X), &tmp, \
1227 nonzero & cond)); \
1228 } while (0)
Hanno Becker595616e2022-01-05 08:28:24 +00001229
Gilles Peskine449bd832023-01-11 14:50:10 +01001230#define MPI_ECP_NEG(X) MPI_ECP_COND_NEG((X), 1)
Hanno Beckerc27a0e02022-01-06 05:56:34 +00001231
Gilles Peskine449bd832023-01-11 14:50:10 +01001232#define MPI_ECP_VALID(X) \
1233 ((X)->p != NULL)
Hanno Beckerc27a0e02022-01-06 05:56:34 +00001234
Gilles Peskine449bd832023-01-11 14:50:10 +01001235#define MPI_ECP_COND_ASSIGN(X, Y, cond) \
1236 MBEDTLS_MPI_CHK(mbedtls_mpi_safe_cond_assign((X), (Y), (cond)))
Hanno Beckerc27a0e02022-01-06 05:56:34 +00001237
Gilles Peskine449bd832023-01-11 14:50:10 +01001238#define MPI_ECP_COND_SWAP(X, Y, cond) \
1239 MBEDTLS_MPI_CHK(mbedtls_mpi_safe_cond_swap((X), (Y), (cond)))
Hanno Beckerc27a0e02022-01-06 05:56:34 +00001240
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02001241#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Glenn Straussefde9d52022-12-20 04:20:12 -05001242
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001243/*
1244 * Computes the right-hand side of the Short Weierstrass equation
1245 * RHS = X^3 + A X + B
1246 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001247static int ecp_sw_rhs(const mbedtls_ecp_group *grp,
1248 mbedtls_mpi *rhs,
1249 const mbedtls_mpi *X)
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001250{
1251 int ret;
1252
1253 /* Compute X^3 + A X + B as X (X^2 + A) + B */
Gilles Peskine449bd832023-01-11 14:50:10 +01001254 MPI_ECP_SQR(rhs, X);
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001255
1256 /* Special case for A = -3 */
Chien Wong153ae462023-01-31 23:27:03 +08001257 if (mbedtls_ecp_group_a_is_minus_3(grp)) {
Gilles Peskine449bd832023-01-11 14:50:10 +01001258 MPI_ECP_SUB_INT(rhs, rhs, 3);
1259 } else {
1260 MPI_ECP_ADD(rhs, rhs, &grp->A);
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001261 }
1262
Gilles Peskine449bd832023-01-11 14:50:10 +01001263 MPI_ECP_MUL(rhs, rhs, X);
1264 MPI_ECP_ADD(rhs, rhs, &grp->B);
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001265
1266cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001267 return ret;
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001268}
1269
1270/*
1271 * Derive Y from X and a parity bit
1272 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001273static int mbedtls_ecp_sw_derive_y(const mbedtls_ecp_group *grp,
1274 const mbedtls_mpi *X,
1275 mbedtls_mpi *Y,
1276 int parity_bit)
Glenn Strauss45241612022-12-19 19:37:07 -05001277{
1278 /* w = y^2 = x^3 + ax + b
1279 * y = sqrt(w) = w^((p+1)/4) mod p (for prime p where p = 3 mod 4)
1280 *
1281 * Note: this method for extracting square root does not validate that w
1282 * was indeed a square so this function will return garbage in Y if X
1283 * does not correspond to a point on the curve.
1284 */
1285
1286 /* Check prerequisite p = 3 mod 4 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001287 if (mbedtls_mpi_get_bit(&grp->P, 0) != 1 ||
1288 mbedtls_mpi_get_bit(&grp->P, 1) != 1) {
1289 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
1290 }
Glenn Strauss45241612022-12-19 19:37:07 -05001291
1292 int ret;
1293 mbedtls_mpi exp;
Gilles Peskine449bd832023-01-11 14:50:10 +01001294 mbedtls_mpi_init(&exp);
Glenn Strauss45241612022-12-19 19:37:07 -05001295
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001296 /* use Y to store intermediate result, actually w above */
Gilles Peskine449bd832023-01-11 14:50:10 +01001297 MBEDTLS_MPI_CHK(ecp_sw_rhs(grp, Y, X));
Glenn Strauss45241612022-12-19 19:37:07 -05001298
1299 /* w = y^2 */ /* Y contains y^2 intermediate result */
1300 /* exp = ((p+1)/4) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001301 MBEDTLS_MPI_CHK(mbedtls_mpi_add_int(&exp, &grp->P, 1));
1302 MBEDTLS_MPI_CHK(mbedtls_mpi_shift_r(&exp, 2));
Glenn Strauss45241612022-12-19 19:37:07 -05001303 /* sqrt(w) = w^((p+1)/4) mod p (for prime p where p = 3 mod 4) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001304 MBEDTLS_MPI_CHK(mbedtls_mpi_exp_mod(Y, Y /*y^2*/, &exp, &grp->P, NULL));
Glenn Strauss45241612022-12-19 19:37:07 -05001305
1306 /* check parity bit match or else invert Y */
1307 /* This quick inversion implementation is valid because Y != 0 for all
1308 * Short Weierstrass curves supported by mbedtls, as each supported curve
1309 * has an order that is a large prime, so each supported curve does not
1310 * have any point of order 2, and a point with Y == 0 would be of order 2 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001311 if (mbedtls_mpi_get_bit(Y, 0) != parity_bit) {
1312 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(Y, &grp->P, Y));
1313 }
Glenn Strauss45241612022-12-19 19:37:07 -05001314
1315cleanup:
1316
Gilles Peskine449bd832023-01-11 14:50:10 +01001317 mbedtls_mpi_free(&exp);
1318 return ret;
Glenn Strauss45241612022-12-19 19:37:07 -05001319}
Valerio Settifd122f42023-04-05 18:15:32 +02001320#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Glenn Strauss45241612022-12-19 19:37:07 -05001321
Valerio Settifd122f42023-04-05 18:15:32 +02001322#if defined(MBEDTLS_ECP_C)
1323#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01001324/*
1325 * For curves in short Weierstrass form, we do all the internal operations in
1326 * Jacobian coordinates.
1327 *
Shaun Case8b0ecbc2021-12-20 21:14:10 -08001328 * For multiplication, we'll use a comb method with countermeasures against
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01001329 * SPA, hence timing attacks.
1330 */
1331
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001332/*
Manuel Pégourié-Gonnard1c2782c2012-11-19 20:16:28 +01001333 * Normalize jacobian coordinates so that Z == 0 || Z == 1 (GECC 3.2.1)
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001334 * Cost: 1N := 1I + 3M + 1S
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001335 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001336static int ecp_normalize_jac(const mbedtls_ecp_group *grp, mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001337{
Gilles Peskine449bd832023-01-11 14:50:10 +01001338 if (MPI_ECP_CMP_INT(&pt->Z, 0) == 0) {
1339 return 0;
1340 }
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001341
Janos Follathb0697532016-08-18 12:38:46 +01001342#if defined(MBEDTLS_ECP_NORMALIZE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001343 if (mbedtls_internal_ecp_grp_capable(grp)) {
1344 return mbedtls_internal_ecp_normalize_jac(grp, pt);
1345 }
Janos Follath372697b2016-10-28 16:53:11 +01001346#endif /* MBEDTLS_ECP_NORMALIZE_JAC_ALT */
Manuel Pégourié-Gonnardebac5d32017-08-23 16:23:36 +02001347
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001348#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_NORMALIZE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001349 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001350#else
1351 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Becker76f897d2022-01-02 12:47:34 +00001352 mbedtls_mpi T;
Gilles Peskine449bd832023-01-11 14:50:10 +01001353 mbedtls_mpi_init(&T);
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001354
Gilles Peskine449bd832023-01-11 14:50:10 +01001355 MPI_ECP_INV(&T, &pt->Z); /* T <- 1 / Z */
1356 MPI_ECP_MUL(&pt->Y, &pt->Y, &T); /* Y' <- Y*T = Y / Z */
1357 MPI_ECP_SQR(&T, &T); /* T <- T^2 = 1 / Z^2 */
1358 MPI_ECP_MUL(&pt->X, &pt->X, &T); /* X <- X * T = X / Z^2 */
1359 MPI_ECP_MUL(&pt->Y, &pt->Y, &T); /* Y'' <- Y' * T = Y / Z^3 */
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001360
Gilles Peskine449bd832023-01-11 14:50:10 +01001361 MPI_ECP_LSET(&pt->Z, 1);
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001362
1363cleanup:
1364
Gilles Peskine449bd832023-01-11 14:50:10 +01001365 mbedtls_mpi_free(&T);
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001366
Gilles Peskine449bd832023-01-11 14:50:10 +01001367 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001368#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_NORMALIZE_JAC_ALT) */
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001369}
1370
1371/*
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001372 * Normalize jacobian coordinates of an array of (pointers to) points,
Manuel Pégourié-Gonnard3680c822012-11-21 18:49:45 +01001373 * using Montgomery's trick to perform only one inversion mod P.
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001374 * (See for example Cohen's "A Course in Computational Algebraic Number
1375 * Theory", Algorithm 10.3.4.)
1376 *
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001377 * Warning: fails (returning an error) if one of the points is zero!
Manuel Pégourié-Gonnard7a949d32013-12-05 10:26:01 +01001378 * This should never happen, see choice of w in ecp_mul_comb().
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001379 *
1380 * Cost: 1N(t) := 1I + (6t - 3)M + 1S
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001381 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001382static int ecp_normalize_jac_many(const mbedtls_ecp_group *grp,
1383 mbedtls_ecp_point *T[], size_t T_size)
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001384{
Gilles Peskine449bd832023-01-11 14:50:10 +01001385 if (T_size < 2) {
1386 return ecp_normalize_jac(grp, *T);
1387 }
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001388
Janos Follathb0697532016-08-18 12:38:46 +01001389#if defined(MBEDTLS_ECP_NORMALIZE_JAC_MANY_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001390 if (mbedtls_internal_ecp_grp_capable(grp)) {
1391 return mbedtls_internal_ecp_normalize_jac_many(grp, T, T_size);
1392 }
Janos Follathb0697532016-08-18 12:38:46 +01001393#endif
1394
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001395#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_NORMALIZE_JAC_MANY_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001396 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001397#else
1398 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
1399 size_t i;
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001400 mbedtls_mpi *c, t;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001401
Gilles Peskine449bd832023-01-11 14:50:10 +01001402 if ((c = mbedtls_calloc(T_size, sizeof(mbedtls_mpi))) == NULL) {
1403 return MBEDTLS_ERR_ECP_ALLOC_FAILED;
1404 }
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001405
Gilles Peskine449bd832023-01-11 14:50:10 +01001406 mbedtls_mpi_init(&t);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001407
Gilles Peskine449bd832023-01-11 14:50:10 +01001408 mpi_init_many(c, T_size);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001409 /*
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001410 * c[i] = Z_0 * ... * Z_i, i = 0,..,n := T_size-1
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001411 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001412 MPI_ECP_MOV(&c[0], &T[0]->Z);
1413 for (i = 1; i < T_size; i++) {
1414 MPI_ECP_MUL(&c[i], &c[i-1], &T[i]->Z);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001415 }
1416
1417 /*
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001418 * c[n] = 1 / (Z_0 * ... * Z_n) mod P
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001419 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001420 MPI_ECP_INV(&c[T_size-1], &c[T_size-1]);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001421
Gilles Peskine449bd832023-01-11 14:50:10 +01001422 for (i = T_size - 1;; i--) {
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001423 /* At the start of iteration i (note that i decrements), we have
1424 * - c[j] = Z_0 * .... * Z_j for j < i,
1425 * - c[j] = 1 / (Z_0 * .... * Z_j) for j == i,
1426 *
1427 * This is maintained via
1428 * - c[i-1] <- c[i] * Z_i
1429 *
1430 * We also derive 1/Z_i = c[i] * c[i-1] for i>0 and use that
1431 * to do the actual normalization. For i==0, we already have
1432 * c[0] = 1 / Z_0.
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001433 */
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001434
Gilles Peskine449bd832023-01-11 14:50:10 +01001435 if (i > 0) {
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001436 /* Compute 1/Z_i and establish invariant for the next iteration. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001437 MPI_ECP_MUL(&t, &c[i], &c[i-1]);
1438 MPI_ECP_MUL(&c[i-1], &c[i], &T[i]->Z);
1439 } else {
1440 MPI_ECP_MOV(&t, &c[0]);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001441 }
1442
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001443 /* Now t holds 1 / Z_i; normalize as in ecp_normalize_jac() */
Gilles Peskine449bd832023-01-11 14:50:10 +01001444 MPI_ECP_MUL(&T[i]->Y, &T[i]->Y, &t);
1445 MPI_ECP_SQR(&t, &t);
1446 MPI_ECP_MUL(&T[i]->X, &T[i]->X, &t);
1447 MPI_ECP_MUL(&T[i]->Y, &T[i]->Y, &t);
Manuel Pégourié-Gonnard1f789b82013-12-30 17:31:56 +01001448
1449 /*
1450 * Post-precessing: reclaim some memory by shrinking coordinates
1451 * - not storing Z (always 1)
1452 * - shrinking other coordinates, but still keeping the same number of
1453 * limbs as P, as otherwise it will too likely be regrown too fast.
1454 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001455 MBEDTLS_MPI_CHK(mbedtls_mpi_shrink(&T[i]->X, grp->P.n));
1456 MBEDTLS_MPI_CHK(mbedtls_mpi_shrink(&T[i]->Y, grp->P.n));
Hanno Beckeree95f6c2022-01-09 05:46:18 +00001457
Gilles Peskine449bd832023-01-11 14:50:10 +01001458 MPI_ECP_LSET(&T[i]->Z, 1);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001459
Gilles Peskine449bd832023-01-11 14:50:10 +01001460 if (i == 0) {
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001461 break;
Gilles Peskine449bd832023-01-11 14:50:10 +01001462 }
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001463 }
1464
1465cleanup:
1466
Gilles Peskine449bd832023-01-11 14:50:10 +01001467 mbedtls_mpi_free(&t);
1468 mpi_free_many(c, T_size);
1469 mbedtls_free(c);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001470
Gilles Peskine449bd832023-01-11 14:50:10 +01001471 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001472#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_NORMALIZE_JAC_MANY_ALT) */
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001473}
1474
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001475/*
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001476 * Conditional point inversion: Q -> -Q = (Q.X, -Q.Y, Q.Z) without leak.
1477 * "inv" must be 0 (don't invert) or 1 (invert) or the result will be invalid
1478 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001479static int ecp_safe_invert_jac(const mbedtls_ecp_group *grp,
1480 mbedtls_ecp_point *Q,
1481 unsigned char inv)
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001482{
Janos Follath24eed8d2019-11-22 13:21:35 +00001483 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Becker595616e2022-01-05 08:28:24 +00001484 mbedtls_mpi tmp;
Gilles Peskine449bd832023-01-11 14:50:10 +01001485 mbedtls_mpi_init(&tmp);
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001486
Gilles Peskine449bd832023-01-11 14:50:10 +01001487 MPI_ECP_COND_NEG(&Q->Y, inv);
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001488
1489cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001490 mbedtls_mpi_free(&tmp);
1491 return ret;
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001492}
1493
1494/*
Manuel Pégourié-Gonnard0cd6f982013-10-10 15:55:39 +02001495 * Point doubling R = 2 P, Jacobian coordinates
Manuel Pégourié-Gonnard0ace4b32013-10-10 12:44:27 +02001496 *
Peter Dettmance661b22015-02-07 14:43:51 +07001497 * Based on http://www.hyperelliptic.org/EFD/g1p/auto-shortw-jacobian.html#doubling-dbl-1998-cmo-2 .
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001498 *
Peter Dettmance661b22015-02-07 14:43:51 +07001499 * We follow the variable naming fairly closely. The formula variations that trade a MUL for a SQR
1500 * (plus a few ADDs) aren't useful as our bignum implementation doesn't distinguish squaring.
1501 *
1502 * Standard optimizations are applied when curve parameter A is one of { 0, -3 }.
1503 *
1504 * Cost: 1D := 3M + 4S (A == 0)
1505 * 4M + 4S (A == -3)
1506 * 3M + 6S + 1a otherwise
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001507 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001508static int ecp_double_jac(const mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
1509 const mbedtls_ecp_point *P,
1510 mbedtls_mpi tmp[4])
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001511{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001512#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnard0cd6f982013-10-10 15:55:39 +02001513 dbl_count++;
1514#endif
1515
Janos Follathb0697532016-08-18 12:38:46 +01001516#if defined(MBEDTLS_ECP_DOUBLE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001517 if (mbedtls_internal_ecp_grp_capable(grp)) {
1518 return mbedtls_internal_ecp_double_jac(grp, R, P);
1519 }
Janos Follath372697b2016-10-28 16:53:11 +01001520#endif /* MBEDTLS_ECP_DOUBLE_JAC_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01001521
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001522#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_DOUBLE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001523 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001524#else
1525 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard73cc01d2013-12-06 12:41:30 +01001526
1527 /* Special case for A = -3 */
Chien Wong153ae462023-01-31 23:27:03 +08001528 if (mbedtls_ecp_group_a_is_minus_3(grp)) {
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001529 /* tmp[0] <- M = 3(X + Z^2)(X - Z^2) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001530 MPI_ECP_SQR(&tmp[1], &P->Z);
1531 MPI_ECP_ADD(&tmp[2], &P->X, &tmp[1]);
1532 MPI_ECP_SUB(&tmp[3], &P->X, &tmp[1]);
1533 MPI_ECP_MUL(&tmp[1], &tmp[2], &tmp[3]);
1534 MPI_ECP_MUL_INT(&tmp[0], &tmp[1], 3);
1535 } else {
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001536 /* tmp[0] <- M = 3.X^2 + A.Z^4 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001537 MPI_ECP_SQR(&tmp[1], &P->X);
1538 MPI_ECP_MUL_INT(&tmp[0], &tmp[1], 3);
Peter Dettmance661b22015-02-07 14:43:51 +07001539
1540 /* Optimize away for "koblitz" curves with A = 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001541 if (MPI_ECP_CMP_INT(&grp->A, 0) != 0) {
Peter Dettmance661b22015-02-07 14:43:51 +07001542 /* M += A.Z^4 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001543 MPI_ECP_SQR(&tmp[1], &P->Z);
1544 MPI_ECP_SQR(&tmp[2], &tmp[1]);
1545 MPI_ECP_MUL(&tmp[1], &tmp[2], &grp->A);
1546 MPI_ECP_ADD(&tmp[0], &tmp[0], &tmp[1]);
Peter Dettmance661b22015-02-07 14:43:51 +07001547 }
Peter Vaskovica676acf2014-08-06 00:48:39 +02001548 }
Manuel Pégourié-Gonnard73cc01d2013-12-06 12:41:30 +01001549
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001550 /* tmp[1] <- S = 4.X.Y^2 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001551 MPI_ECP_SQR(&tmp[2], &P->Y);
1552 MPI_ECP_SHIFT_L(&tmp[2], 1);
1553 MPI_ECP_MUL(&tmp[1], &P->X, &tmp[2]);
1554 MPI_ECP_SHIFT_L(&tmp[1], 1);
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001555
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001556 /* tmp[3] <- U = 8.Y^4 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001557 MPI_ECP_SQR(&tmp[3], &tmp[2]);
1558 MPI_ECP_SHIFT_L(&tmp[3], 1);
Peter Dettmance661b22015-02-07 14:43:51 +07001559
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001560 /* tmp[2] <- T = M^2 - 2.S */
Gilles Peskine449bd832023-01-11 14:50:10 +01001561 MPI_ECP_SQR(&tmp[2], &tmp[0]);
1562 MPI_ECP_SUB(&tmp[2], &tmp[2], &tmp[1]);
1563 MPI_ECP_SUB(&tmp[2], &tmp[2], &tmp[1]);
Peter Dettmance661b22015-02-07 14:43:51 +07001564
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001565 /* tmp[1] <- S = M(S - T) - U */
Gilles Peskine449bd832023-01-11 14:50:10 +01001566 MPI_ECP_SUB(&tmp[1], &tmp[1], &tmp[2]);
1567 MPI_ECP_MUL(&tmp[1], &tmp[1], &tmp[0]);
1568 MPI_ECP_SUB(&tmp[1], &tmp[1], &tmp[3]);
Peter Dettmance661b22015-02-07 14:43:51 +07001569
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001570 /* tmp[3] <- U = 2.Y.Z */
Gilles Peskine449bd832023-01-11 14:50:10 +01001571 MPI_ECP_MUL(&tmp[3], &P->Y, &P->Z);
1572 MPI_ECP_SHIFT_L(&tmp[3], 1);
Peter Dettmance661b22015-02-07 14:43:51 +07001573
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001574 /* Store results */
Gilles Peskine449bd832023-01-11 14:50:10 +01001575 MPI_ECP_MOV(&R->X, &tmp[2]);
1576 MPI_ECP_MOV(&R->Y, &tmp[1]);
1577 MPI_ECP_MOV(&R->Z, &tmp[3]);
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001578
1579cleanup:
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001580
Gilles Peskine449bd832023-01-11 14:50:10 +01001581 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001582#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_DOUBLE_JAC_ALT) */
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001583}
1584
1585/*
Manuel Pégourié-Gonnard469a2092013-11-21 18:20:43 +01001586 * Addition: R = P + Q, mixed affine-Jacobian coordinates (GECC 3.22)
Manuel Pégourié-Gonnard9674fd02012-11-19 21:23:27 +01001587 *
1588 * The coordinates of Q must be normalized (= affine),
1589 * but those of P don't need to. R is not normalized.
1590 *
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001591 * P,Q,R may alias, but only at the level of EC points: they must be either
1592 * equal as pointers, or disjoint (including the coordinate data buffers).
1593 * Fine-grained aliasing at the level of coordinates is not supported.
1594 *
Manuel Pégourié-Gonnardaade42f2013-11-21 19:19:54 +01001595 * Special cases: (1) P or Q is zero, (2) R is zero, (3) P == Q.
Manuel Pégourié-Gonnard7a949d32013-12-05 10:26:01 +01001596 * None of these cases can happen as intermediate step in ecp_mul_comb():
Manuel Pégourié-Gonnardaade42f2013-11-21 19:19:54 +01001597 * - at each step, P, Q and R are multiples of the base point, the factor
1598 * being less than its order, so none of them is zero;
1599 * - Q is an odd multiple of the base point, P an even multiple,
1600 * due to the choice of precomputed points in the modified comb method.
1601 * So branches for these cases do not leak secret information.
1602 *
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001603 * Cost: 1A := 8M + 3S
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001604 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001605static int ecp_add_mixed(const mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
1606 const mbedtls_ecp_point *P, const mbedtls_ecp_point *Q,
1607 mbedtls_mpi tmp[4])
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001608{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001609#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01001610 add_count++;
1611#endif
1612
Janos Follathb0697532016-08-18 12:38:46 +01001613#if defined(MBEDTLS_ECP_ADD_MIXED_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001614 if (mbedtls_internal_ecp_grp_capable(grp)) {
1615 return mbedtls_internal_ecp_add_mixed(grp, R, P, Q);
1616 }
Janos Follath372697b2016-10-28 16:53:11 +01001617#endif /* MBEDTLS_ECP_ADD_MIXED_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01001618
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001619#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_ADD_MIXED_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001620 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001621#else
1622 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Becker838b7152022-01-04 05:01:53 +00001623
1624 /* NOTE: Aliasing between input and output is allowed, so one has to make
1625 * sure that at the point X,Y,Z are written, {P,Q}->{X,Y,Z} are no
1626 * longer read from. */
Hanno Becker5c8ea302022-01-01 06:01:45 +00001627 mbedtls_mpi * const X = &R->X;
1628 mbedtls_mpi * const Y = &R->Y;
1629 mbedtls_mpi * const Z = &R->Z;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001630
Gilles Peskine449bd832023-01-11 14:50:10 +01001631 if (!MPI_ECP_VALID(&Q->Z)) {
1632 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
1633 }
Hanno Beckeree95f6c2022-01-09 05:46:18 +00001634
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001635 /*
Manuel Pégourié-Gonnardaade42f2013-11-21 19:19:54 +01001636 * Trivial cases: P == 0 or Q == 0 (case 1)
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001637 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001638 if (MPI_ECP_CMP_INT(&P->Z, 0) == 0) {
1639 return mbedtls_ecp_copy(R, Q);
1640 }
Manuel Pégourié-Gonnard469a2092013-11-21 18:20:43 +01001641
Gilles Peskine449bd832023-01-11 14:50:10 +01001642 if (MPI_ECP_CMP_INT(&Q->Z, 0) == 0) {
1643 return mbedtls_ecp_copy(R, P);
1644 }
Manuel Pégourié-Gonnard1c2782c2012-11-19 20:16:28 +01001645
1646 /*
1647 * Make sure Q coordinates are normalized
1648 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001649 if (MPI_ECP_CMP_INT(&Q->Z, 1) != 0) {
1650 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
1651 }
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001652
Gilles Peskine449bd832023-01-11 14:50:10 +01001653 MPI_ECP_SQR(&tmp[0], &P->Z);
1654 MPI_ECP_MUL(&tmp[1], &tmp[0], &P->Z);
1655 MPI_ECP_MUL(&tmp[0], &tmp[0], &Q->X);
1656 MPI_ECP_MUL(&tmp[1], &tmp[1], &Q->Y);
1657 MPI_ECP_SUB(&tmp[0], &tmp[0], &P->X);
1658 MPI_ECP_SUB(&tmp[1], &tmp[1], &P->Y);
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001659
Manuel Pégourié-Gonnardaade42f2013-11-21 19:19:54 +01001660 /* Special cases (2) and (3) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001661 if (MPI_ECP_CMP_INT(&tmp[0], 0) == 0) {
1662 if (MPI_ECP_CMP_INT(&tmp[1], 0) == 0) {
1663 ret = ecp_double_jac(grp, R, P, tmp);
Manuel Pégourié-Gonnard7e0adfb2012-11-08 23:21:46 +01001664 goto cleanup;
Gilles Peskine449bd832023-01-11 14:50:10 +01001665 } else {
1666 ret = mbedtls_ecp_set_zero(R);
Manuel Pégourié-Gonnard7e0adfb2012-11-08 23:21:46 +01001667 goto cleanup;
1668 }
1669 }
1670
Hanno Becker838b7152022-01-04 05:01:53 +00001671 /* {P,Q}->Z no longer used, so OK to write to Z even if there's aliasing. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001672 MPI_ECP_MUL(Z, &P->Z, &tmp[0]);
1673 MPI_ECP_SQR(&tmp[2], &tmp[0]);
1674 MPI_ECP_MUL(&tmp[3], &tmp[2], &tmp[0]);
1675 MPI_ECP_MUL(&tmp[2], &tmp[2], &P->X);
Hanno Beckerce29ae82022-01-04 04:55:11 +00001676
Gilles Peskine449bd832023-01-11 14:50:10 +01001677 MPI_ECP_MOV(&tmp[0], &tmp[2]);
1678 MPI_ECP_SHIFT_L(&tmp[0], 1);
Hanno Beckerce29ae82022-01-04 04:55:11 +00001679
Hanno Becker838b7152022-01-04 05:01:53 +00001680 /* {P,Q}->X no longer used, so OK to write to X even if there's aliasing. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001681 MPI_ECP_SQR(X, &tmp[1]);
1682 MPI_ECP_SUB(X, X, &tmp[0]);
1683 MPI_ECP_SUB(X, X, &tmp[3]);
1684 MPI_ECP_SUB(&tmp[2], &tmp[2], X);
1685 MPI_ECP_MUL(&tmp[2], &tmp[2], &tmp[1]);
1686 MPI_ECP_MUL(&tmp[3], &tmp[3], &P->Y);
Hanno Becker838b7152022-01-04 05:01:53 +00001687 /* {P,Q}->Y no longer used, so OK to write to Y even if there's aliasing. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001688 MPI_ECP_SUB(Y, &tmp[2], &tmp[3]);
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001689
1690cleanup:
1691
Gilles Peskine449bd832023-01-11 14:50:10 +01001692 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001693#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_ADD_MIXED_ALT) */
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001694}
1695
1696/*
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001697 * Randomize jacobian coordinates:
1698 * (X, Y, Z) -> (l^2 X, l^3 Y, l Z) for random l
Manuel Pégourié-Gonnard3c0b4ea2013-12-02 19:44:41 +01001699 * This is sort of the reverse operation of ecp_normalize_jac().
Manuel Pégourié-Gonnard44aab792013-11-21 10:53:59 +01001700 *
1701 * This countermeasure was first suggested in [2].
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001702 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001703static int ecp_randomize_jac(const mbedtls_ecp_group *grp, mbedtls_ecp_point *pt,
1704 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001705{
Janos Follathb0697532016-08-18 12:38:46 +01001706#if defined(MBEDTLS_ECP_RANDOMIZE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001707 if (mbedtls_internal_ecp_grp_capable(grp)) {
1708 return mbedtls_internal_ecp_randomize_jac(grp, pt, f_rng, p_rng);
1709 }
Janos Follath372697b2016-10-28 16:53:11 +01001710#endif /* MBEDTLS_ECP_RANDOMIZE_JAC_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01001711
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001712#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_RANDOMIZE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001713 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001714#else
1715 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Becker0d629792022-01-04 06:45:49 +00001716 mbedtls_mpi l;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001717
Gilles Peskine449bd832023-01-11 14:50:10 +01001718 mbedtls_mpi_init(&l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001719
1720 /* Generate l such that 1 < l < p */
Gilles Peskine449bd832023-01-11 14:50:10 +01001721 MPI_ECP_RAND(&l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001722
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001723 /* Z' = l * Z */
Gilles Peskine449bd832023-01-11 14:50:10 +01001724 MPI_ECP_MUL(&pt->Z, &pt->Z, &l);
Hanno Becker0d629792022-01-04 06:45:49 +00001725
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001726 /* Y' = l * Y */
Gilles Peskine449bd832023-01-11 14:50:10 +01001727 MPI_ECP_MUL(&pt->Y, &pt->Y, &l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001728
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001729 /* X' = l^2 * X */
Gilles Peskine449bd832023-01-11 14:50:10 +01001730 MPI_ECP_SQR(&l, &l);
1731 MPI_ECP_MUL(&pt->X, &pt->X, &l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001732
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001733 /* Y'' = l^2 * Y' = l^3 * Y */
Gilles Peskine449bd832023-01-11 14:50:10 +01001734 MPI_ECP_MUL(&pt->Y, &pt->Y, &l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001735
1736cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001737 mbedtls_mpi_free(&l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001738
Gilles Peskine449bd832023-01-11 14:50:10 +01001739 if (ret == MBEDTLS_ERR_MPI_NOT_ACCEPTABLE) {
Gilles Peskine59215172021-03-29 22:28:50 +02001740 ret = MBEDTLS_ERR_ECP_RANDOM_FAILED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001741 }
1742 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001743#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_RANDOMIZE_JAC_ALT) */
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001744}
1745
1746/*
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001747 * Check and define parameters used by the comb method (see below for details)
1748 */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001749#if MBEDTLS_ECP_WINDOW_SIZE < 2 || MBEDTLS_ECP_WINDOW_SIZE > 7
1750#error "MBEDTLS_ECP_WINDOW_SIZE out of bounds"
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001751#endif
1752
1753/* d = ceil( n / w ) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001754#define COMB_MAX_D (MBEDTLS_ECP_MAX_BITS + 1) / 2
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001755
1756/* number of precomputed points */
Gilles Peskine449bd832023-01-11 14:50:10 +01001757#define COMB_MAX_PRE (1 << (MBEDTLS_ECP_WINDOW_SIZE - 1))
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001758
1759/*
1760 * Compute the representation of m that will be used with our comb method.
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001761 *
1762 * The basic comb method is described in GECC 3.44 for example. We use a
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001763 * modified version that provides resistance to SPA by avoiding zero
1764 * digits in the representation as in [3]. We modify the method further by
1765 * requiring that all K_i be odd, which has the small cost that our
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001766 * representation uses one more K_i, due to carries, but saves on the size of
1767 * the precomputed table.
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001768 *
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001769 * Summary of the comb method and its modifications:
1770 *
1771 * - The goal is to compute m*P for some w*d-bit integer m.
1772 *
1773 * - The basic comb method splits m into the w-bit integers
1774 * x[0] .. x[d-1] where x[i] consists of the bits in m whose
1775 * index has residue i modulo d, and computes m * P as
1776 * S[x[0]] + 2 * S[x[1]] + .. + 2^(d-1) S[x[d-1]], where
1777 * S[i_{w-1} .. i_0] := i_{w-1} 2^{(w-1)d} P + ... + i_1 2^d P + i_0 P.
1778 *
1779 * - If it happens that, say, x[i+1]=0 (=> S[x[i+1]]=0), one can replace the sum by
1780 * .. + 2^{i-1} S[x[i-1]] - 2^i S[x[i]] + 2^{i+1} S[x[i]] + 2^{i+2} S[x[i+2]] ..,
1781 * thereby successively converting it into a form where all summands
1782 * are nonzero, at the cost of negative summands. This is the basic idea of [3].
1783 *
1784 * - More generally, even if x[i+1] != 0, we can first transform the sum as
1785 * .. - 2^i S[x[i]] + 2^{i+1} ( S[x[i]] + S[x[i+1]] ) + 2^{i+2} S[x[i+2]] ..,
1786 * and then replace S[x[i]] + S[x[i+1]] = S[x[i] ^ x[i+1]] + 2 S[x[i] & x[i+1]].
1787 * Performing and iterating this procedure for those x[i] that are even
1788 * (keeping track of carry), we can transform the original sum into one of the form
1789 * S[x'[0]] +- 2 S[x'[1]] +- .. +- 2^{d-1} S[x'[d-1]] + 2^d S[x'[d]]
1790 * with all x'[i] odd. It is therefore only necessary to know S at odd indices,
1791 * which is why we are only computing half of it in the first place in
1792 * ecp_precompute_comb and accessing it with index abs(i) / 2 in ecp_select_comb.
1793 *
1794 * - For the sake of compactness, only the seven low-order bits of x[i]
1795 * are used to represent its absolute value (K_i in the paper), and the msb
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001796 * of x[i] encodes the sign (s_i in the paper): it is set if and only if
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001797 * if s_i == -1;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001798 *
1799 * Calling conventions:
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001800 * - x is an array of size d + 1
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001801 * - w is the size, ie number of teeth, of the comb, and must be between
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001802 * 2 and 7 (in practice, between 2 and MBEDTLS_ECP_WINDOW_SIZE)
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001803 * - m is the MPI, expected to be odd and such that bitlength(m) <= w * d
1804 * (the result will be incorrect if these assumptions are not satisfied)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001805 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001806static void ecp_comb_recode_core(unsigned char x[], size_t d,
1807 unsigned char w, const mbedtls_mpi *m)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001808{
1809 size_t i, j;
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001810 unsigned char c, cc, adjust;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001811
Gilles Peskine449bd832023-01-11 14:50:10 +01001812 memset(x, 0, d+1);
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001813
Manuel Pégourié-Gonnardedc1a1f2013-11-21 09:50:00 +01001814 /* First get the classical comb values (except for x_d = 0) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001815 for (i = 0; i < d; i++) {
1816 for (j = 0; j < w; j++) {
1817 x[i] |= mbedtls_mpi_get_bit(m, i + d * j) << j;
1818 }
1819 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001820
Manuel Pégourié-Gonnardedc1a1f2013-11-21 09:50:00 +01001821 /* Now make sure x_1 .. x_d are odd */
1822 c = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01001823 for (i = 1; i <= d; i++) {
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001824 /* Add carry and update it */
1825 cc = x[i] & c;
1826 x[i] = x[i] ^ c;
1827 c = cc;
1828
Manuel Pégourié-Gonnardedc1a1f2013-11-21 09:50:00 +01001829 /* Adjust if needed, avoiding branches */
Gilles Peskine449bd832023-01-11 14:50:10 +01001830 adjust = 1 - (x[i] & 0x01);
1831 c |= x[i] & (x[i-1] * adjust);
1832 x[i] = x[i] ^ (x[i-1] * adjust);
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001833 x[i-1] |= adjust << 7;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001834 }
1835}
1836
1837/*
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001838 * Precompute points for the adapted comb method
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001839 *
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001840 * Assumption: T must be able to hold 2^{w - 1} elements.
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001841 *
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001842 * Operation: If i = i_{w-1} ... i_1 is the binary representation of i,
1843 * sets T[i] = i_{w-1} 2^{(w-1)d} P + ... + i_1 2^d P + P.
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001844 *
1845 * Cost: d(w-1) D + (2^{w-1} - 1) A + 1 N(w-1) + 1 N(2^{w-1} - 1)
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001846 *
1847 * Note: Even comb values (those where P would be omitted from the
1848 * sum defining T[i] above) are not needed in our adaption
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001849 * the comb method. See ecp_comb_recode_core().
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001850 *
1851 * This function currently works in four steps:
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001852 * (1) [dbl] Computation of intermediate T[i] for 2-power values of i
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001853 * (2) [norm_dbl] Normalization of coordinates of these T[i]
1854 * (3) [add] Computation of all T[i]
1855 * (4) [norm_add] Normalization of all T[i]
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001856 *
1857 * Step 1 can be interrupted but not the others; together with the final
1858 * coordinate normalization they are the largest steps done at once, depending
1859 * on the window size. Here are operation counts for P-256:
1860 *
1861 * step (2) (3) (4)
1862 * w = 5 142 165 208
1863 * w = 4 136 77 160
1864 * w = 3 130 33 136
1865 * w = 2 124 11 124
1866 *
1867 * So if ECC operations are blocking for too long even with a low max_ops
1868 * value, it's useful to set MBEDTLS_ECP_WINDOW_SIZE to a lower value in order
1869 * to minimize maximum blocking time.
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001870 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001871static int ecp_precompute_comb(const mbedtls_ecp_group *grp,
1872 mbedtls_ecp_point T[], const mbedtls_ecp_point *P,
1873 unsigned char w, size_t d,
1874 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001875{
Janos Follath24eed8d2019-11-22 13:21:35 +00001876 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001877 unsigned char i;
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01001878 size_t j = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01001879 const unsigned char T_size = 1U << (w - 1);
1880 mbedtls_ecp_point *cur, *TT[COMB_MAX_PRE - 1] = { NULL };
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001881
Hanno Beckera7f8edd2022-01-04 07:29:46 +00001882 mbedtls_mpi tmp[4];
1883
Gilles Peskine449bd832023-01-11 14:50:10 +01001884 mpi_init_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Beckera7f8edd2022-01-04 07:29:46 +00001885
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001886#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001887 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
1888 if (rs_ctx->rsm->state == ecp_rsm_pre_dbl) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001889 goto dbl;
Gilles Peskine449bd832023-01-11 14:50:10 +01001890 }
1891 if (rs_ctx->rsm->state == ecp_rsm_pre_norm_dbl) {
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001892 goto norm_dbl;
Gilles Peskine449bd832023-01-11 14:50:10 +01001893 }
1894 if (rs_ctx->rsm->state == ecp_rsm_pre_add) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001895 goto add;
Gilles Peskine449bd832023-01-11 14:50:10 +01001896 }
1897 if (rs_ctx->rsm->state == ecp_rsm_pre_norm_add) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001898 goto norm_add;
Gilles Peskine449bd832023-01-11 14:50:10 +01001899 }
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01001900 }
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001901#else
1902 (void) rs_ctx;
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01001903#endif
1904
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001905#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001906 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001907 rs_ctx->rsm->state = ecp_rsm_pre_dbl;
1908
1909 /* initial state for the loop */
1910 rs_ctx->rsm->i = 0;
1911 }
1912
1913dbl:
1914#endif
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001915 /*
1916 * Set T[0] = P and
1917 * T[2^{l-1}] = 2^{dl} P for l = 1 .. w-1 (this is not the final value)
1918 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001919 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(&T[0], P));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001920
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001921#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001922 if (rs_ctx != NULL && rs_ctx->rsm != NULL && rs_ctx->rsm->i != 0) {
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02001923 j = rs_ctx->rsm->i;
Gilles Peskine449bd832023-01-11 14:50:10 +01001924 } else
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01001925#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01001926 j = 0;
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01001927
Gilles Peskine449bd832023-01-11 14:50:10 +01001928 for (; j < d * (w - 1); j++) {
1929 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_DBL);
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01001930
Gilles Peskine449bd832023-01-11 14:50:10 +01001931 i = 1U << (j / d);
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001932 cur = T + i;
Manuel Pégourié-Gonnardae557072017-03-20 12:21:24 +01001933
Gilles Peskine449bd832023-01-11 14:50:10 +01001934 if (j % d == 0) {
1935 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(cur, T + (i >> 1)));
1936 }
Manuel Pégourié-Gonnardae557072017-03-20 12:21:24 +01001937
Gilles Peskine449bd832023-01-11 14:50:10 +01001938 MBEDTLS_MPI_CHK(ecp_double_jac(grp, cur, cur, tmp));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001939 }
1940
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001941#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001942 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001943 rs_ctx->rsm->state = ecp_rsm_pre_norm_dbl;
Gilles Peskine449bd832023-01-11 14:50:10 +01001944 }
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001945
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001946norm_dbl:
1947#endif
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001948 /*
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001949 * Normalize current elements in T to allow them to be used in
1950 * ecp_add_mixed() below, which requires one normalized input.
1951 *
1952 * As T has holes, use an auxiliary array of pointers to elements in T.
1953 *
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001954 */
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001955 j = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01001956 for (i = 1; i < T_size; i <<= 1) {
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001957 TT[j++] = T + i;
Gilles Peskine449bd832023-01-11 14:50:10 +01001958 }
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001959
Gilles Peskine449bd832023-01-11 14:50:10 +01001960 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_INV + 6 * j - 2);
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001961
Gilles Peskine449bd832023-01-11 14:50:10 +01001962 MBEDTLS_MPI_CHK(ecp_normalize_jac_many(grp, TT, j));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001963
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001964#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001965 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001966 rs_ctx->rsm->state = ecp_rsm_pre_add;
Gilles Peskine449bd832023-01-11 14:50:10 +01001967 }
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001968
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001969add:
1970#endif
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001971 /*
1972 * Compute the remaining ones using the minimal number of additions
1973 * Be careful to update T[2^l] only after using it!
1974 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001975 MBEDTLS_ECP_BUDGET((T_size - 1) * MBEDTLS_ECP_OPS_ADD);
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001976
Gilles Peskine449bd832023-01-11 14:50:10 +01001977 for (i = 1; i < T_size; i <<= 1) {
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001978 j = i;
Gilles Peskine449bd832023-01-11 14:50:10 +01001979 while (j--) {
1980 MBEDTLS_MPI_CHK(ecp_add_mixed(grp, &T[i + j], &T[j], &T[i], tmp));
1981 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001982 }
1983
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001984#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001985 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001986 rs_ctx->rsm->state = ecp_rsm_pre_norm_add;
Gilles Peskine449bd832023-01-11 14:50:10 +01001987 }
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001988
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001989norm_add:
1990#endif
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001991 /*
Manuel Pégourié-Gonnarda966fde2018-10-23 10:41:11 +02001992 * Normalize final elements in T. Even though there are no holes now, we
1993 * still need the auxiliary array for homogeneity with the previous
1994 * call. Also, skip T[0] which is already normalised, being a copy of P.
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001995 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001996 for (j = 0; j + 1 < T_size; j++) {
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001997 TT[j] = T + j + 1;
Gilles Peskine449bd832023-01-11 14:50:10 +01001998 }
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001999
Gilles Peskine449bd832023-01-11 14:50:10 +01002000 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_INV + 6 * j - 2);
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01002001
Gilles Peskine449bd832023-01-11 14:50:10 +01002002 MBEDTLS_MPI_CHK(ecp_normalize_jac_many(grp, TT, j));
Manuel Pégourié-Gonnarde2820122013-11-21 10:08:50 +01002003
Hanno Beckeree95f6c2022-01-09 05:46:18 +00002004 /* Free Z coordinate (=1 after normalization) to save RAM.
2005 * This makes T[i] invalid as mbedtls_ecp_points, but this is OK
2006 * since from this point onwards, they are only accessed indirectly
2007 * via the getter function ecp_select_comb() which does set the
2008 * target's Z coordinate to 1. */
Gilles Peskine449bd832023-01-11 14:50:10 +01002009 for (i = 0; i < T_size; i++) {
2010 mbedtls_mpi_free(&T[i].Z);
2011 }
Hanno Beckeree95f6c2022-01-09 05:46:18 +00002012
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002013cleanup:
Hanno Beckera7f8edd2022-01-04 07:29:46 +00002014
Gilles Peskine449bd832023-01-11 14:50:10 +01002015 mpi_free_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Beckera7f8edd2022-01-04 07:29:46 +00002016
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002017#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002018 if (rs_ctx != NULL && rs_ctx->rsm != NULL &&
2019 ret == MBEDTLS_ERR_ECP_IN_PROGRESS) {
2020 if (rs_ctx->rsm->state == ecp_rsm_pre_dbl) {
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002021 rs_ctx->rsm->i = j;
Gilles Peskine449bd832023-01-11 14:50:10 +01002022 }
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01002023 }
2024#endif
Janos Follathb0697532016-08-18 12:38:46 +01002025
Gilles Peskine449bd832023-01-11 14:50:10 +01002026 return ret;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002027}
2028
2029/*
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01002030 * Select precomputed point: R = sign(i) * T[ abs(i) / 2 ]
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002031 *
2032 * See ecp_comb_recode_core() for background
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002033 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002034static int ecp_select_comb(const mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2035 const mbedtls_ecp_point T[], unsigned char T_size,
2036 unsigned char i)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002037{
Janos Follath24eed8d2019-11-22 13:21:35 +00002038 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002039 unsigned char ii, j;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002040
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002041 /* Ignore the "sign" bit and scale down */
Gilles Peskine449bd832023-01-11 14:50:10 +01002042 ii = (i & 0x7Fu) >> 1;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002043
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002044 /* Read the whole table to thwart cache-based timing attacks */
Gilles Peskine449bd832023-01-11 14:50:10 +01002045 for (j = 0; j < T_size; j++) {
2046 MPI_ECP_COND_ASSIGN(&R->X, &T[j].X, j == ii);
2047 MPI_ECP_COND_ASSIGN(&R->Y, &T[j].Y, j == ii);
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002048 }
2049
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01002050 /* Safely invert result if i is "negative" */
Gilles Peskine449bd832023-01-11 14:50:10 +01002051 MBEDTLS_MPI_CHK(ecp_safe_invert_jac(grp, R, i >> 7));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002052
Gilles Peskine449bd832023-01-11 14:50:10 +01002053 MPI_ECP_LSET(&R->Z, 1);
Hanno Becker6a288702022-01-05 05:19:48 +00002054
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002055cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002056 return ret;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002057}
2058
2059/*
2060 * Core multiplication algorithm for the (modified) comb method.
2061 * This part is actually common with the basic comb method (GECC 3.44)
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01002062 *
2063 * Cost: d A + d D + 1 R
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002064 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002065static int ecp_mul_comb_core(const mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2066 const mbedtls_ecp_point T[], unsigned char T_size,
2067 const unsigned char x[], size_t d,
2068 int (*f_rng)(void *, unsigned char *, size_t),
2069 void *p_rng,
2070 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002071{
Janos Follath24eed8d2019-11-22 13:21:35 +00002072 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02002073 mbedtls_ecp_point Txi;
Hanno Beckera7f8edd2022-01-04 07:29:46 +00002074 mbedtls_mpi tmp[4];
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002075 size_t i;
2076
Gilles Peskine449bd832023-01-11 14:50:10 +01002077 mbedtls_ecp_point_init(&Txi);
2078 mpi_init_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002079
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002080#if !defined(MBEDTLS_ECP_RESTARTABLE)
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002081 (void) rs_ctx;
2082#endif
2083
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002084#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002085 if (rs_ctx != NULL && rs_ctx->rsm != NULL &&
2086 rs_ctx->rsm->state != ecp_rsm_comb_core) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002087 rs_ctx->rsm->i = 0;
2088 rs_ctx->rsm->state = ecp_rsm_comb_core;
2089 }
2090
2091 /* new 'if' instead of nested for the sake of the 'else' branch */
Gilles Peskine449bd832023-01-11 14:50:10 +01002092 if (rs_ctx != NULL && rs_ctx->rsm != NULL && rs_ctx->rsm->i != 0) {
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002093 /* restore current index (R already pointing to rs_ctx->rsm->R) */
2094 i = rs_ctx->rsm->i;
Gilles Peskine449bd832023-01-11 14:50:10 +01002095 } else
Manuel Pégourié-Gonnardc5d844b2017-03-15 13:06:28 +01002096#endif
2097 {
2098 /* Start with a non-zero point and randomize its coordinates */
2099 i = d;
Gilles Peskine449bd832023-01-11 14:50:10 +01002100 MBEDTLS_MPI_CHK(ecp_select_comb(grp, R, T, T_size, x[i]));
2101 if (f_rng != 0) {
2102 MBEDTLS_MPI_CHK(ecp_randomize_jac(grp, R, f_rng, p_rng));
2103 }
Manuel Pégourié-Gonnardc5d844b2017-03-15 13:06:28 +01002104 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002105
Gilles Peskine449bd832023-01-11 14:50:10 +01002106 while (i != 0) {
2107 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_DBL + MBEDTLS_ECP_OPS_ADD);
Manuel Pégourié-Gonnard90f31b72018-10-16 10:45:24 +02002108 --i;
2109
Gilles Peskine449bd832023-01-11 14:50:10 +01002110 MBEDTLS_MPI_CHK(ecp_double_jac(grp, R, R, tmp));
2111 MBEDTLS_MPI_CHK(ecp_select_comb(grp, &Txi, T, T_size, x[i]));
2112 MBEDTLS_MPI_CHK(ecp_add_mixed(grp, R, R, &Txi, tmp));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002113 }
2114
2115cleanup:
Janos Follathb0697532016-08-18 12:38:46 +01002116
Gilles Peskine449bd832023-01-11 14:50:10 +01002117 mbedtls_ecp_point_free(&Txi);
2118 mpi_free_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Beckera7f8edd2022-01-04 07:29:46 +00002119
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002120#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002121 if (rs_ctx != NULL && rs_ctx->rsm != NULL &&
2122 ret == MBEDTLS_ERR_ECP_IN_PROGRESS) {
Manuel Pégourié-Gonnard90f31b72018-10-16 10:45:24 +02002123 rs_ctx->rsm->i = i;
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002124 /* no need to save R, already pointing to rs_ctx->rsm->R */
Manuel Pégourié-Gonnardc5d844b2017-03-15 13:06:28 +01002125 }
2126#endif
2127
Gilles Peskine449bd832023-01-11 14:50:10 +01002128 return ret;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002129}
2130
2131/*
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002132 * Recode the scalar to get constant-time comb multiplication
2133 *
2134 * As the actual scalar recoding needs an odd scalar as a starting point,
2135 * this wrapper ensures that by replacing m by N - m if necessary, and
2136 * informs the caller that the result of multiplication will be negated.
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002137 *
Manuel Pégourié-Gonnardfd87e352017-08-24 14:21:05 +02002138 * This works because we only support large prime order for Short Weierstrass
2139 * curves, so N is always odd hence either m or N - m is.
2140 *
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002141 * See ecp_comb_recode_core() for background.
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002142 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002143static int ecp_comb_recode_scalar(const mbedtls_ecp_group *grp,
2144 const mbedtls_mpi *m,
2145 unsigned char k[COMB_MAX_D + 1],
2146 size_t d,
2147 unsigned char w,
2148 unsigned char *parity_trick)
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002149{
Janos Follath24eed8d2019-11-22 13:21:35 +00002150 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002151 mbedtls_mpi M, mm;
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002152
Gilles Peskine449bd832023-01-11 14:50:10 +01002153 mbedtls_mpi_init(&M);
2154 mbedtls_mpi_init(&mm);
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002155
Manuel Pégourié-Gonnardfd87e352017-08-24 14:21:05 +02002156 /* N is always odd (see above), just make extra sure */
Gilles Peskine449bd832023-01-11 14:50:10 +01002157 if (mbedtls_mpi_get_bit(&grp->N, 0) != 1) {
2158 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
2159 }
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002160
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002161 /* do we need the parity trick? */
Gilles Peskine449bd832023-01-11 14:50:10 +01002162 *parity_trick = (mbedtls_mpi_get_bit(m, 0) == 0);
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002163
2164 /* execute parity fix in constant time */
Gilles Peskine449bd832023-01-11 14:50:10 +01002165 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&M, m));
2166 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(&mm, &grp->N, m));
2167 MBEDTLS_MPI_CHK(mbedtls_mpi_safe_cond_assign(&M, &mm, *parity_trick));
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002168
2169 /* actual scalar recoding */
Gilles Peskine449bd832023-01-11 14:50:10 +01002170 ecp_comb_recode_core(k, d, w, &M);
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002171
2172cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002173 mbedtls_mpi_free(&mm);
2174 mbedtls_mpi_free(&M);
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002175
Gilles Peskine449bd832023-01-11 14:50:10 +01002176 return ret;
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002177}
2178
2179/*
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002180 * Perform comb multiplication (for short Weierstrass curves)
2181 * once the auxiliary table has been pre-computed.
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002182 *
2183 * Scalar recoding may use a parity trick that makes us compute -m * P,
2184 * if that is the case we'll need to recover m * P at the end.
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002185 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002186static int ecp_mul_comb_after_precomp(const mbedtls_ecp_group *grp,
2187 mbedtls_ecp_point *R,
2188 const mbedtls_mpi *m,
2189 const mbedtls_ecp_point *T,
2190 unsigned char T_size,
2191 unsigned char w,
2192 size_t d,
2193 int (*f_rng)(void *, unsigned char *, size_t),
2194 void *p_rng,
2195 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002196{
Janos Follath24eed8d2019-11-22 13:21:35 +00002197 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002198 unsigned char parity_trick;
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002199 unsigned char k[COMB_MAX_D + 1];
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +01002200 mbedtls_ecp_point *RR = R;
2201
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002202#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002203 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002204 RR = &rs_ctx->rsm->R;
2205
Gilles Peskine449bd832023-01-11 14:50:10 +01002206 if (rs_ctx->rsm->state == ecp_rsm_final_norm) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002207 goto final_norm;
Gilles Peskine449bd832023-01-11 14:50:10 +01002208 }
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002209 }
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +01002210#endif
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002211
Gilles Peskine449bd832023-01-11 14:50:10 +01002212 MBEDTLS_MPI_CHK(ecp_comb_recode_scalar(grp, m, k, d, w,
2213 &parity_trick));
2214 MBEDTLS_MPI_CHK(ecp_mul_comb_core(grp, RR, T, T_size, k, d,
2215 f_rng, p_rng, rs_ctx));
2216 MBEDTLS_MPI_CHK(ecp_safe_invert_jac(grp, RR, parity_trick));
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002217
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002218#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002219 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002220 rs_ctx->rsm->state = ecp_rsm_final_norm;
Gilles Peskine449bd832023-01-11 14:50:10 +01002221 }
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002222
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002223final_norm:
Gilles Peskine449bd832023-01-11 14:50:10 +01002224 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_INV);
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +01002225#endif
Manuel Pégourié-Gonnarda4aa89b2020-03-25 12:41:29 +01002226 /*
2227 * Knowledge of the jacobian coordinates may leak the last few bits of the
2228 * scalar [1], and since our MPI implementation isn't constant-flow,
2229 * inversion (used for coordinate normalization) may leak the full value
2230 * of its input via side-channels [2].
2231 *
2232 * [1] https://eprint.iacr.org/2003/191
2233 * [2] https://eprint.iacr.org/2020/055
2234 *
2235 * Avoid the leak by randomizing coordinates before we normalize them.
2236 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002237 if (f_rng != 0) {
2238 MBEDTLS_MPI_CHK(ecp_randomize_jac(grp, RR, f_rng, p_rng));
2239 }
Manuel Pégourié-Gonnarda4aa89b2020-03-25 12:41:29 +01002240
Gilles Peskine449bd832023-01-11 14:50:10 +01002241 MBEDTLS_MPI_CHK(ecp_normalize_jac(grp, RR));
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +01002242
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002243#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002244 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
2245 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(R, RR));
2246 }
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +01002247#endif
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002248
2249cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002250 return ret;
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002251}
2252
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002253/*
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002254 * Pick window size based on curve size and whether we optimize for base point
2255 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002256static unsigned char ecp_pick_window_size(const mbedtls_ecp_group *grp,
2257 unsigned char p_eq_g)
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002258{
2259 unsigned char w;
2260
2261 /*
2262 * Minimize the number of multiplications, that is minimize
2263 * 10 * d * w + 18 * 2^(w-1) + 11 * d + 7 * w, with d = ceil( nbits / w )
2264 * (see costs of the various parts, with 1S = 1M)
2265 */
2266 w = grp->nbits >= 384 ? 5 : 4;
2267
2268 /*
2269 * If P == G, pre-compute a bit more, since this may be re-used later.
2270 * Just adding one avoids upping the cost of the first mul too much,
2271 * and the memory cost too.
2272 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002273 if (p_eq_g) {
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002274 w++;
Gilles Peskine449bd832023-01-11 14:50:10 +01002275 }
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002276
2277 /*
kXuanba9cb762021-04-08 14:32:06 +08002278 * If static comb table may not be used (!p_eq_g) or static comb table does
2279 * not exists, make sure w is within bounds.
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002280 * (The last test is useful only for very small curves in the test suite.)
kXuanba9cb762021-04-08 14:32:06 +08002281 *
2282 * The user reduces MBEDTLS_ECP_WINDOW_SIZE does not changes the size of
2283 * static comb table, because the size of static comb table is fixed when
2284 * it is generated.
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002285 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002286#if (MBEDTLS_ECP_WINDOW_SIZE < 6)
2287 if ((!p_eq_g || !ecp_group_is_static_comb_table(grp)) && w > MBEDTLS_ECP_WINDOW_SIZE) {
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002288 w = MBEDTLS_ECP_WINDOW_SIZE;
Gilles Peskine449bd832023-01-11 14:50:10 +01002289 }
k-stachowiak653a4a22019-07-03 14:31:09 +02002290#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002291 if (w >= grp->nbits) {
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002292 w = 2;
Gilles Peskine449bd832023-01-11 14:50:10 +01002293 }
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002294
Gilles Peskine449bd832023-01-11 14:50:10 +01002295 return w;
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002296}
2297
2298/*
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002299 * Multiplication using the comb method - for curves in short Weierstrass form
2300 *
2301 * This function is mainly responsible for administrative work:
2302 * - managing the restart context if enabled
Manuel Pégourié-Gonnard11556e22017-08-24 13:41:19 +02002303 * - managing the table of precomputed points (passed between the below two
Shaun Case8b0ecbc2021-12-20 21:14:10 -08002304 * functions): allocation, computation, ownership transfer, freeing.
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002305 *
2306 * It delegates the actual arithmetic work to:
2307 * ecp_precompute_comb() and ecp_mul_comb_with_precomp()
2308 *
2309 * See comments on ecp_comb_recode_core() regarding the computation strategy.
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002310 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002311static int ecp_mul_comb(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2312 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2313 int (*f_rng)(void *, unsigned char *, size_t),
2314 void *p_rng,
2315 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002316{
Janos Follath24eed8d2019-11-22 13:21:35 +00002317 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard11556e22017-08-24 13:41:19 +02002318 unsigned char w, p_eq_g, i;
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002319 size_t d;
Manuel Pégourié-Gonnardf2a9fcf2020-06-03 12:11:56 +02002320 unsigned char T_size = 0, T_ok = 0;
2321 mbedtls_ecp_point *T = NULL;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002322
Gilles Peskine449bd832023-01-11 14:50:10 +01002323 ECP_RS_ENTER(rsm);
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +01002324
Manuel Pégourié-Gonnard22be6352017-03-09 13:02:35 +01002325 /* Is P the base point ? */
2326#if MBEDTLS_ECP_FIXED_POINT_OPTIM == 1
Gilles Peskine449bd832023-01-11 14:50:10 +01002327 p_eq_g = (MPI_ECP_CMP(&P->Y, &grp->G.Y) == 0 &&
2328 MPI_ECP_CMP(&P->X, &grp->G.X) == 0);
Manuel Pégourié-Gonnard196d1332017-08-28 13:14:27 +02002329#else
2330 p_eq_g = 0;
Manuel Pégourié-Gonnard22be6352017-03-09 13:02:35 +01002331#endif
2332
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002333 /* Pick window size and deduce related sizes */
Gilles Peskine449bd832023-01-11 14:50:10 +01002334 w = ecp_pick_window_size(grp, p_eq_g);
2335 T_size = 1U << (w - 1);
2336 d = (grp->nbits + w - 1) / w;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002337
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002338 /* Pre-computed table: do we have it already for the base point? */
Gilles Peskine449bd832023-01-11 14:50:10 +01002339 if (p_eq_g && grp->T != NULL) {
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002340 /* second pointer to the same table, will be deleted on exit */
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002341 T = grp->T;
2342 T_ok = 1;
Gilles Peskine449bd832023-01-11 14:50:10 +01002343 } else
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002344#if defined(MBEDTLS_ECP_RESTARTABLE)
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002345 /* Pre-computed table: do we have one in progress? complete? */
Gilles Peskine449bd832023-01-11 14:50:10 +01002346 if (rs_ctx != NULL && rs_ctx->rsm != NULL && rs_ctx->rsm->T != NULL) {
Manuel Pégourié-Gonnard45fd0162017-03-22 08:24:42 +01002347 /* transfer ownership of T from rsm to local function */
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002348 T = rs_ctx->rsm->T;
2349 rs_ctx->rsm->T = NULL;
2350 rs_ctx->rsm->T_size = 0;
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002351
Manuel Pégourié-Gonnardb25cb602018-10-16 11:48:09 +02002352 /* This effectively jumps to the call to mul_comb_after_precomp() */
Manuel Pégourié-Gonnard11556e22017-08-24 13:41:19 +02002353 T_ok = rs_ctx->rsm->state >= ecp_rsm_comb_core;
Gilles Peskine449bd832023-01-11 14:50:10 +01002354 } else
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +01002355#endif
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002356 /* Allocate table if we didn't have any */
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002357 {
Gilles Peskine449bd832023-01-11 14:50:10 +01002358 T = mbedtls_calloc(T_size, sizeof(mbedtls_ecp_point));
2359 if (T == NULL) {
Manuel Pégourié-Gonnard6a8ca332015-05-28 09:33:39 +02002360 ret = MBEDTLS_ERR_ECP_ALLOC_FAILED;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002361 goto cleanup;
2362 }
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +02002363
Gilles Peskine449bd832023-01-11 14:50:10 +01002364 for (i = 0; i < T_size; i++) {
2365 mbedtls_ecp_point_init(&T[i]);
2366 }
Manuel Pégourié-Gonnard11556e22017-08-24 13:41:19 +02002367
2368 T_ok = 0;
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002369 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002370
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002371 /* Compute table (or finish computing it) if not done already */
Gilles Peskine449bd832023-01-11 14:50:10 +01002372 if (!T_ok) {
2373 MBEDTLS_MPI_CHK(ecp_precompute_comb(grp, T, P, w, d, rs_ctx));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002374
Gilles Peskine449bd832023-01-11 14:50:10 +01002375 if (p_eq_g) {
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002376 /* almost transfer ownership of T to the group, but keep a copy of
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02002377 * the pointer to use for calling the next function more easily */
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002378 grp->T = T;
Manuel Pégourié-Gonnard92cceb22017-08-23 16:27:29 +02002379 grp->T_size = T_size;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002380 }
2381 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002382
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002383 /* Actual comb multiplication using precomputed points */
Gilles Peskine449bd832023-01-11 14:50:10 +01002384 MBEDTLS_MPI_CHK(ecp_mul_comb_after_precomp(grp, R, m,
2385 T, T_size, w, d,
2386 f_rng, p_rng, rs_ctx));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002387
2388cleanup:
2389
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002390 /* does T belong to the group? */
Gilles Peskine449bd832023-01-11 14:50:10 +01002391 if (T == grp->T) {
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002392 T = NULL;
Gilles Peskine449bd832023-01-11 14:50:10 +01002393 }
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002394
2395 /* does T belong to the restart context? */
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002396#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002397 if (rs_ctx != NULL && rs_ctx->rsm != NULL && ret == MBEDTLS_ERR_ECP_IN_PROGRESS && T != NULL) {
Manuel Pégourié-Gonnard45fd0162017-03-22 08:24:42 +01002398 /* transfer ownership of T from local function to rsm */
Manuel Pégourié-Gonnard92cceb22017-08-23 16:27:29 +02002399 rs_ctx->rsm->T_size = T_size;
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002400 rs_ctx->rsm->T = T;
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +01002401 T = NULL;
2402 }
2403#endif
2404
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002405 /* did T belong to us? then let's destroy it! */
Gilles Peskine449bd832023-01-11 14:50:10 +01002406 if (T != NULL) {
2407 for (i = 0; i < T_size; i++) {
2408 mbedtls_ecp_point_free(&T[i]);
2409 }
2410 mbedtls_free(T);
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002411 }
2412
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002413 /* prevent caller from using invalid value */
Gilles Peskine449bd832023-01-11 14:50:10 +01002414 int should_free_R = (ret != 0);
David Horstmannfc735df2022-10-06 19:11:04 +01002415#if defined(MBEDTLS_ECP_RESTARTABLE)
2416 /* don't free R while in progress in case R == P */
Gilles Peskine449bd832023-01-11 14:50:10 +01002417 if (ret == MBEDTLS_ERR_ECP_IN_PROGRESS) {
David Horstmann6e116872022-10-25 10:32:08 +01002418 should_free_R = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01002419 }
David Horstmannfc735df2022-10-06 19:11:04 +01002420#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002421 if (should_free_R) {
2422 mbedtls_ecp_point_free(R);
2423 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002424
Gilles Peskine449bd832023-01-11 14:50:10 +01002425 ECP_RS_LEAVE(rsm);
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +01002426
Gilles Peskine449bd832023-01-11 14:50:10 +01002427 return ret;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002428}
2429
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002430#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01002431
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002432#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01002433/*
2434 * For Montgomery curves, we do all the internal arithmetic in projective
2435 * coordinates. Import/export of points uses only the x coordinates, which is
Shaun Case8b0ecbc2021-12-20 21:14:10 -08002436 * internally represented as X / Z.
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01002437 *
2438 * For scalar multiplication, we'll use a Montgomery ladder.
2439 */
2440
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002441/*
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002442 * Normalize Montgomery x/z coordinates: X = X/Z, Z = 1
2443 * Cost: 1M + 1I
2444 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002445static int ecp_normalize_mxz(const mbedtls_ecp_group *grp, mbedtls_ecp_point *P)
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002446{
Janos Follathb0697532016-08-18 12:38:46 +01002447#if defined(MBEDTLS_ECP_NORMALIZE_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002448 if (mbedtls_internal_ecp_grp_capable(grp)) {
2449 return mbedtls_internal_ecp_normalize_mxz(grp, P);
2450 }
Janos Follath372697b2016-10-28 16:53:11 +01002451#endif /* MBEDTLS_ECP_NORMALIZE_MXZ_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01002452
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002453#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_NORMALIZE_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002454 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002455#else
2456 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01002457 MPI_ECP_INV(&P->Z, &P->Z);
2458 MPI_ECP_MUL(&P->X, &P->X, &P->Z);
2459 MPI_ECP_LSET(&P->Z, 1);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002460
2461cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002462 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002463#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_NORMALIZE_MXZ_ALT) */
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002464}
2465
2466/*
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002467 * Randomize projective x/z coordinates:
2468 * (X, Z) -> (l X, l Z) for random l
2469 * This is sort of the reverse operation of ecp_normalize_mxz().
2470 *
2471 * This countermeasure was first suggested in [2].
2472 * Cost: 2M
2473 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002474static int ecp_randomize_mxz(const mbedtls_ecp_group *grp, mbedtls_ecp_point *P,
2475 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002476{
Janos Follathb0697532016-08-18 12:38:46 +01002477#if defined(MBEDTLS_ECP_RANDOMIZE_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002478 if (mbedtls_internal_ecp_grp_capable(grp)) {
2479 return mbedtls_internal_ecp_randomize_mxz(grp, P, f_rng, p_rng);
2480 }
Janos Follath372697b2016-10-28 16:53:11 +01002481#endif /* MBEDTLS_ECP_RANDOMIZE_MXZ_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01002482
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002483#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_RANDOMIZE_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002484 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002485#else
2486 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
2487 mbedtls_mpi l;
Gilles Peskine449bd832023-01-11 14:50:10 +01002488 mbedtls_mpi_init(&l);
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002489
2490 /* Generate l such that 1 < l < p */
Gilles Peskine449bd832023-01-11 14:50:10 +01002491 MPI_ECP_RAND(&l);
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002492
Gilles Peskine449bd832023-01-11 14:50:10 +01002493 MPI_ECP_MUL(&P->X, &P->X, &l);
2494 MPI_ECP_MUL(&P->Z, &P->Z, &l);
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002495
2496cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002497 mbedtls_mpi_free(&l);
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002498
Gilles Peskine449bd832023-01-11 14:50:10 +01002499 if (ret == MBEDTLS_ERR_MPI_NOT_ACCEPTABLE) {
Gilles Peskine59215172021-03-29 22:28:50 +02002500 ret = MBEDTLS_ERR_ECP_RANDOM_FAILED;
Gilles Peskine449bd832023-01-11 14:50:10 +01002501 }
2502 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002503#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_RANDOMIZE_MXZ_ALT) */
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002504}
2505
2506/*
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002507 * Double-and-add: R = 2P, S = P + Q, with d = X(P - Q),
2508 * for Montgomery curves in x/z coordinates.
2509 *
2510 * http://www.hyperelliptic.org/EFD/g1p/auto-code/montgom/xz/ladder/mladd-1987-m.op3
2511 * with
2512 * d = X1
2513 * P = (X2, Z2)
2514 * Q = (X3, Z3)
2515 * R = (X4, Z4)
2516 * S = (X5, Z5)
2517 * and eliminating temporary variables tO, ..., t4.
2518 *
2519 * Cost: 5M + 4S
2520 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002521static int ecp_double_add_mxz(const mbedtls_ecp_group *grp,
2522 mbedtls_ecp_point *R, mbedtls_ecp_point *S,
2523 const mbedtls_ecp_point *P, const mbedtls_ecp_point *Q,
2524 const mbedtls_mpi *d,
2525 mbedtls_mpi T[4])
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002526{
Janos Follathb0697532016-08-18 12:38:46 +01002527#if defined(MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002528 if (mbedtls_internal_ecp_grp_capable(grp)) {
2529 return mbedtls_internal_ecp_double_add_mxz(grp, R, S, P, Q, d);
2530 }
Janos Follath372697b2016-10-28 16:53:11 +01002531#endif /* MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01002532
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002533#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002534 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002535#else
2536 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002537
Gilles Peskine449bd832023-01-11 14:50:10 +01002538 MPI_ECP_ADD(&T[0], &P->X, &P->Z); /* Pp := PX + PZ */
2539 MPI_ECP_SUB(&T[1], &P->X, &P->Z); /* Pm := PX - PZ */
2540 MPI_ECP_ADD(&T[2], &Q->X, &Q->Z); /* Qp := QX + XZ */
2541 MPI_ECP_SUB(&T[3], &Q->X, &Q->Z); /* Qm := QX - QZ */
2542 MPI_ECP_MUL(&T[3], &T[3], &T[0]); /* Qm * Pp */
2543 MPI_ECP_MUL(&T[2], &T[2], &T[1]); /* Qp * Pm */
2544 MPI_ECP_SQR(&T[0], &T[0]); /* Pp^2 */
2545 MPI_ECP_SQR(&T[1], &T[1]); /* Pm^2 */
2546 MPI_ECP_MUL(&R->X, &T[0], &T[1]); /* Pp^2 * Pm^2 */
2547 MPI_ECP_SUB(&T[0], &T[0], &T[1]); /* Pp^2 - Pm^2 */
2548 MPI_ECP_MUL(&R->Z, &grp->A, &T[0]); /* A * (Pp^2 - Pm^2) */
2549 MPI_ECP_ADD(&R->Z, &T[1], &R->Z); /* [ A * (Pp^2-Pm^2) ] + Pm^2 */
2550 MPI_ECP_ADD(&S->X, &T[3], &T[2]); /* Qm*Pp + Qp*Pm */
2551 MPI_ECP_SQR(&S->X, &S->X); /* (Qm*Pp + Qp*Pm)^2 */
2552 MPI_ECP_SUB(&S->Z, &T[3], &T[2]); /* Qm*Pp - Qp*Pm */
2553 MPI_ECP_SQR(&S->Z, &S->Z); /* (Qm*Pp - Qp*Pm)^2 */
2554 MPI_ECP_MUL(&S->Z, d, &S->Z); /* d * ( Qm*Pp - Qp*Pm )^2 */
2555 MPI_ECP_MUL(&R->Z, &T[0], &R->Z); /* [A*(Pp^2-Pm^2)+Pm^2]*(Pp^2-Pm^2) */
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002556
2557cleanup:
Hanno Becker28ccb1c2022-01-04 07:15:04 +00002558
Gilles Peskine449bd832023-01-11 14:50:10 +01002559 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002560#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT) */
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002561}
2562
2563/*
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002564 * Multiplication with Montgomery ladder in x/z coordinates,
2565 * for curves in Montgomery form
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002566 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002567static int ecp_mul_mxz(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2568 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2569 int (*f_rng)(void *, unsigned char *, size_t),
2570 void *p_rng)
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002571{
Janos Follath24eed8d2019-11-22 13:21:35 +00002572 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002573 size_t i;
Manuel Pégourié-Gonnardb6f45a62013-12-04 21:54:36 +01002574 unsigned char b;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02002575 mbedtls_ecp_point RP;
2576 mbedtls_mpi PX;
Hanno Becker30838862022-01-04 13:25:59 +00002577 mbedtls_mpi tmp[4];
Gilles Peskine449bd832023-01-11 14:50:10 +01002578 mbedtls_ecp_point_init(&RP); mbedtls_mpi_init(&PX);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002579
Gilles Peskine449bd832023-01-11 14:50:10 +01002580 mpi_init_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Becker30838862022-01-04 13:25:59 +00002581
Gilles Peskine449bd832023-01-11 14:50:10 +01002582 if (f_rng == NULL) {
2583 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
2584 }
Manuel Pégourié-Gonnard02b57052021-06-15 11:29:26 +02002585
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002586 /* Save PX and read from P before writing to R, in case P == R */
Gilles Peskine449bd832023-01-11 14:50:10 +01002587 MPI_ECP_MOV(&PX, &P->X);
2588 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(&RP, P));
Manuel Pégourié-Gonnard357ff652013-12-04 18:39:17 +01002589
2590 /* Set R to zero in modified x/z coordinates */
Gilles Peskine449bd832023-01-11 14:50:10 +01002591 MPI_ECP_LSET(&R->X, 1);
2592 MPI_ECP_LSET(&R->Z, 0);
2593 mbedtls_mpi_free(&R->Y);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002594
Shaun Case8b0ecbc2021-12-20 21:14:10 -08002595 /* RP.X might be slightly larger than P, so reduce it */
Gilles Peskine449bd832023-01-11 14:50:10 +01002596 MOD_ADD(&RP.X);
Manuel Pégourié-Gonnard93f41db2013-12-05 10:48:42 +01002597
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002598 /* Randomize coordinates of the starting point */
Gilles Peskine449bd832023-01-11 14:50:10 +01002599 MBEDTLS_MPI_CHK(ecp_randomize_mxz(grp, &RP, f_rng, p_rng));
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002600
Manuel Pégourié-Gonnardb6f45a62013-12-04 21:54:36 +01002601 /* Loop invariant: R = result so far, RP = R + P */
Aurelien Jarnoc79ce882022-05-15 13:24:05 +02002602 i = grp->nbits + 1; /* one past the (zero-based) required msb for private keys */
Gilles Peskine449bd832023-01-11 14:50:10 +01002603 while (i-- > 0) {
2604 b = mbedtls_mpi_get_bit(m, i);
Manuel Pégourié-Gonnardb6f45a62013-12-04 21:54:36 +01002605 /*
2606 * if (b) R = 2R + P else R = 2R,
2607 * which is:
2608 * if (b) double_add( RP, R, RP, R )
2609 * else double_add( R, RP, R, RP )
2610 * but using safe conditional swaps to avoid leaks
2611 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002612 MPI_ECP_COND_SWAP(&R->X, &RP.X, b);
2613 MPI_ECP_COND_SWAP(&R->Z, &RP.Z, b);
2614 MBEDTLS_MPI_CHK(ecp_double_add_mxz(grp, R, &RP, R, &RP, &PX, tmp));
2615 MPI_ECP_COND_SWAP(&R->X, &RP.X, b);
2616 MPI_ECP_COND_SWAP(&R->Z, &RP.Z, b);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002617 }
2618
Manuel Pégourié-Gonnarda4aa89b2020-03-25 12:41:29 +01002619 /*
2620 * Knowledge of the projective coordinates may leak the last few bits of the
2621 * scalar [1], and since our MPI implementation isn't constant-flow,
2622 * inversion (used for coordinate normalization) may leak the full value
2623 * of its input via side-channels [2].
2624 *
2625 * [1] https://eprint.iacr.org/2003/191
2626 * [2] https://eprint.iacr.org/2020/055
2627 *
2628 * Avoid the leak by randomizing coordinates before we normalize them.
2629 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002630 MBEDTLS_MPI_CHK(ecp_randomize_mxz(grp, R, f_rng, p_rng));
2631 MBEDTLS_MPI_CHK(ecp_normalize_mxz(grp, R));
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002632
2633cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002634 mbedtls_ecp_point_free(&RP); mbedtls_mpi_free(&PX);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002635
Gilles Peskine449bd832023-01-11 14:50:10 +01002636 mpi_free_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
2637 return ret;
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002638}
2639
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002640#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01002641
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002642/*
Manuel Pégourié-Gonnard884569c2017-04-20 10:10:59 +02002643 * Restartable multiplication R = m * P
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002644 *
2645 * This internal function can be called without an RNG in case where we know
2646 * the inputs are not sensitive.
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002647 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002648static int ecp_mul_restartable_internal(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2649 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2650 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng,
2651 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002652{
Janos Follathb0697532016-08-18 12:38:46 +01002653 int ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Janos Follathc44ab972016-11-18 16:38:23 +00002654#if defined(MBEDTLS_ECP_INTERNAL_ALT)
2655 char is_grp_capable = 0;
2656#endif
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02002657
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002658#if defined(MBEDTLS_ECP_RESTARTABLE)
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002659 /* reset ops count for this call if top-level */
Gilles Peskine449bd832023-01-11 14:50:10 +01002660 if (rs_ctx != NULL && rs_ctx->depth++ == 0) {
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002661 rs_ctx->ops_done = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01002662 }
Gilles Peskine59970052019-02-28 13:12:06 +01002663#else
2664 (void) rs_ctx;
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002665#endif
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002666
Janos Follathc44ab972016-11-18 16:38:23 +00002667#if defined(MBEDTLS_ECP_INTERNAL_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002668 if ((is_grp_capable = mbedtls_internal_ecp_grp_capable(grp))) {
2669 MBEDTLS_MPI_CHK(mbedtls_internal_ecp_init(grp));
2670 }
Janos Follathc44ab972016-11-18 16:38:23 +00002671#endif /* MBEDTLS_ECP_INTERNAL_ALT */
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002672
David Horstmannfc735df2022-10-06 19:11:04 +01002673 int restarting = 0;
Manuel Pégourié-Gonnard95aedfe2017-08-24 13:47:04 +02002674#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002675 restarting = (rs_ctx != NULL && rs_ctx->rsm != NULL);
Manuel Pégourié-Gonnarda08cd1a2017-04-20 11:29:43 +02002676#endif
David Horstmannfc735df2022-10-06 19:11:04 +01002677 /* skip argument check when restarting */
Gilles Peskine449bd832023-01-11 14:50:10 +01002678 if (!restarting) {
Manuel Pégourié-Gonnard5314f232017-04-21 12:36:59 +02002679 /* check_privkey is free */
Gilles Peskine449bd832023-01-11 14:50:10 +01002680 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_CHK);
Manuel Pégourié-Gonnard5314f232017-04-21 12:36:59 +02002681
Manuel Pégourié-Gonnarda08cd1a2017-04-20 11:29:43 +02002682 /* Common sanity checks */
Gilles Peskine449bd832023-01-11 14:50:10 +01002683 MBEDTLS_MPI_CHK(mbedtls_ecp_check_privkey(grp, m));
2684 MBEDTLS_MPI_CHK(mbedtls_ecp_check_pubkey(grp, P));
Manuel Pégourié-Gonnarda08cd1a2017-04-20 11:29:43 +02002685 }
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002686
2687 ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002688#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01002689 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
2690 MBEDTLS_MPI_CHK(ecp_mul_mxz(grp, R, m, P, f_rng, p_rng));
2691 }
Janos Follath430d3372016-11-03 14:25:37 +00002692#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002693#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01002694 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
2695 MBEDTLS_MPI_CHK(ecp_mul_comb(grp, R, m, P, f_rng, p_rng, rs_ctx));
2696 }
Janos Follath430d3372016-11-03 14:25:37 +00002697#endif
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002698
Janos Follath6c8ccd52016-11-29 15:37:09 +00002699cleanup:
Janos Follathb0697532016-08-18 12:38:46 +01002700
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002701#if defined(MBEDTLS_ECP_INTERNAL_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002702 if (is_grp_capable) {
2703 mbedtls_internal_ecp_free(grp);
2704 }
Janos Follathc44ab972016-11-18 16:38:23 +00002705#endif /* MBEDTLS_ECP_INTERNAL_ALT */
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002706
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002707#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002708 if (rs_ctx != NULL) {
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002709 rs_ctx->depth--;
Gilles Peskine449bd832023-01-11 14:50:10 +01002710 }
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002711#endif
2712
Gilles Peskine449bd832023-01-11 14:50:10 +01002713 return ret;
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002714}
2715
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002716/*
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002717 * Restartable multiplication R = m * P
2718 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002719int mbedtls_ecp_mul_restartable(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2720 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2721 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng,
2722 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002723{
Gilles Peskine449bd832023-01-11 14:50:10 +01002724 if (f_rng == NULL) {
2725 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
2726 }
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002727
Gilles Peskine449bd832023-01-11 14:50:10 +01002728 return ecp_mul_restartable_internal(grp, R, m, P, f_rng, p_rng, rs_ctx);
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002729}
2730
2731/*
Manuel Pégourié-Gonnard884569c2017-04-20 10:10:59 +02002732 * Multiplication R = m * P
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002733 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002734int mbedtls_ecp_mul(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2735 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2736 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002737{
Gilles Peskine449bd832023-01-11 14:50:10 +01002738 return mbedtls_ecp_mul_restartable(grp, R, m, P, f_rng, p_rng, NULL);
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002739}
Valerio Settifd122f42023-04-05 18:15:32 +02002740#endif /* MBEDTLS_ECP_C */
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002741
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002742#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002743/*
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01002744 * Check that an affine point is valid as a public key,
2745 * short weierstrass curves (SEC1 3.2.3.1)
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002746 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002747static int ecp_check_pubkey_sw(const mbedtls_ecp_group *grp, const mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002748{
Janos Follath24eed8d2019-11-22 13:21:35 +00002749 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02002750 mbedtls_mpi YY, RHS;
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002751
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +01002752 /* pt coordinates must be normalized for our checks */
Gilles Peskine449bd832023-01-11 14:50:10 +01002753 if (mbedtls_mpi_cmp_int(&pt->X, 0) < 0 ||
2754 mbedtls_mpi_cmp_int(&pt->Y, 0) < 0 ||
2755 mbedtls_mpi_cmp_mpi(&pt->X, &grp->P) >= 0 ||
2756 mbedtls_mpi_cmp_mpi(&pt->Y, &grp->P) >= 0) {
2757 return MBEDTLS_ERR_ECP_INVALID_KEY;
2758 }
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002759
Gilles Peskine449bd832023-01-11 14:50:10 +01002760 mbedtls_mpi_init(&YY); mbedtls_mpi_init(&RHS);
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002761
2762 /*
2763 * YY = Y^2
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01002764 * RHS = X^3 + A X + B
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002765 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002766 MPI_ECP_SQR(&YY, &pt->Y);
2767 MBEDTLS_MPI_CHK(ecp_sw_rhs(grp, &RHS, &pt->X));
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002768
Gilles Peskine449bd832023-01-11 14:50:10 +01002769 if (MPI_ECP_CMP(&YY, &RHS) != 0) {
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02002770 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
Gilles Peskine449bd832023-01-11 14:50:10 +01002771 }
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002772
2773cleanup:
2774
Gilles Peskine449bd832023-01-11 14:50:10 +01002775 mbedtls_mpi_free(&YY); mbedtls_mpi_free(&RHS);
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002776
Gilles Peskine449bd832023-01-11 14:50:10 +01002777 return ret;
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002778}
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002779#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01002780
Valerio Settifd122f42023-04-05 18:15:32 +02002781#if defined(MBEDTLS_ECP_C)
Gilles Peskine9b99a892018-09-14 18:32:19 +02002782#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002783/*
TRodziewicz9edff742021-03-04 17:59:39 +01002784 * R = m * P with shortcuts for m == 0, m == 1 and m == -1
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002785 * NOT constant-time - ONLY for short Weierstrass!
2786 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002787static int mbedtls_ecp_mul_shortcuts(mbedtls_ecp_group *grp,
2788 mbedtls_ecp_point *R,
2789 const mbedtls_mpi *m,
2790 const mbedtls_ecp_point *P,
2791 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002792{
Janos Follath24eed8d2019-11-22 13:21:35 +00002793 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Beckerc27a0e02022-01-06 05:56:34 +00002794 mbedtls_mpi tmp;
Gilles Peskine449bd832023-01-11 14:50:10 +01002795 mbedtls_mpi_init(&tmp);
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002796
Gilles Peskine449bd832023-01-11 14:50:10 +01002797 if (mbedtls_mpi_cmp_int(m, 0) == 0) {
2798 MBEDTLS_MPI_CHK(mbedtls_ecp_check_pubkey(grp, P));
2799 MBEDTLS_MPI_CHK(mbedtls_ecp_set_zero(R));
2800 } else if (mbedtls_mpi_cmp_int(m, 1) == 0) {
2801 MBEDTLS_MPI_CHK(mbedtls_ecp_check_pubkey(grp, P));
2802 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(R, P));
2803 } else if (mbedtls_mpi_cmp_int(m, -1) == 0) {
2804 MBEDTLS_MPI_CHK(mbedtls_ecp_check_pubkey(grp, P));
2805 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(R, P));
2806 MPI_ECP_NEG(&R->Y);
2807 } else {
2808 MBEDTLS_MPI_CHK(ecp_mul_restartable_internal(grp, R, m, P,
2809 NULL, NULL, rs_ctx));
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002810 }
2811
2812cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002813 mbedtls_mpi_free(&tmp);
Hanno Beckerc27a0e02022-01-06 05:56:34 +00002814
Gilles Peskine449bd832023-01-11 14:50:10 +01002815 return ret;
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002816}
2817
2818/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002819 * Restartable linear combination
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002820 * NOT constant-time
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002821 */
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002822int mbedtls_ecp_muladd_restartable(
Gilles Peskine449bd832023-01-11 14:50:10 +01002823 mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2824 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2825 const mbedtls_mpi *n, const mbedtls_ecp_point *Q,
2826 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002827{
Janos Follath24eed8d2019-11-22 13:21:35 +00002828 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002829 mbedtls_ecp_point mP;
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002830 mbedtls_ecp_point *pmP = &mP;
2831 mbedtls_ecp_point *pR = R;
Hanno Becker3b29f212022-01-04 07:34:14 +00002832 mbedtls_mpi tmp[4];
Janos Follathc44ab972016-11-18 16:38:23 +00002833#if defined(MBEDTLS_ECP_INTERNAL_ALT)
2834 char is_grp_capable = 0;
2835#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002836 if (mbedtls_ecp_get_type(grp) != MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
2837 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
2838 }
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002839
Gilles Peskine449bd832023-01-11 14:50:10 +01002840 mbedtls_ecp_point_init(&mP);
2841 mpi_init_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Becker3b29f212022-01-04 07:34:14 +00002842
Gilles Peskine449bd832023-01-11 14:50:10 +01002843 ECP_RS_ENTER(ma);
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +02002844
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002845#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002846 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002847 /* redirect intermediate results to restart context */
2848 pmP = &rs_ctx->ma->mP;
2849 pR = &rs_ctx->ma->R;
2850
2851 /* jump to next operation */
Gilles Peskine449bd832023-01-11 14:50:10 +01002852 if (rs_ctx->ma->state == ecp_rsma_mul2) {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002853 goto mul2;
Gilles Peskine449bd832023-01-11 14:50:10 +01002854 }
2855 if (rs_ctx->ma->state == ecp_rsma_add) {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002856 goto add;
Gilles Peskine449bd832023-01-11 14:50:10 +01002857 }
2858 if (rs_ctx->ma->state == ecp_rsma_norm) {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002859 goto norm;
Gilles Peskine449bd832023-01-11 14:50:10 +01002860 }
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002861 }
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002862#endif /* MBEDTLS_ECP_RESTARTABLE */
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002863
Gilles Peskine449bd832023-01-11 14:50:10 +01002864 MBEDTLS_MPI_CHK(mbedtls_ecp_mul_shortcuts(grp, pmP, m, P, rs_ctx));
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002865#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002866 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
Manuel Pégourié-Gonnardc9efa002017-08-24 10:25:06 +02002867 rs_ctx->ma->state = ecp_rsma_mul2;
Gilles Peskine449bd832023-01-11 14:50:10 +01002868 }
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002869
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002870mul2:
2871#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002872 MBEDTLS_MPI_CHK(mbedtls_ecp_mul_shortcuts(grp, pR, n, Q, rs_ctx));
Andrzej Kurekc470b6b2019-01-31 08:20:20 -05002873
2874#if defined(MBEDTLS_ECP_INTERNAL_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002875 if ((is_grp_capable = mbedtls_internal_ecp_grp_capable(grp))) {
2876 MBEDTLS_MPI_CHK(mbedtls_internal_ecp_init(grp));
2877 }
Andrzej Kurekc470b6b2019-01-31 08:20:20 -05002878#endif /* MBEDTLS_ECP_INTERNAL_ALT */
2879
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002880#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002881 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
Manuel Pégourié-Gonnardc9efa002017-08-24 10:25:06 +02002882 rs_ctx->ma->state = ecp_rsma_add;
Gilles Peskine449bd832023-01-11 14:50:10 +01002883 }
Manuel Pégourié-Gonnard1a7c5ef2015-08-13 10:19:09 +02002884
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002885add:
2886#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002887 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_ADD);
2888 MBEDTLS_MPI_CHK(ecp_add_mixed(grp, pR, pmP, pR, tmp));
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002889#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002890 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
Manuel Pégourié-Gonnardc9efa002017-08-24 10:25:06 +02002891 rs_ctx->ma->state = ecp_rsma_norm;
Gilles Peskine449bd832023-01-11 14:50:10 +01002892 }
Janos Follath430d3372016-11-03 14:25:37 +00002893
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002894norm:
2895#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002896 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_INV);
2897 MBEDTLS_MPI_CHK(ecp_normalize_jac(grp, pR));
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002898
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002899#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002900 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
2901 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(R, pR));
2902 }
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002903#endif
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002904
2905cleanup:
Hanno Becker3b29f212022-01-04 07:34:14 +00002906
Gilles Peskine449bd832023-01-11 14:50:10 +01002907 mpi_free_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Becker3b29f212022-01-04 07:34:14 +00002908
Janos Follathc44ab972016-11-18 16:38:23 +00002909#if defined(MBEDTLS_ECP_INTERNAL_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002910 if (is_grp_capable) {
2911 mbedtls_internal_ecp_free(grp);
2912 }
Janos Follathc44ab972016-11-18 16:38:23 +00002913#endif /* MBEDTLS_ECP_INTERNAL_ALT */
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002914
Gilles Peskine449bd832023-01-11 14:50:10 +01002915 mbedtls_ecp_point_free(&mP);
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002916
Gilles Peskine449bd832023-01-11 14:50:10 +01002917 ECP_RS_LEAVE(ma);
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002918
Gilles Peskine449bd832023-01-11 14:50:10 +01002919 return ret;
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002920}
2921
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002922/*
2923 * Linear combination
2924 * NOT constant-time
2925 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002926int mbedtls_ecp_muladd(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2927 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2928 const mbedtls_mpi *n, const mbedtls_ecp_point *Q)
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002929{
Gilles Peskine449bd832023-01-11 14:50:10 +01002930 return mbedtls_ecp_muladd_restartable(grp, R, m, P, n, Q, NULL);
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002931}
Gilles Peskine9b99a892018-09-14 18:32:19 +02002932#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Valerio Settifd122f42023-04-05 18:15:32 +02002933#endif /* MBEDTLS_ECP_C */
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01002934
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002935#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002936#if defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Dave Rodgmanb8f18852023-07-18 12:45:17 +01002937#define ECP_MPI_INIT(_p, _n) { .p = (mbedtls_mpi_uint *) (_p), .s = 1, .n = (_n) }
Manuel Pégourié-Gonnard06215ea2021-06-23 12:53:18 +02002938#define ECP_MPI_INIT_ARRAY(x) \
Dave Rodgmanb8f18852023-07-18 12:45:17 +01002939 ECP_MPI_INIT(x, sizeof(x) / sizeof(mbedtls_mpi_uint))
Manuel Pégourié-Gonnard06215ea2021-06-23 12:53:18 +02002940/*
2941 * Constants for the two points other than 0, 1, -1 (mod p) in
2942 * https://cr.yp.to/ecdh.html#validate
2943 * See ecp_check_pubkey_x25519().
2944 */
2945static const mbedtls_mpi_uint x25519_bad_point_1[] = {
Gilles Peskine449bd832023-01-11 14:50:10 +01002946 MBEDTLS_BYTES_TO_T_UINT_8(0xe0, 0xeb, 0x7a, 0x7c, 0x3b, 0x41, 0xb8, 0xae),
2947 MBEDTLS_BYTES_TO_T_UINT_8(0x16, 0x56, 0xe3, 0xfa, 0xf1, 0x9f, 0xc4, 0x6a),
2948 MBEDTLS_BYTES_TO_T_UINT_8(0xda, 0x09, 0x8d, 0xeb, 0x9c, 0x32, 0xb1, 0xfd),
2949 MBEDTLS_BYTES_TO_T_UINT_8(0x86, 0x62, 0x05, 0x16, 0x5f, 0x49, 0xb8, 0x00),
Manuel Pégourié-Gonnard06215ea2021-06-23 12:53:18 +02002950};
2951static const mbedtls_mpi_uint x25519_bad_point_2[] = {
Gilles Peskine449bd832023-01-11 14:50:10 +01002952 MBEDTLS_BYTES_TO_T_UINT_8(0x5f, 0x9c, 0x95, 0xbc, 0xa3, 0x50, 0x8c, 0x24),
2953 MBEDTLS_BYTES_TO_T_UINT_8(0xb1, 0xd0, 0xb1, 0x55, 0x9c, 0x83, 0xef, 0x5b),
2954 MBEDTLS_BYTES_TO_T_UINT_8(0x04, 0x44, 0x5c, 0xc4, 0x58, 0x1c, 0x8e, 0x86),
2955 MBEDTLS_BYTES_TO_T_UINT_8(0xd8, 0x22, 0x4e, 0xdd, 0xd0, 0x9f, 0x11, 0x57),
Manuel Pégourié-Gonnard06215ea2021-06-23 12:53:18 +02002956};
2957static const mbedtls_mpi ecp_x25519_bad_point_1 = ECP_MPI_INIT_ARRAY(
Gilles Peskine449bd832023-01-11 14:50:10 +01002958 x25519_bad_point_1);
Manuel Pégourié-Gonnard06215ea2021-06-23 12:53:18 +02002959static const mbedtls_mpi ecp_x25519_bad_point_2 = ECP_MPI_INIT_ARRAY(
Gilles Peskine449bd832023-01-11 14:50:10 +01002960 x25519_bad_point_2);
Janos Follath865a75e2021-06-24 15:34:59 +01002961#endif /* MBEDTLS_ECP_DP_CURVE25519_ENABLED */
Manuel Pégourié-Gonnard2389a602021-06-23 12:25:48 +02002962
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002963/*
2964 * Check that the input point is not one of the low-order points.
2965 * This is recommended by the "May the Fourth" paper:
2966 * https://eprint.iacr.org/2017/806.pdf
2967 * Those points are never sent by an honest peer.
2968 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002969static int ecp_check_bad_points_mx(const mbedtls_mpi *X, const mbedtls_mpi *P,
2970 const mbedtls_ecp_group_id grp_id)
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002971{
2972 int ret;
Manuel Pégourié-Gonnard2389a602021-06-23 12:25:48 +02002973 mbedtls_mpi XmP;
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002974
Gilles Peskine449bd832023-01-11 14:50:10 +01002975 mbedtls_mpi_init(&XmP);
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002976
2977 /* Reduce X mod P so that we only need to check values less than P.
2978 * We know X < 2^256 so we can proceed by subtraction. */
Gilles Peskine449bd832023-01-11 14:50:10 +01002979 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&XmP, X));
2980 while (mbedtls_mpi_cmp_mpi(&XmP, P) >= 0) {
2981 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(&XmP, &XmP, P));
2982 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002983
Janos Follath865a75e2021-06-24 15:34:59 +01002984 /* Check against the known bad values that are less than P. For Curve448
2985 * these are 0, 1 and -1. For Curve25519 we check the values less than P
2986 * from the following list: https://cr.yp.to/ecdh.html#validate */
Gilles Peskine449bd832023-01-11 14:50:10 +01002987 if (mbedtls_mpi_cmp_int(&XmP, 1) <= 0) { /* takes care of 0 and 1 */
Janos Follath8081ced2021-06-24 14:24:13 +01002988 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
2989 goto cleanup;
2990 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002991
Janos Follath865a75e2021-06-24 15:34:59 +01002992#if defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01002993 if (grp_id == MBEDTLS_ECP_DP_CURVE25519) {
2994 if (mbedtls_mpi_cmp_mpi(&XmP, &ecp_x25519_bad_point_1) == 0) {
Janos Follath865a75e2021-06-24 15:34:59 +01002995 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
2996 goto cleanup;
2997 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002998
Gilles Peskine449bd832023-01-11 14:50:10 +01002999 if (mbedtls_mpi_cmp_mpi(&XmP, &ecp_x25519_bad_point_2) == 0) {
Janos Follath865a75e2021-06-24 15:34:59 +01003000 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
3001 goto cleanup;
3002 }
Janos Follath8081ced2021-06-24 14:24:13 +01003003 }
Janos Follath83e384d2021-06-25 15:29:56 +01003004#else
3005 (void) grp_id;
Janos Follath865a75e2021-06-24 15:34:59 +01003006#endif
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003007
Manuel Pégourié-Gonnard2389a602021-06-23 12:25:48 +02003008 /* Final check: check if XmP + 1 is P (final because it changes XmP!) */
Gilles Peskine449bd832023-01-11 14:50:10 +01003009 MBEDTLS_MPI_CHK(mbedtls_mpi_add_int(&XmP, &XmP, 1));
3010 if (mbedtls_mpi_cmp_mpi(&XmP, P) == 0) {
Janos Follath8081ced2021-06-24 14:24:13 +01003011 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
3012 goto cleanup;
3013 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003014
3015 ret = 0;
3016
3017cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003018 mbedtls_mpi_free(&XmP);
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003019
Gilles Peskine449bd832023-01-11 14:50:10 +01003020 return ret;
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003021}
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003022
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003023/*
3024 * Check validity of a public key for Montgomery curves with x-only schemes
3025 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003026static int ecp_check_pubkey_mx(const mbedtls_ecp_group *grp, const mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003027{
Manuel Pégourié-Gonnard07894332015-06-23 00:18:41 +02003028 /* [Curve25519 p. 5] Just check X is the correct number of bytes */
Nicholas Wilson08f3ef12015-11-10 13:10:01 +00003029 /* Allow any public value, if it's too big then we'll just reduce it mod p
3030 * (RFC 7748 sec. 5 para. 3). */
Gilles Peskine449bd832023-01-11 14:50:10 +01003031 if (mbedtls_mpi_size(&pt->X) > (grp->nbits + 7) / 8) {
3032 return MBEDTLS_ERR_ECP_INVALID_KEY;
3033 }
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003034
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003035 /* Implicit in all standards (as they don't consider negative numbers):
3036 * X must be non-negative. This is normally ensured by the way it's
3037 * encoded for transmission, but let's be extra sure. */
Gilles Peskine449bd832023-01-11 14:50:10 +01003038 if (mbedtls_mpi_cmp_int(&pt->X, 0) < 0) {
3039 return MBEDTLS_ERR_ECP_INVALID_KEY;
3040 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003041
Gilles Peskine449bd832023-01-11 14:50:10 +01003042 return ecp_check_bad_points_mx(&pt->X, &grp->P, grp->id);
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003043}
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003044#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003045
3046/*
3047 * Check that a point is valid as a public key
3048 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003049int mbedtls_ecp_check_pubkey(const mbedtls_ecp_group *grp,
3050 const mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003051{
3052 /* Must use affine coordinates */
Gilles Peskine449bd832023-01-11 14:50:10 +01003053 if (mbedtls_mpi_cmp_int(&pt->Z, 1) != 0) {
3054 return MBEDTLS_ERR_ECP_INVALID_KEY;
3055 }
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003056
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003057#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003058 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
3059 return ecp_check_pubkey_mx(grp, pt);
3060 }
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003061#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003062#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003063 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
3064 return ecp_check_pubkey_sw(grp, pt);
3065 }
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003066#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01003067 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003068}
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003069
3070/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003071 * Check that an mbedtls_mpi is valid as a private key
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003072 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003073int mbedtls_ecp_check_privkey(const mbedtls_ecp_group *grp,
3074 const mbedtls_mpi *d)
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003075{
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003076#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003077 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
Nicholas Wilson08f3ef12015-11-10 13:10:01 +00003078 /* see RFC 7748 sec. 5 para. 5 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003079 if (mbedtls_mpi_get_bit(d, 0) != 0 ||
3080 mbedtls_mpi_get_bit(d, 1) != 0 ||
3081 mbedtls_mpi_bitlen(d) - 1 != grp->nbits) { /* mbedtls_mpi_bitlen is one-based! */
3082 return MBEDTLS_ERR_ECP_INVALID_KEY;
3083 }
Nicholas Wilson08f3ef12015-11-10 13:10:01 +00003084
3085 /* see [Curve25519] page 5 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003086 if (grp->nbits == 254 && mbedtls_mpi_get_bit(d, 2) != 0) {
3087 return MBEDTLS_ERR_ECP_INVALID_KEY;
3088 }
Nicholas Wilson08f3ef12015-11-10 13:10:01 +00003089
Gilles Peskine449bd832023-01-11 14:50:10 +01003090 return 0;
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +01003091 }
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003092#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
3093#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003094 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +01003095 /* see SEC1 3.2 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003096 if (mbedtls_mpi_cmp_int(d, 1) < 0 ||
3097 mbedtls_mpi_cmp_mpi(d, &grp->N) >= 0) {
3098 return MBEDTLS_ERR_ECP_INVALID_KEY;
3099 } else {
3100 return 0;
3101 }
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +01003102 }
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003103#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003104
Gilles Peskine449bd832023-01-11 14:50:10 +01003105 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003106}
3107
Gilles Peskine72fcc982021-03-23 22:31:31 +01003108#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
3109MBEDTLS_STATIC_TESTABLE
Gilles Peskine449bd832023-01-11 14:50:10 +01003110int mbedtls_ecp_gen_privkey_mx(size_t high_bit,
3111 mbedtls_mpi *d,
3112 int (*f_rng)(void *, unsigned char *, size_t),
3113 void *p_rng)
Gilles Peskine72fcc982021-03-23 22:31:31 +01003114{
3115 int ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Gilles Peskine61f1f5f2021-03-24 12:46:46 +01003116 size_t n_random_bytes = high_bit / 8 + 1;
Gilles Peskine72fcc982021-03-23 22:31:31 +01003117
3118 /* [Curve25519] page 5 */
Gilles Peskine61f1f5f2021-03-24 12:46:46 +01003119 /* Generate a (high_bit+1)-bit random number by generating just enough
3120 * random bytes, then shifting out extra bits from the top (necessary
3121 * when (high_bit+1) is not a multiple of 8). */
Gilles Peskine449bd832023-01-11 14:50:10 +01003122 MBEDTLS_MPI_CHK(mbedtls_mpi_fill_random(d, n_random_bytes,
3123 f_rng, p_rng));
3124 MBEDTLS_MPI_CHK(mbedtls_mpi_shift_r(d, 8 * n_random_bytes - high_bit - 1));
Gilles Peskine72fcc982021-03-23 22:31:31 +01003125
Gilles Peskine449bd832023-01-11 14:50:10 +01003126 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(d, high_bit, 1));
Gilles Peskine72fcc982021-03-23 22:31:31 +01003127
3128 /* Make sure the last two bits are unset for Curve448, three bits for
3129 Curve25519 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003130 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(d, 0, 0));
3131 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(d, 1, 0));
3132 if (high_bit == 254) {
3133 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(d, 2, 0));
Gilles Peskine72fcc982021-03-23 22:31:31 +01003134 }
3135
3136cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003137 return ret;
Gilles Peskine72fcc982021-03-23 22:31:31 +01003138}
3139#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
3140
Gilles Peskine60d8b982021-03-29 22:28:21 +02003141#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
3142static int mbedtls_ecp_gen_privkey_sw(
3143 const mbedtls_mpi *N, mbedtls_mpi *d,
Gilles Peskine449bd832023-01-11 14:50:10 +01003144 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Gilles Peskine60d8b982021-03-29 22:28:21 +02003145{
Gilles Peskine449bd832023-01-11 14:50:10 +01003146 int ret = mbedtls_mpi_random(d, 1, N, f_rng, p_rng);
3147 switch (ret) {
Gilles Peskine60d8b982021-03-29 22:28:21 +02003148 case MBEDTLS_ERR_MPI_NOT_ACCEPTABLE:
Gilles Peskine449bd832023-01-11 14:50:10 +01003149 return MBEDTLS_ERR_ECP_RANDOM_FAILED;
Gilles Peskine60d8b982021-03-29 22:28:21 +02003150 default:
Gilles Peskine449bd832023-01-11 14:50:10 +01003151 return ret;
Gilles Peskine60d8b982021-03-29 22:28:21 +02003152 }
3153}
3154#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
3155
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003156/*
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003157 * Generate a private key
Manuel Pégourié-Gonnard45a035a2013-01-26 14:42:45 +01003158 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003159int mbedtls_ecp_gen_privkey(const mbedtls_ecp_group *grp,
3160 mbedtls_mpi *d,
3161 int (*f_rng)(void *, unsigned char *, size_t),
3162 void *p_rng)
Manuel Pégourié-Gonnard45a035a2013-01-26 14:42:45 +01003163{
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003164#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003165 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
3166 return mbedtls_ecp_gen_privkey_mx(grp->nbits, d, f_rng, p_rng);
3167 }
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003168#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003169
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003170#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003171 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
3172 return mbedtls_ecp_gen_privkey_sw(&grp->N, d, f_rng, p_rng);
3173 }
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003174#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Manuel Pégourié-Gonnard45a035a2013-01-26 14:42:45 +01003175
Gilles Peskine449bd832023-01-11 14:50:10 +01003176 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003177}
Manuel Pégourié-Gonnardc9573992014-01-03 12:54:00 +01003178
Valerio Settifd122f42023-04-05 18:15:32 +02003179#if defined(MBEDTLS_ECP_C)
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003180/*
3181 * Generate a keypair with configurable base point
3182 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003183int mbedtls_ecp_gen_keypair_base(mbedtls_ecp_group *grp,
3184 const mbedtls_ecp_point *G,
3185 mbedtls_mpi *d, mbedtls_ecp_point *Q,
3186 int (*f_rng)(void *, unsigned char *, size_t),
3187 void *p_rng)
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003188{
Janos Follath24eed8d2019-11-22 13:21:35 +00003189 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01003190 MBEDTLS_MPI_CHK(mbedtls_ecp_gen_privkey(grp, d, f_rng, p_rng));
3191 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(grp, Q, d, G, f_rng, p_rng));
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003192
3193cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003194 return ret;
Manuel Pégourié-Gonnardd9a3f472015-08-11 14:31:03 +02003195}
3196
3197/*
3198 * Generate key pair, wrapper for conventional base point
3199 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003200int mbedtls_ecp_gen_keypair(mbedtls_ecp_group *grp,
3201 mbedtls_mpi *d, mbedtls_ecp_point *Q,
3202 int (*f_rng)(void *, unsigned char *, size_t),
3203 void *p_rng)
Manuel Pégourié-Gonnardd9a3f472015-08-11 14:31:03 +02003204{
Gilles Peskine449bd832023-01-11 14:50:10 +01003205 return mbedtls_ecp_gen_keypair_base(grp, &grp->G, d, Q, f_rng, p_rng);
Manuel Pégourié-Gonnard45a035a2013-01-26 14:42:45 +01003206}
Manuel Pégourié-Gonnardefaa31e2012-11-06 21:34:35 +01003207
Manuel Pégourié-Gonnard104ee1d2013-11-30 14:13:16 +01003208/*
3209 * Generate a keypair, prettier wrapper
3210 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003211int mbedtls_ecp_gen_key(mbedtls_ecp_group_id grp_id, mbedtls_ecp_keypair *key,
3212 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnard104ee1d2013-11-30 14:13:16 +01003213{
Janos Follath24eed8d2019-11-22 13:21:35 +00003214 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01003215 if ((ret = mbedtls_ecp_group_load(&key->grp, grp_id)) != 0) {
3216 return ret;
3217 }
Manuel Pégourié-Gonnard104ee1d2013-11-30 14:13:16 +01003218
Gilles Peskine449bd832023-01-11 14:50:10 +01003219 return mbedtls_ecp_gen_keypair(&key->grp, &key->d, &key->Q, f_rng, p_rng);
Manuel Pégourié-Gonnard104ee1d2013-11-30 14:13:16 +01003220}
Valerio Settifd122f42023-04-05 18:15:32 +02003221#endif /* MBEDTLS_ECP_C */
Manuel Pégourié-Gonnard104ee1d2013-11-30 14:13:16 +01003222
Janos Follath77800962019-02-25 16:32:08 +00003223#define ECP_CURVE25519_KEY_SIZE 32
Archana1d2e2bb2021-06-07 06:13:16 +05303224#define ECP_CURVE448_KEY_SIZE 56
Janos Follath171a7ef2019-02-15 16:17:45 +00003225/*
3226 * Read a private key.
3227 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003228int mbedtls_ecp_read_key(mbedtls_ecp_group_id grp_id, mbedtls_ecp_keypair *key,
3229 const unsigned char *buf, size_t buflen)
Janos Follath171a7ef2019-02-15 16:17:45 +00003230{
3231 int ret = 0;
3232
Gilles Peskine449bd832023-01-11 14:50:10 +01003233 if ((ret = mbedtls_ecp_group_load(&key->grp, grp_id)) != 0) {
3234 return ret;
3235 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003236
Janos Follath28eb06d2019-02-26 10:53:34 +00003237 ret = MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
3238
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003239#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003240 if (mbedtls_ecp_get_type(&key->grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
Janos Follath28eb06d2019-02-26 10:53:34 +00003241 /*
Archana1d2e2bb2021-06-07 06:13:16 +05303242 * Mask the key as mandated by RFC7748 for Curve25519 and Curve448.
Janos Follath28eb06d2019-02-26 10:53:34 +00003243 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003244 if (grp_id == MBEDTLS_ECP_DP_CURVE25519) {
3245 if (buflen != ECP_CURVE25519_KEY_SIZE) {
3246 return MBEDTLS_ERR_ECP_INVALID_KEY;
3247 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003248
Gilles Peskine449bd832023-01-11 14:50:10 +01003249 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary_le(&key->d, buf, buflen));
Janos Follath171a7ef2019-02-15 16:17:45 +00003250
Janos Follath28eb06d2019-02-26 10:53:34 +00003251 /* Set the three least significant bits to 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003252 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 0, 0));
3253 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 1, 0));
3254 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 2, 0));
Janos Follath171a7ef2019-02-15 16:17:45 +00003255
Janos Follath28eb06d2019-02-26 10:53:34 +00003256 /* Set the most significant bit to 0 */
3257 MBEDTLS_MPI_CHK(
Gilles Peskine449bd832023-01-11 14:50:10 +01003258 mbedtls_mpi_set_bit(&key->d,
3259 ECP_CURVE25519_KEY_SIZE * 8 - 1, 0)
3260 );
Janos Follath171a7ef2019-02-15 16:17:45 +00003261
Janos Follath28eb06d2019-02-26 10:53:34 +00003262 /* Set the second most significant bit to 1 */
3263 MBEDTLS_MPI_CHK(
Gilles Peskine449bd832023-01-11 14:50:10 +01003264 mbedtls_mpi_set_bit(&key->d,
3265 ECP_CURVE25519_KEY_SIZE * 8 - 2, 1)
3266 );
3267 } else if (grp_id == MBEDTLS_ECP_DP_CURVE448) {
3268 if (buflen != ECP_CURVE448_KEY_SIZE) {
3269 return MBEDTLS_ERR_ECP_INVALID_KEY;
3270 }
Archana1d2e2bb2021-06-07 06:13:16 +05303271
Gilles Peskine449bd832023-01-11 14:50:10 +01003272 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary_le(&key->d, buf, buflen));
Archana1d2e2bb2021-06-07 06:13:16 +05303273
3274 /* Set the two least significant bits to 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003275 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 0, 0));
3276 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 1, 0));
Archana1d2e2bb2021-06-07 06:13:16 +05303277
3278 /* Set the most significant bit to 1 */
3279 MBEDTLS_MPI_CHK(
Gilles Peskine449bd832023-01-11 14:50:10 +01003280 mbedtls_mpi_set_bit(&key->d,
3281 ECP_CURVE448_KEY_SIZE * 8 - 1, 1)
3282 );
Archana1d2e2bb2021-06-07 06:13:16 +05303283 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003284 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003285#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003286#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003287 if (mbedtls_ecp_get_type(&key->grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
3288 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary(&key->d, buf, buflen));
Janos Follath171a7ef2019-02-15 16:17:45 +00003289 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003290#endif
Valerio Setti41b08182023-07-04 12:14:21 +02003291 MBEDTLS_MPI_CHK(mbedtls_ecp_check_privkey(&key->grp, &key->d));
3292
Janos Follath171a7ef2019-02-15 16:17:45 +00003293cleanup:
3294
Gilles Peskine449bd832023-01-11 14:50:10 +01003295 if (ret != 0) {
3296 mbedtls_mpi_free(&key->d);
3297 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003298
Gilles Peskine449bd832023-01-11 14:50:10 +01003299 return ret;
Janos Follath171a7ef2019-02-15 16:17:45 +00003300}
3301
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003302/*
Steven Cooremande8593f2020-06-09 19:55:26 +02003303 * Write a private key.
3304 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003305int mbedtls_ecp_write_key(mbedtls_ecp_keypair *key,
3306 unsigned char *buf, size_t buflen)
Steven Cooremande8593f2020-06-09 19:55:26 +02003307{
Steven Cooreman0024df62020-07-13 10:59:40 +02003308 int ret = MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooremande8593f2020-06-09 19:55:26 +02003309
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003310#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003311 if (mbedtls_ecp_get_type(&key->grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
3312 if (key->grp.id == MBEDTLS_ECP_DP_CURVE25519) {
3313 if (buflen < ECP_CURVE25519_KEY_SIZE) {
3314 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
3315 }
Steven Cooremande8593f2020-06-09 19:55:26 +02003316
Gilles Peskine449bd832023-01-11 14:50:10 +01003317 } else if (key->grp.id == MBEDTLS_ECP_DP_CURVE448) {
3318 if (buflen < ECP_CURVE448_KEY_SIZE) {
3319 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
3320 }
Steven Cooremande8593f2020-06-09 19:55:26 +02003321 }
Gilles Peskine449bd832023-01-11 14:50:10 +01003322 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary_le(&key->d, buf, buflen));
Steven Cooremande8593f2020-06-09 19:55:26 +02003323 }
Steven Cooremande8593f2020-06-09 19:55:26 +02003324#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003325#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003326 if (mbedtls_ecp_get_type(&key->grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
3327 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(&key->d, buf, buflen));
Steven Cooremande8593f2020-06-09 19:55:26 +02003328 }
3329
3330#endif
3331cleanup:
3332
Gilles Peskine449bd832023-01-11 14:50:10 +01003333 return ret;
Steven Cooremande8593f2020-06-09 19:55:26 +02003334}
3335
Valerio Settifd122f42023-04-05 18:15:32 +02003336#if defined(MBEDTLS_ECP_C)
Steven Cooremande8593f2020-06-09 19:55:26 +02003337/*
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003338 * Check a public-private key pair
3339 */
Manuel Pégourié-Gonnardf8c24bf2021-06-15 11:29:26 +02003340int mbedtls_ecp_check_pub_priv(
Gilles Peskine449bd832023-01-11 14:50:10 +01003341 const mbedtls_ecp_keypair *pub, const mbedtls_ecp_keypair *prv,
3342 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003343{
Janos Follath24eed8d2019-11-22 13:21:35 +00003344 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003345 mbedtls_ecp_point Q;
3346 mbedtls_ecp_group grp;
Gilles Peskine449bd832023-01-11 14:50:10 +01003347 if (pub->grp.id == MBEDTLS_ECP_DP_NONE ||
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003348 pub->grp.id != prv->grp.id ||
Gilles Peskine449bd832023-01-11 14:50:10 +01003349 mbedtls_mpi_cmp_mpi(&pub->Q.X, &prv->Q.X) ||
3350 mbedtls_mpi_cmp_mpi(&pub->Q.Y, &prv->Q.Y) ||
3351 mbedtls_mpi_cmp_mpi(&pub->Q.Z, &prv->Q.Z)) {
3352 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003353 }
3354
Gilles Peskine449bd832023-01-11 14:50:10 +01003355 mbedtls_ecp_point_init(&Q);
3356 mbedtls_ecp_group_init(&grp);
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003357
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003358 /* mbedtls_ecp_mul() needs a non-const group... */
Gilles Peskine449bd832023-01-11 14:50:10 +01003359 mbedtls_ecp_group_copy(&grp, &prv->grp);
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003360
3361 /* Also checks d is valid */
Gilles Peskine449bd832023-01-11 14:50:10 +01003362 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(&grp, &Q, &prv->d, &prv->grp.G, f_rng, p_rng));
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003363
Gilles Peskine449bd832023-01-11 14:50:10 +01003364 if (mbedtls_mpi_cmp_mpi(&Q.X, &prv->Q.X) ||
3365 mbedtls_mpi_cmp_mpi(&Q.Y, &prv->Q.Y) ||
3366 mbedtls_mpi_cmp_mpi(&Q.Z, &prv->Q.Z)) {
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003367 ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003368 goto cleanup;
3369 }
3370
3371cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003372 mbedtls_ecp_point_free(&Q);
3373 mbedtls_ecp_group_free(&grp);
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003374
Gilles Peskine449bd832023-01-11 14:50:10 +01003375 return ret;
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003376}
Valerio Settifd122f42023-04-05 18:15:32 +02003377#endif /* MBEDTLS_ECP_C */
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003378
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003379/*
3380 * Export generic key-pair parameters.
3381 */
3382int mbedtls_ecp_export(const mbedtls_ecp_keypair *key, mbedtls_ecp_group *grp,
3383 mbedtls_mpi *d, mbedtls_ecp_point *Q)
3384{
3385 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003386
Gilles Peskine449bd832023-01-11 14:50:10 +01003387 if ((ret = mbedtls_ecp_group_copy(grp, &key->grp)) != 0) {
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003388 return ret;
Gilles Peskine449bd832023-01-11 14:50:10 +01003389 }
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003390
Gilles Peskine449bd832023-01-11 14:50:10 +01003391 if ((ret = mbedtls_mpi_copy(d, &key->d)) != 0) {
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003392 return ret;
Gilles Peskine449bd832023-01-11 14:50:10 +01003393 }
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003394
Gilles Peskine449bd832023-01-11 14:50:10 +01003395 if ((ret = mbedtls_ecp_copy(Q, &key->Q)) != 0) {
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003396 return ret;
Gilles Peskine449bd832023-01-11 14:50:10 +01003397 }
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003398
3399 return 0;
3400}
3401
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003402#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003403
Valerio Settifd122f42023-04-05 18:15:32 +02003404#if defined(MBEDTLS_ECP_C)
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02003405/*
3406 * PRNG for test - !!!INSECURE NEVER USE IN PRODUCTION!!!
3407 *
3408 * This is the linear congruential generator from numerical recipes,
3409 * except we only use the low byte as the output. See
3410 * https://en.wikipedia.org/wiki/Linear_congruential_generator#Parameters_in_common_use
3411 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003412static int self_test_rng(void *ctx, unsigned char *out, size_t len)
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02003413{
3414 static uint32_t state = 42;
3415
3416 (void) ctx;
3417
Gilles Peskine449bd832023-01-11 14:50:10 +01003418 for (size_t i = 0; i < len; i++) {
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02003419 state = state * 1664525u + 1013904223u;
3420 out[i] = (unsigned char) state;
3421 }
3422
Gilles Peskine449bd832023-01-11 14:50:10 +01003423 return 0;
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02003424}
3425
Gilles Peskine6d9c8d72020-07-22 01:26:25 +02003426/* Adjust the exponent to be a valid private point for the specified curve.
3427 * This is sometimes necessary because we use a single set of exponents
3428 * for all curves but the validity of values depends on the curve. */
Gilles Peskine449bd832023-01-11 14:50:10 +01003429static int self_test_adjust_exponent(const mbedtls_ecp_group *grp,
3430 mbedtls_mpi *m)
Gilles Peskinea088c812018-09-17 18:31:15 +02003431{
3432 int ret = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01003433 switch (grp->id) {
3434 /* If Curve25519 is available, then that's what we use for the
3435 * Montgomery test, so we don't need the adjustment code. */
3436#if !defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Gilles Peskinea088c812018-09-17 18:31:15 +02003437#if defined(MBEDTLS_ECP_DP_CURVE448_ENABLED)
3438 case MBEDTLS_ECP_DP_CURVE448:
3439 /* Move highest bit from 254 to N-1. Setting bit N-1 is
3440 * necessary to enforce the highest-bit-set constraint. */
Gilles Peskine449bd832023-01-11 14:50:10 +01003441 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(m, 254, 0));
3442 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(m, grp->nbits, 1));
Gilles Peskinea088c812018-09-17 18:31:15 +02003443 /* Copy second-highest bit from 253 to N-2. This is not
3444 * necessary but improves the test variety a bit. */
3445 MBEDTLS_MPI_CHK(
Gilles Peskine449bd832023-01-11 14:50:10 +01003446 mbedtls_mpi_set_bit(m, grp->nbits - 1,
3447 mbedtls_mpi_get_bit(m, 253)));
Gilles Peskinea088c812018-09-17 18:31:15 +02003448 break;
3449#endif
3450#endif /* ! defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED) */
3451 default:
3452 /* Non-Montgomery curves and Curve25519 need no adjustment. */
3453 (void) grp;
3454 (void) m;
3455 goto cleanup;
3456 }
3457cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003458 return ret;
Gilles Peskinea088c812018-09-17 18:31:15 +02003459}
3460
Gilles Peskine6d9c8d72020-07-22 01:26:25 +02003461/* Calculate R = m.P for each m in exponents. Check that the number of
3462 * basic operations doesn't depend on the value of m. */
Gilles Peskine449bd832023-01-11 14:50:10 +01003463static int self_test_point(int verbose,
3464 mbedtls_ecp_group *grp,
3465 mbedtls_ecp_point *R,
3466 mbedtls_mpi *m,
3467 const mbedtls_ecp_point *P,
3468 const char *const *exponents,
3469 size_t n_exponents)
Gilles Peskinec95696f2018-09-17 15:59:01 +02003470{
3471 int ret = 0;
Gilles Peskine24666792018-09-17 18:29:49 +02003472 size_t i = 0;
Gilles Peskinec95696f2018-09-17 15:59:01 +02003473 unsigned long add_c_prev, dbl_c_prev, mul_c_prev;
3474 add_count = 0;
3475 dbl_count = 0;
3476 mul_count = 0;
Gilles Peskinea088c812018-09-17 18:31:15 +02003477
Gilles Peskine449bd832023-01-11 14:50:10 +01003478 MBEDTLS_MPI_CHK(mbedtls_mpi_read_string(m, 16, exponents[0]));
3479 MBEDTLS_MPI_CHK(self_test_adjust_exponent(grp, m));
3480 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(grp, R, m, P, self_test_rng, NULL));
Gilles Peskinec95696f2018-09-17 15:59:01 +02003481
Gilles Peskine449bd832023-01-11 14:50:10 +01003482 for (i = 1; i < n_exponents; i++) {
Gilles Peskinec95696f2018-09-17 15:59:01 +02003483 add_c_prev = add_count;
3484 dbl_c_prev = dbl_count;
3485 mul_c_prev = mul_count;
3486 add_count = 0;
3487 dbl_count = 0;
3488 mul_count = 0;
3489
Gilles Peskine449bd832023-01-11 14:50:10 +01003490 MBEDTLS_MPI_CHK(mbedtls_mpi_read_string(m, 16, exponents[i]));
3491 MBEDTLS_MPI_CHK(self_test_adjust_exponent(grp, m));
3492 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(grp, R, m, P, self_test_rng, NULL));
Gilles Peskinec95696f2018-09-17 15:59:01 +02003493
Gilles Peskine449bd832023-01-11 14:50:10 +01003494 if (add_count != add_c_prev ||
Gilles Peskinec95696f2018-09-17 15:59:01 +02003495 dbl_count != dbl_c_prev ||
Gilles Peskine449bd832023-01-11 14:50:10 +01003496 mul_count != mul_c_prev) {
Gilles Peskinec95696f2018-09-17 15:59:01 +02003497 ret = 1;
3498 break;
3499 }
3500 }
3501
3502cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003503 if (verbose != 0) {
3504 if (ret != 0) {
3505 mbedtls_printf("failed (%u)\n", (unsigned int) i);
3506 } else {
3507 mbedtls_printf("passed\n");
3508 }
Gilles Peskinec95696f2018-09-17 15:59:01 +02003509 }
Gilles Peskine449bd832023-01-11 14:50:10 +01003510 return ret;
Gilles Peskinec95696f2018-09-17 15:59:01 +02003511}
Valerio Settifd122f42023-04-05 18:15:32 +02003512#endif /* MBEDTLS_ECP_C */
Gilles Peskinec95696f2018-09-17 15:59:01 +02003513
Manuel Pégourié-Gonnardb505c272012-11-05 17:27:54 +01003514/*
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003515 * Checkup routine
3516 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003517int mbedtls_ecp_self_test(int verbose)
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003518{
Valerio Settifd122f42023-04-05 18:15:32 +02003519#if defined(MBEDTLS_ECP_C)
Janos Follath24eed8d2019-11-22 13:21:35 +00003520 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003521 mbedtls_ecp_group grp;
3522 mbedtls_ecp_point R, P;
3523 mbedtls_mpi m;
Gilles Peskine24666792018-09-17 18:29:49 +02003524
3525#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskined9767a52018-09-14 19:29:47 +02003526 /* Exponents especially adapted for secp192k1, which has the lowest
3527 * order n of all supported curves (secp192r1 is in a slightly larger
3528 * field but the order of its base point is slightly smaller). */
Gilles Peskine24666792018-09-17 18:29:49 +02003529 const char *sw_exponents[] =
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003530 {
Manuel Pégourié-Gonnardb63f9e92012-11-21 13:00:58 +01003531 "000000000000000000000000000000000000000000000001", /* one */
Gilles Peskined9767a52018-09-14 19:29:47 +02003532 "FFFFFFFFFFFFFFFFFFFFFFFE26F2FC170F69466A74DEFD8C", /* n - 1 */
Manuel Pégourié-Gonnardb63f9e92012-11-21 13:00:58 +01003533 "5EA6F389A38B8BC81E767753B15AA5569E1782E30ABE7D25", /* random */
Manuel Pégourié-Gonnardff27b7c2013-11-21 09:28:03 +01003534 "400000000000000000000000000000000000000000000000", /* one and zeros */
3535 "7FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF", /* all ones */
3536 "555555555555555555555555555555555555555555555555", /* 101010... */
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003537 };
Gilles Peskine24666792018-09-17 18:29:49 +02003538#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
3539#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
3540 const char *m_exponents[] =
3541 {
Gilles Peskine6d9c8d72020-07-22 01:26:25 +02003542 /* Valid private values for Curve25519. In a build with Curve448
3543 * but not Curve25519, they will be adjusted in
3544 * self_test_adjust_exponent(). */
Gilles Peskine24666792018-09-17 18:29:49 +02003545 "4000000000000000000000000000000000000000000000000000000000000000",
3546 "5C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C30",
3547 "5715ECCE24583F7A7023C24164390586842E816D7280A49EF6DF4EAE6B280BF8",
3548 "41A2B017516F6D254E1F002BCCBADD54BE30F8CEC737A0E912B4963B6BA74460",
3549 "5555555555555555555555555555555555555555555555555555555555555550",
3550 "7FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF8",
3551 };
3552#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003553
Gilles Peskine449bd832023-01-11 14:50:10 +01003554 mbedtls_ecp_group_init(&grp);
3555 mbedtls_ecp_point_init(&R);
3556 mbedtls_ecp_point_init(&P);
3557 mbedtls_mpi_init(&m);
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003558
Gilles Peskine24666792018-09-17 18:29:49 +02003559#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Manuel Pégourié-Gonnardb8012fc2013-10-10 15:40:49 +02003560 /* Use secp192r1 if available, or any available curve */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003561#if defined(MBEDTLS_ECP_DP_SECP192R1_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003562 MBEDTLS_MPI_CHK(mbedtls_ecp_group_load(&grp, MBEDTLS_ECP_DP_SECP192R1));
Paul Bakker5dc6b5f2013-06-29 23:26:34 +02003563#else
Gilles Peskine449bd832023-01-11 14:50:10 +01003564 MBEDTLS_MPI_CHK(mbedtls_ecp_group_load(&grp, mbedtls_ecp_curve_list()->grp_id));
Manuel Pégourié-Gonnardb8012fc2013-10-10 15:40:49 +02003565#endif
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003566
Gilles Peskine449bd832023-01-11 14:50:10 +01003567 if (verbose != 0) {
3568 mbedtls_printf(" ECP SW test #1 (constant op_count, base point G): ");
3569 }
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +02003570 /* Do a dummy multiplication first to trigger precomputation */
Gilles Peskine449bd832023-01-11 14:50:10 +01003571 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&m, 2));
3572 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(&grp, &P, &m, &grp.G, self_test_rng, NULL));
3573 ret = self_test_point(verbose,
3574 &grp, &R, &m, &grp.G,
3575 sw_exponents,
3576 sizeof(sw_exponents) / sizeof(sw_exponents[0]));
3577 if (ret != 0) {
Gilles Peskinec95696f2018-09-17 15:59:01 +02003578 goto cleanup;
Gilles Peskine449bd832023-01-11 14:50:10 +01003579 }
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003580
Gilles Peskine449bd832023-01-11 14:50:10 +01003581 if (verbose != 0) {
3582 mbedtls_printf(" ECP SW test #2 (constant op_count, other point): ");
3583 }
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +02003584 /* We computed P = 2G last time, use it */
Gilles Peskine449bd832023-01-11 14:50:10 +01003585 ret = self_test_point(verbose,
3586 &grp, &R, &m, &P,
3587 sw_exponents,
3588 sizeof(sw_exponents) / sizeof(sw_exponents[0]));
3589 if (ret != 0) {
Gilles Peskine24666792018-09-17 18:29:49 +02003590 goto cleanup;
Gilles Peskine449bd832023-01-11 14:50:10 +01003591 }
Gilles Peskine24666792018-09-17 18:29:49 +02003592
Gilles Peskine449bd832023-01-11 14:50:10 +01003593 mbedtls_ecp_group_free(&grp);
3594 mbedtls_ecp_point_free(&R);
Gilles Peskine24666792018-09-17 18:29:49 +02003595#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
3596
3597#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003598 if (verbose != 0) {
3599 mbedtls_printf(" ECP Montgomery test (constant op_count): ");
3600 }
Gilles Peskine24666792018-09-17 18:29:49 +02003601#if defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003602 MBEDTLS_MPI_CHK(mbedtls_ecp_group_load(&grp, MBEDTLS_ECP_DP_CURVE25519));
Gilles Peskine24666792018-09-17 18:29:49 +02003603#elif defined(MBEDTLS_ECP_DP_CURVE448_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003604 MBEDTLS_MPI_CHK(mbedtls_ecp_group_load(&grp, MBEDTLS_ECP_DP_CURVE448));
Gilles Peskine24666792018-09-17 18:29:49 +02003605#else
3606#error "MBEDTLS_ECP_MONTGOMERY_ENABLED is defined, but no curve is supported for self-test"
3607#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01003608 ret = self_test_point(verbose,
3609 &grp, &R, &m, &grp.G,
3610 m_exponents,
3611 sizeof(m_exponents) / sizeof(m_exponents[0]));
3612 if (ret != 0) {
Gilles Peskine24666792018-09-17 18:29:49 +02003613 goto cleanup;
Gilles Peskine449bd832023-01-11 14:50:10 +01003614 }
Gilles Peskine24666792018-09-17 18:29:49 +02003615#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +02003616
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003617cleanup:
3618
Gilles Peskine449bd832023-01-11 14:50:10 +01003619 if (ret < 0 && verbose != 0) {
3620 mbedtls_printf("Unexpected error, return code = %08X\n", (unsigned int) ret);
3621 }
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003622
Gilles Peskine449bd832023-01-11 14:50:10 +01003623 mbedtls_ecp_group_free(&grp);
3624 mbedtls_ecp_point_free(&R);
3625 mbedtls_ecp_point_free(&P);
3626 mbedtls_mpi_free(&m);
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003627
Gilles Peskine449bd832023-01-11 14:50:10 +01003628 if (verbose != 0) {
3629 mbedtls_printf("\n");
3630 }
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003631
Gilles Peskine449bd832023-01-11 14:50:10 +01003632 return ret;
Valerio Settifd122f42023-04-05 18:15:32 +02003633#else /* MBEDTLS_ECP_C */
3634 (void) verbose;
3635 return 0;
3636#endif /* MBEDTLS_ECP_C */
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003637}
3638
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003639#endif /* MBEDTLS_SELF_TEST */
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003640
Janos Follathb0697532016-08-18 12:38:46 +01003641#endif /* !MBEDTLS_ECP_ALT */
3642
Valerio Settifd122f42023-04-05 18:15:32 +02003643#endif /* MBEDTLS_ECP_LIGHT */