Besides author also check committer
Signed-off-by: Fabio Utzig <utzig@apache.org>
diff --git a/scripts/check-signed-off-by.sh b/scripts/check-signed-off-by.sh
index 8f5c4ee..497917b 100755
--- a/scripts/check-signed-off-by.sh
+++ b/scripts/check-signed-off-by.sh
@@ -19,20 +19,28 @@
has_commits=false
for sha in $commits; do
- expected="Signed-off-by: $(git show -s --format="%an <%ae>" ${sha})"
+ author="Signed-off-by: $(git show -s --format="%an <%ae>" ${sha})"
+ committer="Signed-off-by: $(git show -s --format="%cn <%ce>" ${sha})"
+
lines="$(git show -s --format=%B ${sha})"
- found_sob=false
+
+ found_author=false
+ found_committer=false
IFS=$'\n'
for line in ${lines}; do
stripped=$(echo $line | sed -e 's/^\s*//' | sed -e 's/\s*$//')
- if [[ $stripped == ${expected} ]]; then
- found_sob=true
- break
+ if [[ ${stripped} == ${author} ]]; then
+ found_author=true
fi
+ if [[ ${stripped} == ${committer} ]]; then
+ found_committer=true
+ fi
+
+ [[ ${found_author} == true && ${found_committer} == true ]] && break
done
- if [[ ${found_sob} = false ]]; then
- echo -e "No \"${expected}\" found in commit ${sha}"
+ if [[ ${found_author} == false || ${found_committer} == false ]]; then
+ echo -e "One or more \"Signed-off-by\" lines missing in commit ${sha}"
exit 1
fi