tree ea08902dd24a219132d349845aa7889c945ffd95
parent 5e6ea22cff2802e0b7eb3e6bbb037099012fcf25
author Fabio Utzig <utzig@apache.org> 1575982277 -0300
committer Fabio Utzig <utzig@utzig.org> 1575990135 -0300

bootutil: fix random upgrade failure using swap move

Fix an issue where an upgrade could fail to execute.

This happened randomly in the "perm_with_fails" test in the simulator;
for it to happen the first reset had to occur just after writing the
metadata to mark the start of a new upgrade, but before any swap happened;
if followed by a new reset happening at a point where the metadata was
erased and rewritten, it would result in an upgrade failure. The images
would still be valid though although in their original slots.

The fix stores the detected boot status source in the state. When
metadata was found in the primary slot we assume a swap has already
started (even though no sector swap has happened) and avoid
erasing/rewriting it.

Signed-off-by: Fabio Utzig <utzig@apache.org>