commit f48b95022ad53e5f769f1eaaa6fbe07c2daf2054
author David Brown <david.brown@linaro.org> Mon Nov 06 14:00:26 2017 -0700
committer David Brown <davidb@davidb.org> Tue Nov 07 09:39:45 2017 -0700
tree 10a70b9249463766625140cd0f776fa48c9ca932
parent 5f7ec2b403fb3fd1e797cf8e15ced9613ff1c8f5

sim: Make `Run` a factory for `Images`

Generate the various test images as methods of the `Run` struct.

Signed-off-by: David Brown <david.brown@linaro.org>

sim/src/lib.rs

diff --git a/sim/src/lib.rs b/sim/src/lib.rs
index 9e630ba..1a0e413 100644
--- a/sim/src/lib.rs
+++ b/sim/src/lib.rs
@@ -205,6 +205,44 @@
             }
         }
     }
+
+    /// Construct an `Images` that doesn't expect an upgrade to happen.
+    pub fn make_no_upgrade_image(&self) -> Images {
+        let mut flash = self.flash.clone();
+        let primary = install_image(&mut flash, self.slots[0].base_off, 32784, false);
+        let upgrade = install_image(&mut flash, self.slots[1].base_off, 41928, false);
+        Images {
+            flash: flash,
+            areadesc: self.areadesc.clone(),
+            slot0: self.slots[0].clone(),
+            slot1: self.slots[1].clone(),
+            primary: primary,
+            upgrade: upgrade,
+            align: self.align,
+        }
+    }
+
+    /// Construct an `Images` for normal testing.
+    pub fn make_image(&self) -> Images {
+        let mut images = self.make_no_upgrade_image();
+        mark_upgrade(&mut images.flash, &images.slot1);
+        images
+    }
+
+    pub fn make_bad_slot1_image(&self) -> Images {
+        let mut bad_flash = self.flash.clone();
+        let primary = install_image(&mut bad_flash, self.slots[0].base_off, 32784, false);
+        let upgrade = install_image(&mut bad_flash, self.slots[1].base_off, 41928, true);
+        Images {
+            flash: bad_flash,
+            areadesc: self.areadesc.clone(),
+            slot0: self.slots[0].clone(),
+            slot1: self.slots[1].clone(),
+            primary: primary,
+            upgrade: upgrade,
+            align: self.align,
+        }
+    }
 }
 
 pub struct RunStatus {
@@ -229,37 +267,14 @@
 
         // Creates a badly signed image in slot1 to check that it is not
         // upgraded to
-        let mut bad_flash = run.flash.clone();
-        let primary = install_image(&mut bad_flash, run.slots[0].base_off, 32784, false);
-        let upgrade = install_image(&mut bad_flash, run.slots[1].base_off, 41928, true);
-        let bad_slot1_image = Images {
-            flash: bad_flash,
-            areadesc: run.areadesc.clone(),
-            slot0: run.slots[0].clone(),
-            slot1: run.slots[1].clone(),
-            primary: primary,
-            upgrade: upgrade,
-            align: align,
-        };
+        let bad_slot1_image = run.make_bad_slot1_image();
 
         failed |= bad_slot1_image.run_signfail_upgrade();
 
-        let mut flash = run.flash.clone();
-        let primary = install_image(&mut flash, run.slots[0].base_off, 32784, false);
-        let upgrade = install_image(&mut flash, run.slots[1].base_off, 41928, false);
-        let mut images = Images {
-            flash: flash,
-            areadesc: run.areadesc.clone(),
-            slot0: run.slots[0].clone(),
-            slot1: run.slots[1].clone(),
-            primary: primary,
-            upgrade: upgrade,
-            align: align,
-        };
-
+        let images = run.make_no_upgrade_image();
         failed |= images.run_norevert_newimage();
 
-        mark_upgrade(&mut images.flash, &images.slot1);
+        let images = run.make_image();
 
         // upgrades without fails, counts number of flash operations
         let total_count = match images.run_basic_upgrade() {
@@ -975,7 +990,7 @@
     trailer_off: usize,
 }
 
-struct Images {
+pub struct Images {
     flash: SimFlash,
     areadesc: AreaDesc,
     slot0: SlotInfo,