blob: 2d368fd3e84343984122616e8757305551dc1c6e [file] [log] [blame]
Christopher Collins92ea77f2016-12-12 15:59:26 -08001/*
David Brownaac71112020-02-03 16:13:42 -07002 * SPDX-License-Identifier: Apache-2.0
3 *
4 * Copyright (c) 2017-2019 Linaro LTD
5 * Copyright (c) 2016-2019 JUUL Labs
6 * Copyright (c) 2019-2020 Arm Limited
7 *
8 * Original license:
9 *
Christopher Collins92ea77f2016-12-12 15:59:26 -080010 * Licensed to the Apache Software Foundation (ASF) under one
11 * or more contributor license agreements. See the NOTICE file
12 * distributed with this work for additional information
13 * regarding copyright ownership. The ASF licenses this file
14 * to you under the Apache License, Version 2.0 (the
15 * "License"); you may not use this file except in compliance
16 * with the License. You may obtain a copy of the License at
17 *
18 * http://www.apache.org/licenses/LICENSE-2.0
19 *
20 * Unless required by applicable law or agreed to in writing,
21 * software distributed under the License is distributed on an
22 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
23 * KIND, either express or implied. See the License for the
24 * specific language governing permissions and limitations
25 * under the License.
26 */
27
Christopher Collins92ea77f2016-12-12 15:59:26 -080028#include <stddef.h>
David Vinczec3084132020-02-18 14:50:47 +010029#include <stdint.h>
Christopher Collins92ea77f2016-12-12 15:59:26 -080030#include <inttypes.h>
31#include <string.h>
32
Andrzej Puzdrowskib788c712018-04-12 12:42:49 +020033#include <flash_map_backend/flash_map_backend.h>
34
Christopher Collins92ea77f2016-12-12 15:59:26 -080035#include "bootutil/image.h"
Blaž Hrastnik4f4833d2020-09-14 13:53:31 +090036#include "bootutil/crypto/sha256.h"
Christopher Collins92ea77f2016-12-12 15:59:26 -080037#include "bootutil/sign_key.h"
David Vinczec3084132020-02-18 14:50:47 +010038#include "bootutil/security_cnt.h"
Raef Colese8fe6cf2020-05-26 13:07:40 +010039#include "bootutil/fault_injection_hardening.h"
Christopher Collins92ea77f2016-12-12 15:59:26 -080040
Fabio Utzigba1fbe62017-07-21 14:01:20 -030041#include "mcuboot_config/mcuboot_config.h"
Fabio Utzigeed80b62017-06-10 08:03:05 -030042
Fabio Utzigba829042018-09-18 08:29:34 -030043#ifdef MCUBOOT_ENC_IMAGES
44#include "bootutil/enc_key.h"
45#endif
46#if defined(MCUBOOT_SIGN_RSA)
Christopher Collins92ea77f2016-12-12 15:59:26 -080047#include "mbedtls/rsa.h"
David Brownd7e350d2017-04-24 13:29:28 -060048#endif
Fabio Utzig19356bf2017-05-11 16:19:36 -030049#if defined(MCUBOOT_SIGN_EC) || defined(MCUBOOT_SIGN_EC256)
Christopher Collins92ea77f2016-12-12 15:59:26 -080050#include "mbedtls/ecdsa.h"
David Brownd7e350d2017-04-24 13:29:28 -060051#endif
Arvin Farahmandf8240192020-05-05 11:43:52 -040052#if defined(MCUBOOT_ENC_IMAGES) || defined(MCUBOOT_SIGN_RSA) || \
53 defined(MCUBOOT_SIGN_EC) || defined(MCUBOOT_SIGN_EC256)
Christopher Collins92ea77f2016-12-12 15:59:26 -080054#include "mbedtls/asn1.h"
Arvin Farahmandf8240192020-05-05 11:43:52 -040055#endif
Christopher Collins92ea77f2016-12-12 15:59:26 -080056
57#include "bootutil_priv.h"
58
59/*
60 * Compute SHA256 over the image.
61 */
62static int
Fabio Utzig10ee6482019-08-01 12:04:52 -030063bootutil_img_hash(struct enc_key_data *enc_state, int image_index,
64 struct image_header *hdr, const struct flash_area *fap,
65 uint8_t *tmp_buf, uint32_t tmp_buf_sz, uint8_t *hash_result,
66 uint8_t *seed, int seed_len)
Christopher Collins92ea77f2016-12-12 15:59:26 -080067{
David Browne629bf32017-04-24 13:37:33 -060068 bootutil_sha256_context sha256_ctx;
Christopher Collins92ea77f2016-12-12 15:59:26 -080069 uint32_t blk_sz;
70 uint32_t size;
Fabio Utzig2fc80df2018-12-14 06:47:38 -020071 uint16_t hdr_size;
Christopher Collins92ea77f2016-12-12 15:59:26 -080072 uint32_t off;
73 int rc;
Fabio Utzigba829042018-09-18 08:29:34 -030074 uint32_t blk_off;
Fabio Utzige52c08e2019-09-11 19:32:00 -030075 uint32_t tlv_off;
Christopher Collins92ea77f2016-12-12 15:59:26 -080076
Tamas Banfe031092020-09-10 17:32:39 +020077#if (BOOT_IMAGE_NUMBER == 1) || !defined(MCUBOOT_ENC_IMAGES) || \
78 defined(MCUBOOT_RAM_LOAD)
Fabio Utzig10ee6482019-08-01 12:04:52 -030079 (void)enc_state;
Fabio Utzigb0f04732019-07-31 09:49:19 -030080 (void)image_index;
Fabio Utzigc9621352019-08-08 12:15:51 -030081 (void)hdr_size;
Fabio Utzige52c08e2019-09-11 19:32:00 -030082 (void)blk_off;
83 (void)tlv_off;
Tamas Banfe031092020-09-10 17:32:39 +020084#ifdef MCUBOOT_RAM_LOAD
85 (void)blk_sz;
86 (void)off;
87 (void)rc;
David Brown122f9e72021-05-21 15:58:56 -060088 (void)fap;
89 (void)tmp_buf;
90 (void)tmp_buf_sz;
Tamas Banfe031092020-09-10 17:32:39 +020091#endif
Fabio Utzigb0f04732019-07-31 09:49:19 -030092#endif
93
Fabio Utzigbc077932019-08-26 11:16:34 -030094#ifdef MCUBOOT_ENC_IMAGES
95 /* Encrypted images only exist in the secondary slot */
96 if (MUST_DECRYPT(fap, image_index, hdr) &&
97 !boot_enc_valid(enc_state, image_index, fap)) {
98 return -1;
99 }
100#endif
101
David Browne629bf32017-04-24 13:37:33 -0600102 bootutil_sha256_init(&sha256_ctx);
Christopher Collins92ea77f2016-12-12 15:59:26 -0800103
104 /* in some cases (split image) the hash is seeded with data from
105 * the loader image */
Fabio Utzig53986042017-12-12 14:57:07 -0200106 if (seed && (seed_len > 0)) {
David Browne629bf32017-04-24 13:37:33 -0600107 bootutil_sha256_update(&sha256_ctx, seed, seed_len);
Christopher Collins92ea77f2016-12-12 15:59:26 -0800108 }
109
David Vinczee32483f2019-06-13 10:46:24 +0200110 /* Hash is computed over image header and image itself. */
Fabio Utzige52c08e2019-09-11 19:32:00 -0300111 size = hdr_size = hdr->ih_hdr_size;
112 size += hdr->ih_img_size;
113 tlv_off = size;
David Vinczee32483f2019-06-13 10:46:24 +0200114
Fabio Utzige52c08e2019-09-11 19:32:00 -0300115 /* If protected TLVs are present they are also hashed. */
116 size += hdr->ih_protect_tlv_size;
David Vinczee32483f2019-06-13 10:46:24 +0200117
Tamas Banfe031092020-09-10 17:32:39 +0200118#ifdef MCUBOOT_RAM_LOAD
119 bootutil_sha256_update(&sha256_ctx,(void*)(hdr->ih_load_addr), size);
120#else
Christopher Collins92ea77f2016-12-12 15:59:26 -0800121 for (off = 0; off < size; off += blk_sz) {
122 blk_sz = size - off;
Fabio Utzige52c08e2019-09-11 19:32:00 -0300123 if (blk_sz > tmp_buf_sz) {
124 blk_sz = tmp_buf_sz;
125 }
Fabio Utzigc21c2102019-09-10 10:10:42 -0300126#ifdef MCUBOOT_ENC_IMAGES
127 /* The only data that is encrypted in an image is the payload;
128 * both header and TLVs (when protected) are not.
129 */
130 if ((off < hdr_size) && ((off + blk_sz) > hdr_size)) {
131 /* read only the header */
132 blk_sz = hdr_size - off;
Fabio Utzige52c08e2019-09-11 19:32:00 -0300133 }
134 if ((off < tlv_off) && ((off + blk_sz) > tlv_off)) {
135 /* read only up to the end of the image payload */
136 blk_sz = tlv_off - off;
Fabio Utzigc21c2102019-09-10 10:10:42 -0300137 }
138#endif
Christopher Collins92ea77f2016-12-12 15:59:26 -0800139 rc = flash_area_read(fap, off, tmp_buf, blk_sz);
140 if (rc) {
Blaž Hrastnik4f4833d2020-09-14 13:53:31 +0900141 bootutil_sha256_drop(&sha256_ctx);
Christopher Collins92ea77f2016-12-12 15:59:26 -0800142 return rc;
143 }
Fabio Utzigba829042018-09-18 08:29:34 -0300144#ifdef MCUBOOT_ENC_IMAGES
Fabio Utzigc21c2102019-09-10 10:10:42 -0300145 if (MUST_DECRYPT(fap, image_index, hdr)) {
Fabio Utzige52c08e2019-09-11 19:32:00 -0300146 /* Only payload is encrypted (area between header and TLVs) */
147 if (off >= hdr_size && off < tlv_off) {
Fabio Utzigc21c2102019-09-10 10:10:42 -0300148 blk_off = (off - hdr_size) & 0xf;
149 boot_encrypt(enc_state, image_index, fap, off - hdr_size,
150 blk_sz, blk_off, tmp_buf);
151 }
Fabio Utzigba829042018-09-18 08:29:34 -0300152 }
153#endif
David Browne629bf32017-04-24 13:37:33 -0600154 bootutil_sha256_update(&sha256_ctx, tmp_buf, blk_sz);
Christopher Collins92ea77f2016-12-12 15:59:26 -0800155 }
Tamas Banfe031092020-09-10 17:32:39 +0200156#endif /* MCUBOOT_RAM_LOAD */
David Browne629bf32017-04-24 13:37:33 -0600157 bootutil_sha256_finish(&sha256_ctx, hash_result);
Blaž Hrastnik4f4833d2020-09-14 13:53:31 +0900158 bootutil_sha256_drop(&sha256_ctx);
Christopher Collins92ea77f2016-12-12 15:59:26 -0800159
160 return 0;
161}
162
163/*
David Brown43cda332017-09-01 09:53:23 -0600164 * Currently, we only support being able to verify one type of
165 * signature, because there is a single verification function that we
166 * call. List the type of TLV we are expecting. If we aren't
167 * configured for any signature, don't define this macro.
168 */
Fabio Utzig48764842019-05-10 19:28:24 -0300169#if (defined(MCUBOOT_SIGN_RSA) + \
170 defined(MCUBOOT_SIGN_EC) + \
171 defined(MCUBOOT_SIGN_EC256) + \
172 defined(MCUBOOT_SIGN_ED25519)) > 1
Fabio Utzig3501c012019-05-13 15:07:25 -0700173#error "Only a single signature type is supported!"
174#endif
175
David Brown43cda332017-09-01 09:53:23 -0600176#if defined(MCUBOOT_SIGN_RSA)
Fabio Utzig3501c012019-05-13 15:07:25 -0700177# if MCUBOOT_SIGN_RSA_LEN == 2048
178# define EXPECTED_SIG_TLV IMAGE_TLV_RSA2048_PSS
179# elif MCUBOOT_SIGN_RSA_LEN == 3072
180# define EXPECTED_SIG_TLV IMAGE_TLV_RSA3072_PSS
181# else
182# error "Unsupported RSA signature length"
David Brown43cda332017-09-01 09:53:23 -0600183# endif
Fabio Utzig3501c012019-05-13 15:07:25 -0700184# define SIG_BUF_SIZE (MCUBOOT_SIGN_RSA_LEN / 8)
185# define EXPECTED_SIG_LEN(x) ((x) == SIG_BUF_SIZE) /* 2048 bits */
David Brown43cda332017-09-01 09:53:23 -0600186#elif defined(MCUBOOT_SIGN_EC)
187# define EXPECTED_SIG_TLV IMAGE_TLV_ECDSA224
Fabio Utzig3501c012019-05-13 15:07:25 -0700188# define SIG_BUF_SIZE 128
David Browna3608262019-12-12 15:35:31 -0700189# define EXPECTED_SIG_LEN(x) (1) /* always true, ASN.1 will validate */
David Brown43cda332017-09-01 09:53:23 -0600190#elif defined(MCUBOOT_SIGN_EC256)
191# define EXPECTED_SIG_TLV IMAGE_TLV_ECDSA256
Fabio Utzig3501c012019-05-13 15:07:25 -0700192# define SIG_BUF_SIZE 128
David Browna3608262019-12-12 15:35:31 -0700193# define EXPECTED_SIG_LEN(x) (1) /* always true, ASN.1 will validate */
Fabio Utzig48764842019-05-10 19:28:24 -0300194#elif defined(MCUBOOT_SIGN_ED25519)
195# define EXPECTED_SIG_TLV IMAGE_TLV_ED25519
196# define SIG_BUF_SIZE 64
197# define EXPECTED_SIG_LEN(x) ((x) == SIG_BUF_SIZE)
Fabio Utzig3501c012019-05-13 15:07:25 -0700198#else
199# define SIG_BUF_SIZE 32 /* no signing, sha256 digest only */
David Brown43cda332017-09-01 09:53:23 -0600200#endif
201
202#ifdef EXPECTED_SIG_TLV
David Vincze03368b82020-04-01 12:53:53 +0200203#if !defined(MCUBOOT_HW_KEY)
David Brown43cda332017-09-01 09:53:23 -0600204static int
205bootutil_find_key(uint8_t *keyhash, uint8_t keyhash_len)
206{
207 bootutil_sha256_context sha256_ctx;
208 int i;
209 const struct bootutil_key *key;
210 uint8_t hash[32];
211
Fabio Utzig15c14672019-08-09 07:45:20 -0300212 if (keyhash_len > 32) {
213 return -1;
214 }
David Brown43cda332017-09-01 09:53:23 -0600215
216 for (i = 0; i < bootutil_key_cnt; i++) {
217 key = &bootutil_keys[i];
218 bootutil_sha256_init(&sha256_ctx);
219 bootutil_sha256_update(&sha256_ctx, key->key, *key->len);
220 bootutil_sha256_finish(&sha256_ctx, hash);
221 if (!memcmp(hash, keyhash, keyhash_len)) {
Blaž Hrastnik4f4833d2020-09-14 13:53:31 +0900222 bootutil_sha256_drop(&sha256_ctx);
David Brown43cda332017-09-01 09:53:23 -0600223 return i;
224 }
225 }
Blaž Hrastnik4f4833d2020-09-14 13:53:31 +0900226 bootutil_sha256_drop(&sha256_ctx);
David Brown43cda332017-09-01 09:53:23 -0600227 return -1;
228}
David Vincze03368b82020-04-01 12:53:53 +0200229#else
230extern unsigned int pub_key_len;
231static int
232bootutil_find_key(uint8_t image_index, uint8_t *key, uint16_t key_len)
233{
234 bootutil_sha256_context sha256_ctx;
235 uint8_t hash[32];
236 uint8_t key_hash[32];
237 size_t key_hash_size = sizeof(key_hash);
238 int rc;
Raef Colese8fe6cf2020-05-26 13:07:40 +0100239 fih_int fih_rc;
David Vincze03368b82020-04-01 12:53:53 +0200240
241 bootutil_sha256_init(&sha256_ctx);
242 bootutil_sha256_update(&sha256_ctx, key, key_len);
243 bootutil_sha256_finish(&sha256_ctx, hash);
Blaž Hrastnik4f4833d2020-09-14 13:53:31 +0900244 bootutil_sha256_drop(&sha256_ctx);
David Vincze03368b82020-04-01 12:53:53 +0200245
246 rc = boot_retrieve_public_key_hash(image_index, key_hash, &key_hash_size);
247 if (rc) {
248 return rc;
249 }
250
Raef Colese8fe6cf2020-05-26 13:07:40 +0100251 /* Adding hardening to avoid this potential attack:
252 * - Image is signed with an arbitrary key and the corresponding public
253 * key is added as a TLV field.
254 * - During public key validation (comparing against key-hash read from
255 * HW) a fault is injected to accept the public key as valid one.
256 */
257 FIH_CALL(boot_fih_memequal, fih_rc, hash, key_hash, key_hash_size);
258 if (fih_eq(fih_rc, FIH_SUCCESS)) {
David Vincze03368b82020-04-01 12:53:53 +0200259 bootutil_keys[0].key = key;
260 pub_key_len = key_len;
261 return 0;
262 }
Raef Colese8fe6cf2020-05-26 13:07:40 +0100263
David Vincze03368b82020-04-01 12:53:53 +0200264 return -1;
265}
266#endif /* !MCUBOOT_HW_KEY */
David Brown43cda332017-09-01 09:53:23 -0600267#endif
268
David Vinczec3084132020-02-18 14:50:47 +0100269#ifdef MCUBOOT_HW_ROLLBACK_PROT
270/**
271 * Reads the value of an image's security counter.
272 *
273 * @param hdr Pointer to the image header structure.
274 * @param fap Pointer to a description structure of the image's
275 * flash area.
276 * @param security_cnt Pointer to store the security counter value.
277 *
278 * @return 0 on success; nonzero on failure.
279 */
280int32_t
281bootutil_get_img_security_cnt(struct image_header *hdr,
282 const struct flash_area *fap,
283 uint32_t *img_security_cnt)
284{
285 struct image_tlv_iter it;
286 uint32_t off;
287 uint16_t len;
288 int32_t rc;
289
290 if ((hdr == NULL) ||
291 (fap == NULL) ||
292 (img_security_cnt == NULL)) {
293 /* Invalid parameter. */
294 return BOOT_EBADARGS;
295 }
296
297 /* The security counter TLV is in the protected part of the TLV area. */
298 if (hdr->ih_protect_tlv_size == 0) {
299 return BOOT_EBADIMAGE;
300 }
301
302 rc = bootutil_tlv_iter_begin(&it, hdr, fap, IMAGE_TLV_SEC_CNT, true);
303 if (rc) {
304 return rc;
305 }
306
307 /* Traverse through the protected TLV area to find
308 * the security counter TLV.
309 */
310
311 rc = bootutil_tlv_iter_next(&it, &off, &len, NULL);
312 if (rc != 0) {
313 /* Security counter TLV has not been found. */
314 return -1;
315 }
316
317 if (len != sizeof(*img_security_cnt)) {
318 /* Security counter is not valid. */
319 return BOOT_EBADIMAGE;
320 }
321
Tamas Banfe031092020-09-10 17:32:39 +0200322 rc = LOAD_IMAGE_DATA(hdr, fap, off, img_security_cnt, len);
David Vinczec3084132020-02-18 14:50:47 +0100323 if (rc != 0) {
324 return BOOT_EFLASH;
325 }
326
327 return 0;
328}
329#endif /* MCUBOOT_HW_ROLLBACK_PROT */
330
David Brown43cda332017-09-01 09:53:23 -0600331/*
Christopher Collins92ea77f2016-12-12 15:59:26 -0800332 * Verify the integrity of the image.
333 * Return non-zero if image could not be validated/does not validate.
334 */
Raef Colese8fe6cf2020-05-26 13:07:40 +0100335fih_int
Fabio Utzig10ee6482019-08-01 12:04:52 -0300336bootutil_img_validate(struct enc_key_data *enc_state, int image_index,
337 struct image_header *hdr, const struct flash_area *fap,
338 uint8_t *tmp_buf, uint32_t tmp_buf_sz, uint8_t *seed,
339 int seed_len, uint8_t *out_hash)
Christopher Collins92ea77f2016-12-12 15:59:26 -0800340{
341 uint32_t off;
Fabio Utzig61fd8882019-09-14 20:00:20 -0300342 uint16_t len;
David Brownd13318a2019-12-04 17:28:40 -0700343 uint16_t type;
David Brown43cda332017-09-01 09:53:23 -0600344 int sha256_valid = 0;
345#ifdef EXPECTED_SIG_TLV
Raef Colese8fe6cf2020-05-26 13:07:40 +0100346 fih_int valid_signature = FIH_FAILURE;
David Brown43cda332017-09-01 09:53:23 -0600347 int key_id = -1;
David Vincze03368b82020-04-01 12:53:53 +0200348#ifdef MCUBOOT_HW_KEY
349 /* Few extra bytes for encoding and for public exponent. */
350 uint8_t key_buf[SIG_BUF_SIZE + 24];
Christopher Collins92ea77f2016-12-12 15:59:26 -0800351#endif
David Vincze03368b82020-04-01 12:53:53 +0200352#endif /* EXPECTED_SIG_TLV */
Fabio Utzig61fd8882019-09-14 20:00:20 -0300353 struct image_tlv_iter it;
Fabio Utzig3501c012019-05-13 15:07:25 -0700354 uint8_t buf[SIG_BUF_SIZE];
Christopher Collins92ea77f2016-12-12 15:59:26 -0800355 uint8_t hash[32];
Raef Colese8fe6cf2020-05-26 13:07:40 +0100356 int rc = 0;
357 fih_int fih_rc = FIH_FAILURE;
David Vinczec3084132020-02-18 14:50:47 +0100358#ifdef MCUBOOT_HW_ROLLBACK_PROT
Raef Colese8fe6cf2020-05-26 13:07:40 +0100359 fih_int security_cnt = fih_int_encode(INT_MAX);
David Vinczec3084132020-02-18 14:50:47 +0100360 uint32_t img_security_cnt = 0;
Raef Colese8fe6cf2020-05-26 13:07:40 +0100361 fih_int security_counter_valid = FIH_FAILURE;
David Vinczec3084132020-02-18 14:50:47 +0100362#endif
Christopher Collins92ea77f2016-12-12 15:59:26 -0800363
Fabio Utzig10ee6482019-08-01 12:04:52 -0300364 rc = bootutil_img_hash(enc_state, image_index, hdr, fap, tmp_buf,
365 tmp_buf_sz, hash, seed, seed_len);
Christopher Collins92ea77f2016-12-12 15:59:26 -0800366 if (rc) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100367 goto out;
Christopher Collins92ea77f2016-12-12 15:59:26 -0800368 }
369
370 if (out_hash) {
371 memcpy(out_hash, hash, 32);
372 }
373
Fabio Utzig61fd8882019-09-14 20:00:20 -0300374 rc = bootutil_tlv_iter_begin(&it, hdr, fap, IMAGE_TLV_ANY, false);
David Brownf5b33d82017-09-01 10:58:27 -0600375 if (rc) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100376 goto out;
David Brownf5b33d82017-09-01 10:58:27 -0600377 }
Christopher Collins92ea77f2016-12-12 15:59:26 -0800378
David Brown43cda332017-09-01 09:53:23 -0600379 /*
380 * Traverse through all of the TLVs, performing any checks we know
381 * and are able to do.
382 */
Fabio Utzig61fd8882019-09-14 20:00:20 -0300383 while (true) {
384 rc = bootutil_tlv_iter_next(&it, &off, &len, &type);
385 if (rc < 0) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100386 goto out;
Fabio Utzig61fd8882019-09-14 20:00:20 -0300387 } else if (rc > 0) {
388 break;
Christopher Collins92ea77f2016-12-12 15:59:26 -0800389 }
David Brown43cda332017-09-01 09:53:23 -0600390
Fabio Utzig61fd8882019-09-14 20:00:20 -0300391 if (type == IMAGE_TLV_SHA256) {
David Brown43cda332017-09-01 09:53:23 -0600392 /*
393 * Verify the SHA256 image hash. This must always be
394 * present.
395 */
Fabio Utzig61fd8882019-09-14 20:00:20 -0300396 if (len != sizeof(hash)) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100397 rc = -1;
398 goto out;
Christopher Collins92ea77f2016-12-12 15:59:26 -0800399 }
Tamas Banfe031092020-09-10 17:32:39 +0200400 rc = LOAD_IMAGE_DATA(hdr, fap, off, buf, sizeof(hash));
David Brown43cda332017-09-01 09:53:23 -0600401 if (rc) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100402 goto out;
Christopher Collins92ea77f2016-12-12 15:59:26 -0800403 }
Raef Colese8fe6cf2020-05-26 13:07:40 +0100404
405 FIH_CALL(boot_fih_memequal, fih_rc, hash, buf, sizeof(hash));
406 if (fih_not_eq(fih_rc, FIH_SUCCESS)) {
407 goto out;
Christopher Collins92ea77f2016-12-12 15:59:26 -0800408 }
David Brown43cda332017-09-01 09:53:23 -0600409
410 sha256_valid = 1;
411#ifdef EXPECTED_SIG_TLV
David Vincze03368b82020-04-01 12:53:53 +0200412#ifndef MCUBOOT_HW_KEY
Fabio Utzig61fd8882019-09-14 20:00:20 -0300413 } else if (type == IMAGE_TLV_KEYHASH) {
Christopher Collins92ea77f2016-12-12 15:59:26 -0800414 /*
David Brown43cda332017-09-01 09:53:23 -0600415 * Determine which key we should be checking.
Christopher Collins92ea77f2016-12-12 15:59:26 -0800416 */
Fabio Utzig61fd8882019-09-14 20:00:20 -0300417 if (len > 32) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100418 rc = -1;
419 goto out;
David Brown43cda332017-09-01 09:53:23 -0600420 }
Tamas Banfe031092020-09-10 17:32:39 +0200421 rc = LOAD_IMAGE_DATA(hdr, fap, off, buf, len);
David Brown43cda332017-09-01 09:53:23 -0600422 if (rc) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100423 goto out;
David Brown43cda332017-09-01 09:53:23 -0600424 }
Fabio Utzig61fd8882019-09-14 20:00:20 -0300425 key_id = bootutil_find_key(buf, len);
David Brown43cda332017-09-01 09:53:23 -0600426 /*
427 * The key may not be found, which is acceptable. There
428 * can be multiple signatures, each preceded by a key.
429 */
David Vincze03368b82020-04-01 12:53:53 +0200430#else
431 } else if (type == IMAGE_TLV_PUBKEY) {
432 /*
433 * Determine which key we should be checking.
434 */
435 if (len > sizeof(key_buf)) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100436 rc = -1;
437 goto out;
David Vincze03368b82020-04-01 12:53:53 +0200438 }
Tamas Banfe031092020-09-10 17:32:39 +0200439 rc = LOAD_IMAGE_DATA(hdr, fap, off, key_buf, len);
David Vincze03368b82020-04-01 12:53:53 +0200440 if (rc) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100441 goto out;
David Vincze03368b82020-04-01 12:53:53 +0200442 }
443 key_id = bootutil_find_key(image_index, key_buf, len);
444 /*
445 * The key may not be found, which is acceptable. There
446 * can be multiple signatures, each preceded by a key.
447 */
448#endif /* !MCUBOOT_HW_KEY */
Fabio Utzig61fd8882019-09-14 20:00:20 -0300449 } else if (type == EXPECTED_SIG_TLV) {
David Brown43cda332017-09-01 09:53:23 -0600450 /* Ignore this signature if it is out of bounds. */
451 if (key_id < 0 || key_id >= bootutil_key_cnt) {
452 key_id = -1;
453 continue;
454 }
Fabio Utzig61fd8882019-09-14 20:00:20 -0300455 if (!EXPECTED_SIG_LEN(len) || len > sizeof(buf)) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100456 rc = -1;
457 goto out;
David Brown43cda332017-09-01 09:53:23 -0600458 }
Tamas Banfe031092020-09-10 17:32:39 +0200459 rc = LOAD_IMAGE_DATA(hdr, fap, off, buf, len);
David Brown43cda332017-09-01 09:53:23 -0600460 if (rc) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100461 goto out;
David Brown43cda332017-09-01 09:53:23 -0600462 }
Raef Colese8fe6cf2020-05-26 13:07:40 +0100463 FIH_CALL(bootutil_verify_sig, valid_signature, hash, sizeof(hash),
464 buf, len, key_id);
David Brown43cda332017-09-01 09:53:23 -0600465 key_id = -1;
David Vinczec3084132020-02-18 14:50:47 +0100466#endif /* EXPECTED_SIG_TLV */
467#ifdef MCUBOOT_HW_ROLLBACK_PROT
468 } else if (type == IMAGE_TLV_SEC_CNT) {
469 /*
470 * Verify the image's security counter.
471 * This must always be present.
472 */
473 if (len != sizeof(img_security_cnt)) {
474 /* Security counter is not valid. */
Raef Colese8fe6cf2020-05-26 13:07:40 +0100475 rc = -1;
476 goto out;
David Vinczec3084132020-02-18 14:50:47 +0100477 }
478
Tamas Banfe031092020-09-10 17:32:39 +0200479 rc = LOAD_IMAGE_DATA(hdr, fap, off, &img_security_cnt, len);
David Vinczec3084132020-02-18 14:50:47 +0100480 if (rc) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100481 goto out;
David Vinczec3084132020-02-18 14:50:47 +0100482 }
483
Raef Colese8fe6cf2020-05-26 13:07:40 +0100484 FIH_CALL(boot_nv_security_counter_get, fih_rc, image_index,
485 &security_cnt);
486 if (fih_not_eq(fih_rc, FIH_SUCCESS)) {
487 goto out;
David Vinczec3084132020-02-18 14:50:47 +0100488 }
489
490 /* Compare the new image's security counter value against the
491 * stored security counter value.
492 */
Raef Colese8fe6cf2020-05-26 13:07:40 +0100493 fih_rc = fih_int_encode_zero_equality(img_security_cnt <
494 fih_int_decode(security_cnt));
495 if (fih_not_eq(fih_rc, FIH_SUCCESS)) {
496 goto out;
David Vinczec3084132020-02-18 14:50:47 +0100497 }
498
499 /* The image's security counter has been successfully verified. */
Raef Colese8fe6cf2020-05-26 13:07:40 +0100500 security_counter_valid = fih_rc;
David Vinczec3084132020-02-18 14:50:47 +0100501#endif /* MCUBOOT_HW_ROLLBACK_PROT */
Christopher Collins92ea77f2016-12-12 15:59:26 -0800502 }
503 }
David Brown43cda332017-09-01 09:53:23 -0600504
Raef Colese8fe6cf2020-05-26 13:07:40 +0100505 rc = !sha256_valid;
506 if (rc) {
507 goto out;
508 }
David Brown43cda332017-09-01 09:53:23 -0600509#ifdef EXPECTED_SIG_TLV
Raef Colese8fe6cf2020-05-26 13:07:40 +0100510 fih_rc = fih_int_encode_zero_equality(fih_not_eq(valid_signature,
511 FIH_SUCCESS));
Christopher Collins92ea77f2016-12-12 15:59:26 -0800512#endif
David Vinczec3084132020-02-18 14:50:47 +0100513#ifdef MCUBOOT_HW_ROLLBACK_PROT
Raef Colese8fe6cf2020-05-26 13:07:40 +0100514 if (fih_not_eq(security_counter_valid, FIH_SUCCESS)) {
515 rc = -1;
516 goto out;
517 }
David Vinczec3084132020-02-18 14:50:47 +0100518#endif
Raef Colese8fe6cf2020-05-26 13:07:40 +0100519
520out:
521 if (rc) {
522 fih_rc = fih_int_encode(rc);
David Vinczec3084132020-02-18 14:50:47 +0100523 }
David Brown43cda332017-09-01 09:53:23 -0600524
Raef Colese8fe6cf2020-05-26 13:07:40 +0100525 FIH_RET(fih_rc);
Christopher Collins92ea77f2016-12-12 15:59:26 -0800526}