gabor-mezei-arm | d112534 | 2021-07-12 16:31:22 +0200 | [diff] [blame] | 1 | /** |
| 2 | * Constant-time functions |
| 3 | * |
| 4 | * Copyright The Mbed TLS Contributors |
| 5 | * SPDX-License-Identifier: Apache-2.0 |
| 6 | * |
| 7 | * Licensed under the Apache License, Version 2.0 (the "License"); you may |
| 8 | * not use this file except in compliance with the License. |
| 9 | * You may obtain a copy of the License at |
| 10 | * |
| 11 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 12 | * |
| 13 | * Unless required by applicable law or agreed to in writing, software |
| 14 | * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT |
| 15 | * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 16 | * See the License for the specific language governing permissions and |
| 17 | * limitations under the License. |
| 18 | */ |
| 19 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 20 | /* |
Gabor Mezei | 642eeb2 | 2021-11-03 16:13:32 +0100 | [diff] [blame] | 21 | * The following functions are implemented without using comparison operators, as those |
Gabor Mezei | eab90bc | 2021-10-18 16:09:41 +0200 | [diff] [blame] | 22 | * might be translated to branches by some compilers on some platforms. |
| 23 | */ |
| 24 | |
gabor-mezei-arm | d112534 | 2021-07-12 16:31:22 +0200 | [diff] [blame] | 25 | #include "common.h" |
Gabor Mezei | 22c9a6f | 2021-10-20 12:09:35 +0200 | [diff] [blame] | 26 | #include "constant_time_internal.h" |
Gabor Mezei | 765862c | 2021-10-19 12:22:25 +0200 | [diff] [blame] | 27 | #include "mbedtls/constant_time.h" |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 28 | #include "mbedtls/error.h" |
gabor-mezei-arm | 5b3a32d | 2021-09-29 10:50:31 +0200 | [diff] [blame] | 29 | #include "mbedtls/platform_util.h" |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 30 | |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 31 | #if defined(MBEDTLS_BIGNUM_C) |
| 32 | #include "mbedtls/bignum.h" |
Gabor Mezei | 87638a9 | 2022-09-15 20:02:36 +0200 | [diff] [blame] | 33 | #include "bignum_core.h" |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 34 | #endif |
| 35 | |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 36 | #if defined(MBEDTLS_SSL_TLS_C) |
| 37 | #include "ssl_misc.h" |
| 38 | #endif |
| 39 | |
gabor-mezei-arm | 5b3a32d | 2021-09-29 10:50:31 +0200 | [diff] [blame] | 40 | #if defined(MBEDTLS_RSA_C) |
| 41 | #include "mbedtls/rsa.h" |
| 42 | #endif |
| 43 | |
Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 44 | #if defined(MBEDTLS_BASE64_C) |
| 45 | #include "constant_time_invasive.h" |
| 46 | #endif |
| 47 | |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 48 | #include <string.h> |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 49 | |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 50 | /* |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 51 | * Define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS where assembly is present to |
| 52 | * perform fast unaligned access to volatile data. |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 53 | * |
| 54 | * This is needed because mbedtls_get_unaligned_uintXX etc don't support volatile |
| 55 | * memory accesses. |
| 56 | * |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 57 | * Some of these definitions could be moved into alignment.h but for now they are |
| 58 | * only used here. |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 59 | */ |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 60 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS) && defined(MBEDTLS_HAVE_ASM) |
| 61 | #if defined(__arm__) || defined(__thumb__) || defined(__thumb2__) || defined(__aarch64__) |
| 62 | #define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS |
| 63 | #endif |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 64 | #endif |
| 65 | |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 66 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS) |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 67 | static inline uint32_t mbedtls_get_unaligned_volatile_uint32(volatile const unsigned char *p) |
| 68 | { |
| 69 | /* This is UB, even where it's safe: |
| 70 | * return *((volatile uint32_t*)p); |
| 71 | * so instead the same thing is expressed in assembly below. |
| 72 | */ |
| 73 | uint32_t r; |
| 74 | #if defined(__arm__) || defined(__thumb__) || defined(__thumb2__) |
| 75 | asm ("ldr %0, [%1]" : "=r" (r) : "r" (p) :); |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 76 | #elif defined(__aarch64__) |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 77 | asm ("ldr %w0, [%1]" : "=r" (r) : "r" (p) :); |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 78 | #endif |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 79 | return r; |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 80 | } |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 81 | #endif /* MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS */ |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 82 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 83 | int mbedtls_ct_memcmp(const void *a, |
| 84 | const void *b, |
| 85 | size_t n) |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 86 | { |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 87 | size_t i = 0; |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 88 | volatile const unsigned char *A = (volatile const unsigned char *) a; |
| 89 | volatile const unsigned char *B = (volatile const unsigned char *) b; |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 90 | volatile uint32_t diff = 0; |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 91 | |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 92 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS) |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 93 | for (; (i + 4) <= n; i += 4) { |
| 94 | uint32_t x = mbedtls_get_unaligned_volatile_uint32(A + i); |
| 95 | uint32_t y = mbedtls_get_unaligned_volatile_uint32(B + i); |
| 96 | diff |= x ^ y; |
| 97 | } |
| 98 | #endif |
| 99 | |
| 100 | for (; i < n; i++) { |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 101 | /* Read volatile data in order before computing diff. |
| 102 | * This avoids IAR compiler warning: |
| 103 | * 'the order of volatile accesses is undefined ..' */ |
| 104 | unsigned char x = A[i], y = B[i]; |
| 105 | diff |= x ^ y; |
| 106 | } |
| 107 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 108 | return (int) diff; |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 109 | } |
| 110 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 111 | unsigned mbedtls_ct_uint_mask(unsigned value) |
gabor-mezei-arm | 340948e | 2021-09-27 11:40:03 +0200 | [diff] [blame] | 112 | { |
| 113 | /* MSVC has a warning about unary minus on unsigned, but this is |
| 114 | * well-defined and precisely what we want to do here */ |
| 115 | #if defined(_MSC_VER) |
| 116 | #pragma warning( push ) |
| 117 | #pragma warning( disable : 4146 ) |
| 118 | #endif |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 119 | return -((value | -value) >> (sizeof(value) * 8 - 1)); |
gabor-mezei-arm | 340948e | 2021-09-27 11:40:03 +0200 | [diff] [blame] | 120 | #if defined(_MSC_VER) |
| 121 | #pragma warning( pop ) |
| 122 | #endif |
| 123 | } |
gabor-mezei-arm | 3733bf8 | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 124 | |
Przemek Stekiel | 89ad623 | 2022-09-27 13:36:12 +0200 | [diff] [blame] | 125 | #if defined(MBEDTLS_SSL_SOME_SUITES_USE_MAC) |
Gabor Mezei | 6a426c9 | 2021-10-20 11:17:43 +0200 | [diff] [blame] | 126 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 127 | size_t mbedtls_ct_size_mask(size_t value) |
gabor-mezei-arm | 3733bf8 | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 128 | { |
| 129 | /* MSVC has a warning about unary minus on unsigned integer types, |
| 130 | * but this is well-defined and precisely what we want to do here. */ |
| 131 | #if defined(_MSC_VER) |
| 132 | #pragma warning( push ) |
| 133 | #pragma warning( disable : 4146 ) |
| 134 | #endif |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 135 | return -((value | -value) >> (sizeof(value) * 8 - 1)); |
gabor-mezei-arm | 3733bf8 | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 136 | #if defined(_MSC_VER) |
| 137 | #pragma warning( pop ) |
| 138 | #endif |
| 139 | } |
gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 140 | |
Przemek Stekiel | 89ad623 | 2022-09-27 13:36:12 +0200 | [diff] [blame] | 141 | #endif /* MBEDTLS_SSL_SOME_SUITES_USE_MAC */ |
Gabor Mezei | 6a426c9 | 2021-10-20 11:17:43 +0200 | [diff] [blame] | 142 | |
gabor-mezei-arm | 9cb5569 | 2021-08-11 15:07:02 +0200 | [diff] [blame] | 143 | #if defined(MBEDTLS_BIGNUM_C) |
| 144 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 145 | mbedtls_mpi_uint mbedtls_ct_mpi_uint_mask(mbedtls_mpi_uint value) |
gabor-mezei-arm | 9cb5569 | 2021-08-11 15:07:02 +0200 | [diff] [blame] | 146 | { |
| 147 | /* MSVC has a warning about unary minus on unsigned, but this is |
| 148 | * well-defined and precisely what we want to do here */ |
| 149 | #if defined(_MSC_VER) |
| 150 | #pragma warning( push ) |
| 151 | #pragma warning( disable : 4146 ) |
| 152 | #endif |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 153 | return -((value | -value) >> (sizeof(value) * 8 - 1)); |
gabor-mezei-arm | 9cb5569 | 2021-08-11 15:07:02 +0200 | [diff] [blame] | 154 | #if defined(_MSC_VER) |
| 155 | #pragma warning( pop ) |
| 156 | #endif |
| 157 | } |
| 158 | |
| 159 | #endif /* MBEDTLS_BIGNUM_C */ |
| 160 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 161 | #if defined(MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC) |
| 162 | |
Gabor Mezei | 1e64261 | 2021-10-18 16:05:50 +0200 | [diff] [blame] | 163 | /** Constant-flow mask generation for "less than" comparison: |
| 164 | * - if \p x < \p y, return all-bits 1, that is (size_t) -1 |
| 165 | * - otherwise, return all bits 0, that is 0 |
| 166 | * |
| 167 | * This function can be used to write constant-time code by replacing branches |
| 168 | * with bit operations using masks. |
| 169 | * |
| 170 | * \param x The first value to analyze. |
| 171 | * \param y The second value to analyze. |
| 172 | * |
| 173 | * \return All-bits-one if \p x is less than \p y, otherwise zero. |
| 174 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 175 | static size_t mbedtls_ct_size_mask_lt(size_t x, |
| 176 | size_t y) |
gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 177 | { |
| 178 | /* This has the most significant bit set if and only if x < y */ |
| 179 | const size_t sub = x - y; |
| 180 | |
| 181 | /* sub1 = (x < y) ? 1 : 0 */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 182 | const size_t sub1 = sub >> (sizeof(sub) * 8 - 1); |
gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 183 | |
| 184 | /* mask = (x < y) ? 0xff... : 0x00... */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 185 | const size_t mask = mbedtls_ct_size_mask(sub1); |
gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 186 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 187 | return mask; |
gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 188 | } |
gabor-mezei-arm | 16fc57b | 2021-09-27 11:58:31 +0200 | [diff] [blame] | 189 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 190 | size_t mbedtls_ct_size_mask_ge(size_t x, |
| 191 | size_t y) |
gabor-mezei-arm | 16fc57b | 2021-09-27 11:58:31 +0200 | [diff] [blame] | 192 | { |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 193 | return ~mbedtls_ct_size_mask_lt(x, y); |
gabor-mezei-arm | 16fc57b | 2021-09-27 11:58:31 +0200 | [diff] [blame] | 194 | } |
gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 195 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 196 | #endif /* MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC */ |
| 197 | |
Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 198 | #if defined(MBEDTLS_BASE64_C) |
| 199 | |
| 200 | /* Return 0xff if low <= c <= high, 0 otherwise. |
| 201 | * |
| 202 | * Constant flow with respect to c. |
| 203 | */ |
Gabor Mezei | c0d8dda | 2021-11-26 17:20:36 +0100 | [diff] [blame] | 204 | MBEDTLS_STATIC_TESTABLE |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 205 | unsigned char mbedtls_ct_uchar_mask_of_range(unsigned char low, |
| 206 | unsigned char high, |
| 207 | unsigned char c) |
Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 208 | { |
| 209 | /* low_mask is: 0 if low <= c, 0x...ff if low > c */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 210 | unsigned low_mask = ((unsigned) c - low) >> 8; |
Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 211 | /* high_mask is: 0 if c <= high, 0x...ff if c > high */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 212 | unsigned high_mask = ((unsigned) high - c) >> 8; |
| 213 | return ~(low_mask | high_mask) & 0xff; |
Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 214 | } |
| 215 | |
| 216 | #endif /* MBEDTLS_BASE64_C */ |
| 217 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 218 | unsigned mbedtls_ct_size_bool_eq(size_t x, |
| 219 | size_t y) |
gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 220 | { |
| 221 | /* diff = 0 if x == y, non-zero otherwise */ |
| 222 | const size_t diff = x ^ y; |
| 223 | |
| 224 | /* MSVC has a warning about unary minus on unsigned integer types, |
| 225 | * but this is well-defined and precisely what we want to do here. */ |
| 226 | #if defined(_MSC_VER) |
| 227 | #pragma warning( push ) |
| 228 | #pragma warning( disable : 4146 ) |
| 229 | #endif |
| 230 | |
| 231 | /* diff_msb's most significant bit is equal to x != y */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 232 | const size_t diff_msb = (diff | (size_t) -diff); |
gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 233 | |
| 234 | #if defined(_MSC_VER) |
| 235 | #pragma warning( pop ) |
| 236 | #endif |
| 237 | |
| 238 | /* diff1 = (x != y) ? 1 : 0 */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 239 | const unsigned diff1 = diff_msb >> (sizeof(diff_msb) * 8 - 1); |
gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 240 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 241 | return 1 ^ diff1; |
gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 242 | } |
gabor-mezei-arm | 5a85442 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 243 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 244 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) |
| 245 | |
Gabor Mezei | a2d0f90 | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 246 | /** Constant-flow "greater than" comparison: |
| 247 | * return x > y |
| 248 | * |
| 249 | * This is equivalent to \p x > \p y, but is likely to be compiled |
| 250 | * to code using bitwise operation rather than a branch. |
| 251 | * |
| 252 | * \param x The first value to analyze. |
| 253 | * \param y The second value to analyze. |
| 254 | * |
| 255 | * \return 1 if \p x greater than \p y, otherwise 0. |
| 256 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 257 | static unsigned mbedtls_ct_size_gt(size_t x, |
| 258 | size_t y) |
gabor-mezei-arm | 5a85442 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 259 | { |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 260 | /* Return the sign bit (1 for negative) of (y - x). */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 261 | return (y - x) >> (sizeof(size_t) * 8 - 1); |
gabor-mezei-arm | 5a85442 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 262 | } |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 263 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 264 | #endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */ |
| 265 | |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 266 | #if defined(MBEDTLS_BIGNUM_C) |
| 267 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 268 | unsigned mbedtls_ct_mpi_uint_lt(const mbedtls_mpi_uint x, |
| 269 | const mbedtls_mpi_uint y) |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 270 | { |
| 271 | mbedtls_mpi_uint ret; |
| 272 | mbedtls_mpi_uint cond; |
| 273 | |
| 274 | /* |
| 275 | * Check if the most significant bits (MSB) of the operands are different. |
| 276 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 277 | cond = (x ^ y); |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 278 | /* |
| 279 | * If the MSB are the same then the difference x-y will be negative (and |
| 280 | * have its MSB set to 1 during conversion to unsigned) if and only if x<y. |
| 281 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 282 | ret = (x - y) & ~cond; |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 283 | /* |
| 284 | * If the MSB are different, then the operand with the MSB of 1 is the |
| 285 | * bigger. (That is if y has MSB of 1, then x<y is true and it is false if |
| 286 | * the MSB of y is 0.) |
| 287 | */ |
| 288 | ret |= y & cond; |
| 289 | |
| 290 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 291 | ret = ret >> (sizeof(mbedtls_mpi_uint) * 8 - 1); |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 292 | |
| 293 | return (unsigned) ret; |
| 294 | } |
| 295 | |
| 296 | #endif /* MBEDTLS_BIGNUM_C */ |
gabor-mezei-arm | b2dbf2c | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 297 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 298 | unsigned mbedtls_ct_uint_if(unsigned condition, |
| 299 | unsigned if1, |
| 300 | unsigned if0) |
gabor-mezei-arm | b2dbf2c | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 301 | { |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 302 | unsigned mask = mbedtls_ct_uint_mask(condition); |
| 303 | return (mask & if1) | (~mask & if0); |
gabor-mezei-arm | b2dbf2c | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 304 | } |
gabor-mezei-arm | d3230d5 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 305 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 306 | #if defined(MBEDTLS_BIGNUM_C) |
gabor-mezei-arm | 65cefdb | 2021-09-27 15:47:00 +0200 | [diff] [blame] | 307 | |
Gabor Mezei | 642eeb2 | 2021-11-03 16:13:32 +0100 | [diff] [blame] | 308 | /** Select between two sign values without branches. |
Gabor Mezei | a2d0f90 | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 309 | * |
| 310 | * This is functionally equivalent to `condition ? if1 : if0` but uses only bit |
| 311 | * operations in order to avoid branches. |
| 312 | * |
| 313 | * \note if1 and if0 must be either 1 or -1, otherwise the result |
| 314 | * is undefined. |
| 315 | * |
Tom Cosgrove | 583816c | 2022-08-18 14:09:18 +0100 | [diff] [blame] | 316 | * \param condition Condition to test; must be either 0 or 1. |
Gabor Mezei | a2d0f90 | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 317 | * \param if1 The first sign; must be either +1 or -1. |
| 318 | * \param if0 The second sign; must be either +1 or -1. |
| 319 | * |
| 320 | * \return \c if1 if \p condition is nonzero, otherwise \c if0. |
| 321 | * */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 322 | static int mbedtls_ct_cond_select_sign(unsigned char condition, |
| 323 | int if1, |
| 324 | int if0) |
gabor-mezei-arm | d3230d5 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 325 | { |
Gabor Mezei | 642eeb2 | 2021-11-03 16:13:32 +0100 | [diff] [blame] | 326 | /* In order to avoid questions about what we can reasonably assume about |
gabor-mezei-arm | d3230d5 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 327 | * the representations of signed integers, move everything to unsigned |
Gabor Mezei | a316fc8 | 2021-10-18 16:28:27 +0200 | [diff] [blame] | 328 | * by taking advantage of the fact that if1 and if0 are either +1 or -1. */ |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 329 | unsigned uif1 = if1 + 1; |
| 330 | unsigned uif0 = if0 + 1; |
gabor-mezei-arm | d3230d5 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 331 | |
Gabor Mezei | a316fc8 | 2021-10-18 16:28:27 +0200 | [diff] [blame] | 332 | /* condition was 0 or 1, mask is 0 or 2 as are uif1 and uif0 */ |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 333 | const unsigned mask = condition << 1; |
gabor-mezei-arm | d3230d5 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 334 | |
Gabor Mezei | a316fc8 | 2021-10-18 16:28:27 +0200 | [diff] [blame] | 335 | /* select uif1 or uif0 */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 336 | unsigned ur = (uif0 & ~mask) | (uif1 & mask); |
gabor-mezei-arm | d3230d5 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 337 | |
| 338 | /* ur is now 0 or 2, convert back to -1 or +1 */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 339 | return (int) ur - 1; |
gabor-mezei-arm | d3230d5 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 340 | } |
gabor-mezei-arm | be8d98b | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 341 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 342 | void mbedtls_ct_mpi_uint_cond_assign(size_t n, |
| 343 | mbedtls_mpi_uint *dest, |
| 344 | const mbedtls_mpi_uint *src, |
| 345 | unsigned char condition) |
gabor-mezei-arm | be8d98b | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 346 | { |
| 347 | size_t i; |
| 348 | |
| 349 | /* MSVC has a warning about unary minus on unsigned integer types, |
| 350 | * but this is well-defined and precisely what we want to do here. */ |
| 351 | #if defined(_MSC_VER) |
| 352 | #pragma warning( push ) |
| 353 | #pragma warning( disable : 4146 ) |
| 354 | #endif |
| 355 | |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 356 | /* all-bits 1 if condition is 1, all-bits 0 if condition is 0 */ |
| 357 | const mbedtls_mpi_uint mask = -condition; |
gabor-mezei-arm | be8d98b | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 358 | |
| 359 | #if defined(_MSC_VER) |
| 360 | #pragma warning( pop ) |
| 361 | #endif |
| 362 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 363 | for (i = 0; i < n; i++) { |
| 364 | dest[i] = (src[i] & mask) | (dest[i] & ~mask); |
| 365 | } |
gabor-mezei-arm | be8d98b | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 366 | } |
| 367 | |
| 368 | #endif /* MBEDTLS_BIGNUM_C */ |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 369 | |
Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 370 | #if defined(MBEDTLS_BASE64_C) |
| 371 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 372 | unsigned char mbedtls_ct_base64_enc_char(unsigned char value) |
Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 373 | { |
| 374 | unsigned char digit = 0; |
Gabor Mezei | 14d5fac | 2021-11-24 15:51:39 +0100 | [diff] [blame] | 375 | /* For each range of values, if value is in that range, mask digit with |
| 376 | * the corresponding value. Since value can only be in a single range, |
Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 377 | * only at most one masking will change digit. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 378 | digit |= mbedtls_ct_uchar_mask_of_range(0, 25, value) & ('A' + value); |
| 379 | digit |= mbedtls_ct_uchar_mask_of_range(26, 51, value) & ('a' + value - 26); |
| 380 | digit |= mbedtls_ct_uchar_mask_of_range(52, 61, value) & ('0' + value - 52); |
| 381 | digit |= mbedtls_ct_uchar_mask_of_range(62, 62, value) & '+'; |
| 382 | digit |= mbedtls_ct_uchar_mask_of_range(63, 63, value) & '/'; |
| 383 | return digit; |
Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 384 | } |
| 385 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 386 | signed char mbedtls_ct_base64_dec_value(unsigned char c) |
Gabor Mezei | 358829a | 2021-11-15 16:22:37 +0100 | [diff] [blame] | 387 | { |
| 388 | unsigned char val = 0; |
| 389 | /* For each range of digits, if c is in that range, mask val with |
| 390 | * the corresponding value. Since c can only be in a single range, |
| 391 | * only at most one masking will change val. Set val to one plus |
| 392 | * the desired value so that it stays 0 if c is in none of the ranges. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 393 | val |= mbedtls_ct_uchar_mask_of_range('A', 'Z', c) & (c - 'A' + 0 + 1); |
| 394 | val |= mbedtls_ct_uchar_mask_of_range('a', 'z', c) & (c - 'a' + 26 + 1); |
| 395 | val |= mbedtls_ct_uchar_mask_of_range('0', '9', c) & (c - '0' + 52 + 1); |
| 396 | val |= mbedtls_ct_uchar_mask_of_range('+', '+', c) & (c - '+' + 62 + 1); |
| 397 | val |= mbedtls_ct_uchar_mask_of_range('/', '/', c) & (c - '/' + 63 + 1); |
Gabor Mezei | 358829a | 2021-11-15 16:22:37 +0100 | [diff] [blame] | 398 | /* At this point, val is 0 if c is an invalid digit and v+1 if c is |
| 399 | * a digit with the value v. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 400 | return val - 1; |
Gabor Mezei | 358829a | 2021-11-15 16:22:37 +0100 | [diff] [blame] | 401 | } |
| 402 | |
Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 403 | #endif /* MBEDTLS_BASE64_C */ |
| 404 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 405 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) |
| 406 | |
Gabor Mezei | a2d0f90 | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 407 | /** Shift some data towards the left inside a buffer. |
| 408 | * |
Gabor Mezei | 90437e3 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 409 | * `mbedtls_ct_mem_move_to_left(start, total, offset)` is functionally |
Gabor Mezei | a2d0f90 | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 410 | * equivalent to |
| 411 | * ``` |
| 412 | * memmove(start, start + offset, total - offset); |
| 413 | * memset(start + offset, 0, total - offset); |
| 414 | * ``` |
| 415 | * but it strives to use a memory access pattern (and thus total timing) |
| 416 | * that does not depend on \p offset. This timing independence comes at |
| 417 | * the expense of performance. |
| 418 | * |
| 419 | * \param start Pointer to the start of the buffer. |
| 420 | * \param total Total size of the buffer. |
| 421 | * \param offset Offset from which to copy \p total - \p offset bytes. |
| 422 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 423 | static void mbedtls_ct_mem_move_to_left(void *start, |
| 424 | size_t total, |
| 425 | size_t offset) |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 426 | { |
| 427 | volatile unsigned char *buf = start; |
| 428 | size_t i, n; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 429 | if (total == 0) { |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 430 | return; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 431 | } |
| 432 | for (i = 0; i < total; i++) { |
| 433 | unsigned no_op = mbedtls_ct_size_gt(total - offset, i); |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 434 | /* The first `total - offset` passes are a no-op. The last |
| 435 | * `offset` passes shift the data one byte to the left and |
| 436 | * zero out the last byte. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 437 | for (n = 0; n < total - 1; n++) { |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 438 | unsigned char current = buf[n]; |
| 439 | unsigned char next = buf[n+1]; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 440 | buf[n] = mbedtls_ct_uint_if(no_op, current, next); |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 441 | } |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 442 | buf[total-1] = mbedtls_ct_uint_if(no_op, buf[total-1], 0); |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 443 | } |
| 444 | } |
gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 445 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 446 | #endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */ |
| 447 | |
Przemek Stekiel | 89ad623 | 2022-09-27 13:36:12 +0200 | [diff] [blame] | 448 | #if defined(MBEDTLS_SSL_SOME_SUITES_USE_MAC) |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 449 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 450 | void mbedtls_ct_memcpy_if_eq(unsigned char *dest, |
| 451 | const unsigned char *src, |
| 452 | size_t len, |
| 453 | size_t c1, |
| 454 | size_t c2) |
gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 455 | { |
| 456 | /* mask = c1 == c2 ? 0xff : 0x00 */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 457 | const size_t equal = mbedtls_ct_size_bool_eq(c1, c2); |
gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 458 | |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 459 | /* dest[i] = c1 == c2 ? src[i] : dest[i] */ |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 460 | size_t i = 0; |
| 461 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS) |
| 462 | const uint32_t mask32 = (uint32_t) mbedtls_ct_size_mask(equal); |
| 463 | const unsigned char mask = (unsigned char) mask32 & 0xff; |
| 464 | |
| 465 | for (; (i + 4) <= len; i += 4) { |
| 466 | uint32_t a = mbedtls_get_unaligned_uint32(src + i) & mask32; |
| 467 | uint32_t b = mbedtls_get_unaligned_uint32(dest + i) & ~mask32; |
| 468 | mbedtls_put_unaligned_uint32(dest + i, a | b); |
| 469 | } |
| 470 | #else |
| 471 | const unsigned char mask = (unsigned char) mbedtls_ct_size_mask(equal); |
| 472 | #endif /* MBEDTLS_EFFICIENT_UNALIGNED_ACCESS */ |
| 473 | for (; i < len; i++) { |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 474 | dest[i] = (src[i] & mask) | (dest[i] & ~mask); |
| 475 | } |
gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 476 | } |
gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 477 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 478 | void mbedtls_ct_memcpy_offset(unsigned char *dest, |
| 479 | const unsigned char *src, |
| 480 | size_t offset, |
| 481 | size_t offset_min, |
| 482 | size_t offset_max, |
| 483 | size_t len) |
gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 484 | { |
Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 485 | size_t offsetval; |
gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 486 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 487 | for (offsetval = offset_min; offsetval <= offset_max; offsetval++) { |
| 488 | mbedtls_ct_memcpy_if_eq(dest, src + offsetval, len, |
| 489 | offsetval, offset); |
gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 490 | } |
| 491 | } |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 492 | |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 493 | #if defined(MBEDTLS_USE_PSA_CRYPTO) |
Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 494 | |
| 495 | #if defined(PSA_WANT_ALG_SHA_384) |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 496 | #define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_384) |
Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 497 | #elif defined(PSA_WANT_ALG_SHA_256) |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 498 | #define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_256) |
Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 499 | #else /* See check_config.h */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 500 | #define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_1) |
Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 501 | #endif |
| 502 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 503 | int mbedtls_ct_hmac(mbedtls_svc_key_id_t key, |
| 504 | psa_algorithm_t mac_alg, |
| 505 | const unsigned char *add_data, |
| 506 | size_t add_data_len, |
| 507 | const unsigned char *data, |
| 508 | size_t data_len_secret, |
| 509 | size_t min_data_len, |
| 510 | size_t max_data_len, |
| 511 | unsigned char *output) |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 512 | { |
| 513 | /* |
Neil Armstrong | 28d9c63 | 2022-03-17 16:33:27 +0100 | [diff] [blame] | 514 | * This function breaks the HMAC abstraction and uses psa_hash_clone() |
| 515 | * extension in order to get constant-flow behaviour. |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 516 | * |
| 517 | * HMAC(msg) is defined as HASH(okey + HASH(ikey + msg)) where + means |
| 518 | * concatenation, and okey/ikey are the XOR of the key with some fixed bit |
| 519 | * patterns (see RFC 2104, sec. 2). |
| 520 | * |
| 521 | * We'll first compute ikey/okey, then inner_hash = HASH(ikey + msg) by |
| 522 | * hashing up to minlen, then cloning the context, and for each byte up |
| 523 | * to maxlen finishing up the hash computation, keeping only the |
| 524 | * correct result. |
| 525 | * |
| 526 | * Then we only need to compute HASH(okey + inner_hash) and we're done. |
| 527 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 528 | psa_algorithm_t hash_alg = PSA_ALG_HMAC_GET_HASH(mac_alg); |
| 529 | const size_t block_size = PSA_HASH_BLOCK_LENGTH(hash_alg); |
Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 530 | unsigned char key_buf[MAX_HASH_BLOCK_LENGTH]; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 531 | const size_t hash_size = PSA_HASH_LENGTH(hash_alg); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 532 | psa_hash_operation_t operation = PSA_HASH_OPERATION_INIT; |
| 533 | size_t hash_length; |
| 534 | |
Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 535 | unsigned char aux_out[PSA_HASH_MAX_SIZE]; |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 536 | psa_hash_operation_t aux_operation = PSA_HASH_OPERATION_INIT; |
| 537 | size_t offset; |
| 538 | psa_status_t status = PSA_ERROR_CORRUPTION_DETECTED; |
| 539 | |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 540 | size_t mac_key_length; |
| 541 | size_t i; |
| 542 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 543 | #define PSA_CHK(func_call) \ |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 544 | do { \ |
| 545 | status = (func_call); \ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 546 | if (status != PSA_SUCCESS) \ |
| 547 | goto cleanup; \ |
| 548 | } while (0) |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 549 | |
Neil Armstrong | 72c2f76 | 2022-03-17 16:39:10 +0100 | [diff] [blame] | 550 | /* Export MAC key |
| 551 | * We assume key length is always exactly the output size |
| 552 | * which is never more than the block size, thus we use block_size |
| 553 | * as the key buffer size. |
| 554 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 555 | PSA_CHK(psa_export_key(key, key_buf, block_size, &mac_key_length)); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 556 | |
Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 557 | /* Calculate ikey */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 558 | for (i = 0; i < mac_key_length; i++) { |
| 559 | key_buf[i] = (unsigned char) (key_buf[i] ^ 0x36); |
| 560 | } |
| 561 | for (; i < block_size; ++i) { |
Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 562 | key_buf[i] = 0x36; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 563 | } |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 564 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 565 | PSA_CHK(psa_hash_setup(&operation, hash_alg)); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 566 | |
| 567 | /* Now compute inner_hash = HASH(ikey + msg) */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 568 | PSA_CHK(psa_hash_update(&operation, key_buf, block_size)); |
| 569 | PSA_CHK(psa_hash_update(&operation, add_data, add_data_len)); |
| 570 | PSA_CHK(psa_hash_update(&operation, data, min_data_len)); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 571 | |
Paul Elliott | 5260ce2 | 2022-05-09 18:15:54 +0100 | [diff] [blame] | 572 | /* Fill the hash buffer in advance with something that is |
| 573 | * not a valid hash (barring an attack on the hash and |
| 574 | * deliberately-crafted input), in case the caller doesn't |
| 575 | * check the return status properly. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 576 | memset(output, '!', hash_size); |
Paul Elliott | 5260ce2 | 2022-05-09 18:15:54 +0100 | [diff] [blame] | 577 | |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 578 | /* For each possible length, compute the hash up to that point */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 579 | for (offset = min_data_len; offset <= max_data_len; offset++) { |
| 580 | PSA_CHK(psa_hash_clone(&operation, &aux_operation)); |
| 581 | PSA_CHK(psa_hash_finish(&aux_operation, aux_out, |
| 582 | PSA_HASH_MAX_SIZE, &hash_length)); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 583 | /* Keep only the correct inner_hash in the output buffer */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 584 | mbedtls_ct_memcpy_if_eq(output, aux_out, hash_size, |
| 585 | offset, data_len_secret); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 586 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 587 | if (offset < max_data_len) { |
| 588 | PSA_CHK(psa_hash_update(&operation, data + offset, 1)); |
| 589 | } |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 590 | } |
| 591 | |
Neil Armstrong | 28d9c63 | 2022-03-17 16:33:27 +0100 | [diff] [blame] | 592 | /* Abort current operation to prepare for final operation */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 593 | PSA_CHK(psa_hash_abort(&operation)); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 594 | |
Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 595 | /* Calculate okey */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 596 | for (i = 0; i < mac_key_length; i++) { |
| 597 | key_buf[i] = (unsigned char) ((key_buf[i] ^ 0x36) ^ 0x5C); |
| 598 | } |
| 599 | for (; i < block_size; ++i) { |
Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 600 | key_buf[i] = 0x5C; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 601 | } |
Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 602 | |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 603 | /* Now compute HASH(okey + inner_hash) */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 604 | PSA_CHK(psa_hash_setup(&operation, hash_alg)); |
| 605 | PSA_CHK(psa_hash_update(&operation, key_buf, block_size)); |
| 606 | PSA_CHK(psa_hash_update(&operation, output, hash_size)); |
| 607 | PSA_CHK(psa_hash_finish(&operation, output, hash_size, &hash_length)); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 608 | |
| 609 | #undef PSA_CHK |
| 610 | |
| 611 | cleanup: |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 612 | mbedtls_platform_zeroize(key_buf, MAX_HASH_BLOCK_LENGTH); |
| 613 | mbedtls_platform_zeroize(aux_out, PSA_HASH_MAX_SIZE); |
Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 614 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 615 | psa_hash_abort(&operation); |
| 616 | psa_hash_abort(&aux_operation); |
| 617 | return psa_ssl_status_to_mbedtls(status); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 618 | } |
Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 619 | |
| 620 | #undef MAX_HASH_BLOCK_LENGTH |
| 621 | |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 622 | #else |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 623 | int mbedtls_ct_hmac(mbedtls_md_context_t *ctx, |
| 624 | const unsigned char *add_data, |
| 625 | size_t add_data_len, |
| 626 | const unsigned char *data, |
| 627 | size_t data_len_secret, |
| 628 | size_t min_data_len, |
| 629 | size_t max_data_len, |
| 630 | unsigned char *output) |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 631 | { |
| 632 | /* |
| 633 | * This function breaks the HMAC abstraction and uses the md_clone() |
| 634 | * extension to the MD API in order to get constant-flow behaviour. |
| 635 | * |
| 636 | * HMAC(msg) is defined as HASH(okey + HASH(ikey + msg)) where + means |
| 637 | * concatenation, and okey/ikey are the XOR of the key with some fixed bit |
| 638 | * patterns (see RFC 2104, sec. 2), which are stored in ctx->hmac_ctx. |
| 639 | * |
| 640 | * We'll first compute inner_hash = HASH(ikey + msg) by hashing up to |
| 641 | * minlen, then cloning the context, and for each byte up to maxlen |
| 642 | * finishing up the hash computation, keeping only the correct result. |
| 643 | * |
| 644 | * Then we only need to compute HASH(okey + inner_hash) and we're done. |
| 645 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 646 | const mbedtls_md_type_t md_alg = mbedtls_md_get_type(ctx->md_info); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 647 | /* TLS 1.2 only supports SHA-384, SHA-256, SHA-1, MD-5, |
| 648 | * all of which have the same block size except SHA-384. */ |
| 649 | const size_t block_size = md_alg == MBEDTLS_MD_SHA384 ? 128 : 64; |
| 650 | const unsigned char * const ikey = ctx->hmac_ctx; |
| 651 | const unsigned char * const okey = ikey + block_size; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 652 | const size_t hash_size = mbedtls_md_get_size(ctx->md_info); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 653 | |
| 654 | unsigned char aux_out[MBEDTLS_MD_MAX_SIZE]; |
| 655 | mbedtls_md_context_t aux; |
| 656 | size_t offset; |
| 657 | int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED; |
| 658 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 659 | mbedtls_md_init(&aux); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 660 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 661 | #define MD_CHK(func_call) \ |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 662 | do { \ |
| 663 | ret = (func_call); \ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 664 | if (ret != 0) \ |
| 665 | goto cleanup; \ |
| 666 | } while (0) |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 667 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 668 | MD_CHK(mbedtls_md_setup(&aux, ctx->md_info, 0)); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 669 | |
| 670 | /* After hmac_start() of hmac_reset(), ikey has already been hashed, |
| 671 | * so we can start directly with the message */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 672 | MD_CHK(mbedtls_md_update(ctx, add_data, add_data_len)); |
| 673 | MD_CHK(mbedtls_md_update(ctx, data, min_data_len)); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 674 | |
Paul Elliott | 5260ce2 | 2022-05-09 18:15:54 +0100 | [diff] [blame] | 675 | /* Fill the hash buffer in advance with something that is |
| 676 | * not a valid hash (barring an attack on the hash and |
| 677 | * deliberately-crafted input), in case the caller doesn't |
| 678 | * check the return status properly. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 679 | memset(output, '!', hash_size); |
Paul Elliott | 5260ce2 | 2022-05-09 18:15:54 +0100 | [diff] [blame] | 680 | |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 681 | /* For each possible length, compute the hash up to that point */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 682 | for (offset = min_data_len; offset <= max_data_len; offset++) { |
| 683 | MD_CHK(mbedtls_md_clone(&aux, ctx)); |
| 684 | MD_CHK(mbedtls_md_finish(&aux, aux_out)); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 685 | /* Keep only the correct inner_hash in the output buffer */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 686 | mbedtls_ct_memcpy_if_eq(output, aux_out, hash_size, |
| 687 | offset, data_len_secret); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 688 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 689 | if (offset < max_data_len) { |
| 690 | MD_CHK(mbedtls_md_update(ctx, data + offset, 1)); |
| 691 | } |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 692 | } |
| 693 | |
| 694 | /* The context needs to finish() before it starts() again */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 695 | MD_CHK(mbedtls_md_finish(ctx, aux_out)); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 696 | |
| 697 | /* Now compute HASH(okey + inner_hash) */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 698 | MD_CHK(mbedtls_md_starts(ctx)); |
| 699 | MD_CHK(mbedtls_md_update(ctx, okey, block_size)); |
| 700 | MD_CHK(mbedtls_md_update(ctx, output, hash_size)); |
| 701 | MD_CHK(mbedtls_md_finish(ctx, output)); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 702 | |
| 703 | /* Done, get ready for next time */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 704 | MD_CHK(mbedtls_md_hmac_reset(ctx)); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 705 | |
| 706 | #undef MD_CHK |
| 707 | |
| 708 | cleanup: |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 709 | mbedtls_md_free(&aux); |
| 710 | return ret; |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 711 | } |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 712 | #endif /* MBEDTLS_USE_PSA_CRYPTO */ |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 713 | |
Przemek Stekiel | 89ad623 | 2022-09-27 13:36:12 +0200 | [diff] [blame] | 714 | #endif /* MBEDTLS_SSL_SOME_SUITES_USE_MAC */ |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 715 | |
| 716 | #if defined(MBEDTLS_BIGNUM_C) |
| 717 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 718 | #define MPI_VALIDATE_RET(cond) \ |
| 719 | MBEDTLS_INTERNAL_VALIDATE_RET(cond, MBEDTLS_ERR_MPI_BAD_INPUT_DATA) |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 720 | |
| 721 | /* |
| 722 | * Conditionally assign X = Y, without leaking information |
| 723 | * about whether the assignment was made or not. |
| 724 | * (Leaking information about the respective sizes of X and Y is ok however.) |
| 725 | */ |
Tautvydas Žilys | 40fc7da | 2022-01-31 13:34:01 -0800 | [diff] [blame] | 726 | #if defined(_MSC_VER) && defined(_M_ARM64) && (_MSC_FULL_VER < 193131103) |
Tautvydas Žilys | 60165d7 | 2022-01-26 15:33:27 -0800 | [diff] [blame] | 727 | /* |
Tautvydas Žilys | 40fc7da | 2022-01-31 13:34:01 -0800 | [diff] [blame] | 728 | * MSVC miscompiles this function if it's inlined prior to Visual Studio 2022 version 17.1. See: |
Tautvydas Žilys | 60165d7 | 2022-01-26 15:33:27 -0800 | [diff] [blame] | 729 | * https://developercommunity.visualstudio.com/t/c-compiler-miscompiles-part-of-mbedtls-library-on/1646989 |
| 730 | */ |
| 731 | __declspec(noinline) |
| 732 | #endif |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 733 | int mbedtls_mpi_safe_cond_assign(mbedtls_mpi *X, |
| 734 | const mbedtls_mpi *Y, |
| 735 | unsigned char assign) |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 736 | { |
| 737 | int ret = 0; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 738 | MPI_VALIDATE_RET(X != NULL); |
| 739 | MPI_VALIDATE_RET(Y != NULL); |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 740 | |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 741 | /* all-bits 1 if assign is 1, all-bits 0 if assign is 0 */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 742 | mbedtls_mpi_uint limb_mask = mbedtls_ct_mpi_uint_mask(assign); |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 743 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 744 | MBEDTLS_MPI_CHK(mbedtls_mpi_grow(X, Y->n)); |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 745 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 746 | X->s = mbedtls_ct_cond_select_sign(assign, Y->s, X->s); |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 747 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 748 | mbedtls_mpi_core_cond_assign(X->p, Y->p, Y->n, assign); |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 749 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 750 | for (size_t i = Y->n; i < X->n; i++) { |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 751 | X->p[i] &= ~limb_mask; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 752 | } |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 753 | |
| 754 | cleanup: |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 755 | return ret; |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 756 | } |
| 757 | |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 758 | /* |
| 759 | * Conditionally swap X and Y, without leaking information |
| 760 | * about whether the swap was made or not. |
Shaun Case | 8b0ecbc | 2021-12-20 21:14:10 -0800 | [diff] [blame] | 761 | * Here it is not ok to simply swap the pointers, which would lead to |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 762 | * different memory access patterns when X and Y are used afterwards. |
| 763 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 764 | int mbedtls_mpi_safe_cond_swap(mbedtls_mpi *X, |
| 765 | mbedtls_mpi *Y, |
| 766 | unsigned char swap) |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 767 | { |
Gabor Mezei | d7edb1d | 2022-10-10 14:32:09 +0200 | [diff] [blame] | 768 | int ret = 0; |
| 769 | int s; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 770 | MPI_VALIDATE_RET(X != NULL); |
| 771 | MPI_VALIDATE_RET(Y != NULL); |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 772 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 773 | if (X == Y) { |
| 774 | return 0; |
| 775 | } |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 776 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 777 | MBEDTLS_MPI_CHK(mbedtls_mpi_grow(X, Y->n)); |
| 778 | MBEDTLS_MPI_CHK(mbedtls_mpi_grow(Y, X->n)); |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 779 | |
| 780 | s = X->s; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 781 | X->s = mbedtls_ct_cond_select_sign(swap, Y->s, X->s); |
| 782 | Y->s = mbedtls_ct_cond_select_sign(swap, s, Y->s); |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 783 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 784 | mbedtls_mpi_core_cond_swap(X->p, Y->p, X->n, swap); |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 785 | |
| 786 | cleanup: |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 787 | return ret; |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 788 | } |
| 789 | |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 790 | /* |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 791 | * Compare unsigned values in constant time |
| 792 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 793 | unsigned mbedtls_mpi_core_lt_ct(const mbedtls_mpi_uint *A, |
| 794 | const mbedtls_mpi_uint *B, |
| 795 | size_t limbs) |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 796 | { |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 797 | unsigned ret, cond, done; |
| 798 | |
Janos Follath | 6318468 | 2022-08-11 17:42:59 +0100 | [diff] [blame] | 799 | /* The value of any of these variables is either 0 or 1 for the rest of |
| 800 | * their scope. */ |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 801 | ret = cond = done = 0; |
| 802 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 803 | for (size_t i = limbs; i > 0; i--) { |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 804 | /* |
Janos Follath | b7a88ec | 2022-08-19 12:24:40 +0100 | [diff] [blame] | 805 | * If B[i - 1] < A[i - 1] then A < B is false and the result must |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 806 | * remain 0. |
| 807 | * |
| 808 | * Again even if we can make a decision, we just mark the result and |
| 809 | * the fact that we are done and continue looping. |
| 810 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 811 | cond = mbedtls_ct_mpi_uint_lt(B[i - 1], A[i - 1]); |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 812 | done |= cond; |
| 813 | |
| 814 | /* |
Janos Follath | b7a88ec | 2022-08-19 12:24:40 +0100 | [diff] [blame] | 815 | * If A[i - 1] < B[i - 1] then A < B is true. |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 816 | * |
| 817 | * Again even if we can make a decision, we just mark the result and |
| 818 | * the fact that we are done and continue looping. |
| 819 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 820 | cond = mbedtls_ct_mpi_uint_lt(A[i - 1], B[i - 1]); |
| 821 | ret |= cond & (1 - done); |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 822 | done |= cond; |
| 823 | } |
| 824 | |
| 825 | /* |
Janos Follath | b7a88ec | 2022-08-19 12:24:40 +0100 | [diff] [blame] | 826 | * If all the limbs were equal, then the numbers are equal, A < B is false |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 827 | * and leaving the result 0 is correct. |
| 828 | */ |
| 829 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 830 | return ret; |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 831 | } |
| 832 | |
| 833 | /* |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 834 | * Compare signed values in constant time |
| 835 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 836 | int mbedtls_mpi_lt_mpi_ct(const mbedtls_mpi *X, |
| 837 | const mbedtls_mpi *Y, |
| 838 | unsigned *ret) |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 839 | { |
| 840 | size_t i; |
| 841 | /* The value of any of these variables is either 0 or 1 at all times. */ |
| 842 | unsigned cond, done, X_is_negative, Y_is_negative; |
| 843 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 844 | MPI_VALIDATE_RET(X != NULL); |
| 845 | MPI_VALIDATE_RET(Y != NULL); |
| 846 | MPI_VALIDATE_RET(ret != NULL); |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 847 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 848 | if (X->n != Y->n) { |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 849 | return MBEDTLS_ERR_MPI_BAD_INPUT_DATA; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 850 | } |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 851 | |
| 852 | /* |
| 853 | * Set sign_N to 1 if N >= 0, 0 if N < 0. |
| 854 | * We know that N->s == 1 if N >= 0 and N->s == -1 if N < 0. |
| 855 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 856 | X_is_negative = (X->s & 2) >> 1; |
| 857 | Y_is_negative = (Y->s & 2) >> 1; |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 858 | |
| 859 | /* |
| 860 | * If the signs are different, then the positive operand is the bigger. |
| 861 | * That is if X is negative (X_is_negative == 1), then X < Y is true and it |
| 862 | * is false if X is positive (X_is_negative == 0). |
| 863 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 864 | cond = (X_is_negative ^ Y_is_negative); |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 865 | *ret = cond & X_is_negative; |
| 866 | |
| 867 | /* |
| 868 | * This is a constant-time function. We might have the result, but we still |
| 869 | * need to go through the loop. Record if we have the result already. |
| 870 | */ |
| 871 | done = cond; |
| 872 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 873 | for (i = X->n; i > 0; i--) { |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 874 | /* |
| 875 | * If Y->p[i - 1] < X->p[i - 1] then X < Y is true if and only if both |
| 876 | * X and Y are negative. |
| 877 | * |
| 878 | * Again even if we can make a decision, we just mark the result and |
| 879 | * the fact that we are done and continue looping. |
| 880 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 881 | cond = mbedtls_ct_mpi_uint_lt(Y->p[i - 1], X->p[i - 1]); |
| 882 | *ret |= cond & (1 - done) & X_is_negative; |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 883 | done |= cond; |
| 884 | |
| 885 | /* |
| 886 | * If X->p[i - 1] < Y->p[i - 1] then X < Y is true if and only if both |
| 887 | * X and Y are positive. |
| 888 | * |
| 889 | * Again even if we can make a decision, we just mark the result and |
| 890 | * the fact that we are done and continue looping. |
| 891 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 892 | cond = mbedtls_ct_mpi_uint_lt(X->p[i - 1], Y->p[i - 1]); |
| 893 | *ret |= cond & (1 - done) & (1 - X_is_negative); |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 894 | done |= cond; |
| 895 | } |
| 896 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 897 | return 0; |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 898 | } |
| 899 | |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 900 | #endif /* MBEDTLS_BIGNUM_C */ |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 901 | |
| 902 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) |
| 903 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 904 | int mbedtls_ct_rsaes_pkcs1_v15_unpadding(unsigned char *input, |
| 905 | size_t ilen, |
| 906 | unsigned char *output, |
| 907 | size_t output_max_len, |
| 908 | size_t *olen) |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 909 | { |
| 910 | int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED; |
| 911 | size_t i, plaintext_max_size; |
| 912 | |
| 913 | /* The following variables take sensitive values: their value must |
| 914 | * not leak into the observable behavior of the function other than |
| 915 | * the designated outputs (output, olen, return value). Otherwise |
| 916 | * this would open the execution of the function to |
| 917 | * side-channel-based variants of the Bleichenbacher padding oracle |
| 918 | * attack. Potential side channels include overall timing, memory |
| 919 | * access patterns (especially visible to an adversary who has access |
| 920 | * to a shared memory cache), and branches (especially visible to |
| 921 | * an adversary who has access to a shared code cache or to a shared |
| 922 | * branch predictor). */ |
| 923 | size_t pad_count = 0; |
| 924 | unsigned bad = 0; |
| 925 | unsigned char pad_done = 0; |
| 926 | size_t plaintext_size = 0; |
| 927 | unsigned output_too_large; |
| 928 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 929 | plaintext_max_size = (output_max_len > ilen - 11) ? ilen - 11 |
Gabor Mezei | 7013f62 | 2021-10-18 16:12:45 +0200 | [diff] [blame] | 930 | : output_max_len; |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 931 | |
| 932 | /* Check and get padding length in constant time and constant |
| 933 | * memory trace. The first byte must be 0. */ |
Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 934 | bad |= input[0]; |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 935 | |
| 936 | |
| 937 | /* Decode EME-PKCS1-v1_5 padding: 0x00 || 0x02 || PS || 0x00 |
Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 938 | * where PS must be at least 8 nonzero bytes. */ |
| 939 | bad |= input[1] ^ MBEDTLS_RSA_CRYPT; |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 940 | |
| 941 | /* Read the whole buffer. Set pad_done to nonzero if we find |
Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 942 | * the 0x00 byte and remember the padding length in pad_count. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 943 | for (i = 2; i < ilen; i++) { |
| 944 | pad_done |= ((input[i] | (unsigned char) -input[i]) >> 7) ^ 1; |
| 945 | pad_count += ((pad_done | (unsigned char) -pad_done) >> 7) ^ 1; |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 946 | } |
| 947 | |
| 948 | |
| 949 | /* If pad_done is still zero, there's no data, only unfinished padding. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 950 | bad |= mbedtls_ct_uint_if(pad_done, 0, 1); |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 951 | |
| 952 | /* There must be at least 8 bytes of padding. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 953 | bad |= mbedtls_ct_size_gt(8, pad_count); |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 954 | |
| 955 | /* If the padding is valid, set plaintext_size to the number of |
| 956 | * remaining bytes after stripping the padding. If the padding |
| 957 | * is invalid, avoid leaking this fact through the size of the |
| 958 | * output: use the maximum message size that fits in the output |
| 959 | * buffer. Do it without branches to avoid leaking the padding |
| 960 | * validity through timing. RSA keys are small enough that all the |
| 961 | * size_t values involved fit in unsigned int. */ |
Gabor Mezei | 90437e3 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 962 | plaintext_size = mbedtls_ct_uint_if( |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 963 | bad, (unsigned) plaintext_max_size, |
| 964 | (unsigned) (ilen - pad_count - 3)); |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 965 | |
| 966 | /* Set output_too_large to 0 if the plaintext fits in the output |
| 967 | * buffer and to 1 otherwise. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 968 | output_too_large = mbedtls_ct_size_gt(plaintext_size, |
| 969 | plaintext_max_size); |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 970 | |
| 971 | /* Set ret without branches to avoid timing attacks. Return: |
| 972 | * - INVALID_PADDING if the padding is bad (bad != 0). |
| 973 | * - OUTPUT_TOO_LARGE if the padding is good but the decrypted |
| 974 | * plaintext does not fit in the output buffer. |
| 975 | * - 0 if the padding is correct. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 976 | ret = -(int) mbedtls_ct_uint_if( |
| 977 | bad, -MBEDTLS_ERR_RSA_INVALID_PADDING, |
| 978 | mbedtls_ct_uint_if(output_too_large, |
| 979 | -MBEDTLS_ERR_RSA_OUTPUT_TOO_LARGE, |
| 980 | 0)); |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 981 | |
| 982 | /* If the padding is bad or the plaintext is too large, zero the |
| 983 | * data that we're about to copy to the output buffer. |
| 984 | * We need to copy the same amount of data |
| 985 | * from the same buffer whether the padding is good or not to |
| 986 | * avoid leaking the padding validity through overall timing or |
| 987 | * through memory or cache access patterns. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 988 | bad = mbedtls_ct_uint_mask(bad | output_too_large); |
| 989 | for (i = 11; i < ilen; i++) { |
Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 990 | input[i] &= ~bad; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 991 | } |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 992 | |
| 993 | /* If the plaintext is too large, truncate it to the buffer size. |
| 994 | * Copy anyway to avoid revealing the length through timing, because |
| 995 | * revealing the length is as bad as revealing the padding validity |
| 996 | * for a Bleichenbacher attack. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 997 | plaintext_size = mbedtls_ct_uint_if(output_too_large, |
| 998 | (unsigned) plaintext_max_size, |
| 999 | (unsigned) plaintext_size); |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 1000 | |
| 1001 | /* Move the plaintext to the leftmost position where it can start in |
| 1002 | * the working buffer, i.e. make it start plaintext_max_size from |
| 1003 | * the end of the buffer. Do this with a memory access trace that |
| 1004 | * does not depend on the plaintext size. After this move, the |
| 1005 | * starting location of the plaintext is no longer sensitive |
| 1006 | * information. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 1007 | mbedtls_ct_mem_move_to_left(input + ilen - plaintext_max_size, |
| 1008 | plaintext_max_size, |
| 1009 | plaintext_max_size - plaintext_size); |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 1010 | |
| 1011 | /* Finally copy the decrypted plaintext plus trailing zeros into the output |
| 1012 | * buffer. If output_max_len is 0, then output may be an invalid pointer |
| 1013 | * and the result of memcpy() would be undefined; prevent undefined |
| 1014 | * behavior making sure to depend only on output_max_len (the size of the |
| 1015 | * user-provided output buffer), which is independent from plaintext |
| 1016 | * length, validity of padding, success of the decryption, and other |
| 1017 | * secrets. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 1018 | if (output_max_len != 0) { |
| 1019 | memcpy(output, input + ilen - plaintext_max_size, plaintext_max_size); |
| 1020 | } |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 1021 | |
| 1022 | /* Report the amount of data we copied to the output buffer. In case |
| 1023 | * of errors (bad padding or output too large), the value of *olen |
| 1024 | * when this function returns is not specified. Making it equivalent |
| 1025 | * to the good case limits the risks of leaking the padding validity. */ |
| 1026 | *olen = plaintext_size; |
| 1027 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 1028 | return ret; |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 1029 | } |
| 1030 | |
| 1031 | #endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */ |