gabor-mezei-arm | d112534 | 2021-07-12 16:31:22 +0200 | [diff] [blame] | 1 | /** |
| 2 | * Constant-time functions |
| 3 | * |
| 4 | * Copyright The Mbed TLS Contributors |
| 5 | * SPDX-License-Identifier: Apache-2.0 |
| 6 | * |
| 7 | * Licensed under the Apache License, Version 2.0 (the "License"); you may |
| 8 | * not use this file except in compliance with the License. |
| 9 | * You may obtain a copy of the License at |
| 10 | * |
| 11 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 12 | * |
| 13 | * Unless required by applicable law or agreed to in writing, software |
| 14 | * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT |
| 15 | * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 16 | * See the License for the specific language governing permissions and |
| 17 | * limitations under the License. |
| 18 | */ |
| 19 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 20 | /* |
Gabor Mezei | 642eeb2 | 2021-11-03 16:13:32 +0100 | [diff] [blame] | 21 | * The following functions are implemented without using comparison operators, as those |
Gabor Mezei | eab90bc | 2021-10-18 16:09:41 +0200 | [diff] [blame] | 22 | * might be translated to branches by some compilers on some platforms. |
| 23 | */ |
| 24 | |
gabor-mezei-arm | d112534 | 2021-07-12 16:31:22 +0200 | [diff] [blame] | 25 | #include "common.h" |
Gabor Mezei | 22c9a6f | 2021-10-20 12:09:35 +0200 | [diff] [blame] | 26 | #include "constant_time_internal.h" |
Gabor Mezei | 765862c | 2021-10-19 12:22:25 +0200 | [diff] [blame] | 27 | #include "mbedtls/constant_time.h" |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 28 | #include "mbedtls/error.h" |
gabor-mezei-arm | 5b3a32d | 2021-09-29 10:50:31 +0200 | [diff] [blame] | 29 | #include "mbedtls/platform_util.h" |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 30 | |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 31 | #if defined(MBEDTLS_BIGNUM_C) |
| 32 | #include "mbedtls/bignum.h" |
Gabor Mezei | 87638a9 | 2022-09-15 20:02:36 +0200 | [diff] [blame] | 33 | #include "bignum_core.h" |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 34 | #endif |
| 35 | |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 36 | #if defined(MBEDTLS_SSL_TLS_C) |
| 37 | #include "ssl_misc.h" |
| 38 | #endif |
| 39 | |
gabor-mezei-arm | 5b3a32d | 2021-09-29 10:50:31 +0200 | [diff] [blame] | 40 | #if defined(MBEDTLS_RSA_C) |
| 41 | #include "mbedtls/rsa.h" |
| 42 | #endif |
| 43 | |
Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 44 | #if defined(MBEDTLS_BASE64_C) |
| 45 | #include "constant_time_invasive.h" |
| 46 | #endif |
| 47 | |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 48 | #include <string.h> |
Andrzej Kurek | 8a045ce | 2022-12-23 11:00:06 -0500 | [diff] [blame] | 49 | #if defined(MBEDTLS_USE_PSA_CRYPTO) |
| 50 | #define PSA_TO_MBEDTLS_ERR(status) PSA_TO_MBEDTLS_ERR_LIST(status, \ |
| 51 | psa_to_ssl_errors, \ |
| 52 | psa_generic_status_to_mbedtls) |
| 53 | #endif |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 54 | |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 55 | /* |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 56 | * Define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS where assembly is present to |
| 57 | * perform fast unaligned access to volatile data. |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 58 | * |
| 59 | * This is needed because mbedtls_get_unaligned_uintXX etc don't support volatile |
| 60 | * memory accesses. |
| 61 | * |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 62 | * Some of these definitions could be moved into alignment.h but for now they are |
| 63 | * only used here. |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 64 | */ |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 65 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS) && defined(MBEDTLS_HAVE_ASM) |
Dave Rodgman | c54f25e | 2023-06-21 13:39:30 +0100 | [diff] [blame] | 66 | #if ((defined(__arm__) || defined(__thumb__) || defined(__thumb2__)) && \ |
| 67 | (UINTPTR_MAX == 0xfffffffful)) || \ |
| 68 | (defined(__aarch64__) && ((UINTPTR_MAX == 0xffffffffull) || \ |
| 69 | (UINTPTR_MAX == 0xffffffffffffffffull))) |
Dave Rodgman | 63e89b4 | 2023-06-21 11:55:17 +0100 | [diff] [blame] | 70 | /* We check pointer sizes to avoid issues with them not matching register size requirements */ |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 71 | #define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS |
| 72 | #endif |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 73 | #endif |
| 74 | |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 75 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS) |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 76 | static inline uint32_t mbedtls_get_unaligned_volatile_uint32(volatile const unsigned char *p) |
| 77 | { |
| 78 | /* This is UB, even where it's safe: |
| 79 | * return *((volatile uint32_t*)p); |
| 80 | * so instead the same thing is expressed in assembly below. |
| 81 | */ |
| 82 | uint32_t r; |
| 83 | #if defined(__arm__) || defined(__thumb__) || defined(__thumb2__) |
Dave Rodgman | 4610d4b | 2023-01-30 09:26:48 +0000 | [diff] [blame] | 84 | asm volatile ("ldr %0, [%1]" : "=r" (r) : "r" (p) :); |
Dave Rodgman | 04cb9ac | 2023-06-21 07:32:22 +0100 | [diff] [blame] | 85 | #elif defined(__aarch64__) |
Dave Rodgman | 0400ae2 | 2023-06-21 16:14:46 +0100 | [diff] [blame^] | 86 | asm volatile ("ldr %w0, [%1]" : "=r" (r) : MBEDTLS_ASM_AARCH64_PTR_CONSTRAINT (p) :); |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 87 | #endif |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 88 | return r; |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 89 | } |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 90 | #endif /* MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS */ |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 91 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 92 | int mbedtls_ct_memcmp(const void *a, |
| 93 | const void *b, |
| 94 | size_t n) |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 95 | { |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 96 | size_t i = 0; |
Dave Rodgman | 7658b63 | 2023-01-11 17:39:33 +0000 | [diff] [blame] | 97 | /* |
| 98 | * `A` and `B` are cast to volatile to ensure that the compiler |
| 99 | * generates code that always fully reads both buffers. |
| 100 | * Otherwise it could generate a test to exit early if `diff` has all |
| 101 | * bits set early in the loop. |
| 102 | */ |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 103 | volatile const unsigned char *A = (volatile const unsigned char *) a; |
| 104 | volatile const unsigned char *B = (volatile const unsigned char *) b; |
Dave Rodgman | 7658b63 | 2023-01-11 17:39:33 +0000 | [diff] [blame] | 105 | uint32_t diff = 0; |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 106 | |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 107 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS) |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 108 | for (; (i + 4) <= n; i += 4) { |
| 109 | uint32_t x = mbedtls_get_unaligned_volatile_uint32(A + i); |
| 110 | uint32_t y = mbedtls_get_unaligned_volatile_uint32(B + i); |
| 111 | diff |= x ^ y; |
| 112 | } |
| 113 | #endif |
| 114 | |
| 115 | for (; i < n; i++) { |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 116 | /* Read volatile data in order before computing diff. |
| 117 | * This avoids IAR compiler warning: |
| 118 | * 'the order of volatile accesses is undefined ..' */ |
| 119 | unsigned char x = A[i], y = B[i]; |
| 120 | diff |= x ^ y; |
| 121 | } |
| 122 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 123 | return (int) diff; |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 124 | } |
| 125 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 126 | unsigned mbedtls_ct_uint_mask(unsigned value) |
gabor-mezei-arm | 340948e | 2021-09-27 11:40:03 +0200 | [diff] [blame] | 127 | { |
| 128 | /* MSVC has a warning about unary minus on unsigned, but this is |
| 129 | * well-defined and precisely what we want to do here */ |
| 130 | #if defined(_MSC_VER) |
| 131 | #pragma warning( push ) |
| 132 | #pragma warning( disable : 4146 ) |
| 133 | #endif |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 134 | return -((value | -value) >> (sizeof(value) * 8 - 1)); |
gabor-mezei-arm | 340948e | 2021-09-27 11:40:03 +0200 | [diff] [blame] | 135 | #if defined(_MSC_VER) |
| 136 | #pragma warning( pop ) |
| 137 | #endif |
| 138 | } |
gabor-mezei-arm | 3733bf8 | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 139 | |
Przemek Stekiel | 89ad623 | 2022-09-27 13:36:12 +0200 | [diff] [blame] | 140 | #if defined(MBEDTLS_SSL_SOME_SUITES_USE_MAC) |
Gabor Mezei | 6a426c9 | 2021-10-20 11:17:43 +0200 | [diff] [blame] | 141 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 142 | size_t mbedtls_ct_size_mask(size_t value) |
gabor-mezei-arm | 3733bf8 | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 143 | { |
| 144 | /* MSVC has a warning about unary minus on unsigned integer types, |
| 145 | * but this is well-defined and precisely what we want to do here. */ |
| 146 | #if defined(_MSC_VER) |
| 147 | #pragma warning( push ) |
| 148 | #pragma warning( disable : 4146 ) |
| 149 | #endif |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 150 | return -((value | -value) >> (sizeof(value) * 8 - 1)); |
gabor-mezei-arm | 3733bf8 | 2021-09-27 11:49:42 +0200 | [diff] [blame] | 151 | #if defined(_MSC_VER) |
| 152 | #pragma warning( pop ) |
| 153 | #endif |
| 154 | } |
gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 155 | |
Przemek Stekiel | 89ad623 | 2022-09-27 13:36:12 +0200 | [diff] [blame] | 156 | #endif /* MBEDTLS_SSL_SOME_SUITES_USE_MAC */ |
Gabor Mezei | 6a426c9 | 2021-10-20 11:17:43 +0200 | [diff] [blame] | 157 | |
gabor-mezei-arm | 9cb5569 | 2021-08-11 15:07:02 +0200 | [diff] [blame] | 158 | #if defined(MBEDTLS_BIGNUM_C) |
| 159 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 160 | mbedtls_mpi_uint mbedtls_ct_mpi_uint_mask(mbedtls_mpi_uint value) |
gabor-mezei-arm | 9cb5569 | 2021-08-11 15:07:02 +0200 | [diff] [blame] | 161 | { |
| 162 | /* MSVC has a warning about unary minus on unsigned, but this is |
| 163 | * well-defined and precisely what we want to do here */ |
| 164 | #if defined(_MSC_VER) |
| 165 | #pragma warning( push ) |
| 166 | #pragma warning( disable : 4146 ) |
| 167 | #endif |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 168 | return -((value | -value) >> (sizeof(value) * 8 - 1)); |
gabor-mezei-arm | 9cb5569 | 2021-08-11 15:07:02 +0200 | [diff] [blame] | 169 | #if defined(_MSC_VER) |
| 170 | #pragma warning( pop ) |
| 171 | #endif |
| 172 | } |
| 173 | |
| 174 | #endif /* MBEDTLS_BIGNUM_C */ |
| 175 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 176 | #if defined(MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC) |
| 177 | |
Gabor Mezei | 1e64261 | 2021-10-18 16:05:50 +0200 | [diff] [blame] | 178 | /** Constant-flow mask generation for "less than" comparison: |
| 179 | * - if \p x < \p y, return all-bits 1, that is (size_t) -1 |
| 180 | * - otherwise, return all bits 0, that is 0 |
| 181 | * |
| 182 | * This function can be used to write constant-time code by replacing branches |
| 183 | * with bit operations using masks. |
| 184 | * |
| 185 | * \param x The first value to analyze. |
| 186 | * \param y The second value to analyze. |
| 187 | * |
| 188 | * \return All-bits-one if \p x is less than \p y, otherwise zero. |
| 189 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 190 | static size_t mbedtls_ct_size_mask_lt(size_t x, |
| 191 | size_t y) |
gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 192 | { |
| 193 | /* This has the most significant bit set if and only if x < y */ |
| 194 | const size_t sub = x - y; |
| 195 | |
| 196 | /* sub1 = (x < y) ? 1 : 0 */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 197 | const size_t sub1 = sub >> (sizeof(sub) * 8 - 1); |
gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 198 | |
| 199 | /* mask = (x < y) ? 0xff... : 0x00... */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 200 | const size_t mask = mbedtls_ct_size_mask(sub1); |
gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 201 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 202 | return mask; |
gabor-mezei-arm | c76227d | 2021-09-27 11:53:54 +0200 | [diff] [blame] | 203 | } |
gabor-mezei-arm | 16fc57b | 2021-09-27 11:58:31 +0200 | [diff] [blame] | 204 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 205 | size_t mbedtls_ct_size_mask_ge(size_t x, |
| 206 | size_t y) |
gabor-mezei-arm | 16fc57b | 2021-09-27 11:58:31 +0200 | [diff] [blame] | 207 | { |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 208 | return ~mbedtls_ct_size_mask_lt(x, y); |
gabor-mezei-arm | 16fc57b | 2021-09-27 11:58:31 +0200 | [diff] [blame] | 209 | } |
gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 210 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 211 | #endif /* MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC */ |
| 212 | |
Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 213 | #if defined(MBEDTLS_BASE64_C) |
| 214 | |
| 215 | /* Return 0xff if low <= c <= high, 0 otherwise. |
| 216 | * |
| 217 | * Constant flow with respect to c. |
| 218 | */ |
Gabor Mezei | c0d8dda | 2021-11-26 17:20:36 +0100 | [diff] [blame] | 219 | MBEDTLS_STATIC_TESTABLE |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 220 | unsigned char mbedtls_ct_uchar_mask_of_range(unsigned char low, |
| 221 | unsigned char high, |
| 222 | unsigned char c) |
Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 223 | { |
| 224 | /* low_mask is: 0 if low <= c, 0x...ff if low > c */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 225 | unsigned low_mask = ((unsigned) c - low) >> 8; |
Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 226 | /* high_mask is: 0 if c <= high, 0x...ff if c > high */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 227 | unsigned high_mask = ((unsigned) high - c) >> 8; |
| 228 | return ~(low_mask | high_mask) & 0xff; |
Gabor Mezei | 28d6115 | 2021-11-15 16:13:01 +0100 | [diff] [blame] | 229 | } |
| 230 | |
| 231 | #endif /* MBEDTLS_BASE64_C */ |
| 232 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 233 | unsigned mbedtls_ct_size_bool_eq(size_t x, |
| 234 | size_t y) |
gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 235 | { |
| 236 | /* diff = 0 if x == y, non-zero otherwise */ |
| 237 | const size_t diff = x ^ y; |
| 238 | |
| 239 | /* MSVC has a warning about unary minus on unsigned integer types, |
| 240 | * but this is well-defined and precisely what we want to do here. */ |
| 241 | #if defined(_MSC_VER) |
| 242 | #pragma warning( push ) |
| 243 | #pragma warning( disable : 4146 ) |
| 244 | #endif |
| 245 | |
| 246 | /* diff_msb's most significant bit is equal to x != y */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 247 | const size_t diff_msb = (diff | (size_t) -diff); |
gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 248 | |
| 249 | #if defined(_MSC_VER) |
| 250 | #pragma warning( pop ) |
| 251 | #endif |
| 252 | |
| 253 | /* diff1 = (x != y) ? 1 : 0 */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 254 | const unsigned diff1 = diff_msb >> (sizeof(diff_msb) * 8 - 1); |
gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 255 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 256 | return 1 ^ diff1; |
gabor-mezei-arm | 8d1d5fd | 2021-09-27 12:15:19 +0200 | [diff] [blame] | 257 | } |
gabor-mezei-arm | 5a85442 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 258 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 259 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) |
| 260 | |
Gabor Mezei | a2d0f90 | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 261 | /** Constant-flow "greater than" comparison: |
| 262 | * return x > y |
| 263 | * |
| 264 | * This is equivalent to \p x > \p y, but is likely to be compiled |
| 265 | * to code using bitwise operation rather than a branch. |
| 266 | * |
| 267 | * \param x The first value to analyze. |
| 268 | * \param y The second value to analyze. |
| 269 | * |
| 270 | * \return 1 if \p x greater than \p y, otherwise 0. |
| 271 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 272 | static unsigned mbedtls_ct_size_gt(size_t x, |
| 273 | size_t y) |
gabor-mezei-arm | 5a85442 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 274 | { |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 275 | /* Return the sign bit (1 for negative) of (y - x). */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 276 | return (y - x) >> (sizeof(size_t) * 8 - 1); |
gabor-mezei-arm | 5a85442 | 2021-09-27 12:25:07 +0200 | [diff] [blame] | 277 | } |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 278 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 279 | #endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */ |
| 280 | |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 281 | #if defined(MBEDTLS_BIGNUM_C) |
| 282 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 283 | unsigned mbedtls_ct_mpi_uint_lt(const mbedtls_mpi_uint x, |
| 284 | const mbedtls_mpi_uint y) |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 285 | { |
| 286 | mbedtls_mpi_uint ret; |
| 287 | mbedtls_mpi_uint cond; |
| 288 | |
| 289 | /* |
| 290 | * Check if the most significant bits (MSB) of the operands are different. |
| 291 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 292 | cond = (x ^ y); |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 293 | /* |
| 294 | * If the MSB are the same then the difference x-y will be negative (and |
| 295 | * have its MSB set to 1 during conversion to unsigned) if and only if x<y. |
| 296 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 297 | ret = (x - y) & ~cond; |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 298 | /* |
| 299 | * If the MSB are different, then the operand with the MSB of 1 is the |
| 300 | * bigger. (That is if y has MSB of 1, then x<y is true and it is false if |
| 301 | * the MSB of y is 0.) |
| 302 | */ |
| 303 | ret |= y & cond; |
| 304 | |
| 305 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 306 | ret = ret >> (sizeof(mbedtls_mpi_uint) * 8 - 1); |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 307 | |
| 308 | return (unsigned) ret; |
| 309 | } |
| 310 | |
| 311 | #endif /* MBEDTLS_BIGNUM_C */ |
gabor-mezei-arm | b2dbf2c | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 312 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 313 | unsigned mbedtls_ct_uint_if(unsigned condition, |
| 314 | unsigned if1, |
| 315 | unsigned if0) |
gabor-mezei-arm | b2dbf2c | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 316 | { |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 317 | unsigned mask = mbedtls_ct_uint_mask(condition); |
| 318 | return (mask & if1) | (~mask & if0); |
gabor-mezei-arm | b2dbf2c | 2021-09-27 12:59:30 +0200 | [diff] [blame] | 319 | } |
gabor-mezei-arm | d3230d5 | 2021-09-27 13:03:57 +0200 | [diff] [blame] | 320 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 321 | #if defined(MBEDTLS_BIGNUM_C) |
gabor-mezei-arm | 65cefdb | 2021-09-27 15:47:00 +0200 | [diff] [blame] | 322 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 323 | void mbedtls_ct_mpi_uint_cond_assign(size_t n, |
| 324 | mbedtls_mpi_uint *dest, |
| 325 | const mbedtls_mpi_uint *src, |
| 326 | unsigned char condition) |
gabor-mezei-arm | be8d98b | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 327 | { |
| 328 | size_t i; |
| 329 | |
| 330 | /* MSVC has a warning about unary minus on unsigned integer types, |
| 331 | * but this is well-defined and precisely what we want to do here. */ |
| 332 | #if defined(_MSC_VER) |
| 333 | #pragma warning( push ) |
| 334 | #pragma warning( disable : 4146 ) |
| 335 | #endif |
| 336 | |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 337 | /* all-bits 1 if condition is 1, all-bits 0 if condition is 0 */ |
| 338 | const mbedtls_mpi_uint mask = -condition; |
gabor-mezei-arm | be8d98b | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 339 | |
| 340 | #if defined(_MSC_VER) |
| 341 | #pragma warning( pop ) |
| 342 | #endif |
| 343 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 344 | for (i = 0; i < n; i++) { |
| 345 | dest[i] = (src[i] & mask) | (dest[i] & ~mask); |
| 346 | } |
gabor-mezei-arm | be8d98b | 2021-09-27 13:17:15 +0200 | [diff] [blame] | 347 | } |
| 348 | |
| 349 | #endif /* MBEDTLS_BIGNUM_C */ |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 350 | |
Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 351 | #if defined(MBEDTLS_BASE64_C) |
| 352 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 353 | unsigned char mbedtls_ct_base64_enc_char(unsigned char value) |
Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 354 | { |
| 355 | unsigned char digit = 0; |
Gabor Mezei | 14d5fac | 2021-11-24 15:51:39 +0100 | [diff] [blame] | 356 | /* For each range of values, if value is in that range, mask digit with |
| 357 | * the corresponding value. Since value can only be in a single range, |
Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 358 | * only at most one masking will change digit. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 359 | digit |= mbedtls_ct_uchar_mask_of_range(0, 25, value) & ('A' + value); |
| 360 | digit |= mbedtls_ct_uchar_mask_of_range(26, 51, value) & ('a' + value - 26); |
| 361 | digit |= mbedtls_ct_uchar_mask_of_range(52, 61, value) & ('0' + value - 52); |
| 362 | digit |= mbedtls_ct_uchar_mask_of_range(62, 62, value) & '+'; |
| 363 | digit |= mbedtls_ct_uchar_mask_of_range(63, 63, value) & '/'; |
| 364 | return digit; |
Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 365 | } |
| 366 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 367 | signed char mbedtls_ct_base64_dec_value(unsigned char c) |
Gabor Mezei | 358829a | 2021-11-15 16:22:37 +0100 | [diff] [blame] | 368 | { |
| 369 | unsigned char val = 0; |
| 370 | /* For each range of digits, if c is in that range, mask val with |
| 371 | * the corresponding value. Since c can only be in a single range, |
| 372 | * only at most one masking will change val. Set val to one plus |
| 373 | * the desired value so that it stays 0 if c is in none of the ranges. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 374 | val |= mbedtls_ct_uchar_mask_of_range('A', 'Z', c) & (c - 'A' + 0 + 1); |
| 375 | val |= mbedtls_ct_uchar_mask_of_range('a', 'z', c) & (c - 'a' + 26 + 1); |
| 376 | val |= mbedtls_ct_uchar_mask_of_range('0', '9', c) & (c - '0' + 52 + 1); |
| 377 | val |= mbedtls_ct_uchar_mask_of_range('+', '+', c) & (c - '+' + 62 + 1); |
| 378 | val |= mbedtls_ct_uchar_mask_of_range('/', '/', c) & (c - '/' + 63 + 1); |
Gabor Mezei | 358829a | 2021-11-15 16:22:37 +0100 | [diff] [blame] | 379 | /* At this point, val is 0 if c is an invalid digit and v+1 if c is |
| 380 | * a digit with the value v. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 381 | return val - 1; |
Gabor Mezei | 358829a | 2021-11-15 16:22:37 +0100 | [diff] [blame] | 382 | } |
| 383 | |
Gabor Mezei | 9a4074a | 2021-11-15 16:18:54 +0100 | [diff] [blame] | 384 | #endif /* MBEDTLS_BASE64_C */ |
| 385 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 386 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) |
| 387 | |
Gabor Mezei | a2d0f90 | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 388 | /** Shift some data towards the left inside a buffer. |
| 389 | * |
Gabor Mezei | 90437e3 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 390 | * `mbedtls_ct_mem_move_to_left(start, total, offset)` is functionally |
Gabor Mezei | a2d0f90 | 2021-10-18 16:35:23 +0200 | [diff] [blame] | 391 | * equivalent to |
| 392 | * ``` |
| 393 | * memmove(start, start + offset, total - offset); |
| 394 | * memset(start + offset, 0, total - offset); |
| 395 | * ``` |
| 396 | * but it strives to use a memory access pattern (and thus total timing) |
| 397 | * that does not depend on \p offset. This timing independence comes at |
| 398 | * the expense of performance. |
| 399 | * |
| 400 | * \param start Pointer to the start of the buffer. |
| 401 | * \param total Total size of the buffer. |
| 402 | * \param offset Offset from which to copy \p total - \p offset bytes. |
| 403 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 404 | static void mbedtls_ct_mem_move_to_left(void *start, |
| 405 | size_t total, |
| 406 | size_t offset) |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 407 | { |
| 408 | volatile unsigned char *buf = start; |
| 409 | size_t i, n; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 410 | if (total == 0) { |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 411 | return; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 412 | } |
| 413 | for (i = 0; i < total; i++) { |
| 414 | unsigned no_op = mbedtls_ct_size_gt(total - offset, i); |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 415 | /* The first `total - offset` passes are a no-op. The last |
| 416 | * `offset` passes shift the data one byte to the left and |
| 417 | * zero out the last byte. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 418 | for (n = 0; n < total - 1; n++) { |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 419 | unsigned char current = buf[n]; |
| 420 | unsigned char next = buf[n+1]; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 421 | buf[n] = mbedtls_ct_uint_if(no_op, current, next); |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 422 | } |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 423 | buf[total-1] = mbedtls_ct_uint_if(no_op, buf[total-1], 0); |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 424 | } |
| 425 | } |
gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 426 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 427 | #endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */ |
| 428 | |
Przemek Stekiel | 89ad623 | 2022-09-27 13:36:12 +0200 | [diff] [blame] | 429 | #if defined(MBEDTLS_SSL_SOME_SUITES_USE_MAC) |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 430 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 431 | void mbedtls_ct_memcpy_if_eq(unsigned char *dest, |
| 432 | const unsigned char *src, |
| 433 | size_t len, |
| 434 | size_t c1, |
| 435 | size_t c2) |
gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 436 | { |
| 437 | /* mask = c1 == c2 ? 0xff : 0x00 */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 438 | const size_t equal = mbedtls_ct_size_bool_eq(c1, c2); |
gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 439 | |
gabor-mezei-arm | 87ac5be | 2021-08-10 20:36:09 +0200 | [diff] [blame] | 440 | /* dest[i] = c1 == c2 ? src[i] : dest[i] */ |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 441 | size_t i = 0; |
| 442 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS) |
| 443 | const uint32_t mask32 = (uint32_t) mbedtls_ct_size_mask(equal); |
| 444 | const unsigned char mask = (unsigned char) mask32 & 0xff; |
| 445 | |
| 446 | for (; (i + 4) <= len; i += 4) { |
| 447 | uint32_t a = mbedtls_get_unaligned_uint32(src + i) & mask32; |
| 448 | uint32_t b = mbedtls_get_unaligned_uint32(dest + i) & ~mask32; |
| 449 | mbedtls_put_unaligned_uint32(dest + i, a | b); |
| 450 | } |
| 451 | #else |
| 452 | const unsigned char mask = (unsigned char) mbedtls_ct_size_mask(equal); |
| 453 | #endif /* MBEDTLS_EFFICIENT_UNALIGNED_ACCESS */ |
| 454 | for (; i < len; i++) { |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 455 | dest[i] = (src[i] & mask) | (dest[i] & ~mask); |
| 456 | } |
gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 457 | } |
gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 458 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 459 | void mbedtls_ct_memcpy_offset(unsigned char *dest, |
| 460 | const unsigned char *src, |
| 461 | size_t offset, |
| 462 | size_t offset_min, |
| 463 | size_t offset_max, |
| 464 | size_t len) |
gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 465 | { |
Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 466 | size_t offsetval; |
gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 467 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 468 | for (offsetval = offset_min; offsetval <= offset_max; offsetval++) { |
| 469 | mbedtls_ct_memcpy_if_eq(dest, src + offsetval, len, |
| 470 | offsetval, offset); |
gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 471 | } |
| 472 | } |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 473 | |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 474 | #if defined(MBEDTLS_USE_PSA_CRYPTO) |
Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 475 | |
| 476 | #if defined(PSA_WANT_ALG_SHA_384) |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 477 | #define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_384) |
Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 478 | #elif defined(PSA_WANT_ALG_SHA_256) |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 479 | #define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_256) |
Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 480 | #else /* See check_config.h */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 481 | #define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_1) |
Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 482 | #endif |
| 483 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 484 | int mbedtls_ct_hmac(mbedtls_svc_key_id_t key, |
| 485 | psa_algorithm_t mac_alg, |
| 486 | const unsigned char *add_data, |
| 487 | size_t add_data_len, |
| 488 | const unsigned char *data, |
| 489 | size_t data_len_secret, |
| 490 | size_t min_data_len, |
| 491 | size_t max_data_len, |
| 492 | unsigned char *output) |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 493 | { |
| 494 | /* |
Neil Armstrong | 28d9c63 | 2022-03-17 16:33:27 +0100 | [diff] [blame] | 495 | * This function breaks the HMAC abstraction and uses psa_hash_clone() |
| 496 | * extension in order to get constant-flow behaviour. |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 497 | * |
| 498 | * HMAC(msg) is defined as HASH(okey + HASH(ikey + msg)) where + means |
| 499 | * concatenation, and okey/ikey are the XOR of the key with some fixed bit |
| 500 | * patterns (see RFC 2104, sec. 2). |
| 501 | * |
| 502 | * We'll first compute ikey/okey, then inner_hash = HASH(ikey + msg) by |
| 503 | * hashing up to minlen, then cloning the context, and for each byte up |
| 504 | * to maxlen finishing up the hash computation, keeping only the |
| 505 | * correct result. |
| 506 | * |
| 507 | * Then we only need to compute HASH(okey + inner_hash) and we're done. |
| 508 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 509 | psa_algorithm_t hash_alg = PSA_ALG_HMAC_GET_HASH(mac_alg); |
| 510 | const size_t block_size = PSA_HASH_BLOCK_LENGTH(hash_alg); |
Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 511 | unsigned char key_buf[MAX_HASH_BLOCK_LENGTH]; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 512 | const size_t hash_size = PSA_HASH_LENGTH(hash_alg); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 513 | psa_hash_operation_t operation = PSA_HASH_OPERATION_INIT; |
| 514 | size_t hash_length; |
| 515 | |
Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 516 | unsigned char aux_out[PSA_HASH_MAX_SIZE]; |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 517 | psa_hash_operation_t aux_operation = PSA_HASH_OPERATION_INIT; |
| 518 | size_t offset; |
| 519 | psa_status_t status = PSA_ERROR_CORRUPTION_DETECTED; |
| 520 | |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 521 | size_t mac_key_length; |
| 522 | size_t i; |
| 523 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 524 | #define PSA_CHK(func_call) \ |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 525 | do { \ |
| 526 | status = (func_call); \ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 527 | if (status != PSA_SUCCESS) \ |
| 528 | goto cleanup; \ |
| 529 | } while (0) |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 530 | |
Neil Armstrong | 72c2f76 | 2022-03-17 16:39:10 +0100 | [diff] [blame] | 531 | /* Export MAC key |
| 532 | * We assume key length is always exactly the output size |
| 533 | * which is never more than the block size, thus we use block_size |
| 534 | * as the key buffer size. |
| 535 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 536 | PSA_CHK(psa_export_key(key, key_buf, block_size, &mac_key_length)); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 537 | |
Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 538 | /* Calculate ikey */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 539 | for (i = 0; i < mac_key_length; i++) { |
| 540 | key_buf[i] = (unsigned char) (key_buf[i] ^ 0x36); |
| 541 | } |
| 542 | for (; i < block_size; ++i) { |
Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 543 | key_buf[i] = 0x36; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 544 | } |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 545 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 546 | PSA_CHK(psa_hash_setup(&operation, hash_alg)); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 547 | |
| 548 | /* Now compute inner_hash = HASH(ikey + msg) */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 549 | PSA_CHK(psa_hash_update(&operation, key_buf, block_size)); |
| 550 | PSA_CHK(psa_hash_update(&operation, add_data, add_data_len)); |
| 551 | PSA_CHK(psa_hash_update(&operation, data, min_data_len)); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 552 | |
Paul Elliott | 5260ce2 | 2022-05-09 18:15:54 +0100 | [diff] [blame] | 553 | /* Fill the hash buffer in advance with something that is |
| 554 | * not a valid hash (barring an attack on the hash and |
| 555 | * deliberately-crafted input), in case the caller doesn't |
| 556 | * check the return status properly. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 557 | memset(output, '!', hash_size); |
Paul Elliott | 5260ce2 | 2022-05-09 18:15:54 +0100 | [diff] [blame] | 558 | |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 559 | /* For each possible length, compute the hash up to that point */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 560 | for (offset = min_data_len; offset <= max_data_len; offset++) { |
| 561 | PSA_CHK(psa_hash_clone(&operation, &aux_operation)); |
| 562 | PSA_CHK(psa_hash_finish(&aux_operation, aux_out, |
| 563 | PSA_HASH_MAX_SIZE, &hash_length)); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 564 | /* Keep only the correct inner_hash in the output buffer */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 565 | mbedtls_ct_memcpy_if_eq(output, aux_out, hash_size, |
| 566 | offset, data_len_secret); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 567 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 568 | if (offset < max_data_len) { |
| 569 | PSA_CHK(psa_hash_update(&operation, data + offset, 1)); |
| 570 | } |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 571 | } |
| 572 | |
Neil Armstrong | 28d9c63 | 2022-03-17 16:33:27 +0100 | [diff] [blame] | 573 | /* Abort current operation to prepare for final operation */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 574 | PSA_CHK(psa_hash_abort(&operation)); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 575 | |
Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 576 | /* Calculate okey */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 577 | for (i = 0; i < mac_key_length; i++) { |
| 578 | key_buf[i] = (unsigned char) ((key_buf[i] ^ 0x36) ^ 0x5C); |
| 579 | } |
| 580 | for (; i < block_size; ++i) { |
Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 581 | key_buf[i] = 0x5C; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 582 | } |
Neil Armstrong | 9ebb9ff | 2022-03-17 17:04:37 +0100 | [diff] [blame] | 583 | |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 584 | /* Now compute HASH(okey + inner_hash) */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 585 | PSA_CHK(psa_hash_setup(&operation, hash_alg)); |
| 586 | PSA_CHK(psa_hash_update(&operation, key_buf, block_size)); |
| 587 | PSA_CHK(psa_hash_update(&operation, output, hash_size)); |
| 588 | PSA_CHK(psa_hash_finish(&operation, output, hash_size, &hash_length)); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 589 | |
| 590 | #undef PSA_CHK |
| 591 | |
| 592 | cleanup: |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 593 | mbedtls_platform_zeroize(key_buf, MAX_HASH_BLOCK_LENGTH); |
| 594 | mbedtls_platform_zeroize(aux_out, PSA_HASH_MAX_SIZE); |
Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 595 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 596 | psa_hash_abort(&operation); |
| 597 | psa_hash_abort(&aux_operation); |
Andrzej Kurek | 8a045ce | 2022-12-23 11:00:06 -0500 | [diff] [blame] | 598 | return PSA_TO_MBEDTLS_ERR(status); |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 599 | } |
Neil Armstrong | 36cc13b | 2022-03-17 16:36:52 +0100 | [diff] [blame] | 600 | |
| 601 | #undef MAX_HASH_BLOCK_LENGTH |
| 602 | |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 603 | #else |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 604 | int mbedtls_ct_hmac(mbedtls_md_context_t *ctx, |
| 605 | const unsigned char *add_data, |
| 606 | size_t add_data_len, |
| 607 | const unsigned char *data, |
| 608 | size_t data_len_secret, |
| 609 | size_t min_data_len, |
| 610 | size_t max_data_len, |
| 611 | unsigned char *output) |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 612 | { |
| 613 | /* |
| 614 | * This function breaks the HMAC abstraction and uses the md_clone() |
| 615 | * extension to the MD API in order to get constant-flow behaviour. |
| 616 | * |
| 617 | * HMAC(msg) is defined as HASH(okey + HASH(ikey + msg)) where + means |
| 618 | * concatenation, and okey/ikey are the XOR of the key with some fixed bit |
| 619 | * patterns (see RFC 2104, sec. 2), which are stored in ctx->hmac_ctx. |
| 620 | * |
| 621 | * We'll first compute inner_hash = HASH(ikey + msg) by hashing up to |
| 622 | * minlen, then cloning the context, and for each byte up to maxlen |
| 623 | * finishing up the hash computation, keeping only the correct result. |
| 624 | * |
| 625 | * Then we only need to compute HASH(okey + inner_hash) and we're done. |
| 626 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 627 | const mbedtls_md_type_t md_alg = mbedtls_md_get_type(ctx->md_info); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 628 | /* TLS 1.2 only supports SHA-384, SHA-256, SHA-1, MD-5, |
| 629 | * all of which have the same block size except SHA-384. */ |
| 630 | const size_t block_size = md_alg == MBEDTLS_MD_SHA384 ? 128 : 64; |
| 631 | const unsigned char * const ikey = ctx->hmac_ctx; |
| 632 | const unsigned char * const okey = ikey + block_size; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 633 | const size_t hash_size = mbedtls_md_get_size(ctx->md_info); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 634 | |
| 635 | unsigned char aux_out[MBEDTLS_MD_MAX_SIZE]; |
| 636 | mbedtls_md_context_t aux; |
| 637 | size_t offset; |
| 638 | int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED; |
| 639 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 640 | mbedtls_md_init(&aux); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 641 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 642 | #define MD_CHK(func_call) \ |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 643 | do { \ |
| 644 | ret = (func_call); \ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 645 | if (ret != 0) \ |
| 646 | goto cleanup; \ |
| 647 | } while (0) |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 648 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 649 | MD_CHK(mbedtls_md_setup(&aux, ctx->md_info, 0)); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 650 | |
| 651 | /* After hmac_start() of hmac_reset(), ikey has already been hashed, |
| 652 | * so we can start directly with the message */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 653 | MD_CHK(mbedtls_md_update(ctx, add_data, add_data_len)); |
| 654 | MD_CHK(mbedtls_md_update(ctx, data, min_data_len)); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 655 | |
Paul Elliott | 5260ce2 | 2022-05-09 18:15:54 +0100 | [diff] [blame] | 656 | /* Fill the hash buffer in advance with something that is |
| 657 | * not a valid hash (barring an attack on the hash and |
| 658 | * deliberately-crafted input), in case the caller doesn't |
| 659 | * check the return status properly. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 660 | memset(output, '!', hash_size); |
Paul Elliott | 5260ce2 | 2022-05-09 18:15:54 +0100 | [diff] [blame] | 661 | |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 662 | /* For each possible length, compute the hash up to that point */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 663 | for (offset = min_data_len; offset <= max_data_len; offset++) { |
| 664 | MD_CHK(mbedtls_md_clone(&aux, ctx)); |
| 665 | MD_CHK(mbedtls_md_finish(&aux, aux_out)); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 666 | /* Keep only the correct inner_hash in the output buffer */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 667 | mbedtls_ct_memcpy_if_eq(output, aux_out, hash_size, |
| 668 | offset, data_len_secret); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 669 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 670 | if (offset < max_data_len) { |
| 671 | MD_CHK(mbedtls_md_update(ctx, data + offset, 1)); |
| 672 | } |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 673 | } |
| 674 | |
| 675 | /* The context needs to finish() before it starts() again */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 676 | MD_CHK(mbedtls_md_finish(ctx, aux_out)); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 677 | |
| 678 | /* Now compute HASH(okey + inner_hash) */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 679 | MD_CHK(mbedtls_md_starts(ctx)); |
| 680 | MD_CHK(mbedtls_md_update(ctx, okey, block_size)); |
| 681 | MD_CHK(mbedtls_md_update(ctx, output, hash_size)); |
| 682 | MD_CHK(mbedtls_md_finish(ctx, output)); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 683 | |
| 684 | /* Done, get ready for next time */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 685 | MD_CHK(mbedtls_md_hmac_reset(ctx)); |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 686 | |
| 687 | #undef MD_CHK |
| 688 | |
| 689 | cleanup: |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 690 | mbedtls_md_free(&aux); |
| 691 | return ret; |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 692 | } |
Neil Armstrong | 2968d30 | 2022-02-25 15:09:36 +0100 | [diff] [blame] | 693 | #endif /* MBEDTLS_USE_PSA_CRYPTO */ |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 694 | |
Przemek Stekiel | 89ad623 | 2022-09-27 13:36:12 +0200 | [diff] [blame] | 695 | #endif /* MBEDTLS_SSL_SOME_SUITES_USE_MAC */ |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 696 | |
| 697 | #if defined(MBEDTLS_BIGNUM_C) |
| 698 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 699 | #define MPI_VALIDATE_RET(cond) \ |
| 700 | MBEDTLS_INTERNAL_VALIDATE_RET(cond, MBEDTLS_ERR_MPI_BAD_INPUT_DATA) |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 701 | |
| 702 | /* |
| 703 | * Conditionally assign X = Y, without leaking information |
| 704 | * about whether the assignment was made or not. |
| 705 | * (Leaking information about the respective sizes of X and Y is ok however.) |
| 706 | */ |
Tautvydas Žilys | 40fc7da | 2022-01-31 13:34:01 -0800 | [diff] [blame] | 707 | #if defined(_MSC_VER) && defined(_M_ARM64) && (_MSC_FULL_VER < 193131103) |
Tautvydas Žilys | 60165d7 | 2022-01-26 15:33:27 -0800 | [diff] [blame] | 708 | /* |
Tautvydas Žilys | 40fc7da | 2022-01-31 13:34:01 -0800 | [diff] [blame] | 709 | * MSVC miscompiles this function if it's inlined prior to Visual Studio 2022 version 17.1. See: |
Tautvydas Žilys | 60165d7 | 2022-01-26 15:33:27 -0800 | [diff] [blame] | 710 | * https://developercommunity.visualstudio.com/t/c-compiler-miscompiles-part-of-mbedtls-library-on/1646989 |
| 711 | */ |
| 712 | __declspec(noinline) |
| 713 | #endif |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 714 | int mbedtls_mpi_safe_cond_assign(mbedtls_mpi *X, |
| 715 | const mbedtls_mpi *Y, |
| 716 | unsigned char assign) |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 717 | { |
| 718 | int ret = 0; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 719 | MPI_VALIDATE_RET(X != NULL); |
| 720 | MPI_VALIDATE_RET(Y != NULL); |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 721 | |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 722 | /* all-bits 1 if assign is 1, all-bits 0 if assign is 0 */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 723 | mbedtls_mpi_uint limb_mask = mbedtls_ct_mpi_uint_mask(assign); |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 724 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 725 | MBEDTLS_MPI_CHK(mbedtls_mpi_grow(X, Y->n)); |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 726 | |
Tom Cosgrove | e22413c | 2023-05-03 09:44:01 +0100 | [diff] [blame] | 727 | X->s = (int) mbedtls_ct_uint_if(assign, Y->s, X->s); |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 728 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 729 | mbedtls_mpi_core_cond_assign(X->p, Y->p, Y->n, assign); |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 730 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 731 | for (size_t i = Y->n; i < X->n; i++) { |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 732 | X->p[i] &= ~limb_mask; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 733 | } |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 734 | |
| 735 | cleanup: |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 736 | return ret; |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 737 | } |
| 738 | |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 739 | /* |
| 740 | * Conditionally swap X and Y, without leaking information |
| 741 | * about whether the swap was made or not. |
Shaun Case | 8b0ecbc | 2021-12-20 21:14:10 -0800 | [diff] [blame] | 742 | * Here it is not ok to simply swap the pointers, which would lead to |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 743 | * different memory access patterns when X and Y are used afterwards. |
| 744 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 745 | int mbedtls_mpi_safe_cond_swap(mbedtls_mpi *X, |
| 746 | mbedtls_mpi *Y, |
| 747 | unsigned char swap) |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 748 | { |
Gabor Mezei | d7edb1d | 2022-10-10 14:32:09 +0200 | [diff] [blame] | 749 | int ret = 0; |
| 750 | int s; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 751 | MPI_VALIDATE_RET(X != NULL); |
| 752 | MPI_VALIDATE_RET(Y != NULL); |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 753 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 754 | if (X == Y) { |
| 755 | return 0; |
| 756 | } |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 757 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 758 | MBEDTLS_MPI_CHK(mbedtls_mpi_grow(X, Y->n)); |
| 759 | MBEDTLS_MPI_CHK(mbedtls_mpi_grow(Y, X->n)); |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 760 | |
| 761 | s = X->s; |
Tom Cosgrove | e22413c | 2023-05-03 09:44:01 +0100 | [diff] [blame] | 762 | X->s = (int) mbedtls_ct_uint_if(swap, Y->s, X->s); |
| 763 | Y->s = (int) mbedtls_ct_uint_if(swap, s, Y->s); |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 764 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 765 | mbedtls_mpi_core_cond_swap(X->p, Y->p, X->n, swap); |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 766 | |
| 767 | cleanup: |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 768 | return ret; |
gabor-mezei-arm | 5c97621 | 2021-09-27 15:37:50 +0200 | [diff] [blame] | 769 | } |
| 770 | |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 771 | /* |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 772 | * Compare unsigned values in constant time |
| 773 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 774 | unsigned mbedtls_mpi_core_lt_ct(const mbedtls_mpi_uint *A, |
| 775 | const mbedtls_mpi_uint *B, |
| 776 | size_t limbs) |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 777 | { |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 778 | unsigned ret, cond, done; |
| 779 | |
Janos Follath | 6318468 | 2022-08-11 17:42:59 +0100 | [diff] [blame] | 780 | /* The value of any of these variables is either 0 or 1 for the rest of |
| 781 | * their scope. */ |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 782 | ret = cond = done = 0; |
| 783 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 784 | for (size_t i = limbs; i > 0; i--) { |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 785 | /* |
Janos Follath | b7a88ec | 2022-08-19 12:24:40 +0100 | [diff] [blame] | 786 | * If B[i - 1] < A[i - 1] then A < B is false and the result must |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 787 | * remain 0. |
| 788 | * |
| 789 | * Again even if we can make a decision, we just mark the result and |
| 790 | * the fact that we are done and continue looping. |
| 791 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 792 | cond = mbedtls_ct_mpi_uint_lt(B[i - 1], A[i - 1]); |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 793 | done |= cond; |
| 794 | |
| 795 | /* |
Janos Follath | b7a88ec | 2022-08-19 12:24:40 +0100 | [diff] [blame] | 796 | * If A[i - 1] < B[i - 1] then A < B is true. |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 797 | * |
| 798 | * Again even if we can make a decision, we just mark the result and |
| 799 | * the fact that we are done and continue looping. |
| 800 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 801 | cond = mbedtls_ct_mpi_uint_lt(A[i - 1], B[i - 1]); |
| 802 | ret |= cond & (1 - done); |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 803 | done |= cond; |
| 804 | } |
| 805 | |
| 806 | /* |
Janos Follath | b7a88ec | 2022-08-19 12:24:40 +0100 | [diff] [blame] | 807 | * If all the limbs were equal, then the numbers are equal, A < B is false |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 808 | * and leaving the result 0 is correct. |
| 809 | */ |
| 810 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 811 | return ret; |
Janos Follath | 23bdeca | 2022-07-22 18:24:06 +0100 | [diff] [blame] | 812 | } |
| 813 | |
| 814 | /* |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 815 | * Compare signed values in constant time |
| 816 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 817 | int mbedtls_mpi_lt_mpi_ct(const mbedtls_mpi *X, |
| 818 | const mbedtls_mpi *Y, |
| 819 | unsigned *ret) |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 820 | { |
| 821 | size_t i; |
| 822 | /* The value of any of these variables is either 0 or 1 at all times. */ |
| 823 | unsigned cond, done, X_is_negative, Y_is_negative; |
| 824 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 825 | MPI_VALIDATE_RET(X != NULL); |
| 826 | MPI_VALIDATE_RET(Y != NULL); |
| 827 | MPI_VALIDATE_RET(ret != NULL); |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 828 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 829 | if (X->n != Y->n) { |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 830 | return MBEDTLS_ERR_MPI_BAD_INPUT_DATA; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 831 | } |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 832 | |
| 833 | /* |
| 834 | * Set sign_N to 1 if N >= 0, 0 if N < 0. |
| 835 | * We know that N->s == 1 if N >= 0 and N->s == -1 if N < 0. |
| 836 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 837 | X_is_negative = (X->s & 2) >> 1; |
| 838 | Y_is_negative = (Y->s & 2) >> 1; |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 839 | |
| 840 | /* |
| 841 | * If the signs are different, then the positive operand is the bigger. |
| 842 | * That is if X is negative (X_is_negative == 1), then X < Y is true and it |
| 843 | * is false if X is positive (X_is_negative == 0). |
| 844 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 845 | cond = (X_is_negative ^ Y_is_negative); |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 846 | *ret = cond & X_is_negative; |
| 847 | |
| 848 | /* |
| 849 | * This is a constant-time function. We might have the result, but we still |
| 850 | * need to go through the loop. Record if we have the result already. |
| 851 | */ |
| 852 | done = cond; |
| 853 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 854 | for (i = X->n; i > 0; i--) { |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 855 | /* |
| 856 | * If Y->p[i - 1] < X->p[i - 1] then X < Y is true if and only if both |
| 857 | * X and Y are negative. |
| 858 | * |
| 859 | * Again even if we can make a decision, we just mark the result and |
| 860 | * the fact that we are done and continue looping. |
| 861 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 862 | cond = mbedtls_ct_mpi_uint_lt(Y->p[i - 1], X->p[i - 1]); |
| 863 | *ret |= cond & (1 - done) & X_is_negative; |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 864 | done |= cond; |
| 865 | |
| 866 | /* |
| 867 | * If X->p[i - 1] < Y->p[i - 1] then X < Y is true if and only if both |
| 868 | * X and Y are positive. |
| 869 | * |
| 870 | * Again even if we can make a decision, we just mark the result and |
| 871 | * the fact that we are done and continue looping. |
| 872 | */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 873 | cond = mbedtls_ct_mpi_uint_lt(X->p[i - 1], Y->p[i - 1]); |
| 874 | *ret |= cond & (1 - done) & (1 - X_is_negative); |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 875 | done |= cond; |
| 876 | } |
| 877 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 878 | return 0; |
gabor-mezei-arm | c29a3da | 2021-09-27 15:41:30 +0200 | [diff] [blame] | 879 | } |
| 880 | |
gabor-mezei-arm | 40a4925 | 2021-09-27 15:33:35 +0200 | [diff] [blame] | 881 | #endif /* MBEDTLS_BIGNUM_C */ |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 882 | |
| 883 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) |
| 884 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 885 | int mbedtls_ct_rsaes_pkcs1_v15_unpadding(unsigned char *input, |
| 886 | size_t ilen, |
| 887 | unsigned char *output, |
| 888 | size_t output_max_len, |
| 889 | size_t *olen) |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 890 | { |
| 891 | int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED; |
| 892 | size_t i, plaintext_max_size; |
| 893 | |
| 894 | /* The following variables take sensitive values: their value must |
| 895 | * not leak into the observable behavior of the function other than |
| 896 | * the designated outputs (output, olen, return value). Otherwise |
| 897 | * this would open the execution of the function to |
| 898 | * side-channel-based variants of the Bleichenbacher padding oracle |
| 899 | * attack. Potential side channels include overall timing, memory |
| 900 | * access patterns (especially visible to an adversary who has access |
| 901 | * to a shared memory cache), and branches (especially visible to |
| 902 | * an adversary who has access to a shared code cache or to a shared |
| 903 | * branch predictor). */ |
| 904 | size_t pad_count = 0; |
| 905 | unsigned bad = 0; |
| 906 | unsigned char pad_done = 0; |
| 907 | size_t plaintext_size = 0; |
| 908 | unsigned output_too_large; |
| 909 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 910 | plaintext_max_size = (output_max_len > ilen - 11) ? ilen - 11 |
Gabor Mezei | 7013f62 | 2021-10-18 16:12:45 +0200 | [diff] [blame] | 911 | : output_max_len; |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 912 | |
| 913 | /* Check and get padding length in constant time and constant |
| 914 | * memory trace. The first byte must be 0. */ |
Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 915 | bad |= input[0]; |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 916 | |
| 917 | |
| 918 | /* Decode EME-PKCS1-v1_5 padding: 0x00 || 0x02 || PS || 0x00 |
Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 919 | * where PS must be at least 8 nonzero bytes. */ |
| 920 | bad |= input[1] ^ MBEDTLS_RSA_CRYPT; |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 921 | |
| 922 | /* Read the whole buffer. Set pad_done to nonzero if we find |
Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 923 | * the 0x00 byte and remember the padding length in pad_count. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 924 | for (i = 2; i < ilen; i++) { |
| 925 | pad_done |= ((input[i] | (unsigned char) -input[i]) >> 7) ^ 1; |
| 926 | pad_count += ((pad_done | (unsigned char) -pad_done) >> 7) ^ 1; |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 927 | } |
| 928 | |
| 929 | |
| 930 | /* If pad_done is still zero, there's no data, only unfinished padding. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 931 | bad |= mbedtls_ct_uint_if(pad_done, 0, 1); |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 932 | |
| 933 | /* There must be at least 8 bytes of padding. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 934 | bad |= mbedtls_ct_size_gt(8, pad_count); |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 935 | |
| 936 | /* If the padding is valid, set plaintext_size to the number of |
| 937 | * remaining bytes after stripping the padding. If the padding |
| 938 | * is invalid, avoid leaking this fact through the size of the |
| 939 | * output: use the maximum message size that fits in the output |
| 940 | * buffer. Do it without branches to avoid leaking the padding |
| 941 | * validity through timing. RSA keys are small enough that all the |
| 942 | * size_t values involved fit in unsigned int. */ |
Gabor Mezei | 90437e3 | 2021-10-20 11:59:27 +0200 | [diff] [blame] | 943 | plaintext_size = mbedtls_ct_uint_if( |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 944 | bad, (unsigned) plaintext_max_size, |
| 945 | (unsigned) (ilen - pad_count - 3)); |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 946 | |
| 947 | /* Set output_too_large to 0 if the plaintext fits in the output |
| 948 | * buffer and to 1 otherwise. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 949 | output_too_large = mbedtls_ct_size_gt(plaintext_size, |
| 950 | plaintext_max_size); |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 951 | |
| 952 | /* Set ret without branches to avoid timing attacks. Return: |
| 953 | * - INVALID_PADDING if the padding is bad (bad != 0). |
| 954 | * - OUTPUT_TOO_LARGE if the padding is good but the decrypted |
| 955 | * plaintext does not fit in the output buffer. |
| 956 | * - 0 if the padding is correct. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 957 | ret = -(int) mbedtls_ct_uint_if( |
| 958 | bad, -MBEDTLS_ERR_RSA_INVALID_PADDING, |
| 959 | mbedtls_ct_uint_if(output_too_large, |
| 960 | -MBEDTLS_ERR_RSA_OUTPUT_TOO_LARGE, |
| 961 | 0)); |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 962 | |
| 963 | /* If the padding is bad or the plaintext is too large, zero the |
| 964 | * data that we're about to copy to the output buffer. |
| 965 | * We need to copy the same amount of data |
| 966 | * from the same buffer whether the padding is good or not to |
| 967 | * avoid leaking the padding validity through overall timing or |
| 968 | * through memory or cache access patterns. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 969 | bad = mbedtls_ct_uint_mask(bad | output_too_large); |
| 970 | for (i = 11; i < ilen; i++) { |
Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 971 | input[i] &= ~bad; |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 972 | } |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 973 | |
| 974 | /* If the plaintext is too large, truncate it to the buffer size. |
| 975 | * Copy anyway to avoid revealing the length through timing, because |
| 976 | * revealing the length is as bad as revealing the padding validity |
| 977 | * for a Bleichenbacher attack. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 978 | plaintext_size = mbedtls_ct_uint_if(output_too_large, |
| 979 | (unsigned) plaintext_max_size, |
| 980 | (unsigned) plaintext_size); |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 981 | |
| 982 | /* Move the plaintext to the leftmost position where it can start in |
| 983 | * the working buffer, i.e. make it start plaintext_max_size from |
| 984 | * the end of the buffer. Do this with a memory access trace that |
| 985 | * does not depend on the plaintext size. After this move, the |
| 986 | * starting location of the plaintext is no longer sensitive |
| 987 | * information. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 988 | mbedtls_ct_mem_move_to_left(input + ilen - plaintext_max_size, |
| 989 | plaintext_max_size, |
| 990 | plaintext_max_size - plaintext_size); |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 991 | |
| 992 | /* Finally copy the decrypted plaintext plus trailing zeros into the output |
| 993 | * buffer. If output_max_len is 0, then output may be an invalid pointer |
| 994 | * and the result of memcpy() would be undefined; prevent undefined |
| 995 | * behavior making sure to depend only on output_max_len (the size of the |
| 996 | * user-provided output buffer), which is independent from plaintext |
| 997 | * length, validity of padding, success of the decryption, and other |
| 998 | * secrets. */ |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 999 | if (output_max_len != 0) { |
| 1000 | memcpy(output, input + ilen - plaintext_max_size, plaintext_max_size); |
| 1001 | } |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 1002 | |
| 1003 | /* Report the amount of data we copied to the output buffer. In case |
| 1004 | * of errors (bad padding or output too large), the value of *olen |
| 1005 | * when this function returns is not specified. Making it equivalent |
| 1006 | * to the good case limits the risks of leaking the padding validity. */ |
| 1007 | *olen = plaintext_size; |
| 1008 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 1009 | return ret; |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 1010 | } |
| 1011 | |
| 1012 | #endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */ |