blob: f066add803f4c65a43b66076ba8a3a67a10090b7 [file] [log] [blame]
Christopher Collins92ea77f2016-12-12 15:59:26 -08001/*
David Brownaac71112020-02-03 16:13:42 -07002 * SPDX-License-Identifier: Apache-2.0
3 *
4 * Copyright (c) 2017-2019 Linaro LTD
5 * Copyright (c) 2016-2019 JUUL Labs
6 * Copyright (c) 2019-2020 Arm Limited
7 *
8 * Original license:
9 *
Christopher Collins92ea77f2016-12-12 15:59:26 -080010 * Licensed to the Apache Software Foundation (ASF) under one
11 * or more contributor license agreements. See the NOTICE file
12 * distributed with this work for additional information
13 * regarding copyright ownership. The ASF licenses this file
14 * to you under the Apache License, Version 2.0 (the
15 * "License"); you may not use this file except in compliance
16 * with the License. You may obtain a copy of the License at
17 *
18 * http://www.apache.org/licenses/LICENSE-2.0
19 *
20 * Unless required by applicable law or agreed to in writing,
21 * software distributed under the License is distributed on an
22 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
23 * KIND, either express or implied. See the License for the
24 * specific language governing permissions and limitations
25 * under the License.
26 */
27
Christopher Collins92ea77f2016-12-12 15:59:26 -080028#include <stddef.h>
David Vinczec3084132020-02-18 14:50:47 +010029#include <stdint.h>
Christopher Collins92ea77f2016-12-12 15:59:26 -080030#include <inttypes.h>
31#include <string.h>
32
Andrzej Puzdrowskib788c712018-04-12 12:42:49 +020033#include <flash_map_backend/flash_map_backend.h>
34
Christopher Collins92ea77f2016-12-12 15:59:26 -080035#include "bootutil/image.h"
Blaž Hrastnik4f4833d2020-09-14 13:53:31 +090036#include "bootutil/crypto/sha256.h"
Christopher Collins92ea77f2016-12-12 15:59:26 -080037#include "bootutil/sign_key.h"
David Vinczec3084132020-02-18 14:50:47 +010038#include "bootutil/security_cnt.h"
Raef Colese8fe6cf2020-05-26 13:07:40 +010039#include "bootutil/fault_injection_hardening.h"
Christopher Collins92ea77f2016-12-12 15:59:26 -080040
Fabio Utzigba1fbe62017-07-21 14:01:20 -030041#include "mcuboot_config/mcuboot_config.h"
Fabio Utzigeed80b62017-06-10 08:03:05 -030042
Fabio Utzigba829042018-09-18 08:29:34 -030043#ifdef MCUBOOT_ENC_IMAGES
44#include "bootutil/enc_key.h"
45#endif
46#if defined(MCUBOOT_SIGN_RSA)
Christopher Collins92ea77f2016-12-12 15:59:26 -080047#include "mbedtls/rsa.h"
David Brownd7e350d2017-04-24 13:29:28 -060048#endif
Fabio Utzig19356bf2017-05-11 16:19:36 -030049#if defined(MCUBOOT_SIGN_EC) || defined(MCUBOOT_SIGN_EC256)
Christopher Collins92ea77f2016-12-12 15:59:26 -080050#include "mbedtls/ecdsa.h"
David Brownd7e350d2017-04-24 13:29:28 -060051#endif
Arvin Farahmandf8240192020-05-05 11:43:52 -040052#if defined(MCUBOOT_ENC_IMAGES) || defined(MCUBOOT_SIGN_RSA) || \
53 defined(MCUBOOT_SIGN_EC) || defined(MCUBOOT_SIGN_EC256)
Christopher Collins92ea77f2016-12-12 15:59:26 -080054#include "mbedtls/asn1.h"
Arvin Farahmandf8240192020-05-05 11:43:52 -040055#endif
Christopher Collins92ea77f2016-12-12 15:59:26 -080056
57#include "bootutil_priv.h"
58
59/*
60 * Compute SHA256 over the image.
61 */
62static int
Fabio Utzig10ee6482019-08-01 12:04:52 -030063bootutil_img_hash(struct enc_key_data *enc_state, int image_index,
64 struct image_header *hdr, const struct flash_area *fap,
65 uint8_t *tmp_buf, uint32_t tmp_buf_sz, uint8_t *hash_result,
66 uint8_t *seed, int seed_len)
Christopher Collins92ea77f2016-12-12 15:59:26 -080067{
David Browne629bf32017-04-24 13:37:33 -060068 bootutil_sha256_context sha256_ctx;
Christopher Collins92ea77f2016-12-12 15:59:26 -080069 uint32_t blk_sz;
70 uint32_t size;
Fabio Utzig2fc80df2018-12-14 06:47:38 -020071 uint16_t hdr_size;
Christopher Collins92ea77f2016-12-12 15:59:26 -080072 uint32_t off;
73 int rc;
Fabio Utzigba829042018-09-18 08:29:34 -030074 uint32_t blk_off;
Fabio Utzige52c08e2019-09-11 19:32:00 -030075 uint32_t tlv_off;
Christopher Collins92ea77f2016-12-12 15:59:26 -080076
Tamas Banfe031092020-09-10 17:32:39 +020077#if (BOOT_IMAGE_NUMBER == 1) || !defined(MCUBOOT_ENC_IMAGES) || \
78 defined(MCUBOOT_RAM_LOAD)
Fabio Utzig10ee6482019-08-01 12:04:52 -030079 (void)enc_state;
Fabio Utzigb0f04732019-07-31 09:49:19 -030080 (void)image_index;
Fabio Utzigc9621352019-08-08 12:15:51 -030081 (void)hdr_size;
Fabio Utzige52c08e2019-09-11 19:32:00 -030082 (void)blk_off;
83 (void)tlv_off;
Tamas Banfe031092020-09-10 17:32:39 +020084#ifdef MCUBOOT_RAM_LOAD
85 (void)blk_sz;
86 (void)off;
87 (void)rc;
88#endif
Fabio Utzigb0f04732019-07-31 09:49:19 -030089#endif
90
Fabio Utzigbc077932019-08-26 11:16:34 -030091#ifdef MCUBOOT_ENC_IMAGES
92 /* Encrypted images only exist in the secondary slot */
93 if (MUST_DECRYPT(fap, image_index, hdr) &&
94 !boot_enc_valid(enc_state, image_index, fap)) {
95 return -1;
96 }
97#endif
98
David Browne629bf32017-04-24 13:37:33 -060099 bootutil_sha256_init(&sha256_ctx);
Christopher Collins92ea77f2016-12-12 15:59:26 -0800100
101 /* in some cases (split image) the hash is seeded with data from
102 * the loader image */
Fabio Utzig53986042017-12-12 14:57:07 -0200103 if (seed && (seed_len > 0)) {
David Browne629bf32017-04-24 13:37:33 -0600104 bootutil_sha256_update(&sha256_ctx, seed, seed_len);
Christopher Collins92ea77f2016-12-12 15:59:26 -0800105 }
106
David Vinczee32483f2019-06-13 10:46:24 +0200107 /* Hash is computed over image header and image itself. */
Fabio Utzige52c08e2019-09-11 19:32:00 -0300108 size = hdr_size = hdr->ih_hdr_size;
109 size += hdr->ih_img_size;
110 tlv_off = size;
David Vinczee32483f2019-06-13 10:46:24 +0200111
Fabio Utzige52c08e2019-09-11 19:32:00 -0300112 /* If protected TLVs are present they are also hashed. */
113 size += hdr->ih_protect_tlv_size;
David Vinczee32483f2019-06-13 10:46:24 +0200114
Tamas Banfe031092020-09-10 17:32:39 +0200115#ifdef MCUBOOT_RAM_LOAD
116 bootutil_sha256_update(&sha256_ctx,(void*)(hdr->ih_load_addr), size);
117#else
Christopher Collins92ea77f2016-12-12 15:59:26 -0800118 for (off = 0; off < size; off += blk_sz) {
119 blk_sz = size - off;
Fabio Utzige52c08e2019-09-11 19:32:00 -0300120 if (blk_sz > tmp_buf_sz) {
121 blk_sz = tmp_buf_sz;
122 }
Fabio Utzigc21c2102019-09-10 10:10:42 -0300123#ifdef MCUBOOT_ENC_IMAGES
124 /* The only data that is encrypted in an image is the payload;
125 * both header and TLVs (when protected) are not.
126 */
127 if ((off < hdr_size) && ((off + blk_sz) > hdr_size)) {
128 /* read only the header */
129 blk_sz = hdr_size - off;
Fabio Utzige52c08e2019-09-11 19:32:00 -0300130 }
131 if ((off < tlv_off) && ((off + blk_sz) > tlv_off)) {
132 /* read only up to the end of the image payload */
133 blk_sz = tlv_off - off;
Fabio Utzigc21c2102019-09-10 10:10:42 -0300134 }
135#endif
Christopher Collins92ea77f2016-12-12 15:59:26 -0800136 rc = flash_area_read(fap, off, tmp_buf, blk_sz);
137 if (rc) {
Blaž Hrastnik4f4833d2020-09-14 13:53:31 +0900138 bootutil_sha256_drop(&sha256_ctx);
Christopher Collins92ea77f2016-12-12 15:59:26 -0800139 return rc;
140 }
Fabio Utzigba829042018-09-18 08:29:34 -0300141#ifdef MCUBOOT_ENC_IMAGES
Fabio Utzigc21c2102019-09-10 10:10:42 -0300142 if (MUST_DECRYPT(fap, image_index, hdr)) {
Fabio Utzige52c08e2019-09-11 19:32:00 -0300143 /* Only payload is encrypted (area between header and TLVs) */
144 if (off >= hdr_size && off < tlv_off) {
Fabio Utzigc21c2102019-09-10 10:10:42 -0300145 blk_off = (off - hdr_size) & 0xf;
146 boot_encrypt(enc_state, image_index, fap, off - hdr_size,
147 blk_sz, blk_off, tmp_buf);
148 }
Fabio Utzigba829042018-09-18 08:29:34 -0300149 }
150#endif
David Browne629bf32017-04-24 13:37:33 -0600151 bootutil_sha256_update(&sha256_ctx, tmp_buf, blk_sz);
Christopher Collins92ea77f2016-12-12 15:59:26 -0800152 }
Tamas Banfe031092020-09-10 17:32:39 +0200153#endif /* MCUBOOT_RAM_LOAD */
David Browne629bf32017-04-24 13:37:33 -0600154 bootutil_sha256_finish(&sha256_ctx, hash_result);
Blaž Hrastnik4f4833d2020-09-14 13:53:31 +0900155 bootutil_sha256_drop(&sha256_ctx);
Christopher Collins92ea77f2016-12-12 15:59:26 -0800156
157 return 0;
158}
159
160/*
David Brown43cda332017-09-01 09:53:23 -0600161 * Currently, we only support being able to verify one type of
162 * signature, because there is a single verification function that we
163 * call. List the type of TLV we are expecting. If we aren't
164 * configured for any signature, don't define this macro.
165 */
Fabio Utzig48764842019-05-10 19:28:24 -0300166#if (defined(MCUBOOT_SIGN_RSA) + \
167 defined(MCUBOOT_SIGN_EC) + \
168 defined(MCUBOOT_SIGN_EC256) + \
169 defined(MCUBOOT_SIGN_ED25519)) > 1
Fabio Utzig3501c012019-05-13 15:07:25 -0700170#error "Only a single signature type is supported!"
171#endif
172
David Brown43cda332017-09-01 09:53:23 -0600173#if defined(MCUBOOT_SIGN_RSA)
Fabio Utzig3501c012019-05-13 15:07:25 -0700174# if MCUBOOT_SIGN_RSA_LEN == 2048
175# define EXPECTED_SIG_TLV IMAGE_TLV_RSA2048_PSS
176# elif MCUBOOT_SIGN_RSA_LEN == 3072
177# define EXPECTED_SIG_TLV IMAGE_TLV_RSA3072_PSS
178# else
179# error "Unsupported RSA signature length"
David Brown43cda332017-09-01 09:53:23 -0600180# endif
Fabio Utzig3501c012019-05-13 15:07:25 -0700181# define SIG_BUF_SIZE (MCUBOOT_SIGN_RSA_LEN / 8)
182# define EXPECTED_SIG_LEN(x) ((x) == SIG_BUF_SIZE) /* 2048 bits */
David Brown43cda332017-09-01 09:53:23 -0600183#elif defined(MCUBOOT_SIGN_EC)
184# define EXPECTED_SIG_TLV IMAGE_TLV_ECDSA224
Fabio Utzig3501c012019-05-13 15:07:25 -0700185# define SIG_BUF_SIZE 128
David Browna3608262019-12-12 15:35:31 -0700186# define EXPECTED_SIG_LEN(x) (1) /* always true, ASN.1 will validate */
David Brown43cda332017-09-01 09:53:23 -0600187#elif defined(MCUBOOT_SIGN_EC256)
188# define EXPECTED_SIG_TLV IMAGE_TLV_ECDSA256
Fabio Utzig3501c012019-05-13 15:07:25 -0700189# define SIG_BUF_SIZE 128
David Browna3608262019-12-12 15:35:31 -0700190# define EXPECTED_SIG_LEN(x) (1) /* always true, ASN.1 will validate */
Fabio Utzig48764842019-05-10 19:28:24 -0300191#elif defined(MCUBOOT_SIGN_ED25519)
192# define EXPECTED_SIG_TLV IMAGE_TLV_ED25519
193# define SIG_BUF_SIZE 64
194# define EXPECTED_SIG_LEN(x) ((x) == SIG_BUF_SIZE)
Fabio Utzig3501c012019-05-13 15:07:25 -0700195#else
196# define SIG_BUF_SIZE 32 /* no signing, sha256 digest only */
David Brown43cda332017-09-01 09:53:23 -0600197#endif
198
199#ifdef EXPECTED_SIG_TLV
David Vincze03368b82020-04-01 12:53:53 +0200200#if !defined(MCUBOOT_HW_KEY)
David Brown43cda332017-09-01 09:53:23 -0600201static int
202bootutil_find_key(uint8_t *keyhash, uint8_t keyhash_len)
203{
204 bootutil_sha256_context sha256_ctx;
205 int i;
206 const struct bootutil_key *key;
207 uint8_t hash[32];
208
Fabio Utzig15c14672019-08-09 07:45:20 -0300209 if (keyhash_len > 32) {
210 return -1;
211 }
David Brown43cda332017-09-01 09:53:23 -0600212
213 for (i = 0; i < bootutil_key_cnt; i++) {
214 key = &bootutil_keys[i];
215 bootutil_sha256_init(&sha256_ctx);
216 bootutil_sha256_update(&sha256_ctx, key->key, *key->len);
217 bootutil_sha256_finish(&sha256_ctx, hash);
218 if (!memcmp(hash, keyhash, keyhash_len)) {
Blaž Hrastnik4f4833d2020-09-14 13:53:31 +0900219 bootutil_sha256_drop(&sha256_ctx);
David Brown43cda332017-09-01 09:53:23 -0600220 return i;
221 }
222 }
Blaž Hrastnik4f4833d2020-09-14 13:53:31 +0900223 bootutil_sha256_drop(&sha256_ctx);
David Brown43cda332017-09-01 09:53:23 -0600224 return -1;
225}
David Vincze03368b82020-04-01 12:53:53 +0200226#else
227extern unsigned int pub_key_len;
228static int
229bootutil_find_key(uint8_t image_index, uint8_t *key, uint16_t key_len)
230{
231 bootutil_sha256_context sha256_ctx;
232 uint8_t hash[32];
233 uint8_t key_hash[32];
234 size_t key_hash_size = sizeof(key_hash);
235 int rc;
Raef Colese8fe6cf2020-05-26 13:07:40 +0100236 fih_int fih_rc;
David Vincze03368b82020-04-01 12:53:53 +0200237
238 bootutil_sha256_init(&sha256_ctx);
239 bootutil_sha256_update(&sha256_ctx, key, key_len);
240 bootutil_sha256_finish(&sha256_ctx, hash);
Blaž Hrastnik4f4833d2020-09-14 13:53:31 +0900241 bootutil_sha256_drop(&sha256_ctx);
David Vincze03368b82020-04-01 12:53:53 +0200242
243 rc = boot_retrieve_public_key_hash(image_index, key_hash, &key_hash_size);
244 if (rc) {
245 return rc;
246 }
247
Raef Colese8fe6cf2020-05-26 13:07:40 +0100248 /* Adding hardening to avoid this potential attack:
249 * - Image is signed with an arbitrary key and the corresponding public
250 * key is added as a TLV field.
251 * - During public key validation (comparing against key-hash read from
252 * HW) a fault is injected to accept the public key as valid one.
253 */
254 FIH_CALL(boot_fih_memequal, fih_rc, hash, key_hash, key_hash_size);
255 if (fih_eq(fih_rc, FIH_SUCCESS)) {
David Vincze03368b82020-04-01 12:53:53 +0200256 bootutil_keys[0].key = key;
257 pub_key_len = key_len;
258 return 0;
259 }
Raef Colese8fe6cf2020-05-26 13:07:40 +0100260
David Vincze03368b82020-04-01 12:53:53 +0200261 return -1;
262}
263#endif /* !MCUBOOT_HW_KEY */
David Brown43cda332017-09-01 09:53:23 -0600264#endif
265
David Vinczec3084132020-02-18 14:50:47 +0100266#ifdef MCUBOOT_HW_ROLLBACK_PROT
267/**
268 * Reads the value of an image's security counter.
269 *
270 * @param hdr Pointer to the image header structure.
271 * @param fap Pointer to a description structure of the image's
272 * flash area.
273 * @param security_cnt Pointer to store the security counter value.
274 *
275 * @return 0 on success; nonzero on failure.
276 */
277int32_t
278bootutil_get_img_security_cnt(struct image_header *hdr,
279 const struct flash_area *fap,
280 uint32_t *img_security_cnt)
281{
282 struct image_tlv_iter it;
283 uint32_t off;
284 uint16_t len;
285 int32_t rc;
286
287 if ((hdr == NULL) ||
288 (fap == NULL) ||
289 (img_security_cnt == NULL)) {
290 /* Invalid parameter. */
291 return BOOT_EBADARGS;
292 }
293
294 /* The security counter TLV is in the protected part of the TLV area. */
295 if (hdr->ih_protect_tlv_size == 0) {
296 return BOOT_EBADIMAGE;
297 }
298
299 rc = bootutil_tlv_iter_begin(&it, hdr, fap, IMAGE_TLV_SEC_CNT, true);
300 if (rc) {
301 return rc;
302 }
303
304 /* Traverse through the protected TLV area to find
305 * the security counter TLV.
306 */
307
308 rc = bootutil_tlv_iter_next(&it, &off, &len, NULL);
309 if (rc != 0) {
310 /* Security counter TLV has not been found. */
311 return -1;
312 }
313
314 if (len != sizeof(*img_security_cnt)) {
315 /* Security counter is not valid. */
316 return BOOT_EBADIMAGE;
317 }
318
Tamas Banfe031092020-09-10 17:32:39 +0200319 rc = LOAD_IMAGE_DATA(hdr, fap, off, img_security_cnt, len);
David Vinczec3084132020-02-18 14:50:47 +0100320 if (rc != 0) {
321 return BOOT_EFLASH;
322 }
323
324 return 0;
325}
326#endif /* MCUBOOT_HW_ROLLBACK_PROT */
327
David Brown43cda332017-09-01 09:53:23 -0600328/*
Christopher Collins92ea77f2016-12-12 15:59:26 -0800329 * Verify the integrity of the image.
330 * Return non-zero if image could not be validated/does not validate.
331 */
Raef Colese8fe6cf2020-05-26 13:07:40 +0100332fih_int
Fabio Utzig10ee6482019-08-01 12:04:52 -0300333bootutil_img_validate(struct enc_key_data *enc_state, int image_index,
334 struct image_header *hdr, const struct flash_area *fap,
335 uint8_t *tmp_buf, uint32_t tmp_buf_sz, uint8_t *seed,
336 int seed_len, uint8_t *out_hash)
Christopher Collins92ea77f2016-12-12 15:59:26 -0800337{
338 uint32_t off;
Fabio Utzig61fd8882019-09-14 20:00:20 -0300339 uint16_t len;
David Brownd13318a2019-12-04 17:28:40 -0700340 uint16_t type;
David Brown43cda332017-09-01 09:53:23 -0600341 int sha256_valid = 0;
342#ifdef EXPECTED_SIG_TLV
Raef Colese8fe6cf2020-05-26 13:07:40 +0100343 fih_int valid_signature = FIH_FAILURE;
David Brown43cda332017-09-01 09:53:23 -0600344 int key_id = -1;
David Vincze03368b82020-04-01 12:53:53 +0200345#ifdef MCUBOOT_HW_KEY
346 /* Few extra bytes for encoding and for public exponent. */
347 uint8_t key_buf[SIG_BUF_SIZE + 24];
Christopher Collins92ea77f2016-12-12 15:59:26 -0800348#endif
David Vincze03368b82020-04-01 12:53:53 +0200349#endif /* EXPECTED_SIG_TLV */
Fabio Utzig61fd8882019-09-14 20:00:20 -0300350 struct image_tlv_iter it;
Fabio Utzig3501c012019-05-13 15:07:25 -0700351 uint8_t buf[SIG_BUF_SIZE];
Christopher Collins92ea77f2016-12-12 15:59:26 -0800352 uint8_t hash[32];
Raef Colese8fe6cf2020-05-26 13:07:40 +0100353 int rc = 0;
354 fih_int fih_rc = FIH_FAILURE;
David Vinczec3084132020-02-18 14:50:47 +0100355#ifdef MCUBOOT_HW_ROLLBACK_PROT
Raef Colese8fe6cf2020-05-26 13:07:40 +0100356 fih_int security_cnt = fih_int_encode(INT_MAX);
David Vinczec3084132020-02-18 14:50:47 +0100357 uint32_t img_security_cnt = 0;
Raef Colese8fe6cf2020-05-26 13:07:40 +0100358 fih_int security_counter_valid = FIH_FAILURE;
David Vinczec3084132020-02-18 14:50:47 +0100359#endif
Christopher Collins92ea77f2016-12-12 15:59:26 -0800360
Fabio Utzig10ee6482019-08-01 12:04:52 -0300361 rc = bootutil_img_hash(enc_state, image_index, hdr, fap, tmp_buf,
362 tmp_buf_sz, hash, seed, seed_len);
Christopher Collins92ea77f2016-12-12 15:59:26 -0800363 if (rc) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100364 goto out;
Christopher Collins92ea77f2016-12-12 15:59:26 -0800365 }
366
367 if (out_hash) {
368 memcpy(out_hash, hash, 32);
369 }
370
Fabio Utzig61fd8882019-09-14 20:00:20 -0300371 rc = bootutil_tlv_iter_begin(&it, hdr, fap, IMAGE_TLV_ANY, false);
David Brownf5b33d82017-09-01 10:58:27 -0600372 if (rc) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100373 goto out;
David Brownf5b33d82017-09-01 10:58:27 -0600374 }
Christopher Collins92ea77f2016-12-12 15:59:26 -0800375
David Brown43cda332017-09-01 09:53:23 -0600376 /*
377 * Traverse through all of the TLVs, performing any checks we know
378 * and are able to do.
379 */
Fabio Utzig61fd8882019-09-14 20:00:20 -0300380 while (true) {
381 rc = bootutil_tlv_iter_next(&it, &off, &len, &type);
382 if (rc < 0) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100383 goto out;
Fabio Utzig61fd8882019-09-14 20:00:20 -0300384 } else if (rc > 0) {
385 break;
Christopher Collins92ea77f2016-12-12 15:59:26 -0800386 }
David Brown43cda332017-09-01 09:53:23 -0600387
Fabio Utzig61fd8882019-09-14 20:00:20 -0300388 if (type == IMAGE_TLV_SHA256) {
David Brown43cda332017-09-01 09:53:23 -0600389 /*
390 * Verify the SHA256 image hash. This must always be
391 * present.
392 */
Fabio Utzig61fd8882019-09-14 20:00:20 -0300393 if (len != sizeof(hash)) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100394 rc = -1;
395 goto out;
Christopher Collins92ea77f2016-12-12 15:59:26 -0800396 }
Tamas Banfe031092020-09-10 17:32:39 +0200397 rc = LOAD_IMAGE_DATA(hdr, fap, off, buf, sizeof(hash));
David Brown43cda332017-09-01 09:53:23 -0600398 if (rc) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100399 goto out;
Christopher Collins92ea77f2016-12-12 15:59:26 -0800400 }
Raef Colese8fe6cf2020-05-26 13:07:40 +0100401
402 FIH_CALL(boot_fih_memequal, fih_rc, hash, buf, sizeof(hash));
403 if (fih_not_eq(fih_rc, FIH_SUCCESS)) {
404 goto out;
Christopher Collins92ea77f2016-12-12 15:59:26 -0800405 }
David Brown43cda332017-09-01 09:53:23 -0600406
407 sha256_valid = 1;
408#ifdef EXPECTED_SIG_TLV
David Vincze03368b82020-04-01 12:53:53 +0200409#ifndef MCUBOOT_HW_KEY
Fabio Utzig61fd8882019-09-14 20:00:20 -0300410 } else if (type == IMAGE_TLV_KEYHASH) {
Christopher Collins92ea77f2016-12-12 15:59:26 -0800411 /*
David Brown43cda332017-09-01 09:53:23 -0600412 * Determine which key we should be checking.
Christopher Collins92ea77f2016-12-12 15:59:26 -0800413 */
Fabio Utzig61fd8882019-09-14 20:00:20 -0300414 if (len > 32) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100415 rc = -1;
416 goto out;
David Brown43cda332017-09-01 09:53:23 -0600417 }
Tamas Banfe031092020-09-10 17:32:39 +0200418 rc = LOAD_IMAGE_DATA(hdr, fap, off, buf, len);
David Brown43cda332017-09-01 09:53:23 -0600419 if (rc) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100420 goto out;
David Brown43cda332017-09-01 09:53:23 -0600421 }
Fabio Utzig61fd8882019-09-14 20:00:20 -0300422 key_id = bootutil_find_key(buf, len);
David Brown43cda332017-09-01 09:53:23 -0600423 /*
424 * The key may not be found, which is acceptable. There
425 * can be multiple signatures, each preceded by a key.
426 */
David Vincze03368b82020-04-01 12:53:53 +0200427#else
428 } else if (type == IMAGE_TLV_PUBKEY) {
429 /*
430 * Determine which key we should be checking.
431 */
432 if (len > sizeof(key_buf)) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100433 rc = -1;
434 goto out;
David Vincze03368b82020-04-01 12:53:53 +0200435 }
Tamas Banfe031092020-09-10 17:32:39 +0200436 rc = LOAD_IMAGE_DATA(hdr, fap, off, key_buf, len);
David Vincze03368b82020-04-01 12:53:53 +0200437 if (rc) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100438 goto out;
David Vincze03368b82020-04-01 12:53:53 +0200439 }
440 key_id = bootutil_find_key(image_index, key_buf, len);
441 /*
442 * The key may not be found, which is acceptable. There
443 * can be multiple signatures, each preceded by a key.
444 */
445#endif /* !MCUBOOT_HW_KEY */
Fabio Utzig61fd8882019-09-14 20:00:20 -0300446 } else if (type == EXPECTED_SIG_TLV) {
David Brown43cda332017-09-01 09:53:23 -0600447 /* Ignore this signature if it is out of bounds. */
448 if (key_id < 0 || key_id >= bootutil_key_cnt) {
449 key_id = -1;
450 continue;
451 }
Fabio Utzig61fd8882019-09-14 20:00:20 -0300452 if (!EXPECTED_SIG_LEN(len) || len > sizeof(buf)) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100453 rc = -1;
454 goto out;
David Brown43cda332017-09-01 09:53:23 -0600455 }
Tamas Banfe031092020-09-10 17:32:39 +0200456 rc = LOAD_IMAGE_DATA(hdr, fap, off, buf, len);
David Brown43cda332017-09-01 09:53:23 -0600457 if (rc) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100458 goto out;
David Brown43cda332017-09-01 09:53:23 -0600459 }
Raef Colese8fe6cf2020-05-26 13:07:40 +0100460 FIH_CALL(bootutil_verify_sig, valid_signature, hash, sizeof(hash),
461 buf, len, key_id);
David Brown43cda332017-09-01 09:53:23 -0600462 key_id = -1;
David Vinczec3084132020-02-18 14:50:47 +0100463#endif /* EXPECTED_SIG_TLV */
464#ifdef MCUBOOT_HW_ROLLBACK_PROT
465 } else if (type == IMAGE_TLV_SEC_CNT) {
466 /*
467 * Verify the image's security counter.
468 * This must always be present.
469 */
470 if (len != sizeof(img_security_cnt)) {
471 /* Security counter is not valid. */
Raef Colese8fe6cf2020-05-26 13:07:40 +0100472 rc = -1;
473 goto out;
David Vinczec3084132020-02-18 14:50:47 +0100474 }
475
Tamas Banfe031092020-09-10 17:32:39 +0200476 rc = LOAD_IMAGE_DATA(hdr, fap, off, &img_security_cnt, len);
David Vinczec3084132020-02-18 14:50:47 +0100477 if (rc) {
Raef Colese8fe6cf2020-05-26 13:07:40 +0100478 goto out;
David Vinczec3084132020-02-18 14:50:47 +0100479 }
480
Raef Colese8fe6cf2020-05-26 13:07:40 +0100481 FIH_CALL(boot_nv_security_counter_get, fih_rc, image_index,
482 &security_cnt);
483 if (fih_not_eq(fih_rc, FIH_SUCCESS)) {
484 goto out;
David Vinczec3084132020-02-18 14:50:47 +0100485 }
486
487 /* Compare the new image's security counter value against the
488 * stored security counter value.
489 */
Raef Colese8fe6cf2020-05-26 13:07:40 +0100490 fih_rc = fih_int_encode_zero_equality(img_security_cnt <
491 fih_int_decode(security_cnt));
492 if (fih_not_eq(fih_rc, FIH_SUCCESS)) {
493 goto out;
David Vinczec3084132020-02-18 14:50:47 +0100494 }
495
496 /* The image's security counter has been successfully verified. */
Raef Colese8fe6cf2020-05-26 13:07:40 +0100497 security_counter_valid = fih_rc;
David Vinczec3084132020-02-18 14:50:47 +0100498#endif /* MCUBOOT_HW_ROLLBACK_PROT */
Christopher Collins92ea77f2016-12-12 15:59:26 -0800499 }
500 }
David Brown43cda332017-09-01 09:53:23 -0600501
Raef Colese8fe6cf2020-05-26 13:07:40 +0100502 rc = !sha256_valid;
503 if (rc) {
504 goto out;
505 }
David Brown43cda332017-09-01 09:53:23 -0600506#ifdef EXPECTED_SIG_TLV
Raef Colese8fe6cf2020-05-26 13:07:40 +0100507 fih_rc = fih_int_encode_zero_equality(fih_not_eq(valid_signature,
508 FIH_SUCCESS));
Christopher Collins92ea77f2016-12-12 15:59:26 -0800509#endif
David Vinczec3084132020-02-18 14:50:47 +0100510#ifdef MCUBOOT_HW_ROLLBACK_PROT
Raef Colese8fe6cf2020-05-26 13:07:40 +0100511 if (fih_not_eq(security_counter_valid, FIH_SUCCESS)) {
512 rc = -1;
513 goto out;
514 }
David Vinczec3084132020-02-18 14:50:47 +0100515#endif
Raef Colese8fe6cf2020-05-26 13:07:40 +0100516
517out:
518 if (rc) {
519 fih_rc = fih_int_encode(rc);
David Vinczec3084132020-02-18 14:50:47 +0100520 }
David Brown43cda332017-09-01 09:53:23 -0600521
Raef Colese8fe6cf2020-05-26 13:07:40 +0100522 FIH_RET(fih_rc);
Christopher Collins92ea77f2016-12-12 15:59:26 -0800523}