gabor-mezei-arm | d112534 | 2021-07-12 16:31:22 +0200 | [diff] [blame] | 1 | /** |
| 2 | * Constant-time functions |
| 3 | * |
| 4 | * Copyright The Mbed TLS Contributors |
Dave Rodgman | 16799db | 2023-11-02 19:47:20 +0000 | [diff] [blame^] | 5 | * SPDX-License-Identifier: Apache-2.0 OR GPL-2.0-or-later |
gabor-mezei-arm | d112534 | 2021-07-12 16:31:22 +0200 | [diff] [blame] | 6 | */ |
| 7 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 8 | /* |
Gabor Mezei | 642eeb2 | 2021-11-03 16:13:32 +0100 | [diff] [blame] | 9 | * The following functions are implemented without using comparison operators, as those |
Gabor Mezei | eab90bc | 2021-10-18 16:09:41 +0200 | [diff] [blame] | 10 | * might be translated to branches by some compilers on some platforms. |
| 11 | */ |
| 12 | |
Dave Rodgman | 4f26770 | 2023-09-11 19:05:51 +0100 | [diff] [blame] | 13 | #include <stdint.h> |
Dave Rodgman | 40a41d0 | 2023-05-17 11:59:56 +0100 | [diff] [blame] | 14 | #include <limits.h> |
| 15 | |
gabor-mezei-arm | d112534 | 2021-07-12 16:31:22 +0200 | [diff] [blame] | 16 | #include "common.h" |
Gabor Mezei | 22c9a6f | 2021-10-20 12:09:35 +0200 | [diff] [blame] | 17 | #include "constant_time_internal.h" |
Gabor Mezei | 765862c | 2021-10-19 12:22:25 +0200 | [diff] [blame] | 18 | #include "mbedtls/constant_time.h" |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 19 | #include "mbedtls/error.h" |
gabor-mezei-arm | 5b3a32d | 2021-09-29 10:50:31 +0200 | [diff] [blame] | 20 | #include "mbedtls/platform_util.h" |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 21 | |
gabor-mezei-arm | fdb7118 | 2021-09-27 16:11:12 +0200 | [diff] [blame] | 22 | #include <string.h> |
Andrzej Kurek | 1c7a998 | 2023-05-30 09:21:20 -0400 | [diff] [blame] | 23 | |
| 24 | #if defined(MBEDTLS_USE_PSA_CRYPTO) && defined(MBEDTLS_SSL_SOME_SUITES_USE_MAC) |
| 25 | #include "psa/crypto.h" |
Andrzej Kurek | 0064484 | 2023-05-30 05:45:00 -0400 | [diff] [blame] | 26 | /* Define a local translating function to save code size by not using too many |
| 27 | * arguments in each translating place. */ |
| 28 | static int local_err_translation(psa_status_t status) |
| 29 | { |
| 30 | return psa_status_to_mbedtls(status, psa_to_ssl_errors, |
Andrzej Kurek | 1e4a030 | 2023-05-30 09:45:17 -0400 | [diff] [blame] | 31 | ARRAY_LENGTH(psa_to_ssl_errors), |
Andrzej Kurek | 0064484 | 2023-05-30 05:45:00 -0400 | [diff] [blame] | 32 | psa_generic_status_to_mbedtls); |
| 33 | } |
| 34 | #define PSA_TO_MBEDTLS_ERR(status) local_err_translation(status) |
Andrzej Kurek | 8a045ce | 2022-12-23 11:00:06 -0500 | [diff] [blame] | 35 | #endif |
gabor-mezei-arm | 3f90fd5 | 2021-09-27 12:55:33 +0200 | [diff] [blame] | 36 | |
Dave Rodgman | 58c80f4 | 2023-06-12 18:19:46 +0100 | [diff] [blame] | 37 | #if !defined(MBEDTLS_CT_ASM) |
| 38 | /* |
Dave Rodgman | 1ab0b48 | 2023-06-12 18:22:18 +0100 | [diff] [blame] | 39 | * Define an object with the value zero, such that the compiler cannot prove that it |
| 40 | * has the value zero (because it is volatile, it "may be modified in ways unknown to |
| 41 | * the implementation"). |
| 42 | */ |
Dave Rodgman | 58c80f4 | 2023-06-12 18:19:46 +0100 | [diff] [blame] | 43 | volatile mbedtls_ct_uint_t mbedtls_ct_zero = 0; |
| 44 | #endif |
| 45 | |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 46 | /* |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 47 | * Define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS where assembly is present to |
| 48 | * perform fast unaligned access to volatile data. |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 49 | * |
| 50 | * This is needed because mbedtls_get_unaligned_uintXX etc don't support volatile |
| 51 | * memory accesses. |
| 52 | * |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 53 | * Some of these definitions could be moved into alignment.h but for now they are |
| 54 | * only used here. |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 55 | */ |
Dave Rodgman | 40a41d0 | 2023-05-17 11:59:56 +0100 | [diff] [blame] | 56 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS) && \ |
Dave Rodgman | 9fbb0cf | 2023-06-28 18:52:02 +0100 | [diff] [blame] | 57 | ((defined(MBEDTLS_CT_ARM_ASM) && (UINTPTR_MAX == 0xfffffffful)) || \ |
| 58 | defined(MBEDTLS_CT_AARCH64_ASM)) |
Dave Rodgman | 63e89b4 | 2023-06-21 11:55:17 +0100 | [diff] [blame] | 59 | /* We check pointer sizes to avoid issues with them not matching register size requirements */ |
Dave Rodgman | 40a41d0 | 2023-05-17 11:59:56 +0100 | [diff] [blame] | 60 | #define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS |
| 61 | |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 62 | static inline uint32_t mbedtls_get_unaligned_volatile_uint32(volatile const unsigned char *p) |
| 63 | { |
| 64 | /* This is UB, even where it's safe: |
| 65 | * return *((volatile uint32_t*)p); |
| 66 | * so instead the same thing is expressed in assembly below. |
| 67 | */ |
| 68 | uint32_t r; |
Dave Rodgman | 40a41d0 | 2023-05-17 11:59:56 +0100 | [diff] [blame] | 69 | #if defined(MBEDTLS_CT_ARM_ASM) |
Antonio de Angelis | f1adc2a | 2023-08-16 12:31:54 +0100 | [diff] [blame] | 70 | asm volatile ("ldr %0, [%1]" : "=r" (r) : "r" (p) :); |
Dave Rodgman | 40a41d0 | 2023-05-17 11:59:56 +0100 | [diff] [blame] | 71 | #elif defined(MBEDTLS_CT_AARCH64_ASM) |
Dave Rodgman | 5b5dd01 | 2023-06-21 16:36:47 +0100 | [diff] [blame] | 72 | asm volatile ("ldr %w0, [%1]" : "=r" (r) : MBEDTLS_ASM_AARCH64_PTR_CONSTRAINT(p) :); |
Dave Rodgman | 40a41d0 | 2023-05-17 11:59:56 +0100 | [diff] [blame] | 73 | #else |
Antonio de Angelis | 1ee4d12 | 2023-08-16 12:26:37 +0100 | [diff] [blame] | 74 | #error "No assembly defined for mbedtls_get_unaligned_volatile_uint32" |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 75 | #endif |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 76 | return r; |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 77 | } |
Dave Rodgman | 40a41d0 | 2023-05-17 11:59:56 +0100 | [diff] [blame] | 78 | #endif /* defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS) && |
| 79 | (defined(MBEDTLS_CT_ARM_ASM) || defined(MBEDTLS_CT_AARCH64_ASM)) */ |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 80 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 81 | int mbedtls_ct_memcmp(const void *a, |
| 82 | const void *b, |
| 83 | size_t n) |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 84 | { |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 85 | size_t i = 0; |
Dave Rodgman | 7658b63 | 2023-01-11 17:39:33 +0000 | [diff] [blame] | 86 | /* |
| 87 | * `A` and `B` are cast to volatile to ensure that the compiler |
| 88 | * generates code that always fully reads both buffers. |
| 89 | * Otherwise it could generate a test to exit early if `diff` has all |
| 90 | * bits set early in the loop. |
| 91 | */ |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 92 | volatile const unsigned char *A = (volatile const unsigned char *) a; |
| 93 | volatile const unsigned char *B = (volatile const unsigned char *) b; |
Dave Rodgman | 7658b63 | 2023-01-11 17:39:33 +0000 | [diff] [blame] | 94 | uint32_t diff = 0; |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 95 | |
Dave Rodgman | 051225d | 2022-12-30 21:25:35 +0000 | [diff] [blame] | 96 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS) |
Dave Rodgman | 36dfc5a | 2022-12-22 15:04:43 +0000 | [diff] [blame] | 97 | for (; (i + 4) <= n; i += 4) { |
| 98 | uint32_t x = mbedtls_get_unaligned_volatile_uint32(A + i); |
| 99 | uint32_t y = mbedtls_get_unaligned_volatile_uint32(B + i); |
| 100 | diff |= x ^ y; |
| 101 | } |
| 102 | #endif |
| 103 | |
| 104 | for (; i < n; i++) { |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 105 | /* Read volatile data in order before computing diff. |
| 106 | * This avoids IAR compiler warning: |
| 107 | * 'the order of volatile accesses is undefined ..' */ |
| 108 | unsigned char x = A[i], y = B[i]; |
| 109 | diff |= x ^ y; |
| 110 | } |
| 111 | |
Dave Rodgman | 98926d5 | 2023-09-12 09:29:33 +0100 | [diff] [blame] | 112 | |
Dave Rodgman | 50b0a35 | 2023-09-12 09:30:44 +0100 | [diff] [blame] | 113 | #if (INT_MAX < INT32_MAX) |
Dave Rodgman | 98926d5 | 2023-09-12 09:29:33 +0100 | [diff] [blame] | 114 | /* We don't support int smaller than 32-bits, but if someone tried to build |
| 115 | * with this configuration, there is a risk that, for differing data, the |
| 116 | * only bits set in diff are in the top 16-bits, and would be lost by a |
| 117 | * simple cast from uint32 to int. |
| 118 | * This would have significant security implications, so protect against it. */ |
| 119 | #error "mbedtls_ct_memcmp() requires minimum 32-bit ints" |
Dave Rodgman | 4f26770 | 2023-09-11 19:05:51 +0100 | [diff] [blame] | 120 | #else |
Dave Rodgman | bd58944 | 2023-09-12 12:38:53 +0100 | [diff] [blame] | 121 | /* The bit-twiddling ensures that when we cast uint32_t to int, we are casting |
| 122 | * a value that is in the range 0..INT_MAX - a value larger than this would |
| 123 | * result in implementation defined behaviour. |
| 124 | * |
| 125 | * This ensures that the value returned by the function is non-zero iff |
| 126 | * diff is non-zero. |
| 127 | */ |
| 128 | return (int) ((diff & 0xffff) | (diff >> 16)); |
Dave Rodgman | 4f26770 | 2023-09-11 19:05:51 +0100 | [diff] [blame] | 129 | #endif |
gabor-mezei-arm | db9a38c | 2021-09-27 11:28:54 +0200 | [diff] [blame] | 130 | } |
| 131 | |
Dave Rodgman | 9c14007 | 2023-09-18 18:20:27 +0100 | [diff] [blame] | 132 | #if defined(MBEDTLS_NIST_KW_C) |
| 133 | |
| 134 | int mbedtls_ct_memcmp_partial(const void *a, |
| 135 | const void *b, |
| 136 | size_t n, |
| 137 | size_t skip_head, |
| 138 | size_t skip_tail) |
| 139 | { |
| 140 | unsigned int diff = 0; |
| 141 | |
| 142 | volatile const unsigned char *A = (volatile const unsigned char *) a; |
| 143 | volatile const unsigned char *B = (volatile const unsigned char *) b; |
| 144 | |
| 145 | size_t valid_end = n - skip_tail; |
| 146 | |
| 147 | for (size_t i = 0; i < n; i++) { |
| 148 | unsigned char x = A[i], y = B[i]; |
Dave Rodgman | c2630fa | 2023-09-19 14:13:41 +0100 | [diff] [blame] | 149 | unsigned int d = x ^ y; |
Dave Rodgman | 9c14007 | 2023-09-18 18:20:27 +0100 | [diff] [blame] | 150 | mbedtls_ct_condition_t valid = mbedtls_ct_bool_and(mbedtls_ct_uint_ge(i, skip_head), |
| 151 | mbedtls_ct_uint_lt(i, valid_end)); |
| 152 | diff |= mbedtls_ct_uint_if_else_0(valid, d); |
| 153 | } |
| 154 | |
Dave Rodgman | c2630fa | 2023-09-19 14:13:41 +0100 | [diff] [blame] | 155 | /* Since we go byte-by-byte, the only bits set will be in the bottom 8 bits, so the |
| 156 | * cast from uint to int is safe. */ |
| 157 | return (int) diff; |
Dave Rodgman | 9c14007 | 2023-09-18 18:20:27 +0100 | [diff] [blame] | 158 | } |
| 159 | |
| 160 | #endif |
| 161 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 162 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) |
| 163 | |
Dave Rodgman | 15c142b | 2023-05-17 12:20:11 +0100 | [diff] [blame] | 164 | void mbedtls_ct_memmove_left(void *start, size_t total, size_t offset) |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 165 | { |
Dave Rodgman | 1714a9b | 2023-07-31 12:37:01 +0100 | [diff] [blame] | 166 | volatile unsigned char *buf = start; |
Dave Rodgman | 15c142b | 2023-05-17 12:20:11 +0100 | [diff] [blame] | 167 | for (size_t i = 0; i < total; i++) { |
Dave Rodgman | b7825ce | 2023-08-10 11:58:18 +0100 | [diff] [blame] | 168 | mbedtls_ct_condition_t no_op = mbedtls_ct_uint_gt(total - offset, i); |
Dave Rodgman | 1714a9b | 2023-07-31 12:37:01 +0100 | [diff] [blame] | 169 | /* The first `total - offset` passes are a no-op. The last |
| 170 | * `offset` passes shift the data one byte to the left and |
| 171 | * zero out the last byte. */ |
| 172 | for (size_t n = 0; n < total - 1; n++) { |
| 173 | unsigned char current = buf[n]; |
| 174 | unsigned char next = buf[n+1]; |
| 175 | buf[n] = mbedtls_ct_uint_if(no_op, current, next); |
| 176 | } |
Dave Rodgman | 98ddc01 | 2023-08-10 12:11:31 +0100 | [diff] [blame] | 177 | buf[total-1] = mbedtls_ct_uint_if_else_0(no_op, buf[total-1]); |
gabor-mezei-arm | 394aeaa | 2021-09-27 13:31:06 +0200 | [diff] [blame] | 178 | } |
| 179 | } |
gabor-mezei-arm | dee0fd3 | 2021-09-27 13:34:25 +0200 | [diff] [blame] | 180 | |
Gabor Mezei | e212379 | 2021-10-18 17:05:06 +0200 | [diff] [blame] | 181 | #endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */ |
| 182 | |
Dave Rodgman | 7fe6e6f | 2023-05-17 12:34:56 +0100 | [diff] [blame] | 183 | void mbedtls_ct_memcpy_if(mbedtls_ct_condition_t condition, |
| 184 | unsigned char *dest, |
| 185 | const unsigned char *src1, |
| 186 | const unsigned char *src2, |
| 187 | size_t len) |
| 188 | { |
Dave Rodgman | 42391b4 | 2023-05-19 10:33:21 +0100 | [diff] [blame] | 189 | #if defined(MBEDTLS_CT_SIZE_64) |
| 190 | const uint64_t mask = (uint64_t) condition; |
| 191 | const uint64_t not_mask = (uint64_t) ~mbedtls_ct_compiler_opaque(condition); |
| 192 | #else |
Dave Rodgman | 7fe6e6f | 2023-05-17 12:34:56 +0100 | [diff] [blame] | 193 | const uint32_t mask = (uint32_t) condition; |
| 194 | const uint32_t not_mask = (uint32_t) ~mbedtls_ct_compiler_opaque(condition); |
Dave Rodgman | 42391b4 | 2023-05-19 10:33:21 +0100 | [diff] [blame] | 195 | #endif |
Dave Rodgman | 7fe6e6f | 2023-05-17 12:34:56 +0100 | [diff] [blame] | 196 | |
Dave Rodgman | 07f8537 | 2023-07-31 12:27:49 +0100 | [diff] [blame] | 197 | /* If src2 is NULL, setup src2 so that we read from the destination address. |
| 198 | * |
| 199 | * This means that if src2 == NULL && condition is false, the result will be a |
| 200 | * no-op because we read from dest and write the same data back into dest. |
| 201 | */ |
Dave Rodgman | 7fe6e6f | 2023-05-17 12:34:56 +0100 | [diff] [blame] | 202 | if (src2 == NULL) { |
| 203 | src2 = dest; |
| 204 | } |
| 205 | |
| 206 | /* dest[i] = c1 == c2 ? src[i] : dest[i] */ |
| 207 | size_t i = 0; |
| 208 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS) |
Dave Rodgman | 42391b4 | 2023-05-19 10:33:21 +0100 | [diff] [blame] | 209 | #if defined(MBEDTLS_CT_SIZE_64) |
| 210 | for (; (i + 8) <= len; i += 8) { |
| 211 | uint64_t a = mbedtls_get_unaligned_uint64(src1 + i) & mask; |
| 212 | uint64_t b = mbedtls_get_unaligned_uint64(src2 + i) & not_mask; |
| 213 | mbedtls_put_unaligned_uint64(dest + i, a | b); |
| 214 | } |
| 215 | #else |
Dave Rodgman | 7fe6e6f | 2023-05-17 12:34:56 +0100 | [diff] [blame] | 216 | for (; (i + 4) <= len; i += 4) { |
| 217 | uint32_t a = mbedtls_get_unaligned_uint32(src1 + i) & mask; |
| 218 | uint32_t b = mbedtls_get_unaligned_uint32(src2 + i) & not_mask; |
| 219 | mbedtls_put_unaligned_uint32(dest + i, a | b); |
| 220 | } |
Dave Rodgman | 42391b4 | 2023-05-19 10:33:21 +0100 | [diff] [blame] | 221 | #endif /* defined(MBEDTLS_CT_SIZE_64) */ |
Dave Rodgman | 7fe6e6f | 2023-05-17 12:34:56 +0100 | [diff] [blame] | 222 | #endif /* MBEDTLS_EFFICIENT_UNALIGNED_ACCESS */ |
| 223 | for (; i < len; i++) { |
| 224 | dest[i] = (src1[i] & mask) | (src2[i] & not_mask); |
| 225 | } |
| 226 | } |
| 227 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 228 | void mbedtls_ct_memcpy_offset(unsigned char *dest, |
| 229 | const unsigned char *src, |
| 230 | size_t offset, |
| 231 | size_t offset_min, |
| 232 | size_t offset_max, |
| 233 | size_t len) |
gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 234 | { |
Gabor Mezei | 63bbba5 | 2021-10-18 16:17:57 +0200 | [diff] [blame] | 235 | size_t offsetval; |
gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 236 | |
Gilles Peskine | 449bd83 | 2023-01-11 14:50:10 +0100 | [diff] [blame] | 237 | for (offsetval = offset_min; offsetval <= offset_max; offsetval++) { |
Dave Rodgman | b7825ce | 2023-08-10 11:58:18 +0100 | [diff] [blame] | 238 | mbedtls_ct_memcpy_if(mbedtls_ct_uint_eq(offsetval, offset), dest, src + offsetval, NULL, |
Dave Rodgman | 585f7f7 | 2023-05-17 17:45:33 +0100 | [diff] [blame] | 239 | len); |
gabor-mezei-arm | 0e7f71e | 2021-09-27 13:57:45 +0200 | [diff] [blame] | 240 | } |
| 241 | } |
gabor-mezei-arm | 1349ffd | 2021-09-27 14:28:31 +0200 | [diff] [blame] | 242 | |
Dave Rodgman | debf867 | 2023-05-17 12:12:44 +0100 | [diff] [blame] | 243 | #if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) |
| 244 | |
| 245 | void mbedtls_ct_zeroize_if(mbedtls_ct_condition_t condition, void *buf, size_t len) |
| 246 | { |
| 247 | uint32_t mask = (uint32_t) ~condition; |
| 248 | uint8_t *p = (uint8_t *) buf; |
| 249 | size_t i = 0; |
| 250 | #if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS) |
| 251 | for (; (i + 4) <= len; i += 4) { |
| 252 | mbedtls_put_unaligned_uint32((void *) (p + i), |
| 253 | mbedtls_get_unaligned_uint32((void *) (p + i)) & mask); |
| 254 | } |
| 255 | #endif |
| 256 | for (; i < len; i++) { |
| 257 | p[i] = p[i] & mask; |
| 258 | } |
| 259 | } |
| 260 | |
| 261 | #endif /* defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT) */ |