blob: 2faba69e4581546e720872ad0d9c8c76f7b8ba9f [file] [log] [blame]
gabor-mezei-armd1125342021-07-12 16:31:22 +02001/**
2 * Constant-time functions
3 *
4 * Copyright The Mbed TLS Contributors
5 * SPDX-License-Identifier: Apache-2.0
6 *
7 * Licensed under the Apache License, Version 2.0 (the "License"); you may
8 * not use this file except in compliance with the License.
9 * You may obtain a copy of the License at
10 *
11 * http://www.apache.org/licenses/LICENSE-2.0
12 *
13 * Unless required by applicable law or agreed to in writing, software
14 * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
15 * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16 * See the License for the specific language governing permissions and
17 * limitations under the License.
18 */
19
Gilles Peskine449bd832023-01-11 14:50:10 +010020/*
Gabor Mezei642eeb22021-11-03 16:13:32 +010021 * The following functions are implemented without using comparison operators, as those
Gabor Mezeieab90bc2021-10-18 16:09:41 +020022 * might be translated to branches by some compilers on some platforms.
23 */
24
gabor-mezei-armd1125342021-07-12 16:31:22 +020025#include "common.h"
Gabor Mezei22c9a6f2021-10-20 12:09:35 +020026#include "constant_time_internal.h"
Gabor Mezei765862c2021-10-19 12:22:25 +020027#include "mbedtls/constant_time.h"
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +020028#include "mbedtls/error.h"
gabor-mezei-arm5b3a32d2021-09-29 10:50:31 +020029#include "mbedtls/platform_util.h"
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +020030
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +020031#if defined(MBEDTLS_BIGNUM_C)
32#include "mbedtls/bignum.h"
Gabor Mezei87638a92022-09-15 20:02:36 +020033#include "bignum_core.h"
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +020034#endif
35
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +020036#if defined(MBEDTLS_SSL_TLS_C)
37#include "ssl_misc.h"
38#endif
39
gabor-mezei-arm5b3a32d2021-09-29 10:50:31 +020040#if defined(MBEDTLS_RSA_C)
41#include "mbedtls/rsa.h"
42#endif
43
Gabor Mezei28d61152021-11-15 16:13:01 +010044#if defined(MBEDTLS_BASE64_C)
45#include "constant_time_invasive.h"
46#endif
47
gabor-mezei-armfdb71182021-09-27 16:11:12 +020048#include <string.h>
Andrzej Kurek8a045ce2022-12-23 11:00:06 -050049#if defined(MBEDTLS_USE_PSA_CRYPTO)
50#define PSA_TO_MBEDTLS_ERR(status) PSA_TO_MBEDTLS_ERR_LIST(status, \
51 psa_to_ssl_errors, \
52 psa_generic_status_to_mbedtls)
53#endif
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +020054
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000055/*
Dave Rodgman051225d2022-12-30 21:25:35 +000056 * Define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS where assembly is present to
57 * perform fast unaligned access to volatile data.
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000058 *
59 * This is needed because mbedtls_get_unaligned_uintXX etc don't support volatile
60 * memory accesses.
61 *
Dave Rodgman051225d2022-12-30 21:25:35 +000062 * Some of these definitions could be moved into alignment.h but for now they are
63 * only used here.
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000064 */
Dave Rodgman051225d2022-12-30 21:25:35 +000065#if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS) && defined(MBEDTLS_HAVE_ASM)
Dave Rodgmanc54f25e2023-06-21 13:39:30 +010066#if ((defined(__arm__) || defined(__thumb__) || defined(__thumb2__)) && \
Dave Rodgmanb5b69392023-06-21 16:36:42 +010067 (UINTPTR_MAX == 0xfffffffful)) || defined(__aarch64__)
Dave Rodgman63e89b42023-06-21 11:55:17 +010068/* We check pointer sizes to avoid issues with them not matching register size requirements */
Dave Rodgman051225d2022-12-30 21:25:35 +000069#define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS
70#endif
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000071#endif
72
Dave Rodgman051225d2022-12-30 21:25:35 +000073#if defined(MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS)
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000074static inline uint32_t mbedtls_get_unaligned_volatile_uint32(volatile const unsigned char *p)
75{
76 /* This is UB, even where it's safe:
77 * return *((volatile uint32_t*)p);
78 * so instead the same thing is expressed in assembly below.
79 */
80 uint32_t r;
81#if defined(__arm__) || defined(__thumb__) || defined(__thumb2__)
Dave Rodgman4610d4b2023-01-30 09:26:48 +000082 asm volatile ("ldr %0, [%1]" : "=r" (r) : "r" (p) :);
Dave Rodgman04cb9ac2023-06-21 07:32:22 +010083#elif defined(__aarch64__)
Dave Rodgman5b5dd012023-06-21 16:36:47 +010084 asm volatile ("ldr %w0, [%1]" : "=r" (r) : MBEDTLS_ASM_AARCH64_PTR_CONSTRAINT(p) :);
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000085#endif
Dave Rodgman051225d2022-12-30 21:25:35 +000086 return r;
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000087}
Dave Rodgman051225d2022-12-30 21:25:35 +000088#endif /* MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS */
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000089
Gilles Peskine449bd832023-01-11 14:50:10 +010090int mbedtls_ct_memcmp(const void *a,
91 const void *b,
92 size_t n)
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +020093{
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000094 size_t i = 0;
Dave Rodgman7658b632023-01-11 17:39:33 +000095 /*
96 * `A` and `B` are cast to volatile to ensure that the compiler
97 * generates code that always fully reads both buffers.
98 * Otherwise it could generate a test to exit early if `diff` has all
99 * bits set early in the loop.
100 */
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +0200101 volatile const unsigned char *A = (volatile const unsigned char *) a;
102 volatile const unsigned char *B = (volatile const unsigned char *) b;
Dave Rodgman7658b632023-01-11 17:39:33 +0000103 uint32_t diff = 0;
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +0200104
Dave Rodgman051225d2022-12-30 21:25:35 +0000105#if defined(MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS)
Dave Rodgman36dfc5a2022-12-22 15:04:43 +0000106 for (; (i + 4) <= n; i += 4) {
107 uint32_t x = mbedtls_get_unaligned_volatile_uint32(A + i);
108 uint32_t y = mbedtls_get_unaligned_volatile_uint32(B + i);
109 diff |= x ^ y;
110 }
111#endif
112
113 for (; i < n; i++) {
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +0200114 /* Read volatile data in order before computing diff.
115 * This avoids IAR compiler warning:
116 * 'the order of volatile accesses is undefined ..' */
117 unsigned char x = A[i], y = B[i];
118 diff |= x ^ y;
119 }
120
Gilles Peskine449bd832023-01-11 14:50:10 +0100121 return (int) diff;
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +0200122}
123
Gilles Peskine449bd832023-01-11 14:50:10 +0100124unsigned mbedtls_ct_uint_mask(unsigned value)
gabor-mezei-arm340948e2021-09-27 11:40:03 +0200125{
126 /* MSVC has a warning about unary minus on unsigned, but this is
127 * well-defined and precisely what we want to do here */
128#if defined(_MSC_VER)
129#pragma warning( push )
130#pragma warning( disable : 4146 )
131#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100132 return -((value | -value) >> (sizeof(value) * 8 - 1));
gabor-mezei-arm340948e2021-09-27 11:40:03 +0200133#if defined(_MSC_VER)
134#pragma warning( pop )
135#endif
136}
gabor-mezei-arm3733bf82021-09-27 11:49:42 +0200137
Przemek Stekiel89ad6232022-09-27 13:36:12 +0200138#if defined(MBEDTLS_SSL_SOME_SUITES_USE_MAC)
Gabor Mezei6a426c92021-10-20 11:17:43 +0200139
Gilles Peskine449bd832023-01-11 14:50:10 +0100140size_t mbedtls_ct_size_mask(size_t value)
gabor-mezei-arm3733bf82021-09-27 11:49:42 +0200141{
142 /* MSVC has a warning about unary minus on unsigned integer types,
143 * but this is well-defined and precisely what we want to do here. */
144#if defined(_MSC_VER)
145#pragma warning( push )
146#pragma warning( disable : 4146 )
147#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100148 return -((value | -value) >> (sizeof(value) * 8 - 1));
gabor-mezei-arm3733bf82021-09-27 11:49:42 +0200149#if defined(_MSC_VER)
150#pragma warning( pop )
151#endif
152}
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200153
Przemek Stekiel89ad6232022-09-27 13:36:12 +0200154#endif /* MBEDTLS_SSL_SOME_SUITES_USE_MAC */
Gabor Mezei6a426c92021-10-20 11:17:43 +0200155
gabor-mezei-arm9cb55692021-08-11 15:07:02 +0200156#if defined(MBEDTLS_BIGNUM_C)
157
Gilles Peskine449bd832023-01-11 14:50:10 +0100158mbedtls_mpi_uint mbedtls_ct_mpi_uint_mask(mbedtls_mpi_uint value)
gabor-mezei-arm9cb55692021-08-11 15:07:02 +0200159{
160 /* MSVC has a warning about unary minus on unsigned, but this is
161 * well-defined and precisely what we want to do here */
162#if defined(_MSC_VER)
163#pragma warning( push )
164#pragma warning( disable : 4146 )
165#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100166 return -((value | -value) >> (sizeof(value) * 8 - 1));
gabor-mezei-arm9cb55692021-08-11 15:07:02 +0200167#if defined(_MSC_VER)
168#pragma warning( pop )
169#endif
170}
171
172#endif /* MBEDTLS_BIGNUM_C */
173
Gabor Mezeie2123792021-10-18 17:05:06 +0200174#if defined(MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC)
175
Gabor Mezei1e642612021-10-18 16:05:50 +0200176/** Constant-flow mask generation for "less than" comparison:
177 * - if \p x < \p y, return all-bits 1, that is (size_t) -1
178 * - otherwise, return all bits 0, that is 0
179 *
180 * This function can be used to write constant-time code by replacing branches
181 * with bit operations using masks.
182 *
183 * \param x The first value to analyze.
184 * \param y The second value to analyze.
185 *
186 * \return All-bits-one if \p x is less than \p y, otherwise zero.
187 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100188static size_t mbedtls_ct_size_mask_lt(size_t x,
189 size_t y)
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200190{
191 /* This has the most significant bit set if and only if x < y */
192 const size_t sub = x - y;
193
194 /* sub1 = (x < y) ? 1 : 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100195 const size_t sub1 = sub >> (sizeof(sub) * 8 - 1);
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200196
197 /* mask = (x < y) ? 0xff... : 0x00... */
Gilles Peskine449bd832023-01-11 14:50:10 +0100198 const size_t mask = mbedtls_ct_size_mask(sub1);
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200199
Gilles Peskine449bd832023-01-11 14:50:10 +0100200 return mask;
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200201}
gabor-mezei-arm16fc57b2021-09-27 11:58:31 +0200202
Gilles Peskine449bd832023-01-11 14:50:10 +0100203size_t mbedtls_ct_size_mask_ge(size_t x,
204 size_t y)
gabor-mezei-arm16fc57b2021-09-27 11:58:31 +0200205{
Gilles Peskine449bd832023-01-11 14:50:10 +0100206 return ~mbedtls_ct_size_mask_lt(x, y);
gabor-mezei-arm16fc57b2021-09-27 11:58:31 +0200207}
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200208
Gabor Mezeie2123792021-10-18 17:05:06 +0200209#endif /* MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC */
210
Gabor Mezei28d61152021-11-15 16:13:01 +0100211#if defined(MBEDTLS_BASE64_C)
212
213/* Return 0xff if low <= c <= high, 0 otherwise.
214 *
215 * Constant flow with respect to c.
216 */
Gabor Mezeic0d8dda2021-11-26 17:20:36 +0100217MBEDTLS_STATIC_TESTABLE
Gilles Peskine449bd832023-01-11 14:50:10 +0100218unsigned char mbedtls_ct_uchar_mask_of_range(unsigned char low,
219 unsigned char high,
220 unsigned char c)
Gabor Mezei28d61152021-11-15 16:13:01 +0100221{
222 /* low_mask is: 0 if low <= c, 0x...ff if low > c */
Gilles Peskine449bd832023-01-11 14:50:10 +0100223 unsigned low_mask = ((unsigned) c - low) >> 8;
Gabor Mezei28d61152021-11-15 16:13:01 +0100224 /* high_mask is: 0 if c <= high, 0x...ff if c > high */
Gilles Peskine449bd832023-01-11 14:50:10 +0100225 unsigned high_mask = ((unsigned) high - c) >> 8;
226 return ~(low_mask | high_mask) & 0xff;
Gabor Mezei28d61152021-11-15 16:13:01 +0100227}
228
229#endif /* MBEDTLS_BASE64_C */
230
Gilles Peskine449bd832023-01-11 14:50:10 +0100231unsigned mbedtls_ct_size_bool_eq(size_t x,
232 size_t y)
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200233{
234 /* diff = 0 if x == y, non-zero otherwise */
235 const size_t diff = x ^ y;
236
237 /* MSVC has a warning about unary minus on unsigned integer types,
238 * but this is well-defined and precisely what we want to do here. */
239#if defined(_MSC_VER)
240#pragma warning( push )
241#pragma warning( disable : 4146 )
242#endif
243
244 /* diff_msb's most significant bit is equal to x != y */
Gilles Peskine449bd832023-01-11 14:50:10 +0100245 const size_t diff_msb = (diff | (size_t) -diff);
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200246
247#if defined(_MSC_VER)
248#pragma warning( pop )
249#endif
250
251 /* diff1 = (x != y) ? 1 : 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100252 const unsigned diff1 = diff_msb >> (sizeof(diff_msb) * 8 - 1);
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200253
Gilles Peskine449bd832023-01-11 14:50:10 +0100254 return 1 ^ diff1;
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200255}
gabor-mezei-arm5a854422021-09-27 12:25:07 +0200256
Gabor Mezeie2123792021-10-18 17:05:06 +0200257#if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT)
258
Gabor Mezeia2d0f902021-10-18 16:35:23 +0200259/** Constant-flow "greater than" comparison:
260 * return x > y
261 *
262 * This is equivalent to \p x > \p y, but is likely to be compiled
263 * to code using bitwise operation rather than a branch.
264 *
265 * \param x The first value to analyze.
266 * \param y The second value to analyze.
267 *
268 * \return 1 if \p x greater than \p y, otherwise 0.
269 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100270static unsigned mbedtls_ct_size_gt(size_t x,
271 size_t y)
gabor-mezei-arm5a854422021-09-27 12:25:07 +0200272{
gabor-mezei-arm87ac5be2021-08-10 20:36:09 +0200273 /* Return the sign bit (1 for negative) of (y - x). */
Gilles Peskine449bd832023-01-11 14:50:10 +0100274 return (y - x) >> (sizeof(size_t) * 8 - 1);
gabor-mezei-arm5a854422021-09-27 12:25:07 +0200275}
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200276
Gabor Mezeie2123792021-10-18 17:05:06 +0200277#endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */
278
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200279#if defined(MBEDTLS_BIGNUM_C)
280
Gilles Peskine449bd832023-01-11 14:50:10 +0100281unsigned mbedtls_ct_mpi_uint_lt(const mbedtls_mpi_uint x,
282 const mbedtls_mpi_uint y)
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200283{
284 mbedtls_mpi_uint ret;
285 mbedtls_mpi_uint cond;
286
287 /*
288 * Check if the most significant bits (MSB) of the operands are different.
289 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100290 cond = (x ^ y);
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200291 /*
292 * If the MSB are the same then the difference x-y will be negative (and
293 * have its MSB set to 1 during conversion to unsigned) if and only if x<y.
294 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100295 ret = (x - y) & ~cond;
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200296 /*
297 * If the MSB are different, then the operand with the MSB of 1 is the
298 * bigger. (That is if y has MSB of 1, then x<y is true and it is false if
299 * the MSB of y is 0.)
300 */
301 ret |= y & cond;
302
303
Gilles Peskine449bd832023-01-11 14:50:10 +0100304 ret = ret >> (sizeof(mbedtls_mpi_uint) * 8 - 1);
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200305
306 return (unsigned) ret;
307}
308
309#endif /* MBEDTLS_BIGNUM_C */
gabor-mezei-armb2dbf2c2021-09-27 12:59:30 +0200310
Gilles Peskine449bd832023-01-11 14:50:10 +0100311unsigned mbedtls_ct_uint_if(unsigned condition,
312 unsigned if1,
313 unsigned if0)
gabor-mezei-armb2dbf2c2021-09-27 12:59:30 +0200314{
Gilles Peskine449bd832023-01-11 14:50:10 +0100315 unsigned mask = mbedtls_ct_uint_mask(condition);
316 return (mask & if1) | (~mask & if0);
gabor-mezei-armb2dbf2c2021-09-27 12:59:30 +0200317}
gabor-mezei-armd3230d52021-09-27 13:03:57 +0200318
Gabor Mezeie2123792021-10-18 17:05:06 +0200319#if defined(MBEDTLS_BIGNUM_C)
gabor-mezei-arm65cefdb2021-09-27 15:47:00 +0200320
Gilles Peskine449bd832023-01-11 14:50:10 +0100321void mbedtls_ct_mpi_uint_cond_assign(size_t n,
322 mbedtls_mpi_uint *dest,
323 const mbedtls_mpi_uint *src,
324 unsigned char condition)
gabor-mezei-armbe8d98b2021-09-27 13:17:15 +0200325{
326 size_t i;
327
328 /* MSVC has a warning about unary minus on unsigned integer types,
329 * but this is well-defined and precisely what we want to do here. */
330#if defined(_MSC_VER)
331#pragma warning( push )
332#pragma warning( disable : 4146 )
333#endif
334
gabor-mezei-arm87ac5be2021-08-10 20:36:09 +0200335 /* all-bits 1 if condition is 1, all-bits 0 if condition is 0 */
336 const mbedtls_mpi_uint mask = -condition;
gabor-mezei-armbe8d98b2021-09-27 13:17:15 +0200337
338#if defined(_MSC_VER)
339#pragma warning( pop )
340#endif
341
Gilles Peskine449bd832023-01-11 14:50:10 +0100342 for (i = 0; i < n; i++) {
343 dest[i] = (src[i] & mask) | (dest[i] & ~mask);
344 }
gabor-mezei-armbe8d98b2021-09-27 13:17:15 +0200345}
346
347#endif /* MBEDTLS_BIGNUM_C */
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200348
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100349#if defined(MBEDTLS_BASE64_C)
350
Gilles Peskine449bd832023-01-11 14:50:10 +0100351unsigned char mbedtls_ct_base64_enc_char(unsigned char value)
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100352{
353 unsigned char digit = 0;
Gabor Mezei14d5fac2021-11-24 15:51:39 +0100354 /* For each range of values, if value is in that range, mask digit with
355 * the corresponding value. Since value can only be in a single range,
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100356 * only at most one masking will change digit. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100357 digit |= mbedtls_ct_uchar_mask_of_range(0, 25, value) & ('A' + value);
358 digit |= mbedtls_ct_uchar_mask_of_range(26, 51, value) & ('a' + value - 26);
359 digit |= mbedtls_ct_uchar_mask_of_range(52, 61, value) & ('0' + value - 52);
360 digit |= mbedtls_ct_uchar_mask_of_range(62, 62, value) & '+';
361 digit |= mbedtls_ct_uchar_mask_of_range(63, 63, value) & '/';
362 return digit;
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100363}
364
Gilles Peskine449bd832023-01-11 14:50:10 +0100365signed char mbedtls_ct_base64_dec_value(unsigned char c)
Gabor Mezei358829a2021-11-15 16:22:37 +0100366{
367 unsigned char val = 0;
368 /* For each range of digits, if c is in that range, mask val with
369 * the corresponding value. Since c can only be in a single range,
370 * only at most one masking will change val. Set val to one plus
371 * the desired value so that it stays 0 if c is in none of the ranges. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100372 val |= mbedtls_ct_uchar_mask_of_range('A', 'Z', c) & (c - 'A' + 0 + 1);
373 val |= mbedtls_ct_uchar_mask_of_range('a', 'z', c) & (c - 'a' + 26 + 1);
374 val |= mbedtls_ct_uchar_mask_of_range('0', '9', c) & (c - '0' + 52 + 1);
375 val |= mbedtls_ct_uchar_mask_of_range('+', '+', c) & (c - '+' + 62 + 1);
376 val |= mbedtls_ct_uchar_mask_of_range('/', '/', c) & (c - '/' + 63 + 1);
Gabor Mezei358829a2021-11-15 16:22:37 +0100377 /* At this point, val is 0 if c is an invalid digit and v+1 if c is
378 * a digit with the value v. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100379 return val - 1;
Gabor Mezei358829a2021-11-15 16:22:37 +0100380}
381
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100382#endif /* MBEDTLS_BASE64_C */
383
Gabor Mezeie2123792021-10-18 17:05:06 +0200384#if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT)
385
Gabor Mezeia2d0f902021-10-18 16:35:23 +0200386/** Shift some data towards the left inside a buffer.
387 *
Gabor Mezei90437e32021-10-20 11:59:27 +0200388 * `mbedtls_ct_mem_move_to_left(start, total, offset)` is functionally
Gabor Mezeia2d0f902021-10-18 16:35:23 +0200389 * equivalent to
390 * ```
391 * memmove(start, start + offset, total - offset);
392 * memset(start + offset, 0, total - offset);
393 * ```
394 * but it strives to use a memory access pattern (and thus total timing)
395 * that does not depend on \p offset. This timing independence comes at
396 * the expense of performance.
397 *
398 * \param start Pointer to the start of the buffer.
399 * \param total Total size of the buffer.
400 * \param offset Offset from which to copy \p total - \p offset bytes.
401 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100402static void mbedtls_ct_mem_move_to_left(void *start,
403 size_t total,
404 size_t offset)
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200405{
406 volatile unsigned char *buf = start;
407 size_t i, n;
Gilles Peskine449bd832023-01-11 14:50:10 +0100408 if (total == 0) {
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200409 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100410 }
411 for (i = 0; i < total; i++) {
412 unsigned no_op = mbedtls_ct_size_gt(total - offset, i);
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200413 /* The first `total - offset` passes are a no-op. The last
414 * `offset` passes shift the data one byte to the left and
415 * zero out the last byte. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100416 for (n = 0; n < total - 1; n++) {
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200417 unsigned char current = buf[n];
418 unsigned char next = buf[n+1];
Gilles Peskine449bd832023-01-11 14:50:10 +0100419 buf[n] = mbedtls_ct_uint_if(no_op, current, next);
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200420 }
Gilles Peskine449bd832023-01-11 14:50:10 +0100421 buf[total-1] = mbedtls_ct_uint_if(no_op, buf[total-1], 0);
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200422 }
423}
gabor-mezei-armdee0fd32021-09-27 13:34:25 +0200424
Gabor Mezeie2123792021-10-18 17:05:06 +0200425#endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */
426
Przemek Stekiel89ad6232022-09-27 13:36:12 +0200427#if defined(MBEDTLS_SSL_SOME_SUITES_USE_MAC)
Gabor Mezeie2123792021-10-18 17:05:06 +0200428
Gilles Peskine449bd832023-01-11 14:50:10 +0100429void mbedtls_ct_memcpy_if_eq(unsigned char *dest,
430 const unsigned char *src,
431 size_t len,
432 size_t c1,
433 size_t c2)
gabor-mezei-armdee0fd32021-09-27 13:34:25 +0200434{
435 /* mask = c1 == c2 ? 0xff : 0x00 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100436 const size_t equal = mbedtls_ct_size_bool_eq(c1, c2);
gabor-mezei-armdee0fd32021-09-27 13:34:25 +0200437
gabor-mezei-arm87ac5be2021-08-10 20:36:09 +0200438 /* dest[i] = c1 == c2 ? src[i] : dest[i] */
Dave Rodgman36dfc5a2022-12-22 15:04:43 +0000439 size_t i = 0;
440#if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS)
441 const uint32_t mask32 = (uint32_t) mbedtls_ct_size_mask(equal);
442 const unsigned char mask = (unsigned char) mask32 & 0xff;
443
444 for (; (i + 4) <= len; i += 4) {
445 uint32_t a = mbedtls_get_unaligned_uint32(src + i) & mask32;
446 uint32_t b = mbedtls_get_unaligned_uint32(dest + i) & ~mask32;
447 mbedtls_put_unaligned_uint32(dest + i, a | b);
448 }
449#else
450 const unsigned char mask = (unsigned char) mbedtls_ct_size_mask(equal);
451#endif /* MBEDTLS_EFFICIENT_UNALIGNED_ACCESS */
452 for (; i < len; i++) {
Gilles Peskine449bd832023-01-11 14:50:10 +0100453 dest[i] = (src[i] & mask) | (dest[i] & ~mask);
454 }
gabor-mezei-armdee0fd32021-09-27 13:34:25 +0200455}
gabor-mezei-arm0e7f71e2021-09-27 13:57:45 +0200456
Gilles Peskine449bd832023-01-11 14:50:10 +0100457void mbedtls_ct_memcpy_offset(unsigned char *dest,
458 const unsigned char *src,
459 size_t offset,
460 size_t offset_min,
461 size_t offset_max,
462 size_t len)
gabor-mezei-arm0e7f71e2021-09-27 13:57:45 +0200463{
Gabor Mezei63bbba52021-10-18 16:17:57 +0200464 size_t offsetval;
gabor-mezei-arm0e7f71e2021-09-27 13:57:45 +0200465
Gilles Peskine449bd832023-01-11 14:50:10 +0100466 for (offsetval = offset_min; offsetval <= offset_max; offsetval++) {
467 mbedtls_ct_memcpy_if_eq(dest, src + offsetval, len,
468 offsetval, offset);
gabor-mezei-arm0e7f71e2021-09-27 13:57:45 +0200469 }
470}
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200471
Neil Armstrong2968d302022-02-25 15:09:36 +0100472#if defined(MBEDTLS_USE_PSA_CRYPTO)
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100473
474#if defined(PSA_WANT_ALG_SHA_384)
Gilles Peskine449bd832023-01-11 14:50:10 +0100475#define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_384)
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100476#elif defined(PSA_WANT_ALG_SHA_256)
Gilles Peskine449bd832023-01-11 14:50:10 +0100477#define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_256)
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100478#else /* See check_config.h */
Gilles Peskine449bd832023-01-11 14:50:10 +0100479#define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_1)
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100480#endif
481
Gilles Peskine449bd832023-01-11 14:50:10 +0100482int mbedtls_ct_hmac(mbedtls_svc_key_id_t key,
483 psa_algorithm_t mac_alg,
484 const unsigned char *add_data,
485 size_t add_data_len,
486 const unsigned char *data,
487 size_t data_len_secret,
488 size_t min_data_len,
489 size_t max_data_len,
490 unsigned char *output)
Neil Armstrong2968d302022-02-25 15:09:36 +0100491{
492 /*
Neil Armstrong28d9c632022-03-17 16:33:27 +0100493 * This function breaks the HMAC abstraction and uses psa_hash_clone()
494 * extension in order to get constant-flow behaviour.
Neil Armstrong2968d302022-02-25 15:09:36 +0100495 *
496 * HMAC(msg) is defined as HASH(okey + HASH(ikey + msg)) where + means
497 * concatenation, and okey/ikey are the XOR of the key with some fixed bit
498 * patterns (see RFC 2104, sec. 2).
499 *
500 * We'll first compute ikey/okey, then inner_hash = HASH(ikey + msg) by
501 * hashing up to minlen, then cloning the context, and for each byte up
502 * to maxlen finishing up the hash computation, keeping only the
503 * correct result.
504 *
505 * Then we only need to compute HASH(okey + inner_hash) and we're done.
506 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100507 psa_algorithm_t hash_alg = PSA_ALG_HMAC_GET_HASH(mac_alg);
508 const size_t block_size = PSA_HASH_BLOCK_LENGTH(hash_alg);
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100509 unsigned char key_buf[MAX_HASH_BLOCK_LENGTH];
Gilles Peskine449bd832023-01-11 14:50:10 +0100510 const size_t hash_size = PSA_HASH_LENGTH(hash_alg);
Neil Armstrong2968d302022-02-25 15:09:36 +0100511 psa_hash_operation_t operation = PSA_HASH_OPERATION_INIT;
512 size_t hash_length;
513
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100514 unsigned char aux_out[PSA_HASH_MAX_SIZE];
Neil Armstrong2968d302022-02-25 15:09:36 +0100515 psa_hash_operation_t aux_operation = PSA_HASH_OPERATION_INIT;
516 size_t offset;
517 psa_status_t status = PSA_ERROR_CORRUPTION_DETECTED;
518
Neil Armstrong2968d302022-02-25 15:09:36 +0100519 size_t mac_key_length;
520 size_t i;
521
Gilles Peskine449bd832023-01-11 14:50:10 +0100522#define PSA_CHK(func_call) \
Neil Armstrong2968d302022-02-25 15:09:36 +0100523 do { \
524 status = (func_call); \
Gilles Peskine449bd832023-01-11 14:50:10 +0100525 if (status != PSA_SUCCESS) \
526 goto cleanup; \
527 } while (0)
Neil Armstrong2968d302022-02-25 15:09:36 +0100528
Neil Armstrong72c2f762022-03-17 16:39:10 +0100529 /* Export MAC key
530 * We assume key length is always exactly the output size
531 * which is never more than the block size, thus we use block_size
532 * as the key buffer size.
533 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100534 PSA_CHK(psa_export_key(key, key_buf, block_size, &mac_key_length));
Neil Armstrong2968d302022-02-25 15:09:36 +0100535
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100536 /* Calculate ikey */
Gilles Peskine449bd832023-01-11 14:50:10 +0100537 for (i = 0; i < mac_key_length; i++) {
538 key_buf[i] = (unsigned char) (key_buf[i] ^ 0x36);
539 }
540 for (; i < block_size; ++i) {
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100541 key_buf[i] = 0x36;
Gilles Peskine449bd832023-01-11 14:50:10 +0100542 }
Neil Armstrong2968d302022-02-25 15:09:36 +0100543
Gilles Peskine449bd832023-01-11 14:50:10 +0100544 PSA_CHK(psa_hash_setup(&operation, hash_alg));
Neil Armstrong2968d302022-02-25 15:09:36 +0100545
546 /* Now compute inner_hash = HASH(ikey + msg) */
Gilles Peskine449bd832023-01-11 14:50:10 +0100547 PSA_CHK(psa_hash_update(&operation, key_buf, block_size));
548 PSA_CHK(psa_hash_update(&operation, add_data, add_data_len));
549 PSA_CHK(psa_hash_update(&operation, data, min_data_len));
Neil Armstrong2968d302022-02-25 15:09:36 +0100550
Paul Elliott5260ce22022-05-09 18:15:54 +0100551 /* Fill the hash buffer in advance with something that is
552 * not a valid hash (barring an attack on the hash and
553 * deliberately-crafted input), in case the caller doesn't
554 * check the return status properly. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100555 memset(output, '!', hash_size);
Paul Elliott5260ce22022-05-09 18:15:54 +0100556
Neil Armstrong2968d302022-02-25 15:09:36 +0100557 /* For each possible length, compute the hash up to that point */
Gilles Peskine449bd832023-01-11 14:50:10 +0100558 for (offset = min_data_len; offset <= max_data_len; offset++) {
559 PSA_CHK(psa_hash_clone(&operation, &aux_operation));
560 PSA_CHK(psa_hash_finish(&aux_operation, aux_out,
561 PSA_HASH_MAX_SIZE, &hash_length));
Neil Armstrong2968d302022-02-25 15:09:36 +0100562 /* Keep only the correct inner_hash in the output buffer */
Gilles Peskine449bd832023-01-11 14:50:10 +0100563 mbedtls_ct_memcpy_if_eq(output, aux_out, hash_size,
564 offset, data_len_secret);
Neil Armstrong2968d302022-02-25 15:09:36 +0100565
Gilles Peskine449bd832023-01-11 14:50:10 +0100566 if (offset < max_data_len) {
567 PSA_CHK(psa_hash_update(&operation, data + offset, 1));
568 }
Neil Armstrong2968d302022-02-25 15:09:36 +0100569 }
570
Neil Armstrong28d9c632022-03-17 16:33:27 +0100571 /* Abort current operation to prepare for final operation */
Gilles Peskine449bd832023-01-11 14:50:10 +0100572 PSA_CHK(psa_hash_abort(&operation));
Neil Armstrong2968d302022-02-25 15:09:36 +0100573
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100574 /* Calculate okey */
Gilles Peskine449bd832023-01-11 14:50:10 +0100575 for (i = 0; i < mac_key_length; i++) {
576 key_buf[i] = (unsigned char) ((key_buf[i] ^ 0x36) ^ 0x5C);
577 }
578 for (; i < block_size; ++i) {
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100579 key_buf[i] = 0x5C;
Gilles Peskine449bd832023-01-11 14:50:10 +0100580 }
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100581
Neil Armstrong2968d302022-02-25 15:09:36 +0100582 /* Now compute HASH(okey + inner_hash) */
Gilles Peskine449bd832023-01-11 14:50:10 +0100583 PSA_CHK(psa_hash_setup(&operation, hash_alg));
584 PSA_CHK(psa_hash_update(&operation, key_buf, block_size));
585 PSA_CHK(psa_hash_update(&operation, output, hash_size));
586 PSA_CHK(psa_hash_finish(&operation, output, hash_size, &hash_length));
Neil Armstrong2968d302022-02-25 15:09:36 +0100587
588#undef PSA_CHK
589
590cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100591 mbedtls_platform_zeroize(key_buf, MAX_HASH_BLOCK_LENGTH);
592 mbedtls_platform_zeroize(aux_out, PSA_HASH_MAX_SIZE);
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100593
Gilles Peskine449bd832023-01-11 14:50:10 +0100594 psa_hash_abort(&operation);
595 psa_hash_abort(&aux_operation);
Andrzej Kurek8a045ce2022-12-23 11:00:06 -0500596 return PSA_TO_MBEDTLS_ERR(status);
Neil Armstrong2968d302022-02-25 15:09:36 +0100597}
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100598
599#undef MAX_HASH_BLOCK_LENGTH
600
Neil Armstrong2968d302022-02-25 15:09:36 +0100601#else
Gilles Peskine449bd832023-01-11 14:50:10 +0100602int mbedtls_ct_hmac(mbedtls_md_context_t *ctx,
603 const unsigned char *add_data,
604 size_t add_data_len,
605 const unsigned char *data,
606 size_t data_len_secret,
607 size_t min_data_len,
608 size_t max_data_len,
609 unsigned char *output)
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200610{
611 /*
612 * This function breaks the HMAC abstraction and uses the md_clone()
613 * extension to the MD API in order to get constant-flow behaviour.
614 *
615 * HMAC(msg) is defined as HASH(okey + HASH(ikey + msg)) where + means
616 * concatenation, and okey/ikey are the XOR of the key with some fixed bit
617 * patterns (see RFC 2104, sec. 2), which are stored in ctx->hmac_ctx.
618 *
619 * We'll first compute inner_hash = HASH(ikey + msg) by hashing up to
620 * minlen, then cloning the context, and for each byte up to maxlen
621 * finishing up the hash computation, keeping only the correct result.
622 *
623 * Then we only need to compute HASH(okey + inner_hash) and we're done.
624 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100625 const mbedtls_md_type_t md_alg = mbedtls_md_get_type(ctx->md_info);
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200626 /* TLS 1.2 only supports SHA-384, SHA-256, SHA-1, MD-5,
627 * all of which have the same block size except SHA-384. */
628 const size_t block_size = md_alg == MBEDTLS_MD_SHA384 ? 128 : 64;
629 const unsigned char * const ikey = ctx->hmac_ctx;
630 const unsigned char * const okey = ikey + block_size;
Gilles Peskine449bd832023-01-11 14:50:10 +0100631 const size_t hash_size = mbedtls_md_get_size(ctx->md_info);
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200632
633 unsigned char aux_out[MBEDTLS_MD_MAX_SIZE];
634 mbedtls_md_context_t aux;
635 size_t offset;
636 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
637
Gilles Peskine449bd832023-01-11 14:50:10 +0100638 mbedtls_md_init(&aux);
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200639
Gilles Peskine449bd832023-01-11 14:50:10 +0100640#define MD_CHK(func_call) \
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200641 do { \
642 ret = (func_call); \
Gilles Peskine449bd832023-01-11 14:50:10 +0100643 if (ret != 0) \
644 goto cleanup; \
645 } while (0)
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200646
Gilles Peskine449bd832023-01-11 14:50:10 +0100647 MD_CHK(mbedtls_md_setup(&aux, ctx->md_info, 0));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200648
649 /* After hmac_start() of hmac_reset(), ikey has already been hashed,
650 * so we can start directly with the message */
Gilles Peskine449bd832023-01-11 14:50:10 +0100651 MD_CHK(mbedtls_md_update(ctx, add_data, add_data_len));
652 MD_CHK(mbedtls_md_update(ctx, data, min_data_len));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200653
Paul Elliott5260ce22022-05-09 18:15:54 +0100654 /* Fill the hash buffer in advance with something that is
655 * not a valid hash (barring an attack on the hash and
656 * deliberately-crafted input), in case the caller doesn't
657 * check the return status properly. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100658 memset(output, '!', hash_size);
Paul Elliott5260ce22022-05-09 18:15:54 +0100659
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200660 /* For each possible length, compute the hash up to that point */
Gilles Peskine449bd832023-01-11 14:50:10 +0100661 for (offset = min_data_len; offset <= max_data_len; offset++) {
662 MD_CHK(mbedtls_md_clone(&aux, ctx));
663 MD_CHK(mbedtls_md_finish(&aux, aux_out));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200664 /* Keep only the correct inner_hash in the output buffer */
Gilles Peskine449bd832023-01-11 14:50:10 +0100665 mbedtls_ct_memcpy_if_eq(output, aux_out, hash_size,
666 offset, data_len_secret);
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200667
Gilles Peskine449bd832023-01-11 14:50:10 +0100668 if (offset < max_data_len) {
669 MD_CHK(mbedtls_md_update(ctx, data + offset, 1));
670 }
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200671 }
672
673 /* The context needs to finish() before it starts() again */
Gilles Peskine449bd832023-01-11 14:50:10 +0100674 MD_CHK(mbedtls_md_finish(ctx, aux_out));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200675
676 /* Now compute HASH(okey + inner_hash) */
Gilles Peskine449bd832023-01-11 14:50:10 +0100677 MD_CHK(mbedtls_md_starts(ctx));
678 MD_CHK(mbedtls_md_update(ctx, okey, block_size));
679 MD_CHK(mbedtls_md_update(ctx, output, hash_size));
680 MD_CHK(mbedtls_md_finish(ctx, output));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200681
682 /* Done, get ready for next time */
Gilles Peskine449bd832023-01-11 14:50:10 +0100683 MD_CHK(mbedtls_md_hmac_reset(ctx));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200684
685#undef MD_CHK
686
687cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100688 mbedtls_md_free(&aux);
689 return ret;
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200690}
Neil Armstrong2968d302022-02-25 15:09:36 +0100691#endif /* MBEDTLS_USE_PSA_CRYPTO */
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200692
Przemek Stekiel89ad6232022-09-27 13:36:12 +0200693#endif /* MBEDTLS_SSL_SOME_SUITES_USE_MAC */
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200694
695#if defined(MBEDTLS_BIGNUM_C)
696
Gilles Peskine449bd832023-01-11 14:50:10 +0100697#define MPI_VALIDATE_RET(cond) \
698 MBEDTLS_INTERNAL_VALIDATE_RET(cond, MBEDTLS_ERR_MPI_BAD_INPUT_DATA)
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200699
700/*
701 * Conditionally assign X = Y, without leaking information
702 * about whether the assignment was made or not.
703 * (Leaking information about the respective sizes of X and Y is ok however.)
704 */
Tautvydas Žilys40fc7da2022-01-31 13:34:01 -0800705#if defined(_MSC_VER) && defined(_M_ARM64) && (_MSC_FULL_VER < 193131103)
Tautvydas Žilys60165d72022-01-26 15:33:27 -0800706/*
Tautvydas Žilys40fc7da2022-01-31 13:34:01 -0800707 * MSVC miscompiles this function if it's inlined prior to Visual Studio 2022 version 17.1. See:
Tautvydas Žilys60165d72022-01-26 15:33:27 -0800708 * https://developercommunity.visualstudio.com/t/c-compiler-miscompiles-part-of-mbedtls-library-on/1646989
709 */
710__declspec(noinline)
711#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100712int mbedtls_mpi_safe_cond_assign(mbedtls_mpi *X,
713 const mbedtls_mpi *Y,
714 unsigned char assign)
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200715{
716 int ret = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +0100717 MPI_VALIDATE_RET(X != NULL);
718 MPI_VALIDATE_RET(Y != NULL);
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200719
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200720 /* all-bits 1 if assign is 1, all-bits 0 if assign is 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100721 mbedtls_mpi_uint limb_mask = mbedtls_ct_mpi_uint_mask(assign);
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200722
Gilles Peskine449bd832023-01-11 14:50:10 +0100723 MBEDTLS_MPI_CHK(mbedtls_mpi_grow(X, Y->n));
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200724
Tom Cosgrovee22413c2023-05-03 09:44:01 +0100725 X->s = (int) mbedtls_ct_uint_if(assign, Y->s, X->s);
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200726
Gilles Peskine449bd832023-01-11 14:50:10 +0100727 mbedtls_mpi_core_cond_assign(X->p, Y->p, Y->n, assign);
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200728
Gilles Peskine449bd832023-01-11 14:50:10 +0100729 for (size_t i = Y->n; i < X->n; i++) {
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200730 X->p[i] &= ~limb_mask;
Gilles Peskine449bd832023-01-11 14:50:10 +0100731 }
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200732
733cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100734 return ret;
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200735}
736
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200737/*
738 * Conditionally swap X and Y, without leaking information
739 * about whether the swap was made or not.
Shaun Case8b0ecbc2021-12-20 21:14:10 -0800740 * Here it is not ok to simply swap the pointers, which would lead to
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200741 * different memory access patterns when X and Y are used afterwards.
742 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100743int mbedtls_mpi_safe_cond_swap(mbedtls_mpi *X,
744 mbedtls_mpi *Y,
745 unsigned char swap)
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200746{
Gabor Mezeid7edb1d2022-10-10 14:32:09 +0200747 int ret = 0;
748 int s;
Gilles Peskine449bd832023-01-11 14:50:10 +0100749 MPI_VALIDATE_RET(X != NULL);
750 MPI_VALIDATE_RET(Y != NULL);
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200751
Gilles Peskine449bd832023-01-11 14:50:10 +0100752 if (X == Y) {
753 return 0;
754 }
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200755
Gilles Peskine449bd832023-01-11 14:50:10 +0100756 MBEDTLS_MPI_CHK(mbedtls_mpi_grow(X, Y->n));
757 MBEDTLS_MPI_CHK(mbedtls_mpi_grow(Y, X->n));
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200758
759 s = X->s;
Tom Cosgrovee22413c2023-05-03 09:44:01 +0100760 X->s = (int) mbedtls_ct_uint_if(swap, Y->s, X->s);
761 Y->s = (int) mbedtls_ct_uint_if(swap, s, Y->s);
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200762
Gilles Peskine449bd832023-01-11 14:50:10 +0100763 mbedtls_mpi_core_cond_swap(X->p, Y->p, X->n, swap);
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200764
765cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100766 return ret;
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200767}
768
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200769/*
Janos Follath23bdeca2022-07-22 18:24:06 +0100770 * Compare unsigned values in constant time
771 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100772unsigned mbedtls_mpi_core_lt_ct(const mbedtls_mpi_uint *A,
773 const mbedtls_mpi_uint *B,
774 size_t limbs)
Janos Follath23bdeca2022-07-22 18:24:06 +0100775{
Janos Follath23bdeca2022-07-22 18:24:06 +0100776 unsigned ret, cond, done;
777
Janos Follath63184682022-08-11 17:42:59 +0100778 /* The value of any of these variables is either 0 or 1 for the rest of
779 * their scope. */
Janos Follath23bdeca2022-07-22 18:24:06 +0100780 ret = cond = done = 0;
781
Gilles Peskine449bd832023-01-11 14:50:10 +0100782 for (size_t i = limbs; i > 0; i--) {
Janos Follath23bdeca2022-07-22 18:24:06 +0100783 /*
Janos Follathb7a88ec2022-08-19 12:24:40 +0100784 * If B[i - 1] < A[i - 1] then A < B is false and the result must
Janos Follath23bdeca2022-07-22 18:24:06 +0100785 * remain 0.
786 *
787 * Again even if we can make a decision, we just mark the result and
788 * the fact that we are done and continue looping.
789 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100790 cond = mbedtls_ct_mpi_uint_lt(B[i - 1], A[i - 1]);
Janos Follath23bdeca2022-07-22 18:24:06 +0100791 done |= cond;
792
793 /*
Janos Follathb7a88ec2022-08-19 12:24:40 +0100794 * If A[i - 1] < B[i - 1] then A < B is true.
Janos Follath23bdeca2022-07-22 18:24:06 +0100795 *
796 * Again even if we can make a decision, we just mark the result and
797 * the fact that we are done and continue looping.
798 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100799 cond = mbedtls_ct_mpi_uint_lt(A[i - 1], B[i - 1]);
800 ret |= cond & (1 - done);
Janos Follath23bdeca2022-07-22 18:24:06 +0100801 done |= cond;
802 }
803
804 /*
Janos Follathb7a88ec2022-08-19 12:24:40 +0100805 * If all the limbs were equal, then the numbers are equal, A < B is false
Janos Follath23bdeca2022-07-22 18:24:06 +0100806 * and leaving the result 0 is correct.
807 */
808
Gilles Peskine449bd832023-01-11 14:50:10 +0100809 return ret;
Janos Follath23bdeca2022-07-22 18:24:06 +0100810}
811
812/*
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200813 * Compare signed values in constant time
814 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100815int mbedtls_mpi_lt_mpi_ct(const mbedtls_mpi *X,
816 const mbedtls_mpi *Y,
817 unsigned *ret)
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200818{
819 size_t i;
820 /* The value of any of these variables is either 0 or 1 at all times. */
821 unsigned cond, done, X_is_negative, Y_is_negative;
822
Gilles Peskine449bd832023-01-11 14:50:10 +0100823 MPI_VALIDATE_RET(X != NULL);
824 MPI_VALIDATE_RET(Y != NULL);
825 MPI_VALIDATE_RET(ret != NULL);
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200826
Gilles Peskine449bd832023-01-11 14:50:10 +0100827 if (X->n != Y->n) {
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200828 return MBEDTLS_ERR_MPI_BAD_INPUT_DATA;
Gilles Peskine449bd832023-01-11 14:50:10 +0100829 }
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200830
831 /*
832 * Set sign_N to 1 if N >= 0, 0 if N < 0.
833 * We know that N->s == 1 if N >= 0 and N->s == -1 if N < 0.
834 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100835 X_is_negative = (X->s & 2) >> 1;
836 Y_is_negative = (Y->s & 2) >> 1;
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200837
838 /*
839 * If the signs are different, then the positive operand is the bigger.
840 * That is if X is negative (X_is_negative == 1), then X < Y is true and it
841 * is false if X is positive (X_is_negative == 0).
842 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100843 cond = (X_is_negative ^ Y_is_negative);
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200844 *ret = cond & X_is_negative;
845
846 /*
847 * This is a constant-time function. We might have the result, but we still
848 * need to go through the loop. Record if we have the result already.
849 */
850 done = cond;
851
Gilles Peskine449bd832023-01-11 14:50:10 +0100852 for (i = X->n; i > 0; i--) {
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200853 /*
854 * If Y->p[i - 1] < X->p[i - 1] then X < Y is true if and only if both
855 * X and Y are negative.
856 *
857 * Again even if we can make a decision, we just mark the result and
858 * the fact that we are done and continue looping.
859 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100860 cond = mbedtls_ct_mpi_uint_lt(Y->p[i - 1], X->p[i - 1]);
861 *ret |= cond & (1 - done) & X_is_negative;
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200862 done |= cond;
863
864 /*
865 * If X->p[i - 1] < Y->p[i - 1] then X < Y is true if and only if both
866 * X and Y are positive.
867 *
868 * Again even if we can make a decision, we just mark the result and
869 * the fact that we are done and continue looping.
870 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100871 cond = mbedtls_ct_mpi_uint_lt(X->p[i - 1], Y->p[i - 1]);
872 *ret |= cond & (1 - done) & (1 - X_is_negative);
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200873 done |= cond;
874 }
875
Gilles Peskine449bd832023-01-11 14:50:10 +0100876 return 0;
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200877}
878
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200879#endif /* MBEDTLS_BIGNUM_C */
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200880
881#if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT)
882
Gilles Peskine449bd832023-01-11 14:50:10 +0100883int mbedtls_ct_rsaes_pkcs1_v15_unpadding(unsigned char *input,
884 size_t ilen,
885 unsigned char *output,
886 size_t output_max_len,
887 size_t *olen)
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200888{
889 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
890 size_t i, plaintext_max_size;
891
892 /* The following variables take sensitive values: their value must
893 * not leak into the observable behavior of the function other than
894 * the designated outputs (output, olen, return value). Otherwise
895 * this would open the execution of the function to
896 * side-channel-based variants of the Bleichenbacher padding oracle
897 * attack. Potential side channels include overall timing, memory
898 * access patterns (especially visible to an adversary who has access
899 * to a shared memory cache), and branches (especially visible to
900 * an adversary who has access to a shared code cache or to a shared
901 * branch predictor). */
902 size_t pad_count = 0;
903 unsigned bad = 0;
904 unsigned char pad_done = 0;
905 size_t plaintext_size = 0;
906 unsigned output_too_large;
907
Gilles Peskine449bd832023-01-11 14:50:10 +0100908 plaintext_max_size = (output_max_len > ilen - 11) ? ilen - 11
Gabor Mezei7013f622021-10-18 16:12:45 +0200909 : output_max_len;
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200910
911 /* Check and get padding length in constant time and constant
912 * memory trace. The first byte must be 0. */
Gabor Mezei63bbba52021-10-18 16:17:57 +0200913 bad |= input[0];
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200914
915
916 /* Decode EME-PKCS1-v1_5 padding: 0x00 || 0x02 || PS || 0x00
Gabor Mezei63bbba52021-10-18 16:17:57 +0200917 * where PS must be at least 8 nonzero bytes. */
918 bad |= input[1] ^ MBEDTLS_RSA_CRYPT;
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200919
920 /* Read the whole buffer. Set pad_done to nonzero if we find
Gabor Mezei63bbba52021-10-18 16:17:57 +0200921 * the 0x00 byte and remember the padding length in pad_count. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100922 for (i = 2; i < ilen; i++) {
923 pad_done |= ((input[i] | (unsigned char) -input[i]) >> 7) ^ 1;
924 pad_count += ((pad_done | (unsigned char) -pad_done) >> 7) ^ 1;
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200925 }
926
927
928 /* If pad_done is still zero, there's no data, only unfinished padding. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100929 bad |= mbedtls_ct_uint_if(pad_done, 0, 1);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200930
931 /* There must be at least 8 bytes of padding. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100932 bad |= mbedtls_ct_size_gt(8, pad_count);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200933
934 /* If the padding is valid, set plaintext_size to the number of
935 * remaining bytes after stripping the padding. If the padding
936 * is invalid, avoid leaking this fact through the size of the
937 * output: use the maximum message size that fits in the output
938 * buffer. Do it without branches to avoid leaking the padding
939 * validity through timing. RSA keys are small enough that all the
940 * size_t values involved fit in unsigned int. */
Gabor Mezei90437e32021-10-20 11:59:27 +0200941 plaintext_size = mbedtls_ct_uint_if(
Gilles Peskine449bd832023-01-11 14:50:10 +0100942 bad, (unsigned) plaintext_max_size,
943 (unsigned) (ilen - pad_count - 3));
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200944
945 /* Set output_too_large to 0 if the plaintext fits in the output
946 * buffer and to 1 otherwise. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100947 output_too_large = mbedtls_ct_size_gt(plaintext_size,
948 plaintext_max_size);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200949
950 /* Set ret without branches to avoid timing attacks. Return:
951 * - INVALID_PADDING if the padding is bad (bad != 0).
952 * - OUTPUT_TOO_LARGE if the padding is good but the decrypted
953 * plaintext does not fit in the output buffer.
954 * - 0 if the padding is correct. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100955 ret = -(int) mbedtls_ct_uint_if(
956 bad, -MBEDTLS_ERR_RSA_INVALID_PADDING,
957 mbedtls_ct_uint_if(output_too_large,
958 -MBEDTLS_ERR_RSA_OUTPUT_TOO_LARGE,
959 0));
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200960
961 /* If the padding is bad or the plaintext is too large, zero the
962 * data that we're about to copy to the output buffer.
963 * We need to copy the same amount of data
964 * from the same buffer whether the padding is good or not to
965 * avoid leaking the padding validity through overall timing or
966 * through memory or cache access patterns. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100967 bad = mbedtls_ct_uint_mask(bad | output_too_large);
968 for (i = 11; i < ilen; i++) {
Gabor Mezei63bbba52021-10-18 16:17:57 +0200969 input[i] &= ~bad;
Gilles Peskine449bd832023-01-11 14:50:10 +0100970 }
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200971
972 /* If the plaintext is too large, truncate it to the buffer size.
973 * Copy anyway to avoid revealing the length through timing, because
974 * revealing the length is as bad as revealing the padding validity
975 * for a Bleichenbacher attack. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100976 plaintext_size = mbedtls_ct_uint_if(output_too_large,
977 (unsigned) plaintext_max_size,
978 (unsigned) plaintext_size);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200979
980 /* Move the plaintext to the leftmost position where it can start in
981 * the working buffer, i.e. make it start plaintext_max_size from
982 * the end of the buffer. Do this with a memory access trace that
983 * does not depend on the plaintext size. After this move, the
984 * starting location of the plaintext is no longer sensitive
985 * information. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100986 mbedtls_ct_mem_move_to_left(input + ilen - plaintext_max_size,
987 plaintext_max_size,
988 plaintext_max_size - plaintext_size);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200989
990 /* Finally copy the decrypted plaintext plus trailing zeros into the output
991 * buffer. If output_max_len is 0, then output may be an invalid pointer
992 * and the result of memcpy() would be undefined; prevent undefined
993 * behavior making sure to depend only on output_max_len (the size of the
994 * user-provided output buffer), which is independent from plaintext
995 * length, validity of padding, success of the decryption, and other
996 * secrets. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100997 if (output_max_len != 0) {
998 memcpy(output, input + ilen - plaintext_max_size, plaintext_max_size);
999 }
gabor-mezei-armfdb71182021-09-27 16:11:12 +02001000
1001 /* Report the amount of data we copied to the output buffer. In case
1002 * of errors (bad padding or output too large), the value of *olen
1003 * when this function returns is not specified. Making it equivalent
1004 * to the good case limits the risks of leaking the padding validity. */
1005 *olen = plaintext_size;
1006
Gilles Peskine449bd832023-01-11 14:50:10 +01001007 return ret;
gabor-mezei-armfdb71182021-09-27 16:11:12 +02001008}
1009
1010#endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */