blob: 89d7b4f23459f59840f3b7017a75d967cdc3ec46 [file] [log] [blame]
gabor-mezei-armd1125342021-07-12 16:31:22 +02001/**
2 * Constant-time functions
3 *
4 * Copyright The Mbed TLS Contributors
5 * SPDX-License-Identifier: Apache-2.0
6 *
7 * Licensed under the Apache License, Version 2.0 (the "License"); you may
8 * not use this file except in compliance with the License.
9 * You may obtain a copy of the License at
10 *
11 * http://www.apache.org/licenses/LICENSE-2.0
12 *
13 * Unless required by applicable law or agreed to in writing, software
14 * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
15 * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16 * See the License for the specific language governing permissions and
17 * limitations under the License.
18 */
19
Gilles Peskine449bd832023-01-11 14:50:10 +010020/*
Gabor Mezei642eeb22021-11-03 16:13:32 +010021 * The following functions are implemented without using comparison operators, as those
Gabor Mezeieab90bc2021-10-18 16:09:41 +020022 * might be translated to branches by some compilers on some platforms.
23 */
24
gabor-mezei-armd1125342021-07-12 16:31:22 +020025#include "common.h"
Gabor Mezei22c9a6f2021-10-20 12:09:35 +020026#include "constant_time_internal.h"
Gabor Mezei765862c2021-10-19 12:22:25 +020027#include "mbedtls/constant_time.h"
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +020028#include "mbedtls/error.h"
gabor-mezei-arm5b3a32d2021-09-29 10:50:31 +020029#include "mbedtls/platform_util.h"
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +020030
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +020031#if defined(MBEDTLS_BIGNUM_C)
32#include "mbedtls/bignum.h"
Gabor Mezei87638a92022-09-15 20:02:36 +020033#include "bignum_core.h"
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +020034#endif
35
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +020036#if defined(MBEDTLS_SSL_TLS_C)
37#include "ssl_misc.h"
38#endif
39
gabor-mezei-arm5b3a32d2021-09-29 10:50:31 +020040#if defined(MBEDTLS_RSA_C)
41#include "mbedtls/rsa.h"
42#endif
43
Gabor Mezei28d61152021-11-15 16:13:01 +010044#if defined(MBEDTLS_BASE64_C)
45#include "constant_time_invasive.h"
46#endif
47
gabor-mezei-armfdb71182021-09-27 16:11:12 +020048#include <string.h>
Andrzej Kurek8a045ce2022-12-23 11:00:06 -050049#if defined(MBEDTLS_USE_PSA_CRYPTO)
50#define PSA_TO_MBEDTLS_ERR(status) PSA_TO_MBEDTLS_ERR_LIST(status, \
51 psa_to_ssl_errors, \
52 psa_generic_status_to_mbedtls)
53#endif
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +020054
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000055/*
Dave Rodgman051225d2022-12-30 21:25:35 +000056 * Define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS where assembly is present to
57 * perform fast unaligned access to volatile data.
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000058 *
59 * This is needed because mbedtls_get_unaligned_uintXX etc don't support volatile
60 * memory accesses.
61 *
Dave Rodgman051225d2022-12-30 21:25:35 +000062 * Some of these definitions could be moved into alignment.h but for now they are
63 * only used here.
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000064 */
Dave Rodgman051225d2022-12-30 21:25:35 +000065#if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS) && defined(MBEDTLS_HAVE_ASM)
66#if defined(__arm__) || defined(__thumb__) || defined(__thumb2__) || defined(__aarch64__)
67#define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS
68#endif
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000069#endif
70
Dave Rodgman051225d2022-12-30 21:25:35 +000071#if defined(MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS)
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000072static inline uint32_t mbedtls_get_unaligned_volatile_uint32(volatile const unsigned char *p)
73{
74 /* This is UB, even where it's safe:
75 * return *((volatile uint32_t*)p);
76 * so instead the same thing is expressed in assembly below.
77 */
78 uint32_t r;
79#if defined(__arm__) || defined(__thumb__) || defined(__thumb2__)
Dave Rodgman4610d4b2023-01-30 09:26:48 +000080 asm volatile ("ldr %0, [%1]" : "=r" (r) : "r" (p) :);
Dave Rodgman04cb9ac2023-06-21 07:32:22 +010081#elif defined(__aarch64__)
Dave Rodgmanb67db912023-06-21 09:15:27 +010082#if (SIZE_MAX == 0xffffffff)
83 /* ILP32: Specify the pointer operand slightly differently, as per #7787. */
Dave Rodgman04cb9ac2023-06-21 07:32:22 +010084 asm volatile ("ldr %w0, [%1]" : "=r" (r) : "p" (p) :);
Dave Rodgmanb67db912023-06-21 09:15:27 +010085#else
86 asm volatile ("ldr %w0, [%1]" : "=r" (r) : "r" (p) :);
87#endif
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000088#endif
Dave Rodgman051225d2022-12-30 21:25:35 +000089 return r;
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000090}
Dave Rodgman051225d2022-12-30 21:25:35 +000091#endif /* MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS */
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000092
Gilles Peskine449bd832023-01-11 14:50:10 +010093int mbedtls_ct_memcmp(const void *a,
94 const void *b,
95 size_t n)
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +020096{
Dave Rodgman36dfc5a2022-12-22 15:04:43 +000097 size_t i = 0;
Dave Rodgman7658b632023-01-11 17:39:33 +000098 /*
99 * `A` and `B` are cast to volatile to ensure that the compiler
100 * generates code that always fully reads both buffers.
101 * Otherwise it could generate a test to exit early if `diff` has all
102 * bits set early in the loop.
103 */
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +0200104 volatile const unsigned char *A = (volatile const unsigned char *) a;
105 volatile const unsigned char *B = (volatile const unsigned char *) b;
Dave Rodgman7658b632023-01-11 17:39:33 +0000106 uint32_t diff = 0;
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +0200107
Dave Rodgman051225d2022-12-30 21:25:35 +0000108#if defined(MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS)
Dave Rodgman36dfc5a2022-12-22 15:04:43 +0000109 for (; (i + 4) <= n; i += 4) {
110 uint32_t x = mbedtls_get_unaligned_volatile_uint32(A + i);
111 uint32_t y = mbedtls_get_unaligned_volatile_uint32(B + i);
112 diff |= x ^ y;
113 }
114#endif
115
116 for (; i < n; i++) {
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +0200117 /* Read volatile data in order before computing diff.
118 * This avoids IAR compiler warning:
119 * 'the order of volatile accesses is undefined ..' */
120 unsigned char x = A[i], y = B[i];
121 diff |= x ^ y;
122 }
123
Gilles Peskine449bd832023-01-11 14:50:10 +0100124 return (int) diff;
gabor-mezei-armdb9a38c2021-09-27 11:28:54 +0200125}
126
Gilles Peskine449bd832023-01-11 14:50:10 +0100127unsigned mbedtls_ct_uint_mask(unsigned value)
gabor-mezei-arm340948e2021-09-27 11:40:03 +0200128{
129 /* MSVC has a warning about unary minus on unsigned, but this is
130 * well-defined and precisely what we want to do here */
131#if defined(_MSC_VER)
132#pragma warning( push )
133#pragma warning( disable : 4146 )
134#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100135 return -((value | -value) >> (sizeof(value) * 8 - 1));
gabor-mezei-arm340948e2021-09-27 11:40:03 +0200136#if defined(_MSC_VER)
137#pragma warning( pop )
138#endif
139}
gabor-mezei-arm3733bf82021-09-27 11:49:42 +0200140
Przemek Stekiel89ad6232022-09-27 13:36:12 +0200141#if defined(MBEDTLS_SSL_SOME_SUITES_USE_MAC)
Gabor Mezei6a426c92021-10-20 11:17:43 +0200142
Gilles Peskine449bd832023-01-11 14:50:10 +0100143size_t mbedtls_ct_size_mask(size_t value)
gabor-mezei-arm3733bf82021-09-27 11:49:42 +0200144{
145 /* MSVC has a warning about unary minus on unsigned integer types,
146 * but this is well-defined and precisely what we want to do here. */
147#if defined(_MSC_VER)
148#pragma warning( push )
149#pragma warning( disable : 4146 )
150#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100151 return -((value | -value) >> (sizeof(value) * 8 - 1));
gabor-mezei-arm3733bf82021-09-27 11:49:42 +0200152#if defined(_MSC_VER)
153#pragma warning( pop )
154#endif
155}
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200156
Przemek Stekiel89ad6232022-09-27 13:36:12 +0200157#endif /* MBEDTLS_SSL_SOME_SUITES_USE_MAC */
Gabor Mezei6a426c92021-10-20 11:17:43 +0200158
gabor-mezei-arm9cb55692021-08-11 15:07:02 +0200159#if defined(MBEDTLS_BIGNUM_C)
160
Gilles Peskine449bd832023-01-11 14:50:10 +0100161mbedtls_mpi_uint mbedtls_ct_mpi_uint_mask(mbedtls_mpi_uint value)
gabor-mezei-arm9cb55692021-08-11 15:07:02 +0200162{
163 /* MSVC has a warning about unary minus on unsigned, but this is
164 * well-defined and precisely what we want to do here */
165#if defined(_MSC_VER)
166#pragma warning( push )
167#pragma warning( disable : 4146 )
168#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100169 return -((value | -value) >> (sizeof(value) * 8 - 1));
gabor-mezei-arm9cb55692021-08-11 15:07:02 +0200170#if defined(_MSC_VER)
171#pragma warning( pop )
172#endif
173}
174
175#endif /* MBEDTLS_BIGNUM_C */
176
Gabor Mezeie2123792021-10-18 17:05:06 +0200177#if defined(MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC)
178
Gabor Mezei1e642612021-10-18 16:05:50 +0200179/** Constant-flow mask generation for "less than" comparison:
180 * - if \p x < \p y, return all-bits 1, that is (size_t) -1
181 * - otherwise, return all bits 0, that is 0
182 *
183 * This function can be used to write constant-time code by replacing branches
184 * with bit operations using masks.
185 *
186 * \param x The first value to analyze.
187 * \param y The second value to analyze.
188 *
189 * \return All-bits-one if \p x is less than \p y, otherwise zero.
190 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100191static size_t mbedtls_ct_size_mask_lt(size_t x,
192 size_t y)
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200193{
194 /* This has the most significant bit set if and only if x < y */
195 const size_t sub = x - y;
196
197 /* sub1 = (x < y) ? 1 : 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100198 const size_t sub1 = sub >> (sizeof(sub) * 8 - 1);
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200199
200 /* mask = (x < y) ? 0xff... : 0x00... */
Gilles Peskine449bd832023-01-11 14:50:10 +0100201 const size_t mask = mbedtls_ct_size_mask(sub1);
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200202
Gilles Peskine449bd832023-01-11 14:50:10 +0100203 return mask;
gabor-mezei-armc76227d2021-09-27 11:53:54 +0200204}
gabor-mezei-arm16fc57b2021-09-27 11:58:31 +0200205
Gilles Peskine449bd832023-01-11 14:50:10 +0100206size_t mbedtls_ct_size_mask_ge(size_t x,
207 size_t y)
gabor-mezei-arm16fc57b2021-09-27 11:58:31 +0200208{
Gilles Peskine449bd832023-01-11 14:50:10 +0100209 return ~mbedtls_ct_size_mask_lt(x, y);
gabor-mezei-arm16fc57b2021-09-27 11:58:31 +0200210}
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200211
Gabor Mezeie2123792021-10-18 17:05:06 +0200212#endif /* MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC */
213
Gabor Mezei28d61152021-11-15 16:13:01 +0100214#if defined(MBEDTLS_BASE64_C)
215
216/* Return 0xff if low <= c <= high, 0 otherwise.
217 *
218 * Constant flow with respect to c.
219 */
Gabor Mezeic0d8dda2021-11-26 17:20:36 +0100220MBEDTLS_STATIC_TESTABLE
Gilles Peskine449bd832023-01-11 14:50:10 +0100221unsigned char mbedtls_ct_uchar_mask_of_range(unsigned char low,
222 unsigned char high,
223 unsigned char c)
Gabor Mezei28d61152021-11-15 16:13:01 +0100224{
225 /* low_mask is: 0 if low <= c, 0x...ff if low > c */
Gilles Peskine449bd832023-01-11 14:50:10 +0100226 unsigned low_mask = ((unsigned) c - low) >> 8;
Gabor Mezei28d61152021-11-15 16:13:01 +0100227 /* high_mask is: 0 if c <= high, 0x...ff if c > high */
Gilles Peskine449bd832023-01-11 14:50:10 +0100228 unsigned high_mask = ((unsigned) high - c) >> 8;
229 return ~(low_mask | high_mask) & 0xff;
Gabor Mezei28d61152021-11-15 16:13:01 +0100230}
231
232#endif /* MBEDTLS_BASE64_C */
233
Gilles Peskine449bd832023-01-11 14:50:10 +0100234unsigned mbedtls_ct_size_bool_eq(size_t x,
235 size_t y)
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200236{
237 /* diff = 0 if x == y, non-zero otherwise */
238 const size_t diff = x ^ y;
239
240 /* MSVC has a warning about unary minus on unsigned integer types,
241 * but this is well-defined and precisely what we want to do here. */
242#if defined(_MSC_VER)
243#pragma warning( push )
244#pragma warning( disable : 4146 )
245#endif
246
247 /* diff_msb's most significant bit is equal to x != y */
Gilles Peskine449bd832023-01-11 14:50:10 +0100248 const size_t diff_msb = (diff | (size_t) -diff);
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200249
250#if defined(_MSC_VER)
251#pragma warning( pop )
252#endif
253
254 /* diff1 = (x != y) ? 1 : 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100255 const unsigned diff1 = diff_msb >> (sizeof(diff_msb) * 8 - 1);
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200256
Gilles Peskine449bd832023-01-11 14:50:10 +0100257 return 1 ^ diff1;
gabor-mezei-arm8d1d5fd2021-09-27 12:15:19 +0200258}
gabor-mezei-arm5a854422021-09-27 12:25:07 +0200259
Gabor Mezeie2123792021-10-18 17:05:06 +0200260#if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT)
261
Gabor Mezeia2d0f902021-10-18 16:35:23 +0200262/** Constant-flow "greater than" comparison:
263 * return x > y
264 *
265 * This is equivalent to \p x > \p y, but is likely to be compiled
266 * to code using bitwise operation rather than a branch.
267 *
268 * \param x The first value to analyze.
269 * \param y The second value to analyze.
270 *
271 * \return 1 if \p x greater than \p y, otherwise 0.
272 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100273static unsigned mbedtls_ct_size_gt(size_t x,
274 size_t y)
gabor-mezei-arm5a854422021-09-27 12:25:07 +0200275{
gabor-mezei-arm87ac5be2021-08-10 20:36:09 +0200276 /* Return the sign bit (1 for negative) of (y - x). */
Gilles Peskine449bd832023-01-11 14:50:10 +0100277 return (y - x) >> (sizeof(size_t) * 8 - 1);
gabor-mezei-arm5a854422021-09-27 12:25:07 +0200278}
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200279
Gabor Mezeie2123792021-10-18 17:05:06 +0200280#endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */
281
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200282#if defined(MBEDTLS_BIGNUM_C)
283
Gilles Peskine449bd832023-01-11 14:50:10 +0100284unsigned mbedtls_ct_mpi_uint_lt(const mbedtls_mpi_uint x,
285 const mbedtls_mpi_uint y)
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200286{
287 mbedtls_mpi_uint ret;
288 mbedtls_mpi_uint cond;
289
290 /*
291 * Check if the most significant bits (MSB) of the operands are different.
292 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100293 cond = (x ^ y);
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200294 /*
295 * If the MSB are the same then the difference x-y will be negative (and
296 * have its MSB set to 1 during conversion to unsigned) if and only if x<y.
297 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100298 ret = (x - y) & ~cond;
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200299 /*
300 * If the MSB are different, then the operand with the MSB of 1 is the
301 * bigger. (That is if y has MSB of 1, then x<y is true and it is false if
302 * the MSB of y is 0.)
303 */
304 ret |= y & cond;
305
306
Gilles Peskine449bd832023-01-11 14:50:10 +0100307 ret = ret >> (sizeof(mbedtls_mpi_uint) * 8 - 1);
gabor-mezei-arm3f90fd52021-09-27 12:55:33 +0200308
309 return (unsigned) ret;
310}
311
312#endif /* MBEDTLS_BIGNUM_C */
gabor-mezei-armb2dbf2c2021-09-27 12:59:30 +0200313
Gilles Peskine449bd832023-01-11 14:50:10 +0100314unsigned mbedtls_ct_uint_if(unsigned condition,
315 unsigned if1,
316 unsigned if0)
gabor-mezei-armb2dbf2c2021-09-27 12:59:30 +0200317{
Gilles Peskine449bd832023-01-11 14:50:10 +0100318 unsigned mask = mbedtls_ct_uint_mask(condition);
319 return (mask & if1) | (~mask & if0);
gabor-mezei-armb2dbf2c2021-09-27 12:59:30 +0200320}
gabor-mezei-armd3230d52021-09-27 13:03:57 +0200321
Gabor Mezeie2123792021-10-18 17:05:06 +0200322#if defined(MBEDTLS_BIGNUM_C)
gabor-mezei-arm65cefdb2021-09-27 15:47:00 +0200323
Gilles Peskine449bd832023-01-11 14:50:10 +0100324void mbedtls_ct_mpi_uint_cond_assign(size_t n,
325 mbedtls_mpi_uint *dest,
326 const mbedtls_mpi_uint *src,
327 unsigned char condition)
gabor-mezei-armbe8d98b2021-09-27 13:17:15 +0200328{
329 size_t i;
330
331 /* MSVC has a warning about unary minus on unsigned integer types,
332 * but this is well-defined and precisely what we want to do here. */
333#if defined(_MSC_VER)
334#pragma warning( push )
335#pragma warning( disable : 4146 )
336#endif
337
gabor-mezei-arm87ac5be2021-08-10 20:36:09 +0200338 /* all-bits 1 if condition is 1, all-bits 0 if condition is 0 */
339 const mbedtls_mpi_uint mask = -condition;
gabor-mezei-armbe8d98b2021-09-27 13:17:15 +0200340
341#if defined(_MSC_VER)
342#pragma warning( pop )
343#endif
344
Gilles Peskine449bd832023-01-11 14:50:10 +0100345 for (i = 0; i < n; i++) {
346 dest[i] = (src[i] & mask) | (dest[i] & ~mask);
347 }
gabor-mezei-armbe8d98b2021-09-27 13:17:15 +0200348}
349
350#endif /* MBEDTLS_BIGNUM_C */
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200351
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100352#if defined(MBEDTLS_BASE64_C)
353
Gilles Peskine449bd832023-01-11 14:50:10 +0100354unsigned char mbedtls_ct_base64_enc_char(unsigned char value)
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100355{
356 unsigned char digit = 0;
Gabor Mezei14d5fac2021-11-24 15:51:39 +0100357 /* For each range of values, if value is in that range, mask digit with
358 * the corresponding value. Since value can only be in a single range,
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100359 * only at most one masking will change digit. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100360 digit |= mbedtls_ct_uchar_mask_of_range(0, 25, value) & ('A' + value);
361 digit |= mbedtls_ct_uchar_mask_of_range(26, 51, value) & ('a' + value - 26);
362 digit |= mbedtls_ct_uchar_mask_of_range(52, 61, value) & ('0' + value - 52);
363 digit |= mbedtls_ct_uchar_mask_of_range(62, 62, value) & '+';
364 digit |= mbedtls_ct_uchar_mask_of_range(63, 63, value) & '/';
365 return digit;
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100366}
367
Gilles Peskine449bd832023-01-11 14:50:10 +0100368signed char mbedtls_ct_base64_dec_value(unsigned char c)
Gabor Mezei358829a2021-11-15 16:22:37 +0100369{
370 unsigned char val = 0;
371 /* For each range of digits, if c is in that range, mask val with
372 * the corresponding value. Since c can only be in a single range,
373 * only at most one masking will change val. Set val to one plus
374 * the desired value so that it stays 0 if c is in none of the ranges. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100375 val |= mbedtls_ct_uchar_mask_of_range('A', 'Z', c) & (c - 'A' + 0 + 1);
376 val |= mbedtls_ct_uchar_mask_of_range('a', 'z', c) & (c - 'a' + 26 + 1);
377 val |= mbedtls_ct_uchar_mask_of_range('0', '9', c) & (c - '0' + 52 + 1);
378 val |= mbedtls_ct_uchar_mask_of_range('+', '+', c) & (c - '+' + 62 + 1);
379 val |= mbedtls_ct_uchar_mask_of_range('/', '/', c) & (c - '/' + 63 + 1);
Gabor Mezei358829a2021-11-15 16:22:37 +0100380 /* At this point, val is 0 if c is an invalid digit and v+1 if c is
381 * a digit with the value v. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100382 return val - 1;
Gabor Mezei358829a2021-11-15 16:22:37 +0100383}
384
Gabor Mezei9a4074a2021-11-15 16:18:54 +0100385#endif /* MBEDTLS_BASE64_C */
386
Gabor Mezeie2123792021-10-18 17:05:06 +0200387#if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT)
388
Gabor Mezeia2d0f902021-10-18 16:35:23 +0200389/** Shift some data towards the left inside a buffer.
390 *
Gabor Mezei90437e32021-10-20 11:59:27 +0200391 * `mbedtls_ct_mem_move_to_left(start, total, offset)` is functionally
Gabor Mezeia2d0f902021-10-18 16:35:23 +0200392 * equivalent to
393 * ```
394 * memmove(start, start + offset, total - offset);
395 * memset(start + offset, 0, total - offset);
396 * ```
397 * but it strives to use a memory access pattern (and thus total timing)
398 * that does not depend on \p offset. This timing independence comes at
399 * the expense of performance.
400 *
401 * \param start Pointer to the start of the buffer.
402 * \param total Total size of the buffer.
403 * \param offset Offset from which to copy \p total - \p offset bytes.
404 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100405static void mbedtls_ct_mem_move_to_left(void *start,
406 size_t total,
407 size_t offset)
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200408{
409 volatile unsigned char *buf = start;
410 size_t i, n;
Gilles Peskine449bd832023-01-11 14:50:10 +0100411 if (total == 0) {
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200412 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100413 }
414 for (i = 0; i < total; i++) {
415 unsigned no_op = mbedtls_ct_size_gt(total - offset, i);
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200416 /* The first `total - offset` passes are a no-op. The last
417 * `offset` passes shift the data one byte to the left and
418 * zero out the last byte. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100419 for (n = 0; n < total - 1; n++) {
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200420 unsigned char current = buf[n];
421 unsigned char next = buf[n+1];
Gilles Peskine449bd832023-01-11 14:50:10 +0100422 buf[n] = mbedtls_ct_uint_if(no_op, current, next);
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200423 }
Gilles Peskine449bd832023-01-11 14:50:10 +0100424 buf[total-1] = mbedtls_ct_uint_if(no_op, buf[total-1], 0);
gabor-mezei-arm394aeaa2021-09-27 13:31:06 +0200425 }
426}
gabor-mezei-armdee0fd32021-09-27 13:34:25 +0200427
Gabor Mezeie2123792021-10-18 17:05:06 +0200428#endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */
429
Przemek Stekiel89ad6232022-09-27 13:36:12 +0200430#if defined(MBEDTLS_SSL_SOME_SUITES_USE_MAC)
Gabor Mezeie2123792021-10-18 17:05:06 +0200431
Gilles Peskine449bd832023-01-11 14:50:10 +0100432void mbedtls_ct_memcpy_if_eq(unsigned char *dest,
433 const unsigned char *src,
434 size_t len,
435 size_t c1,
436 size_t c2)
gabor-mezei-armdee0fd32021-09-27 13:34:25 +0200437{
438 /* mask = c1 == c2 ? 0xff : 0x00 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100439 const size_t equal = mbedtls_ct_size_bool_eq(c1, c2);
gabor-mezei-armdee0fd32021-09-27 13:34:25 +0200440
gabor-mezei-arm87ac5be2021-08-10 20:36:09 +0200441 /* dest[i] = c1 == c2 ? src[i] : dest[i] */
Dave Rodgman36dfc5a2022-12-22 15:04:43 +0000442 size_t i = 0;
443#if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS)
444 const uint32_t mask32 = (uint32_t) mbedtls_ct_size_mask(equal);
445 const unsigned char mask = (unsigned char) mask32 & 0xff;
446
447 for (; (i + 4) <= len; i += 4) {
448 uint32_t a = mbedtls_get_unaligned_uint32(src + i) & mask32;
449 uint32_t b = mbedtls_get_unaligned_uint32(dest + i) & ~mask32;
450 mbedtls_put_unaligned_uint32(dest + i, a | b);
451 }
452#else
453 const unsigned char mask = (unsigned char) mbedtls_ct_size_mask(equal);
454#endif /* MBEDTLS_EFFICIENT_UNALIGNED_ACCESS */
455 for (; i < len; i++) {
Gilles Peskine449bd832023-01-11 14:50:10 +0100456 dest[i] = (src[i] & mask) | (dest[i] & ~mask);
457 }
gabor-mezei-armdee0fd32021-09-27 13:34:25 +0200458}
gabor-mezei-arm0e7f71e2021-09-27 13:57:45 +0200459
Gilles Peskine449bd832023-01-11 14:50:10 +0100460void mbedtls_ct_memcpy_offset(unsigned char *dest,
461 const unsigned char *src,
462 size_t offset,
463 size_t offset_min,
464 size_t offset_max,
465 size_t len)
gabor-mezei-arm0e7f71e2021-09-27 13:57:45 +0200466{
Gabor Mezei63bbba52021-10-18 16:17:57 +0200467 size_t offsetval;
gabor-mezei-arm0e7f71e2021-09-27 13:57:45 +0200468
Gilles Peskine449bd832023-01-11 14:50:10 +0100469 for (offsetval = offset_min; offsetval <= offset_max; offsetval++) {
470 mbedtls_ct_memcpy_if_eq(dest, src + offsetval, len,
471 offsetval, offset);
gabor-mezei-arm0e7f71e2021-09-27 13:57:45 +0200472 }
473}
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200474
Neil Armstrong2968d302022-02-25 15:09:36 +0100475#if defined(MBEDTLS_USE_PSA_CRYPTO)
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100476
477#if defined(PSA_WANT_ALG_SHA_384)
Gilles Peskine449bd832023-01-11 14:50:10 +0100478#define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_384)
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100479#elif defined(PSA_WANT_ALG_SHA_256)
Gilles Peskine449bd832023-01-11 14:50:10 +0100480#define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_256)
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100481#else /* See check_config.h */
Gilles Peskine449bd832023-01-11 14:50:10 +0100482#define MAX_HASH_BLOCK_LENGTH PSA_HASH_BLOCK_LENGTH(PSA_ALG_SHA_1)
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100483#endif
484
Gilles Peskine449bd832023-01-11 14:50:10 +0100485int mbedtls_ct_hmac(mbedtls_svc_key_id_t key,
486 psa_algorithm_t mac_alg,
487 const unsigned char *add_data,
488 size_t add_data_len,
489 const unsigned char *data,
490 size_t data_len_secret,
491 size_t min_data_len,
492 size_t max_data_len,
493 unsigned char *output)
Neil Armstrong2968d302022-02-25 15:09:36 +0100494{
495 /*
Neil Armstrong28d9c632022-03-17 16:33:27 +0100496 * This function breaks the HMAC abstraction and uses psa_hash_clone()
497 * extension in order to get constant-flow behaviour.
Neil Armstrong2968d302022-02-25 15:09:36 +0100498 *
499 * HMAC(msg) is defined as HASH(okey + HASH(ikey + msg)) where + means
500 * concatenation, and okey/ikey are the XOR of the key with some fixed bit
501 * patterns (see RFC 2104, sec. 2).
502 *
503 * We'll first compute ikey/okey, then inner_hash = HASH(ikey + msg) by
504 * hashing up to minlen, then cloning the context, and for each byte up
505 * to maxlen finishing up the hash computation, keeping only the
506 * correct result.
507 *
508 * Then we only need to compute HASH(okey + inner_hash) and we're done.
509 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100510 psa_algorithm_t hash_alg = PSA_ALG_HMAC_GET_HASH(mac_alg);
511 const size_t block_size = PSA_HASH_BLOCK_LENGTH(hash_alg);
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100512 unsigned char key_buf[MAX_HASH_BLOCK_LENGTH];
Gilles Peskine449bd832023-01-11 14:50:10 +0100513 const size_t hash_size = PSA_HASH_LENGTH(hash_alg);
Neil Armstrong2968d302022-02-25 15:09:36 +0100514 psa_hash_operation_t operation = PSA_HASH_OPERATION_INIT;
515 size_t hash_length;
516
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100517 unsigned char aux_out[PSA_HASH_MAX_SIZE];
Neil Armstrong2968d302022-02-25 15:09:36 +0100518 psa_hash_operation_t aux_operation = PSA_HASH_OPERATION_INIT;
519 size_t offset;
520 psa_status_t status = PSA_ERROR_CORRUPTION_DETECTED;
521
Neil Armstrong2968d302022-02-25 15:09:36 +0100522 size_t mac_key_length;
523 size_t i;
524
Gilles Peskine449bd832023-01-11 14:50:10 +0100525#define PSA_CHK(func_call) \
Neil Armstrong2968d302022-02-25 15:09:36 +0100526 do { \
527 status = (func_call); \
Gilles Peskine449bd832023-01-11 14:50:10 +0100528 if (status != PSA_SUCCESS) \
529 goto cleanup; \
530 } while (0)
Neil Armstrong2968d302022-02-25 15:09:36 +0100531
Neil Armstrong72c2f762022-03-17 16:39:10 +0100532 /* Export MAC key
533 * We assume key length is always exactly the output size
534 * which is never more than the block size, thus we use block_size
535 * as the key buffer size.
536 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100537 PSA_CHK(psa_export_key(key, key_buf, block_size, &mac_key_length));
Neil Armstrong2968d302022-02-25 15:09:36 +0100538
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100539 /* Calculate ikey */
Gilles Peskine449bd832023-01-11 14:50:10 +0100540 for (i = 0; i < mac_key_length; i++) {
541 key_buf[i] = (unsigned char) (key_buf[i] ^ 0x36);
542 }
543 for (; i < block_size; ++i) {
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100544 key_buf[i] = 0x36;
Gilles Peskine449bd832023-01-11 14:50:10 +0100545 }
Neil Armstrong2968d302022-02-25 15:09:36 +0100546
Gilles Peskine449bd832023-01-11 14:50:10 +0100547 PSA_CHK(psa_hash_setup(&operation, hash_alg));
Neil Armstrong2968d302022-02-25 15:09:36 +0100548
549 /* Now compute inner_hash = HASH(ikey + msg) */
Gilles Peskine449bd832023-01-11 14:50:10 +0100550 PSA_CHK(psa_hash_update(&operation, key_buf, block_size));
551 PSA_CHK(psa_hash_update(&operation, add_data, add_data_len));
552 PSA_CHK(psa_hash_update(&operation, data, min_data_len));
Neil Armstrong2968d302022-02-25 15:09:36 +0100553
Paul Elliott5260ce22022-05-09 18:15:54 +0100554 /* Fill the hash buffer in advance with something that is
555 * not a valid hash (barring an attack on the hash and
556 * deliberately-crafted input), in case the caller doesn't
557 * check the return status properly. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100558 memset(output, '!', hash_size);
Paul Elliott5260ce22022-05-09 18:15:54 +0100559
Neil Armstrong2968d302022-02-25 15:09:36 +0100560 /* For each possible length, compute the hash up to that point */
Gilles Peskine449bd832023-01-11 14:50:10 +0100561 for (offset = min_data_len; offset <= max_data_len; offset++) {
562 PSA_CHK(psa_hash_clone(&operation, &aux_operation));
563 PSA_CHK(psa_hash_finish(&aux_operation, aux_out,
564 PSA_HASH_MAX_SIZE, &hash_length));
Neil Armstrong2968d302022-02-25 15:09:36 +0100565 /* Keep only the correct inner_hash in the output buffer */
Gilles Peskine449bd832023-01-11 14:50:10 +0100566 mbedtls_ct_memcpy_if_eq(output, aux_out, hash_size,
567 offset, data_len_secret);
Neil Armstrong2968d302022-02-25 15:09:36 +0100568
Gilles Peskine449bd832023-01-11 14:50:10 +0100569 if (offset < max_data_len) {
570 PSA_CHK(psa_hash_update(&operation, data + offset, 1));
571 }
Neil Armstrong2968d302022-02-25 15:09:36 +0100572 }
573
Neil Armstrong28d9c632022-03-17 16:33:27 +0100574 /* Abort current operation to prepare for final operation */
Gilles Peskine449bd832023-01-11 14:50:10 +0100575 PSA_CHK(psa_hash_abort(&operation));
Neil Armstrong2968d302022-02-25 15:09:36 +0100576
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100577 /* Calculate okey */
Gilles Peskine449bd832023-01-11 14:50:10 +0100578 for (i = 0; i < mac_key_length; i++) {
579 key_buf[i] = (unsigned char) ((key_buf[i] ^ 0x36) ^ 0x5C);
580 }
581 for (; i < block_size; ++i) {
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100582 key_buf[i] = 0x5C;
Gilles Peskine449bd832023-01-11 14:50:10 +0100583 }
Neil Armstrong9ebb9ff2022-03-17 17:04:37 +0100584
Neil Armstrong2968d302022-02-25 15:09:36 +0100585 /* Now compute HASH(okey + inner_hash) */
Gilles Peskine449bd832023-01-11 14:50:10 +0100586 PSA_CHK(psa_hash_setup(&operation, hash_alg));
587 PSA_CHK(psa_hash_update(&operation, key_buf, block_size));
588 PSA_CHK(psa_hash_update(&operation, output, hash_size));
589 PSA_CHK(psa_hash_finish(&operation, output, hash_size, &hash_length));
Neil Armstrong2968d302022-02-25 15:09:36 +0100590
591#undef PSA_CHK
592
593cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100594 mbedtls_platform_zeroize(key_buf, MAX_HASH_BLOCK_LENGTH);
595 mbedtls_platform_zeroize(aux_out, PSA_HASH_MAX_SIZE);
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100596
Gilles Peskine449bd832023-01-11 14:50:10 +0100597 psa_hash_abort(&operation);
598 psa_hash_abort(&aux_operation);
Andrzej Kurek8a045ce2022-12-23 11:00:06 -0500599 return PSA_TO_MBEDTLS_ERR(status);
Neil Armstrong2968d302022-02-25 15:09:36 +0100600}
Neil Armstrong36cc13b2022-03-17 16:36:52 +0100601
602#undef MAX_HASH_BLOCK_LENGTH
603
Neil Armstrong2968d302022-02-25 15:09:36 +0100604#else
Gilles Peskine449bd832023-01-11 14:50:10 +0100605int mbedtls_ct_hmac(mbedtls_md_context_t *ctx,
606 const unsigned char *add_data,
607 size_t add_data_len,
608 const unsigned char *data,
609 size_t data_len_secret,
610 size_t min_data_len,
611 size_t max_data_len,
612 unsigned char *output)
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200613{
614 /*
615 * This function breaks the HMAC abstraction and uses the md_clone()
616 * extension to the MD API in order to get constant-flow behaviour.
617 *
618 * HMAC(msg) is defined as HASH(okey + HASH(ikey + msg)) where + means
619 * concatenation, and okey/ikey are the XOR of the key with some fixed bit
620 * patterns (see RFC 2104, sec. 2), which are stored in ctx->hmac_ctx.
621 *
622 * We'll first compute inner_hash = HASH(ikey + msg) by hashing up to
623 * minlen, then cloning the context, and for each byte up to maxlen
624 * finishing up the hash computation, keeping only the correct result.
625 *
626 * Then we only need to compute HASH(okey + inner_hash) and we're done.
627 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100628 const mbedtls_md_type_t md_alg = mbedtls_md_get_type(ctx->md_info);
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200629 /* TLS 1.2 only supports SHA-384, SHA-256, SHA-1, MD-5,
630 * all of which have the same block size except SHA-384. */
631 const size_t block_size = md_alg == MBEDTLS_MD_SHA384 ? 128 : 64;
632 const unsigned char * const ikey = ctx->hmac_ctx;
633 const unsigned char * const okey = ikey + block_size;
Gilles Peskine449bd832023-01-11 14:50:10 +0100634 const size_t hash_size = mbedtls_md_get_size(ctx->md_info);
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200635
636 unsigned char aux_out[MBEDTLS_MD_MAX_SIZE];
637 mbedtls_md_context_t aux;
638 size_t offset;
639 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
640
Gilles Peskine449bd832023-01-11 14:50:10 +0100641 mbedtls_md_init(&aux);
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200642
Gilles Peskine449bd832023-01-11 14:50:10 +0100643#define MD_CHK(func_call) \
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200644 do { \
645 ret = (func_call); \
Gilles Peskine449bd832023-01-11 14:50:10 +0100646 if (ret != 0) \
647 goto cleanup; \
648 } while (0)
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200649
Gilles Peskine449bd832023-01-11 14:50:10 +0100650 MD_CHK(mbedtls_md_setup(&aux, ctx->md_info, 0));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200651
652 /* After hmac_start() of hmac_reset(), ikey has already been hashed,
653 * so we can start directly with the message */
Gilles Peskine449bd832023-01-11 14:50:10 +0100654 MD_CHK(mbedtls_md_update(ctx, add_data, add_data_len));
655 MD_CHK(mbedtls_md_update(ctx, data, min_data_len));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200656
Paul Elliott5260ce22022-05-09 18:15:54 +0100657 /* Fill the hash buffer in advance with something that is
658 * not a valid hash (barring an attack on the hash and
659 * deliberately-crafted input), in case the caller doesn't
660 * check the return status properly. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100661 memset(output, '!', hash_size);
Paul Elliott5260ce22022-05-09 18:15:54 +0100662
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200663 /* For each possible length, compute the hash up to that point */
Gilles Peskine449bd832023-01-11 14:50:10 +0100664 for (offset = min_data_len; offset <= max_data_len; offset++) {
665 MD_CHK(mbedtls_md_clone(&aux, ctx));
666 MD_CHK(mbedtls_md_finish(&aux, aux_out));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200667 /* Keep only the correct inner_hash in the output buffer */
Gilles Peskine449bd832023-01-11 14:50:10 +0100668 mbedtls_ct_memcpy_if_eq(output, aux_out, hash_size,
669 offset, data_len_secret);
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200670
Gilles Peskine449bd832023-01-11 14:50:10 +0100671 if (offset < max_data_len) {
672 MD_CHK(mbedtls_md_update(ctx, data + offset, 1));
673 }
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200674 }
675
676 /* The context needs to finish() before it starts() again */
Gilles Peskine449bd832023-01-11 14:50:10 +0100677 MD_CHK(mbedtls_md_finish(ctx, aux_out));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200678
679 /* Now compute HASH(okey + inner_hash) */
Gilles Peskine449bd832023-01-11 14:50:10 +0100680 MD_CHK(mbedtls_md_starts(ctx));
681 MD_CHK(mbedtls_md_update(ctx, okey, block_size));
682 MD_CHK(mbedtls_md_update(ctx, output, hash_size));
683 MD_CHK(mbedtls_md_finish(ctx, output));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200684
685 /* Done, get ready for next time */
Gilles Peskine449bd832023-01-11 14:50:10 +0100686 MD_CHK(mbedtls_md_hmac_reset(ctx));
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200687
688#undef MD_CHK
689
690cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100691 mbedtls_md_free(&aux);
692 return ret;
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200693}
Neil Armstrong2968d302022-02-25 15:09:36 +0100694#endif /* MBEDTLS_USE_PSA_CRYPTO */
gabor-mezei-arm1349ffd2021-09-27 14:28:31 +0200695
Przemek Stekiel89ad6232022-09-27 13:36:12 +0200696#endif /* MBEDTLS_SSL_SOME_SUITES_USE_MAC */
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200697
698#if defined(MBEDTLS_BIGNUM_C)
699
Gilles Peskine449bd832023-01-11 14:50:10 +0100700#define MPI_VALIDATE_RET(cond) \
701 MBEDTLS_INTERNAL_VALIDATE_RET(cond, MBEDTLS_ERR_MPI_BAD_INPUT_DATA)
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200702
703/*
704 * Conditionally assign X = Y, without leaking information
705 * about whether the assignment was made or not.
706 * (Leaking information about the respective sizes of X and Y is ok however.)
707 */
Tautvydas Žilys40fc7da2022-01-31 13:34:01 -0800708#if defined(_MSC_VER) && defined(_M_ARM64) && (_MSC_FULL_VER < 193131103)
Tautvydas Žilys60165d72022-01-26 15:33:27 -0800709/*
Tautvydas Žilys40fc7da2022-01-31 13:34:01 -0800710 * MSVC miscompiles this function if it's inlined prior to Visual Studio 2022 version 17.1. See:
Tautvydas Žilys60165d72022-01-26 15:33:27 -0800711 * https://developercommunity.visualstudio.com/t/c-compiler-miscompiles-part-of-mbedtls-library-on/1646989
712 */
713__declspec(noinline)
714#endif
Gilles Peskine449bd832023-01-11 14:50:10 +0100715int mbedtls_mpi_safe_cond_assign(mbedtls_mpi *X,
716 const mbedtls_mpi *Y,
717 unsigned char assign)
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200718{
719 int ret = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +0100720 MPI_VALIDATE_RET(X != NULL);
721 MPI_VALIDATE_RET(Y != NULL);
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200722
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200723 /* all-bits 1 if assign is 1, all-bits 0 if assign is 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100724 mbedtls_mpi_uint limb_mask = mbedtls_ct_mpi_uint_mask(assign);
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200725
Gilles Peskine449bd832023-01-11 14:50:10 +0100726 MBEDTLS_MPI_CHK(mbedtls_mpi_grow(X, Y->n));
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200727
Tom Cosgrovee22413c2023-05-03 09:44:01 +0100728 X->s = (int) mbedtls_ct_uint_if(assign, Y->s, X->s);
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200729
Gilles Peskine449bd832023-01-11 14:50:10 +0100730 mbedtls_mpi_core_cond_assign(X->p, Y->p, Y->n, assign);
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200731
Gilles Peskine449bd832023-01-11 14:50:10 +0100732 for (size_t i = Y->n; i < X->n; i++) {
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200733 X->p[i] &= ~limb_mask;
Gilles Peskine449bd832023-01-11 14:50:10 +0100734 }
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200735
736cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100737 return ret;
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200738}
739
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200740/*
741 * Conditionally swap X and Y, without leaking information
742 * about whether the swap was made or not.
Shaun Case8b0ecbc2021-12-20 21:14:10 -0800743 * Here it is not ok to simply swap the pointers, which would lead to
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200744 * different memory access patterns when X and Y are used afterwards.
745 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100746int mbedtls_mpi_safe_cond_swap(mbedtls_mpi *X,
747 mbedtls_mpi *Y,
748 unsigned char swap)
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200749{
Gabor Mezeid7edb1d2022-10-10 14:32:09 +0200750 int ret = 0;
751 int s;
Gilles Peskine449bd832023-01-11 14:50:10 +0100752 MPI_VALIDATE_RET(X != NULL);
753 MPI_VALIDATE_RET(Y != NULL);
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200754
Gilles Peskine449bd832023-01-11 14:50:10 +0100755 if (X == Y) {
756 return 0;
757 }
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200758
Gilles Peskine449bd832023-01-11 14:50:10 +0100759 MBEDTLS_MPI_CHK(mbedtls_mpi_grow(X, Y->n));
760 MBEDTLS_MPI_CHK(mbedtls_mpi_grow(Y, X->n));
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200761
762 s = X->s;
Tom Cosgrovee22413c2023-05-03 09:44:01 +0100763 X->s = (int) mbedtls_ct_uint_if(swap, Y->s, X->s);
764 Y->s = (int) mbedtls_ct_uint_if(swap, s, Y->s);
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200765
Gilles Peskine449bd832023-01-11 14:50:10 +0100766 mbedtls_mpi_core_cond_swap(X->p, Y->p, X->n, swap);
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200767
768cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100769 return ret;
gabor-mezei-arm5c976212021-09-27 15:37:50 +0200770}
771
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200772/*
Janos Follath23bdeca2022-07-22 18:24:06 +0100773 * Compare unsigned values in constant time
774 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100775unsigned mbedtls_mpi_core_lt_ct(const mbedtls_mpi_uint *A,
776 const mbedtls_mpi_uint *B,
777 size_t limbs)
Janos Follath23bdeca2022-07-22 18:24:06 +0100778{
Janos Follath23bdeca2022-07-22 18:24:06 +0100779 unsigned ret, cond, done;
780
Janos Follath63184682022-08-11 17:42:59 +0100781 /* The value of any of these variables is either 0 or 1 for the rest of
782 * their scope. */
Janos Follath23bdeca2022-07-22 18:24:06 +0100783 ret = cond = done = 0;
784
Gilles Peskine449bd832023-01-11 14:50:10 +0100785 for (size_t i = limbs; i > 0; i--) {
Janos Follath23bdeca2022-07-22 18:24:06 +0100786 /*
Janos Follathb7a88ec2022-08-19 12:24:40 +0100787 * If B[i - 1] < A[i - 1] then A < B is false and the result must
Janos Follath23bdeca2022-07-22 18:24:06 +0100788 * remain 0.
789 *
790 * Again even if we can make a decision, we just mark the result and
791 * the fact that we are done and continue looping.
792 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100793 cond = mbedtls_ct_mpi_uint_lt(B[i - 1], A[i - 1]);
Janos Follath23bdeca2022-07-22 18:24:06 +0100794 done |= cond;
795
796 /*
Janos Follathb7a88ec2022-08-19 12:24:40 +0100797 * If A[i - 1] < B[i - 1] then A < B is true.
Janos Follath23bdeca2022-07-22 18:24:06 +0100798 *
799 * Again even if we can make a decision, we just mark the result and
800 * the fact that we are done and continue looping.
801 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100802 cond = mbedtls_ct_mpi_uint_lt(A[i - 1], B[i - 1]);
803 ret |= cond & (1 - done);
Janos Follath23bdeca2022-07-22 18:24:06 +0100804 done |= cond;
805 }
806
807 /*
Janos Follathb7a88ec2022-08-19 12:24:40 +0100808 * If all the limbs were equal, then the numbers are equal, A < B is false
Janos Follath23bdeca2022-07-22 18:24:06 +0100809 * and leaving the result 0 is correct.
810 */
811
Gilles Peskine449bd832023-01-11 14:50:10 +0100812 return ret;
Janos Follath23bdeca2022-07-22 18:24:06 +0100813}
814
815/*
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200816 * Compare signed values in constant time
817 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100818int mbedtls_mpi_lt_mpi_ct(const mbedtls_mpi *X,
819 const mbedtls_mpi *Y,
820 unsigned *ret)
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200821{
822 size_t i;
823 /* The value of any of these variables is either 0 or 1 at all times. */
824 unsigned cond, done, X_is_negative, Y_is_negative;
825
Gilles Peskine449bd832023-01-11 14:50:10 +0100826 MPI_VALIDATE_RET(X != NULL);
827 MPI_VALIDATE_RET(Y != NULL);
828 MPI_VALIDATE_RET(ret != NULL);
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200829
Gilles Peskine449bd832023-01-11 14:50:10 +0100830 if (X->n != Y->n) {
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200831 return MBEDTLS_ERR_MPI_BAD_INPUT_DATA;
Gilles Peskine449bd832023-01-11 14:50:10 +0100832 }
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200833
834 /*
835 * Set sign_N to 1 if N >= 0, 0 if N < 0.
836 * We know that N->s == 1 if N >= 0 and N->s == -1 if N < 0.
837 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100838 X_is_negative = (X->s & 2) >> 1;
839 Y_is_negative = (Y->s & 2) >> 1;
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200840
841 /*
842 * If the signs are different, then the positive operand is the bigger.
843 * That is if X is negative (X_is_negative == 1), then X < Y is true and it
844 * is false if X is positive (X_is_negative == 0).
845 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100846 cond = (X_is_negative ^ Y_is_negative);
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200847 *ret = cond & X_is_negative;
848
849 /*
850 * This is a constant-time function. We might have the result, but we still
851 * need to go through the loop. Record if we have the result already.
852 */
853 done = cond;
854
Gilles Peskine449bd832023-01-11 14:50:10 +0100855 for (i = X->n; i > 0; i--) {
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200856 /*
857 * If Y->p[i - 1] < X->p[i - 1] then X < Y is true if and only if both
858 * X and Y are negative.
859 *
860 * Again even if we can make a decision, we just mark the result and
861 * the fact that we are done and continue looping.
862 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100863 cond = mbedtls_ct_mpi_uint_lt(Y->p[i - 1], X->p[i - 1]);
864 *ret |= cond & (1 - done) & X_is_negative;
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200865 done |= cond;
866
867 /*
868 * If X->p[i - 1] < Y->p[i - 1] then X < Y is true if and only if both
869 * X and Y are positive.
870 *
871 * Again even if we can make a decision, we just mark the result and
872 * the fact that we are done and continue looping.
873 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100874 cond = mbedtls_ct_mpi_uint_lt(X->p[i - 1], Y->p[i - 1]);
875 *ret |= cond & (1 - done) & (1 - X_is_negative);
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200876 done |= cond;
877 }
878
Gilles Peskine449bd832023-01-11 14:50:10 +0100879 return 0;
gabor-mezei-armc29a3da2021-09-27 15:41:30 +0200880}
881
gabor-mezei-arm40a49252021-09-27 15:33:35 +0200882#endif /* MBEDTLS_BIGNUM_C */
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200883
884#if defined(MBEDTLS_PKCS1_V15) && defined(MBEDTLS_RSA_C) && !defined(MBEDTLS_RSA_ALT)
885
Gilles Peskine449bd832023-01-11 14:50:10 +0100886int mbedtls_ct_rsaes_pkcs1_v15_unpadding(unsigned char *input,
887 size_t ilen,
888 unsigned char *output,
889 size_t output_max_len,
890 size_t *olen)
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200891{
892 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
893 size_t i, plaintext_max_size;
894
895 /* The following variables take sensitive values: their value must
896 * not leak into the observable behavior of the function other than
897 * the designated outputs (output, olen, return value). Otherwise
898 * this would open the execution of the function to
899 * side-channel-based variants of the Bleichenbacher padding oracle
900 * attack. Potential side channels include overall timing, memory
901 * access patterns (especially visible to an adversary who has access
902 * to a shared memory cache), and branches (especially visible to
903 * an adversary who has access to a shared code cache or to a shared
904 * branch predictor). */
905 size_t pad_count = 0;
906 unsigned bad = 0;
907 unsigned char pad_done = 0;
908 size_t plaintext_size = 0;
909 unsigned output_too_large;
910
Gilles Peskine449bd832023-01-11 14:50:10 +0100911 plaintext_max_size = (output_max_len > ilen - 11) ? ilen - 11
Gabor Mezei7013f622021-10-18 16:12:45 +0200912 : output_max_len;
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200913
914 /* Check and get padding length in constant time and constant
915 * memory trace. The first byte must be 0. */
Gabor Mezei63bbba52021-10-18 16:17:57 +0200916 bad |= input[0];
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200917
918
919 /* Decode EME-PKCS1-v1_5 padding: 0x00 || 0x02 || PS || 0x00
Gabor Mezei63bbba52021-10-18 16:17:57 +0200920 * where PS must be at least 8 nonzero bytes. */
921 bad |= input[1] ^ MBEDTLS_RSA_CRYPT;
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200922
923 /* Read the whole buffer. Set pad_done to nonzero if we find
Gabor Mezei63bbba52021-10-18 16:17:57 +0200924 * the 0x00 byte and remember the padding length in pad_count. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100925 for (i = 2; i < ilen; i++) {
926 pad_done |= ((input[i] | (unsigned char) -input[i]) >> 7) ^ 1;
927 pad_count += ((pad_done | (unsigned char) -pad_done) >> 7) ^ 1;
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200928 }
929
930
931 /* If pad_done is still zero, there's no data, only unfinished padding. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100932 bad |= mbedtls_ct_uint_if(pad_done, 0, 1);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200933
934 /* There must be at least 8 bytes of padding. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100935 bad |= mbedtls_ct_size_gt(8, pad_count);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200936
937 /* If the padding is valid, set plaintext_size to the number of
938 * remaining bytes after stripping the padding. If the padding
939 * is invalid, avoid leaking this fact through the size of the
940 * output: use the maximum message size that fits in the output
941 * buffer. Do it without branches to avoid leaking the padding
942 * validity through timing. RSA keys are small enough that all the
943 * size_t values involved fit in unsigned int. */
Gabor Mezei90437e32021-10-20 11:59:27 +0200944 plaintext_size = mbedtls_ct_uint_if(
Gilles Peskine449bd832023-01-11 14:50:10 +0100945 bad, (unsigned) plaintext_max_size,
946 (unsigned) (ilen - pad_count - 3));
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200947
948 /* Set output_too_large to 0 if the plaintext fits in the output
949 * buffer and to 1 otherwise. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100950 output_too_large = mbedtls_ct_size_gt(plaintext_size,
951 plaintext_max_size);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200952
953 /* Set ret without branches to avoid timing attacks. Return:
954 * - INVALID_PADDING if the padding is bad (bad != 0).
955 * - OUTPUT_TOO_LARGE if the padding is good but the decrypted
956 * plaintext does not fit in the output buffer.
957 * - 0 if the padding is correct. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100958 ret = -(int) mbedtls_ct_uint_if(
959 bad, -MBEDTLS_ERR_RSA_INVALID_PADDING,
960 mbedtls_ct_uint_if(output_too_large,
961 -MBEDTLS_ERR_RSA_OUTPUT_TOO_LARGE,
962 0));
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200963
964 /* If the padding is bad or the plaintext is too large, zero the
965 * data that we're about to copy to the output buffer.
966 * We need to copy the same amount of data
967 * from the same buffer whether the padding is good or not to
968 * avoid leaking the padding validity through overall timing or
969 * through memory or cache access patterns. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100970 bad = mbedtls_ct_uint_mask(bad | output_too_large);
971 for (i = 11; i < ilen; i++) {
Gabor Mezei63bbba52021-10-18 16:17:57 +0200972 input[i] &= ~bad;
Gilles Peskine449bd832023-01-11 14:50:10 +0100973 }
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200974
975 /* If the plaintext is too large, truncate it to the buffer size.
976 * Copy anyway to avoid revealing the length through timing, because
977 * revealing the length is as bad as revealing the padding validity
978 * for a Bleichenbacher attack. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100979 plaintext_size = mbedtls_ct_uint_if(output_too_large,
980 (unsigned) plaintext_max_size,
981 (unsigned) plaintext_size);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200982
983 /* Move the plaintext to the leftmost position where it can start in
984 * the working buffer, i.e. make it start plaintext_max_size from
985 * the end of the buffer. Do this with a memory access trace that
986 * does not depend on the plaintext size. After this move, the
987 * starting location of the plaintext is no longer sensitive
988 * information. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100989 mbedtls_ct_mem_move_to_left(input + ilen - plaintext_max_size,
990 plaintext_max_size,
991 plaintext_max_size - plaintext_size);
gabor-mezei-armfdb71182021-09-27 16:11:12 +0200992
993 /* Finally copy the decrypted plaintext plus trailing zeros into the output
994 * buffer. If output_max_len is 0, then output may be an invalid pointer
995 * and the result of memcpy() would be undefined; prevent undefined
996 * behavior making sure to depend only on output_max_len (the size of the
997 * user-provided output buffer), which is independent from plaintext
998 * length, validity of padding, success of the decryption, and other
999 * secrets. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001000 if (output_max_len != 0) {
1001 memcpy(output, input + ilen - plaintext_max_size, plaintext_max_size);
1002 }
gabor-mezei-armfdb71182021-09-27 16:11:12 +02001003
1004 /* Report the amount of data we copied to the output buffer. In case
1005 * of errors (bad padding or output too large), the value of *olen
1006 * when this function returns is not specified. Making it equivalent
1007 * to the good case limits the risks of leaking the padding validity. */
1008 *olen = plaintext_size;
1009
Gilles Peskine449bd832023-01-11 14:50:10 +01001010 return ret;
gabor-mezei-armfdb71182021-09-27 16:11:12 +02001011}
1012
1013#endif /* MBEDTLS_PKCS1_V15 && MBEDTLS_RSA_C && ! MBEDTLS_RSA_ALT */